Re: [vdsm] pep8 check in vim
On Tue, Apr 24, 2012 at 10:39:24AM +0800, Lei Li wrote: > On 04/12/2012 10:48 PM, Saggi Mizrahi wrote: > >Now that we started moving to conform with pep8 you would probably like to > >be able to easily check your code. > > > >If you use vim you could use this vim script > >http://www.vim.org/scripts/script.php?script_id=2914 > I check PEP8 based on this version and it passed with > no noise. > > But seems it failed to vdsm_unit_test with > 'E261 at least two spaces before inline comment.' > And this version can find the E261 error too: > https://github.com/jcrocholl/pep8/branches/master > > Also I found otherinconsistent check result from different > python-pep8 versions. > So I think It is necessary to have auniformstandard > for pep8 in vdsm to avoid such noise. I'd say that the version running in jenkins.ovirt.org is our de-facto standard (python-pep8-0.6.0-3.fc15.noarch I believe). ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-devel
Re: [vdsm] pep8 check in vim
On 04/12/2012 10:48 PM, Saggi Mizrahi wrote: Now that we started moving to conform with pep8 you would probably like to be able to easily check your code. If you use vim you could use this vim script http://www.vim.org/scripts/script.php?script_id=2914 I check PEP8 based on this version and it passed with no noise. But seems it failed to vdsm_unit_test with 'E261 at least two spaces before inline comment.' And this version can find the E261 error too: https://github.com/jcrocholl/pep8/branches/master Also I found otherinconsistent check result from different python-pep8 versions. So I think It is necessary to have auniformstandard for pep8 in vdsm to avoid such noise. I you are not using vim follow these 3 simple steps: 1. Switch to vim 2. Install the script 3. Profit ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-devel -- Lei ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-devel
Re: [vdsm] pep8 check in vim
On Thu, Apr 12, 2012 at 10:48:26AM -0400, Saggi Mizrahi wrote: > Now that we started moving to conform with pep8 you would probably > like to be able to easily check your code. > > If you use vim you could use this vim script > http://www.vim.org/scripts/script.php?script_id=2914 > > I you are not using vim follow these 3 simple steps: > 1. Switch to vim > 2. Install the script > 3. Profit While we're exchanging cool vim plugins I can recommend syntastic[1] to you which has plugins for pylint, pyflakes and flake8. That last one can also check pep8. [1]: https://github.com/scrooloose/syntastic ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-devel
[vdsm] pep8 check in vim
Now that we started moving to conform with pep8 you would probably like to be able to easily check your code. If you use vim you could use this vim script http://www.vim.org/scripts/script.php?script_id=2914 I you are not using vim follow these 3 simple steps: 1. Switch to vim 2. Install the script 3. Profit ___ vdsm-devel mailing list vdsm-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-devel
