Ayal Baron has posted comments on this change.
Change subject: Change oop to be a new process instead of a fork
..
Patch Set 2: I would prefer that you didn't submit this
(4 inline comments)
...
Ryan Harper has uploaded a new change for review.
Change subject: tests: fix gluster storage exception test
..
tests: fix gluster storage exception test
make check fails after gluster merge:
FAIL: test_collisions (main.TestGlus
Douglas Schilling Landgraf has posted comments on this change.
Change subject: BZ#821867: Do not append comments to config values
..
Patch Set 4: (1 inline comment)
File vdsm
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Configure libvirt to use sanlock
..
Patch Set 11: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/4210
To
Douglas Schilling Landgraf has posted comments on this change.
Change subject: BZ#821867: Do not append comments to config values
..
Patch Set 5: Verified
--
To view, visit http://gerrit.ovirt.org/4716
To unsubscribe, visit htt
Dan Kenigsberg has submitted this change and it was merged.
Change subject: PEP8 fixes for nfsSD
..
PEP8 fixes for nfsSD
pep8 complaints:
vdsm/storage/nfsSD.py:16:80: E501 line too long (80 characters)
vdsm/storage/nfsSD.py:33
Dan Kenigsberg has posted comments on this change.
Change subject: PEP8 fixes for nfsSD
..
Patch Set 2: Verified; Looks good to me, approved
Believing that the verification of http://gerrit.ovirt.org/#change,4478
includes this
Dan Kenigsberg has submitted this change and it was merged.
Change subject: StorageConnection: Fix error message
..
StorageConnection: Fix error message
Signed-off-by: Adam Litke
Change-Id: I84bf8d449f0b85712bde43393ba196fbc69
Dan Kenigsberg has posted comments on this change.
Change subject: StorageConnection: Fix error message
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4818
To unsubscribe, visit http://gerr
Adam Litke has posted comments on this change.
Change subject: storage: Move nfsSD.getFileUtils() to FileStorageDomain class
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.
Ryan Harper has posted comments on this change.
Change subject: Fix multiple commands with same name in different vdsm-tool
modules
..
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
Clean up the ty
Ryan Harper has posted comments on this change.
Change subject: storage: Move nfsSD.getFileUtils() to FileStorageDomain class
..
Patch Set 1: Verified
I verified this yesterday with the same test as in Comment 1, I went to reba
Adam Litke has posted comments on this change.
Change subject: PEP8 fixes for nfsSD
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/3936
To unsubscribe, visit http://ger
Adam Litke has posted comments on this change.
Change subject: PEP8 fixes for localFsSD
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/3938
To unsubscribe, visit http:/
Saggi Mizrahi has posted comments on this change.
Change subject: Change oop to be a new process instead of a fork
..
Patch Set 2: (2 inline comments)
File vdsm/storage/iscsi
Adam Litke has posted comments on this change.
Change subject: StorageConnection: Fix error message
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/4818
To unsubscribe, visit http://gerrit.ovirt.org/settings
Adam Litke has uploaded a new change for review.
Change subject: StorageConnection: Fix error message
..
StorageConnection: Fix error message
Signed-off-by: Adam Litke
Change-Id: I84bf8d449f0b85712bde43393ba196fbc695025e
---
M
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: storage: Move nfsSD.getFileUtils() to FileStorageDomain class
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: PEP8 fixes for nfsSD
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/3936
To unsubscribe,
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: PEP8 fixes for localFsSD
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/3938
To unsubscri
Federico Simoncelli has posted comments on this change.
Change subject: Change oop to be a new process instead of a fork
..
Patch Set 2: Looks good to me, but someone else must approve
(3 inline comments)
Minor questions. I al
Adam Litke has posted comments on this change.
Change subject: Fixing typo in the source files besides vdsm.git/vdsm.
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/433
Adam Litke has posted comments on this change.
Change subject: Fixing typo in all the python files in vdsm.git/vdsm.
..
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
Just needs one small fix as out
Adam Litke has posted comments on this change.
Change subject: Move actual VM creation function to libvirtvm.py
..
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
...
Adam Litke has posted comments on this change.
Change subject: Separate API binding from BindingXMLRPC
..
Patch Set 1:
Mark, Am I correct that this can be abandoned since you are working on a new
approach?
--
To view, visit h
Adam Litke has posted comments on this change.
Change subject: Move uninstall preun section to vdsm-unregister
..
Patch Set 1: No score
Replied in the other change... Removing -1 to invite further review.
--
To view, visit htt
Adam Litke has posted comments on this change.
Change subject: Fix multiple commands with same name in different vdsm-tool
modules
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit
Adam Litke has posted comments on this change.
Change subject: Add passwd command to vdsm-tool
..
Patch Set 3: No score
(1 inline comment)
Removing -1 to encourage further review from others.
.
Mark Wu has posted comments on this change.
Change subject: MOM Integration
..
Patch Set 9:
Adam,
The MOM patch is already done in my local repo. I wrote it to test this patch.
I will submit later.
--
To view, visit http://ge
Mark Wu has posted comments on this change.
Change subject: Move actual VM creation function to libvirtvm.py
..
Patch Set 1: Verified
After applying this patch, I create a VM using vdsm API successfully. After
that, I restart
Mark Wu has posted comments on this change.
Change subject: Remove the parameter of clientIF instance from API
..
Patch Set 6:
Dan,
Actually, the first idea coming to my mind for this work is using clientIF as a
singleton. The
Mark Wu has uploaded a new change for review.
Change subject: Move actual VM creation function to libvirtvm.py
..
Move actual VM creation function to libvirtvm.py
To avoid using API in clientIF.py, we move the VM creation functi
On Fri, May 25, 2012 at 03:46:39AM -0400, Jenkins oVirt Server wrote:
>
> BUILD FAILURE
> Build URL: http://jenkins.ovirt.org/job/vdsm_unit_tests/163/
> Project: vdsm_unit_tests
> Date of build: Fri, 25 May 2012 03:40:29 -0400
> Build duration: 6 min 10 sec
>
> CHANGE SET
> Revision d707ce49718d7
Lei Li has posted comments on this change.
Change subject: Move uninstall preun section to vdsm-unregister
..
Patch Set 1:
Hi Adam,
I think your concern from the same question, and I have replied in the link
here:
http://ger
Lei Li has posted comments on this change.
Change subject: Add passwd command to vdsm-tool
..
Patch Set 3: No score
Hmm, seems I failed to refresh the score '-1' there...give +1 didn't work... :(
--
To view, visit http://gerri
Lei Li has posted comments on this change.
Change subject: Add passwd command to vdsm-tool
..
Patch Set 3: Looks good to me, but someone else must approve
(1 inline comment)
First, I give +1 by myself just to attract your atte
Federico Simoncelli has posted comments on this change.
Change subject: BZ#821867: Do not append comments to config values
..
Patch Set 4: Looks good to me, but someone else must approve
(1 inline comment)
Wenyi Gao has posted comments on this change.
Change subject: [WIP] Move vdsmd.init to vdsm-tool
..
Patch Set 1:
Thank you Adam very much for your helpful suggestion and some useful example
code. I will follow your suggestions
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#821867: Do not append comments to config values
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/471
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Added Gluster file system management support.
..
Added Gluster file system management support.
Verbs added into vdsm are
glusterVolumesList,
gluste
Dan Kenigsberg has posted comments on this change.
Change subject: Added Gluster file system management support.
..
Patch Set 22: Looks good to me, approved
Pushing, even though Haim has reported a possible problem with migrati
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Added gluster cli support in supervdsm.
..
Added gluster cli support in supervdsm.
Now supervdsm has following functions which enable gluster supported
Dan Kenigsberg has posted comments on this change.
Change subject: Added gluster cli support in supervdsm.
..
Patch Set 24: Looks good to me, approved
Pushing, even though Haim has reported a possible problem with migration. I
Dan Kenigsberg has posted comments on this change.
Change subject: Fix - bz #823565 - Gluster - Backend: Replace Brick presented
as failure
..
Patch Set 1: (1 inline comment)
...
Dan Kenigsberg has posted comments on this change.
Change subject: dumpStorageTable: fix path to ovf files
..
Patch Set 1: I would prefer that you didn't submit this
(3 inline comments)
Dan Kenigsberg has posted comments on this change.
Change subject: small fix for import in test cases
..
Patch Set 1: Looks good to me, approved
ok
--
To view, visit http://gerrit.ovirt.org/4586
To unsubscribe, visit http://ge
Dan Kenigsberg has submitted this change and it was merged.
Change subject: small fix for import in test cases
..
small fix for import in test cases
when the test case import modules lies in vdsm, it should
specify "from vdsm
Dan Kenigsberg has submitted this change and it was merged.
Change subject: add run_test_local.sh to .gitignore
..
add run_test_local.sh to .gitignore
Change-Id: I4019d31dee6bc97924b6ca6aeb251e02d448c51f
Signed-off-by: wenchao
Dan Kenigsberg has posted comments on this change.
Change subject: add run_test_local.sh to .gitignore
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4806
To unsubscribe, visit ht
Dan Kenigsberg has posted comments on this change.
Change subject: adjust betterPopenTest.py
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/4585
To unsubscribe, visit h
50 matches
Mail list logo
