Adam Litke has posted comments on this change. Change subject: Add passwd command to vdsm-tool ......................................................................
Patch Set 3: No score (1 inline comment) Removing -1 to encourage further review from others. .................................................... File vdsm.spec.in Line 364 Yes, I like that you moved the code into vdsm-tool. But it seems you have also changed the package installation process. Before your patch, the libvirt sasl password was set here during installation. After your patch, it is never set. -- To view, visit http://gerrit.ovirt.org/4528 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76b5aee4c2f11a7680c675c171ff35a463a70402 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lei Li <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Lei Li <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: Ryan Harper <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Wenyi Gao <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
