Zhou Zheng Sheng has uploaded a new change for review.
Change subject: call sync before umount in mkFloppyFs
..
call sync before umount in mkFloppyFs
mkFloppyFs creates a floppy image, mount it, write some content, and
umount
Zhou Zheng Sheng has posted comments on this change.
Change subject: call sync before umount in mkFloppyFs
..
Patch Set 1:
This problem causes unit test test_mkFloppyFs in tests/mkimageTests.py fail.
My uname -a is as follow,
Bala.FA has posted comments on this change.
Change subject: Added glusterVolumeStatus verb
..
Patch Set 2: (6 inline comments)
File vdsm_cli/vdsClientGluster.py
Line 198:
Bala.FA has posted comments on this change.
Change subject: API: Provide a working getAllTasks API
..
Patch Set 3: Looks good to me, but someone else must approve
(1 inline comment)
Mark Wu has posted comments on this change.
Change subject: call sync before umount in mkFloppyFs
..
Patch Set 1:
Is it necessary to add a new constant and a function to fix a problem in a test
case? How about just call sync
Bala.FA has posted comments on this change.
Change subject: glusterHostsList returns host info as list of dictionaries
..
Patch Set 1: (1 inline comment)
Commit Message
Line
Mark Wu has posted comments on this change.
Change subject: call sync before umount in mkFloppyFs
..
Patch Set 1: (1 inline comment)
File vdsm/mkimage.py
Line 86:
Zhou Zheng Sheng has posted comments on this change.
Change subject: call sync before umount in mkFloppyFs
..
Patch Set 1: (1 inline comment)
Mark Wu, the problem is in the function mkFloppyFs in vdsm/mkimage.py, not
in the
Mark Wu has posted comments on this change.
Change subject: call sync before umount in mkFloppyFs
..
Patch Set 1:
I see there's an existing lazy option for the umount() function, so it's
easier to use lazy umount than sync.
Zhou Zheng Sheng has posted comments on this change.
Change subject: call sync before umount in mkFloppyFs
..
Patch Set 1:
I have tried lazy umount as well, it does not work. The test case will mount
the image immediately
Mark Wu has posted comments on this change.
Change subject: Move option 'save_image_format' to qemu.conf
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/5928
To unsubscribe, visit
Mark Wu has posted comments on this change.
Change subject: Move option 'save_image_format' to qemu.conf
..
Patch Set 2:
Jenkins failed in the test of ResourceManagerTests.testStressTest because it
can't create a new thread
Zhou Zheng Sheng has posted comments on this change.
Change subject: call sync before umount in mkFloppyFs
..
Patch Set 1:
Thanks mark and hejie. After collecting more advice, I will make a new patch
set later.
--
To view,
Deepak C Shetty has posted comments on this change.
Change subject: Support for QEMU cmdline hook
..
Patch Set 2: (2 inline comments)
File
Dan Kenigsberg has posted comments on this change.
Change subject: minimalistic (incomplete) test for mkimage.py with fail for
non-64base data
..
Patch Set 1: Fails; Do not submit
--
To view, visit
Zhou Zheng Sheng has posted comments on this change.
Change subject: call sync before umount in mkFloppyFs
..
Patch Set 2: Verified
patch set 2: add some comments
Run through autobuild.sh and fix the problem for me.
--
To
Bala.FA has posted comments on this change.
Change subject: glusterHostsList returns host info as list of dictionaries
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/6614
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Move createLibvirtNetwork and removeLibvirtNetwork to the
ConfigWriter
..
Move createLibvirtNetwork and removeLibvirtNetwork to the ConfigWriter
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Add atomic/persist backup capabilities for logical networks
..
Add atomic/persist backup capabilities for logical networks
Change-Id:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: configNetwork: Don't swallow exception during
removeLibvirtNetwork
..
configNetwork: Don't swallow exception during removeLibvirtNetwork
In this
Dan Kenigsberg has submitted this change and it was merged.
Change subject: BZ#832765 - configNetwork: add restoreAtomicNetworkBackup
..
BZ#832765 - configNetwork: add restoreAtomicNetworkBackup
Change-Id:
Igor Lvovsky has posted comments on this change.
Change subject: Add restoreBackups and clearBackups
..
Patch Set 3: (1 inline comment)
File vdsm/configNetwork.py
Line 350:
Adam Litke has posted comments on this change.
Change subject: API: Provide a working getAllTasks API
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/3613
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: Remove orphaned API: getStorageConnections
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/6107
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: Initialize the pthread RLock attribute
..
Patch Set 3: (1 inline comment)
File vdsm/pthread.py
Line 74
I
Gal Hammer has posted comments on this change.
Change subject: BZ#842771 Fix for exception TypeError: cannot marshal None
..
Patch Set 1: Verified; Looks good to me, but someone else must approve
--
To view, visit
Bala.FA has posted comments on this change.
Change subject: Added glusterVolumeStatus verb
..
Patch Set 2: (1 inline comment)
File vdsm_cli/vdsClientGluster.py
Line 198:
Hello Ayal Baron, Timothy Asir, Saggi Mizrahi, Federico Simoncelli, Dan
Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/6999
to review the following change.
Change subject: Added xml option in gluster command execution.
Robert Middleswarth has uploaded a new change for review.
Change subject: Updateing ChangeLog just to force an update.
..
Updateing ChangeLog just to force an update.
Change-Id: I860431fb30168a36de1a220fb52da0176e2fd60e
Robert Middleswarth has uploaded a new change for review.
Change subject: Another minor change to tigger a build
..
Another minor change to tigger a build
Change-Id: Ic355534713fbd0ebd4cad8fb9ea79668c32d58f2
Signed-off-by:
Robert Middleswarth has abandoned this change.
Change subject: Another minor change to tigger a build
..
Patch Set 1: Abandoned
This was here just to test the system.
--
To view, visit http://gerrit.ovirt.org/6994
To
Robert Middleswarth has abandoned this change.
Change subject: Updateing ChangeLog just to force an update.
..
Patch Set 1: Abandoned
Testing Jenkins
--
To view, visit http://gerrit.ovirt.org/6993
To unsubscribe, visit
Omri Hochman has posted comments on this change.
Change subject: BZ#844656 Respawn the domain monitor when needed
..
Patch Set 6: Verified
--
To view, visit http://gerrit.ovirt.org/6787
To unsubscribe, visit
Omri Hochman has posted comments on this change.
Change subject: BZ#844656 Release the _syncroot lock during _findDomain
..
Patch Set 7: Verified
--
To view, visit http://gerrit.ovirt.org/6822
To unsubscribe, visit
Adam Litke has uploaded a new change for review.
Change subject: schema: Rename Global class to API
..
schema: Rename Global class to API
The API class is the root of the API. It will have functions to connect and
disconnect
Adam Litke has uploaded a new change for review.
Change subject: schema: Remove remaining instance of IntStr
..
schema: Remove remaining instance of IntStr
Oops, we missed one IntStr type. Remove it.
Change-Id:
Adam Litke has uploaded a new change for review.
Change subject: schema: Remove invalid names
..
schema: Remove invalid names
The identifier type causes conflicts with the GObject type system. Type is
not a great name anyway
Adam Litke has uploaded a new change for review.
Change subject: schema: Add class constructors to the schema
..
schema: Add class constructors to the schema
All classes will accept parameters when they are instantiated.
Adam Litke has uploaded a new change for review.
Change subject: schema: Fix some typos
..
schema: Fix some typos
Just fix a few outstanding typos in the schema. This should be pretty
uncontroversial.
Change-Id:
Adam Litke has uploaded a new change for review.
Change subject: schema: Fixup command return values
..
schema: Fixup command return values
Commands return a single unnamed typed item. Fix the schema to reflect this.
Some vdsm
Adam Litke has uploaded a new change for review.
Change subject: schema: Fix up VmDefinition types
..
schema: Fix up VmDefinition types
There is no such thing as a VmShort definition so we do not need the union type
for
Adam Litke has uploaded a new change for review.
Change subject: schema: Add StorageDomainStatsMap map type
..
schema: Add StorageDomainStatsMap map type
API.getStorageRepoStats refers to an undefined mapping type. Add it.
Adam Litke has uploaded a new change for review.
Change subject: schema: Introduce a Test object
..
schema: Introduce a Test object
Add a Test Class that can be used for testing complex argument and return value
handling.
Deepak C Shetty has posted comments on this change.
Change subject: [RFC] Support for GLUSTERFS_DOMAIN
..
Patch Set 1: (8 inline comments)
I have posted v2. Pls provide your review comments.
Dan Kenigsberg has posted comments on this change.
Change subject: Support for QEMU cmdline hook
..
Patch Set 4: Looks good to me, approved
annoying whitespace removed.
--
To view, visit http://gerrit.ovirt.org/6969
To
Dan Kenigsberg has submitted this change and it was merged.
Change subject: BZ#846014 - Fix virtio hotplug disk fail to a VM with IDE disks.
..
BZ#846014 - Fix virtio hotplug disk fail to a VM with IDE disks.
Change-Id:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add restoreBackups and clearBackups
..
Patch Set 4:
Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests/945/
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: BZ#832765 - Load backups from backup files to memory
..
Patch Set 7:
Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests/946/
--
To view,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: BZ#832765 - Rewrite vdsm-restore-net-config as python module
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.info/job/vdsm_unit_tests/947/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: BZ#832765 - Load backups from backup files to memory
..
Patch Set 7:
Build Successful
http://jenkins.ovirt.info/job/vdsm_unit_tests/946/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: BZ#832765 - Rewrite vdsm-restore-net-config as python module
..
Patch Set 3:
Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests/947/
--
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Specify the ACPI flag when shutting down VMs
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/1/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Specify the ACPI flag when shutting down VMs
..
Patch Set 1: No score
Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/1/
--
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Specify the ACPI flag when shutting down VMs
..
Patch Set 1:
Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/2/
--
To view,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Specify the ACPI flag when shutting down VMs
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/2/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Specify the ACPI flag when shutting down VMs
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/3/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Specify the ACPI flag when shutting down VMs
..
Patch Set 1:
Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/3/
--
To view,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Specify the ACPI flag when shutting down VMs
..
Patch Set 1:
Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/4/
--
To view,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Specify the ACPI flag when shutting down VMs
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/4/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Specify the ACPI flag when shutting down VMs
..
Patch Set 1:
Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/5/
--
To view,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Specify the ACPI flag when shutting down VMs
..
Patch Set 1: Fails
Build Failed
http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/5/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: schema: Remove remaining instance of IntStr
..
Patch Set 1:
Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/6/
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: schema: Remove remaining instance of IntStr
..
Patch Set 1: Fails
Build Failed
http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/6/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: schema: Rename Global class to API
..
Patch Set 1:
Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/7/
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: schema: Rename Global class to API
..
Patch Set 1: Fails
Build Failed
http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/7/ : FAILURE
--
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: schema: Add class constructors to the schema
..
Patch Set 1: Fails
Build Failed
http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/8/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: schema: Fix some typos
..
Patch Set 1:
Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/9/
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: schema: Fix some typos
..
Patch Set 1: Fails
Build Failed
http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/9/ : FAILURE
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: schema: Remove invalid names
..
Patch Set 1: Fails
Build Failed
http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/10/ : FAILURE
--
To view,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: schema: Add StorageDomainStatsMap map type
..
Patch Set 1:
Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/11/
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: schema: Add StorageDomainStatsMap map type
..
Patch Set 1: Fails
Build Failed
http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/11/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: schema: Fix up VmDefinition types
..
Patch Set 1:
Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/12/
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: schema: Fix up VmDefinition types
..
Patch Set 1: Fails
Build Failed
http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/12/ : FAILURE
--
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: schema: ConnectionError should be an object not a tuple
..
Patch Set 1: Fails
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: schema: ConnectionError should be an object not a tuple
..
Patch Set 1:
Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/13/
--
oVirt Jenkins CI Server has posted comments on this change.
Change subject: schema: Fixup command return values
..
Patch Set 1:
Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/14/
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: schema: Fixup command return values
..
Patch Set 1: Fails
Build Failed
http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/14/ : FAILURE
--
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: schema: Introduce a Test object
..
Patch Set 1:
Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/15/
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: schema: Introduce a Test object
..
Patch Set 1: Fails
Build Failed
http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/15/ : FAILURE
--
To view,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Specify the ACPI flag when shutting down VMs
..
Patch Set 1: Fails
Build Failed
http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/17/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Specify the ACPI flag when shutting down VMs
..
Patch Set 1: No score
Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/17/
--
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Specify the ACPI flag when shutting down VMs
..
Patch Set 1: No score
Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/16/
--
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Specify the ACPI flag when shutting down VMs
..
Patch Set 1: Fails
Build Failed
http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/16/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: [RFC] Support for GLUSTERFS_DOMAIN
..
Patch Set 2:
Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/27/
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: [RFC] Support for GLUSTERFS_DOMAIN
..
Patch Set 2: Fails
Build Failed
http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/27/ : ABORTED
--
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Specify the ACPI flag when shutting down VMs
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/18/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Specify the ACPI flag when shutting down VMs
..
Patch Set 1:
Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/28/
--
To view,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Specify the ACPI flag when shutting down VMs
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/28/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Specify the ACPI flag when shutting down VMs
..
Patch Set 1:
Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/29/
--
To view,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Specify the ACPI flag when shutting down VMs
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/29/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: call sync before umount in mkFloppyFs
..
Patch Set 2: No score
Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/30/
--
To view,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: call sync before umount in mkFloppyFs
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/30/ : SUCCESS
--
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Support for QEMU cmdline hook
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/34/ : SUCCESS
--
To view,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Support for QEMU cmdline hook
..
Patch Set 3: No score
Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/34/
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: BZ#844656 Release the _syncroot lock during _findDomain
..
Patch Set 7: No score
Build Started
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Specify the ACPI flag when shutting down VMs
..
Patch Set 1: No score
Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/18/
--
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: BZ#844656 Release the _syncroot lock during _findDomain
..
Patch Set 7:
Build Successful
http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/41/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Support the quiesce flag during a live snapshot
..
Patch Set 5: No score
Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/47/
--
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Support the quiesce flag during a live snapshot
..
Patch Set 5:
Build Successful
http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/47/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Initialize the pthread RLock attribute
..
Patch Set 3: No score
Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/48/
--
To view,
1 - 100 of 264 matches
Mail list logo
