Xu He Jie has posted comments on this change.
Change subject: [WIP] Add text-based console support
..
Patch Set 2: (9 inline comments)
Thanks for both of your review!
File
Dan Kenigsberg has posted comments on this change.
Change subject: bootstrap: eliminate extra new line at ~/.ssh/authorized_keys
..
Patch Set 3: Looks good to me, approved
(1 inline comment)
I can live with this.
Zhou Zheng Sheng has uploaded a new change for review.
Change subject: remove the broken support for delivering video to local display
..
remove the broken support for delivering video to local display
In vdsClient help message
Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: eliminate extra new line at ~/.ssh/authorized_keys
..
Patch Set 3: Verified
(1 inline comment)
Yeela Kaplan has posted comments on this change.
Change subject: BZ#844180: Change scsi scan to asynchronous
..
Patch Set 12: Verified
--
To view, visit http://gerrit.ovirt.org/6796
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: bootstrap: eliminate extra new line at ~/.ssh/authorized_keys
..
bootstrap: eliminate extra new line at ~/.ssh/authorized_keys
In the past engine
Dan Kenigsberg has posted comments on this change.
Change subject: remove the broken support for delivering video to local display
..
Patch Set 1: Looks good to me, but someone else must approve
no point in keeping this
Dan Kenigsberg has posted comments on this change.
Change subject: Move load_needed_modules to vdsm-tool
..
Patch Set 7: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7487
To
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: 2 of 2 Add network logs for VDSM network commands and file
operations.
..
2 of 2 Add network logs for VDSM network commands and file operations.
Royce Lv has uploaded a new change for review.
Change subject: Remove vdsm-restore-net-config from ignore list
..
Remove vdsm-restore-net-config from ignore list
As commit 4d16 remove vdsm-restore-net-config.in and add the
Dan Kenigsberg has posted comments on this change.
Change subject: 2 of 2 Add network logs for VDSM network commands and file
operations.
..
Patch Set 1: I would prefer that you didn't submit this
would you mind reversing the
Igor Lvovsky has posted comments on this change.
Change subject: Remove vdsm-restore-net-config from ignore list
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7732
To
Dan Kenigsberg has posted comments on this change.
Change subject: Remove vdsm-restore-net-config from ignore list
..
Patch Set 1: Verified; Looks good to me, approved
oops, this should have been done it in commit 4d16.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Remove vdsm-restore-net-config from ignore list
..
Remove vdsm-restore-net-config from ignore list
As commit 4d16 remove
Dan Kenigsberg has posted comments on this change.
Change subject: Make svdsm files depend on path definitions
..
Patch Set 2: Looks good to me, but someone else must approve
(1 inline comment)
ShaoHe Feng has posted comments on this change.
Change subject: remove the broken support for delivering video to local display
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: BZ#844180: Change scsi scan to asynchronous
..
Patch Set 12:
Build Successful
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/841/ : SUCCESS
--
Yaniv Bronhaim has posted comments on this change.
Change subject: add simple VM creation functional test
..
Patch Set 8: Verified; I would prefer that you didn't submit this
You right. All tests pass both in rhel and fedora
Antoni Segura Puimedon has posted comments on this change.
Change subject: 2 of 2 Add network logs for VDSM network commands and file
operations.
..
Patch Set 1:
Fine. I'll do that asap.
--
To view, visit
Dan Kenigsberg has posted comments on this change.
Change subject: add simple VM creation functional test
..
Patch Set 8:
Yaniv, regarding your (2): assertIn and retryAssert should probably go into
VdsmTestCase. However, this
Yaniv Bronhaim has posted comments on this change.
Change subject: add is_libvirtd_run method and improve comments.
..
Patch Set 2: Verified
(1 inline comment)
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: BZ#844180: Change scsi scan to asynchronous
..
Patch Set 13:
Build Successful
http://jenkins.ovirt.info/job/patch_vdsm_unit_tests/842/ : SUCCESS
--
Laszlo Hornyak has posted comments on this change.
Change subject: report cpuUser and cpuSys separately
..
Patch Set 1: (1 inline comment)
File vdsm/libvirtvm.py
Line 173:
Dan Kenigsberg has posted comments on this change.
Change subject: WIP: refactor configNetwork
..
Patch Set 1: (3 inline comments)
File vdsm/configNetwork.py
Line 837:
Yaniv Bronhaim has posted comments on this change.
Change subject: Move load_needed_modules to vdsm-tool
..
Patch Set 7: Verified
if this code is must for vdsm (it runs in its initialize script..), it sounds
more logical to
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Move load_needed_modules to vdsm-tool
..
Patch Set 7: (1 inline comment)
File
Dan Kenigsberg has posted comments on this change.
Change subject: [WIP] Add text-based console support
..
Patch Set 2: (2 inline comments)
(just a glimpse)
File
Douglas Schilling Landgraf has posted comments on this change.
Change subject: add is_libvirtd_run method and improve comments.
..
Patch Set 2: Verified; Looks good to me, but someone else must approve
--
To view, visit
Federico Simoncelli has posted comments on this change.
Change subject: Update the lvm rules permissions with sanlock
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/7446
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: changed upstart_libvirt function name
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: changed upstart_libvirt function name
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/7671
To unsubscribe, visit
Mark Wu has posted comments on this change.
Change subject: Introduce a new verb setBalloonTarget
..
Patch Set 10:
Doron,
I believe we don't have unit problem now. We just use the same unit as libvirt
api: KiB (1024 bytes)
Gal Hammer has uploaded a new change for review.
Change subject: BZ#829110 Remove a Domain not found error from stats thread.
..
BZ#829110 Remove a Domain not found error from stats thread.
Removed redundant code which changed
Yaniv Bronhaim has posted comments on this change.
Change subject: Make svdsm files depend on path definitions
..
Patch Set 2: Verified; I would prefer that you didn't submit this
(1 inline comment)
Yaniv Bronhaim has posted comments on this change.
Change subject: add simple VM creation functional test
..
Patch Set 8:
Nope, that's it. If we separate this issue to another patch.
I still want to see the conditions that
Antoni Segura Puimedon has posted comments on this change.
Change subject: Added utility to ensure that files written to the file system
happen atomically.
..
Patch Set 2:
There is still the pending issue of the renaming
Yaniv Bronhaim has posted comments on this change.
Change subject: Make svdsm files depend on path definitions
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
--
To view, visit
Doron Fediuck has posted comments on this change.
Change subject: Introduce a new verb setBalloonTarget
..
Patch Set 10: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/3669
To
Igor Lvovsky has uploaded a new change for review.
Change subject: Update MTU when removing one of networks with custom MTU from
NIC/bond
..
Update MTU when removing one of networks with custom MTU from NIC/bond
Bug-Id:
Dan Kenigsberg has posted comments on this change.
Change subject: Make svdsm files depend on path definitions
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7540
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Make svdsm files depend on path definitions
..
Make svdsm files depend on path definitions
The files created by super vdsm process should
be put into
Alon Bar-Lev has posted comments on this change.
Change subject: vdsm: Unifying engine and vdsm commit templates
..
Patch Set 2: (1 inline comment)
File commit-template.txt
Dan Kenigsberg has posted comments on this change.
Change subject: Update MTU when removing one of networks with custom MTU from
NIC/bond
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
Adam Litke has posted comments on this change.
Change subject: Introduce a new verb setBalloonTarget
..
Patch Set 10: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/3669
To
Adam Litke has posted comments on this change.
Change subject: Added gluster tag support in getAllTasks()
..
Patch Set 2: I would prefer that you didn't submit this
(2 inline comments)
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Move load_needed_modules to vdsm-tool
..
Patch Set 7: I would prefer that you didn't submit this
--
To view, visit http://gerrit.ovirt.org/7487
To
Dan Kenigsberg has posted comments on this change.
Change subject: Added utility to ensure that files written to the file system
happen atomically.
..
Patch Set 2: (1 inline comment)
Dan Kenigsberg has posted comments on this change.
Change subject: Update the lvm rules permissions with sanlock
..
Patch Set 2: Looks good to me, approved
copying Mark and Ayal's scores.
--
To view, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Update the lvm rules permissions with sanlock
..
Update the lvm rules permissions with sanlock
The MODE keyword in the lvm rules wasn't used by udev.
Douglas Schilling Landgraf has abandoned this change.
Change subject: nfs-check: check if temp dir exists
..
Patch Set 4: Abandoned
--
To view, visit http://gerrit.ovirt.org/3167
To unsubscribe, visit
Saggi Mizrahi has posted comments on this change.
Change subject: fileSD.getDomUuidFromMetafilePath: return correct sdUUID
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit
Saggi Mizrahi has posted comments on this change.
Change subject: schema: Rename Global class to Host
..
Patch Set 7: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7010
To
Ayal Baron has posted comments on this change.
Change subject: Fix the check to convert block domains V0 to tag metadata
..
Patch Set 2: I would prefer that you didn't submit this
(2 inline comments)
Saggi Mizrahi has posted comments on this change.
Change subject: [WIP] vdsm API and libvdsm
..
Patch Set 1: I would prefer that you didn't submit this
(9 inline comments)
Dan Kenigsberg has posted comments on this change.
Change subject: 1 of 2 Add network logs for VDSM network commands and file
operations.
..
Patch Set 4: I would prefer that you didn't submit this
(6 inline comments)
thanks
Saggi Mizrahi has uploaded a new change for review.
Change subject: Refactor prepareVolumePath
..
Refactor prepareVolumePath
Change-Id: I57bb8684fd11a47843a158d13fcc2815147fa7ef
Signed-off-by: Saggi Mizrahi smizr...@redhat.com
Bala.FA has posted comments on this change.
Change subject: Added gluster tag support in getAllTasks()
..
Patch Set 2: (2 inline comments)
File vdsm/storage/taskManager.py
Royce Lv has posted comments on this change.
Change subject: Remove imageID in diskstats collect
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/7698
To unsubscribe, visit http://gerrit.ovirt.org/settings
Mark Wu has posted comments on this change.
Change subject: report cpuUser and cpuSys separately
..
Patch Set 1: (1 inline comment)
File vdsm/libvirtvm.py
Line 173:
Line
Zhou Zheng Sheng has posted comments on this change.
Change subject: Correct vdsClient's help for the verb getVmsInfo
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit
Dan Kenigsberg has posted comments on this change.
Change subject: Correct vdsClient's help for the verb getVmsInfo
..
Patch Set 4: Verified; Looks good to me, approved
Thanks!
--
To view, visit http://gerrit.ovirt.org/7560
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Correct vdsClient's help for the verb getVmsInfo
..
Correct vdsClient's help for the verb getVmsInfo
Bug-Id:
Dan Kenigsberg has posted comments on this change.
Change subject: changed upstart_libvirt function name
..
Patch Set 1: Looks good to me, approved
valid renaming
--
To view, visit http://gerrit.ovirt.org/7671
To unsubscribe,
Dan Kenigsberg has submitted this change and it was merged.
Change subject: changed upstart_libvirt function name
..
changed upstart_libvirt function name
Change-Id: I7b773b04766346ab9b00fba6a1f083cffd89
Signed-off-by:
Dan Kenigsberg has posted comments on this change.
Change subject: add is_libvirtd_run method and improve comments.
..
Patch Set 2: I would prefer that you didn't submit this
(2 inline comments)
65 matches
Mail list logo
