Douglas Schilling Landgraf has posted comments on this change.
Change subject: Move load_needed_modules to vdsm-tool
......................................................................
Patch Set 7: (1 inline comment)
....................................................
File vdsm-tool/load_needed_modules.py.in
Line 42: def _enable_bond_dev():
Line 43: REQUIRED = set(['bond0', 'bond1', 'bond2', 'bond3', 'bond4'])
Line 44: MASTER_FILE = '/sys/class/net/bonding_masters'
Line 45:
Line 46: # RHEV-M currently assumes that all bonding devices pre-exist
I would suggest @ENGINENAME@
Line 47: existing = set(file(MASTER_FILE).read().split())
Line 48: with open(MASTER_FILE) as f:
Line 49: for bond in REQUIRED - existing:
Line 50: f.write('+%s\n' % bond)
--
To view, visit http://gerrit.ovirt.org/7487
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icdc8f9d07a7150c4a846228811d6c5dcb17fa358
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Wenyi Gao <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Wenyi Gao <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
