Change in vdsm[ovirt-3.3]: Add support for direct setting of cpu_shares when creating a...

2013-08-04 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: Add support for direct setting of cpu_shares when creating a VM .. Patch Set 2: (1 inline comment) File

Change in vdsm[master]: Management network is now kept in main routing table

2013-08-04 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Management network is now kept in main routing table .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3690/ :

Change in vdsm[ovirt-3.3]: VDSM now writes its version number in VDSM-generated ifcfg f...

2013-08-04 Thread amuller
Hello Dan Kenigsberg, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/17612 to review the following change. Change subject: VDSM now writes its version number in VDSM-generated ifcfg files .. VDSM

Change in vdsm[master]: Management network is now kept in main routing table

2013-08-04 Thread amuller
Assaf Muller has posted comments on this change. Change subject: Management network is now kept in main routing table .. Patch Set 5: Verified -- To view, visit http://gerrit.ovirt.org/17575 To unsubscribe, visit

Change in vdsm[ovirt-3.3]: VDSM now writes its version number in VDSM-generated ifcfg f...

2013-08-04 Thread amuller
Assaf Muller has posted comments on this change. Change subject: VDSM now writes its version number in VDSM-generated ifcfg files .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/17612 To unsubscribe, visit

Change in vdsm[master]: ClientIF: avoid runtime errors at VM shutdown

2013-08-04 Thread ykaplan
Yeela Kaplan has posted comments on this change. Change subject: ClientIF: avoid runtime errors at VM shutdown .. Patch Set 3: I would prefer that you didn't submit this (1 inline comment) This will not fix the issue, since

Change in vdsm[master]: Management network is now kept in main routing table

2013-08-04 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Management network is now kept in main routing table .. Patch Set 5: I would prefer that you didn't submit this (1 inline comment) So sorry, I might have

Change in vdsm[ovirt-3.3]: VDSM now writes its version number in VDSM-generated ifcfg f...

2013-08-04 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: VDSM now writes its version number in VDSM-generated ifcfg files .. Patch Set 1: I would prefer that you didn't submit this (1 inline comment) -1 for

Change in vdsm[master]: tests: delNetwork with specified mtu.

2013-08-04 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: tests: delNetwork with specified mtu. .. Patch Set 2: I would prefer that you didn't submit this (1 inline comment)

Change in vdsm[master]: tests: delNetwork with specified mtu.

2013-08-04 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: tests: delNetwork with specified mtu. .. Patch Set 1: (1 inline comment) File

Change in vdsm[master]: tests: addNetwork bond with one or many vlans.

2013-08-04 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: tests: addNetwork bond with one or many vlans. .. Patch Set 7: Looks good to me, but someone else must approve Thanks for the changes ;-) -- To view,

Change in vdsm[master]: Killing vdsm when first communication to libvirt fails

2013-08-04 Thread ybronhei
Yaniv Bronhaim has uploaded a new change for review. Change subject: Killing vdsm when first communication to libvirt fails .. Killing vdsm when first communication to libvirt fails Change-Id:

Change in vdsm[master]: tests: setupNetworks with invalid params.

2013-08-04 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: tests: setupNetworks with invalid params. .. Patch Set 3: (1 inline comment) File

Change in vdsm[master]: tests: addNetwork with one or more vlans.

2013-08-04 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: tests: addNetwork with one or more vlans. .. Patch Set 4: Looks good to me, but someone else must approve -- To view, visit

Change in vdsm[master]: refactoring: fix imports stmts, replaced glob with iglob for...

2013-08-04 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: refactoring: fix imports stmts, replaced glob with iglob for uniformity. .. Patch Set 5: Looks good to me, but someone else must approve -- To view,

Change in vdsm[master]: tests: setupNetworks add one or more vlans.

2013-08-04 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: tests: setupNetworks add one or more vlans. .. Patch Set 2: I would prefer that you didn't submit this (1 inline comment)

Change in vdsm[master]: Killing vdsm when first communication to libvirt fails

2013-08-04 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Killing vdsm when first communication to libvirt fails .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3692/ :

Change in vdsm[master]: tests: setupNetworks compatibility bond and nic.

2013-08-04 Thread gvallare
Giuseppe Vallarelli has uploaded a new change for review. Change subject: tests: setupNetworks compatibility bond and nic. .. tests: setupNetworks compatibility bond and nic. Added four functional tests, testing setupNetworks

Change in vdsm[master]: tests: setupNetworks compatibility bond and nic.

2013-08-04 Thread gvallare
Giuseppe Vallarelli has posted comments on this change. Change subject: tests: setupNetworks compatibility bond and nic. .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/17621 To unsubscribe, visit

Change in vdsm[master]: tests: setupNetworks compatibility bond and nic.

2013-08-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: setupNetworks compatibility bond and nic. .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3693/ :

Change in vdsm[master]: tests: delNetwork with specified mtu.

2013-08-04 Thread gvallare
Giuseppe Vallarelli has posted comments on this change. Change subject: tests: delNetwork with specified mtu. .. Patch Set 3: Verified+1 Updating commit msg. -- To view, visit http://gerrit.ovirt.org/17400 To unsubscribe,

Change in vdsm[master]: tests: setupNetworks compatibility bond and nic.

2013-08-04 Thread gvallare
Giuseppe Vallarelli has posted comments on this change. Change subject: tests: setupNetworks compatibility bond and nic. .. Patch Set 2: Verified+1 Cherry picked on top of the updated dependency patch. -- To view, visit

Change in vdsm[master]: tests: delNetwork with specified mtu.

2013-08-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: delNetwork with specified mtu. .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3694/ : SUCCESS

Change in vdsm[master]: tests: setupNetworks compatibility bond and nic.

2013-08-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: setupNetworks compatibility bond and nic. .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3695/ :

Change in vdsm[master]: infra: Rearrange PYTHONPATH for remoteFileHandler

2013-08-04 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: infra: Rearrange PYTHONPATH for remoteFileHandler .. Patch Set 7: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/14627 To unsubscribe, visit

Change in vdsm[master]: tests: setupNetworks add one or more vlans.

2013-08-04 Thread gvallare
Giuseppe Vallarelli has posted comments on this change. Change subject: tests: setupNetworks add one or more vlans. .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.ovirt.org/17432 To unsubscribe, visit

Change in vdsm[master]: tests: setupNetworks add one or more vlans.

2013-08-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: setupNetworks add one or more vlans. .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3696/ : SUCCESS

Change in vdsm[master]: tests: setupNetworks with invalid params.

2013-08-04 Thread gvallare
Giuseppe Vallarelli has posted comments on this change. Change subject: tests: setupNetworks with invalid params. .. Patch Set 4: Verified+1 Cherrypicked on top of the updated dependency patch. -- To view, visit

Change in vdsm[master]: tests: setupNetworks with invalid params.

2013-08-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: setupNetworks with invalid params. .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3697/ : SUCCESS

Change in vdsm[master]: tests: delNetwork with specified mtu.

2013-08-04 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: tests: delNetwork with specified mtu. .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/17400 To unsubscribe, visit

Change in vdsm[master]: tests: setupNetworks add one or more vlans.

2013-08-04 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: tests: setupNetworks add one or more vlans. .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/17432 To unsubscribe, visit

Change in vdsm[master]: multipath: Use reload option on multipath rescan

2013-08-04 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: multipath: Use reload option on multipath rescan .. multipath: Use reload option on multipath rescan Change-Id:

Change in vdsm[master]: refactoring: fix imports stmts, replaced glob with iglob for...

2013-08-04 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: refactoring: fix imports stmts, replaced glob with iglob for uniformity. .. refactoring: fix imports stmts, replaced glob with iglob for uniformity.

Change in vdsm[master]: QoS host networks: caps now reports QoS for networks.

2013-08-04 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: QoS host networks: caps now reports QoS for networks. .. QoS host networks: caps now reports QoS for networks. In the context of applying QoS to host

Change in vdsm[master]: QoS host networks: caps now reports QoS for networks.

2013-08-04 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: QoS host networks: caps now reports QoS for networks. .. Patch Set 7: Verified+1 Code-Review+2 seems fine, passed functional tests. -- To view, visit

Change in vdsm[master]: refactoring: fix imports stmts, replaced glob with iglob for...

2013-08-04 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: refactoring: fix imports stmts, replaced glob with iglob for uniformity. .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/16838 To

Change in vdsm[master]: tests: setupNetworks add net bond breaking and resizing.

2013-08-04 Thread gvallare
Giuseppe Vallarelli has uploaded a new change for review. Change subject: tests: setupNetworks add net bond breaking and resizing. .. tests: setupNetworks add net bond breaking and resizing. Added 3 functional tests to cover

Change in vdsm[master]: tests: setupNetworks add net bond breaking and resizing.

2013-08-04 Thread gvallare
Giuseppe Vallarelli has posted comments on this change. Change subject: tests: setupNetworks add net bond breaking and resizing. .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/17634 To unsubscribe, visit

Change in vdsm[master]: tests: setupNetworks add net bond breaking and resizing.

2013-08-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: setupNetworks add net bond breaking and resizing. .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3698/

Change in vdsm[ovirt-3.3]: VDSM now writes its version number in VDSM-generated ifcfg f...

2013-08-04 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: VDSM now writes its version number in VDSM-generated ifcfg files .. Patch Set 1: Code-Review-1 (1 comment)

Change in vdsm[master]: vdsm: Always retrieve alias for Balloon and Console devices

2013-08-04 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vdsm: Always retrieve alias for Balloon and Console devices .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/17602 To unsubscribe,

Change in vdsm[master]: tests: delNetwork with specified mtu.

2013-08-04 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: tests: delNetwork with specified mtu. .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/17400 To unsubscribe, visit

Change in vdsm[master]: tests: delNetwork with specified mtu.

2013-08-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: delNetwork with specified mtu. .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3699/ : SUCCESS

Change in vdsm[master]: tests: delNetwork with specified mtu.

2013-08-04 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: tests: delNetwork with specified mtu. .. Patch Set 4: Verified+1 Code-Review+2 manual rebase, copying scores. -- To view, visit http://gerrit.ovirt.org/17400

Change in vdsm[master]: tests: delNetwork with specified mtu.

2013-08-04 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: tests: delNetwork with specified mtu. .. tests: delNetwork with specified mtu. Added one functional test: * testDelNetworkWithMTU covering the

Change in vdsm[master]: Killing vdsm when first communication to libvirt fails

2013-08-04 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Killing vdsm when first communication to libvirt fails .. Patch Set 2: Code-Review-1 libvirtconnection is a helper module. it is highly non-conventional for

Change in vdsm[ovirt-3.3]: Add support for direct setting of cpu_shares when creating a VM

2013-08-04 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Add support for direct setting of cpu_shares when creating a VM .. Patch Set 2: Martin, the bug you quoted is private, and is not related to the upstream

Change in vdsm[master]: tests: bondHwAddress, safeNetworkConfig, volatileConfig

2013-08-04 Thread gvallare
Giuseppe Vallarelli has uploaded a new change for review. Change subject: tests: bondHwAddress, safeNetworkConfig, volatileConfig .. tests: bondHwAddress, safeNetworkConfig, volatileConfig Added three functional tests: *

Change in vdsm[master]: tests: bondHwAddress, safeNetworkConfig, volatileConfig

2013-08-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: bondHwAddress, safeNetworkConfig, volatileConfig .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3700/ :

Change in vdsm[master]: tests: bondHwAddress, safeNetworkConfig, volatileConfig

2013-08-04 Thread gvallare
Giuseppe Vallarelli has posted comments on this change. Change subject: tests: bondHwAddress, safeNetworkConfig, volatileConfig .. Patch Set 1: (1 comment) the except for volatileConfig the other tests work as expected.

Change in vdsm[master]: netconf: enable multiple gateways for iproute2 configurator

2013-08-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: netconf: enable multiple gateways for iproute2 configurator .. Patch Set 3: Verified-1 Build Failed

Change in vdsm[master]: netconf: Add dhcp support for iproute2 configurator

2013-08-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: netconf: Add dhcp support for iproute2 configurator .. Patch Set 4: Verified-1 Build Failed

Change in vdsm[master]: Add iproute2 configurator

2013-08-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Add iproute2 configurator .. Patch Set 5: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3703/ : SUCCESS

Change in vdsm[master]: Bump requires version of selinux-policy-targeted

2013-08-04 Thread wudxw
Mark Wu has uploaded a new change for review. Change subject: Bump requires version of selinux-policy-targeted .. Bump requires version of selinux-policy-targeted Current SElinux policy prevent the dhcp hook for source routing

Change in vdsm[master]: Bump requires version of selinux-policy-targeted

2013-08-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Bump requires version of selinux-policy-targeted .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3704/ :

Change in vdsm[master]: gluster: command to create a public key file

2013-08-04 Thread dnarayan
Hello Bala.FA, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/17644 to review the following change. Change subject: gluster: command to create a public key file .. gluster: command to create a

Change in vdsm[master]: gluster: command to create a public key file

2013-08-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: command to create a public key file .. Patch Set 1: Code-Review-1 Build Unstable http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3705/