Dan Kenigsberg has posted comments on this change.
Change subject: Management network is now kept in main routing table
......................................................................
Patch Set 5: I would prefer that you didn't submit this
(1 inline comment)
So sorry, I might have missed the "Publish comments" button, just like Toni
earlier...
....................................................
File vdsm/configNetwork.py
Line 182: for nic in nics:
Line 183: _validateInterNetworkCompatibility(_netinfo, vlan,
nic,
Line 184: bridged)
Line 185:
Line 186: options['DEFROUTE'] = \
This option name is so very initscripts-oriented. I would very much prefer a
fully-fledged named argument to objectivizeNetwork. defRoute=False, maybe? Or
name it mgmtNet, so in the future we can move it out to Engine to decide?
Line 187: 'yes' if network == constants.MANAGEMENT_NETWORK else 'no'
Line 188:
Line 189: logging.info("Adding network %s with vlan=%s, bonding=%s,
nics=%s,"
Line 190: " bondingOptions=%s, mtu=%s, bridged=%s, options=%s",
--
To view, visit http://gerrit.ovirt.org/17575
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I55c50269dd3d52fd058951200282c925a7014aca
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amul...@redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com>
Gerrit-Reviewer: Assaf Muller <amul...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
