Change in vdsm[master]: Removing automatic restart of services in libvirt-reconfigure

2013-09-12 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: Removing automatic restart of services in libvirt-reconfigure .. Patch Set 5: No, we just add comment to do it manually. sysv script calls

Change in vdsm[master]: Removing automatic restart of services in libvirt-reconfigure

2013-09-12 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: Removing automatic restart of services in libvirt-reconfigure .. Patch Set 5: The following will not restarting libvirt while it should for backward

Change in vdsm[master]: Fix getStorageDomainInfo() logic.

2013-09-12 Thread oourfali
Oved Ourfali has posted comments on this change. Change subject: Fix getStorageDomainInfo() logic. .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/14671 To unsubscribe, visit

Change in vdsm[master]: Removing automatic restart of services in libvirt-reconfigure

2013-09-12 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: Removing automatic restart of services in libvirt-reconfigure .. Patch Set 5: yes? I didn't think about it much. so each call to service vdsmd reconfigure

Change in vdsm[master]: Nits: clean the magic number for seek()

2013-09-12 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Nits: clean the magic number for seek() .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/11390 To unsubscribe, visit

Change in vdsm[master]: lib: add create function to the qemuImg module

2013-09-12 Thread ykaplan
Yeela Kaplan has posted comments on this change. Change subject: lib: add create function to the qemuImg module .. Patch Set 2: Code-Review+1 great work! I was just writing the same patch :) -- To view, visit

Change in vdsm[master]: Packaging: Fix help string and usage for --disable-libvirt-s...

2013-09-12 Thread zhshzhou
Zhou Zheng Sheng has posted comments on this change. Change subject: Packaging: Fix help string and usage for --disable-libvirt-sanlock .. Patch Set 4: (1 comment) File

Change in vdsm[master]: Removing automatic restart of services in libvirt-reconfigure

2013-09-12 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: Removing automatic restart of services in libvirt-reconfigure .. Patch Set 5: the expected for legacy is reconfigure restart libvirt -- To view, visit

Change in vdsm[master]: Unified network persistence [2/4] Respond to setSafeNetworkC...

2013-09-12 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: Unified network persistence [2/4] Respond to setSafeNetworkConfig .. Patch Set 8: (1 comment)

Change in vdsm[master]: Nits: clean the magic number for seek()

2013-09-12 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Nits: clean the magic number for seek() .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/11390 To unsubscribe, visit

Change in vdsm[master]: Nits: clean the magic number for seek()

2013-09-12 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: Nits: clean the magic number for seek() .. Nits: clean the magic number for seek() Change-Id: I65625ae7a41649e290636c95f0e694c065fe42dc Signed-off-by:

Change in vdsm[master]: Modification in lockfile usage mechanism as part of sysv ini...

2013-09-12 Thread zhshzhou
Zhou Zheng Sheng has posted comments on this change. Change subject: Modification in lockfile usage mechanism as part of sysv init script .. Patch Set 14: Code-Review-1 (2 comments)

Change in vdsm[master]: Removing automatic restart of services in libvirt-reconfigure

2013-09-12 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Removing automatic restart of services in libvirt-reconfigure .. Patch Set 6: Build Successful

Change in vdsm[master]: Modification in lockfile usage mechanism as part of sysv ini...

2013-09-12 Thread zhshzhou
Zhou Zheng Sheng has posted comments on this change. Change subject: Modification in lockfile usage mechanism as part of sysv init script .. Patch Set 14: (1 comment) File

Change in vdsm[master]: sp: update lease parameters on masterMigrate

2013-09-12 Thread fsimonce
Federico Simoncelli has uploaded a new change for review. Change subject: sp: update lease parameters on masterMigrate .. sp: update lease parameters on masterMigrate In this patch: - update lease parameters on masterMigrate -

Change in vdsm[master]: sp: update lease parameters on masterMigrate

2013-09-12 Thread fsimonce
Federico Simoncelli has posted comments on this change. Change subject: sp: update lease parameters on masterMigrate .. Patch Set 1: (1 comment) File vdsm/storage/sp.py

Change in vdsm[master]: sp: update lease parameters on masterMigrate

2013-09-12 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: sp: update lease parameters on masterMigrate .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4383/ :

Change in vdsm[master]: sp: update lease parameters on masterMigrate

2013-09-12 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: sp: update lease parameters on masterMigrate .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4384/ : SUCCESS

Change in vdsm[master]: gluster: bug fix for listing and adding hook

2013-09-12 Thread barumuga
Bala.FA has posted comments on this change. Change subject: gluster: bug fix for listing and adding hook .. Patch Set 6: Code-Review-1 (2 comments) File

Change in vdsm[master]: sp: update lease parameters on masterMigrate

2013-09-12 Thread fsimonce
Federico Simoncelli has posted comments on this change. Change subject: sp: update lease parameters on masterMigrate .. Patch Set 2: (1 comment) File vdsm/storage/sp.py

Change in vdsm[master]: gluster: Using XML output for rebalance/remove-brick status ...

2013-09-12 Thread barumuga
Bala.FA has posted comments on this change. Change subject: gluster: Using XML output for rebalance/remove-brick status verbs .. Patch Set 7: Code-Review-1 (4 comments)

Change in vdsm[master]: Modification in lockfile usage mechanism as part of sysv ini...

2013-09-12 Thread zhshzhou
Zhou Zheng Sheng has posted comments on this change. Change subject: Modification in lockfile usage mechanism as part of sysv init script .. Patch Set 14: (1 comment) File

Change in vdsm[master]: vdsmd.init: remove legacy judgment code

2013-09-12 Thread mhuntxu
Hunt Xu has abandoned this change. Change subject: vdsmd.init: remove legacy judgment code .. Abandoned -- To view, visit http://gerrit.ovirt.org/12875 To unsubscribe, visit http://gerrit.ovirt.org/settings

Change in vdsm[master]: Read pool metadata once in StoragePool.getInfo()

2013-09-12 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Read pool metadata once in StoragePool.getInfo() .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4385/ :

Change in vdsm[master]: Removing automatic restart of services in libvirt-reconfigure

2013-09-12 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: Removing automatic restart of services in libvirt-reconfigure .. Patch Set 6: (2 comments) File

Change in vdsm[master]: Make getRepoStats() a hsm method.

2013-09-12 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Make getRepoStats() a hsm method. .. Patch Set 6: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4386/ : FAILURE

Change in vdsm[master]: netconf: Fix the mtu of bond and nic can't be set for new ne...

2013-09-12 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: netconf: Fix the mtu of bond and nic can't be set for new network .. Patch Set 2: Code-Review-1 (1 comment) Mark, thanks a lot for this patch - it unbreaks

Change in vdsm[master]: Modification in lockfile usage mechanism as part of sysv ini...

2013-09-12 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: Modification in lockfile usage mechanism as part of sysv init script .. Patch Set 14: (1 comment) File

Change in vdsm[master]: [WIP] Adding monitorDomains.

2013-09-12 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: [WIP] Adding monitorDomains. .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4387/ : SUCCESS

Change in vdsm[master]: Fix getStorageDomainInfo() logic.

2013-09-12 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Fix getStorageDomainInfo() logic. .. Patch Set 4: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4388/ : FAILURE

Change in vdsm[master]: Testcase vlaned network to bridgeless

2013-09-12 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Testcase vlaned network to bridgeless .. Patch Set 3: Code-Review-1 Verified-1 Build Failed

Change in vdsm[master]: Testcase vlaned network to bridgeless

2013-09-12 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Testcase vlaned network to bridgeless .. Patch Set 4: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4390/ : FAILURE

Change in vdsm[master]: Unified network persistence [1/3] - Save running config

2013-09-12 Thread wudxw
Mark Wu has posted comments on this change. Change subject: Unified network persistence [1/3] - Save running config .. Patch Set 22: Code-Review-1 (2 comments) File

Change in vdsm[master]: Functional Tests [2/3]: Added ipwrapper.ruleExists+routeExists

2013-09-12 Thread amuller
Assaf Muller has posted comments on this change. Change subject: Functional Tests [2/3]: Added ipwrapper.ruleExists+routeExists .. Patch Set 5: (6 comments) File

Change in vdsm[master]: Functional Tests [2/3]: Added ipwrapper.ruleExists+routeExists

2013-09-12 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Functional Tests [2/3]: Added ipwrapper.ruleExists+routeExists .. Patch Set 6: Verified-1 Build Failed

Change in vdsm[master]: Functional Tests [2/3]: Added ipwrapper.ruleExists+routeExists

2013-09-12 Thread amuller
Assaf Muller has posted comments on this change. Change subject: Functional Tests [2/3]: Added ipwrapper.ruleExists+routeExists .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.ovirt.org/18040 To unsubscribe, visit

Change in vdsm[master]: netconf: Fix the mtu of bond and nic can't be set for new ne...

2013-09-12 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: netconf: Fix the mtu of bond and nic can't be set for new network .. Patch Set 2: Bug-Url: https://bugzilla.redhat.com/1004196 is caused by not updating the

Change in vdsm[master]: Functional Tests [2/3]: Added ipwrapper.ruleExists+routeExists

2013-09-12 Thread amuller
Assaf Muller has posted comments on this change. Change subject: Functional Tests [2/3]: Added ipwrapper.ruleExists+routeExists .. Patch Set 6: Jenkins failure is unrelated to patch. -- To view, visit

Change in vdsm[master]: Functional Tests [3/3]: Added static source routing function...

2013-09-12 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Functional Tests [3/3]: Added static source routing functional test .. Patch Set 6: Build Successful

Change in vdsm[ovirt-3.3]: vdsmd.init: Add service-is-managed in shutdown_conflicting_srv

2013-09-12 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change. Change subject: vdsmd.init: Add service-is-managed in shutdown_conflicting_srv .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/19197 To

Change in vdsm[ovirt-3.3]: vdsmd.init: Add service-is-managed in shutdown_conflicting_srv

2013-09-12 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change. Change subject: vdsmd.init: Add service-is-managed in shutdown_conflicting_srv .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/19197 To

Change in vdsm[ovirt-3.3]: vdsmd.init: Add service-is-managed in shutdown_conflicting_srv

2013-09-12 Thread dougsland
Douglas Schilling Landgraf has uploaded a new change for review. Change subject: vdsmd.init: Add service-is-managed in shutdown_conflicting_srv .. vdsmd.init: Add service-is-managed in shutdown_conflicting_srv We should not

Change in vdsm[master]: Make getRepoStats() a hsm method.

2013-09-12 Thread abaron
Ayal Baron has posted comments on this change. Change subject: Make getRepoStats() a hsm method. .. Patch Set 6: Code-Review+2 It was hard, but after running with meld to compare the changes between sp and hsm this is indeed

Change in vdsm[master]: [WIP]vdsmapi: gluster: vdsmapi schema definitions for existi...

2013-09-12 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: [WIP]vdsmapi: gluster: vdsmapi schema definitions for existing gluster verbs .. Patch Set 4: Build Successful

Change in vdsm[master]: gluster: command to create and delete a geo-replication session

2013-09-12 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: command to create and delete a geo-replication session .. Patch Set 17: Build Successful

Change in vdsm[master]: gluster: geo-replication start and stop session

2013-09-12 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: geo-replication start and stop session .. Patch Set 3: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4397/ :

Change in vdsm[master]: Fix missing bootprot line

2013-09-12 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Fix missing bootprot line .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4394/ : SUCCESS

Change in vdsm[ovirt-3.3]: vdsmd.init: Add service-is-managed in shutdown_conflicting_srv

2013-09-12 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vdsmd.init: Add service-is-managed in shutdown_conflicting_srv .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/19197 To unsubscribe,

Change in vdsm[master]: gluster: bug fix for listing and adding hook

2013-09-12 Thread tjeyasin
Timothy Asir has posted comments on this change. Change subject: gluster: bug fix for listing and adding hook .. Patch Set 6: (2 comments) File vdsm/gluster/hooks.py Line

Change in vdsm[master]: gluster: bug fix for listing and adding hook

2013-09-12 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: bug fix for listing and adding hook .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4395/ : SUCCESS

Change in vdsm[master]: gluster: geo-replication start and stop session

2013-09-12 Thread tjeyasin
Timothy Asir has posted comments on this change. Change subject: gluster: geo-replication start and stop session .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.ovirt.org/17766 To unsubscribe, visit

Change in vdsm[master]: Functional Tests [3/3]: Added static source routing function...

2013-09-12 Thread amuller
Assaf Muller has posted comments on this change. Change subject: Functional Tests [3/3]: Added static source routing functional test .. Patch Set 5: (2 comments) File

Change in vdsm[ovirt-3.3]: vdsmd.init: Add service-is-managed in shutdown_conflicting_srv

2013-09-12 Thread fsimonce
Federico Simoncelli has submitted this change and it was merged. Change subject: vdsmd.init: Add service-is-managed in shutdown_conflicting_srv .. vdsmd.init: Add service-is-managed in shutdown_conflicting_srv We should not

Change in vdsm[master]: Introduce lvm short filters.

2013-09-12 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Introduce lvm short filters. .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4393/ : FAILURE

Change in vdsm[master]: [WIP]Avoid prepare template by using unsafe qemu-img rebase

2013-09-12 Thread ykaplan
Yeela Kaplan has posted comments on this change. Change subject: [WIP]Avoid prepare template by using unsafe qemu-img rebase .. Patch Set 4: (2 comments) File

Change in vdsm[master]: lib: add create function to the qemuImg module

2013-09-12 Thread fsimonce
Federico Simoncelli has posted comments on this change. Change subject: lib: add create function to the qemuImg module .. Patch Set 2: Verified+1 In my current use case it works (backup api). Feel free to merge if you need