- Original Message -
From: Dan Kenigsberg dan...@redhat.com
To: ee...@redhat.com
Cc: vdsm-patches@lists.fedorahosted.org, asegu...@redhat.com
Sent: Monday, November 18, 2013 12:14:52 AM
Subject: Re: [oVirt Jenkins] vdsm_create_rpms - Build # 812 - Failure!
On Sun, Nov 17, 2013 at
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: autotools: fix make distcheck
..
autotools: fix make distcheck
Change-Id: Iba50c8540f35dbe64c67addf3ae522dc4957718a
Signed-off-by: Antoni S. Puimedon
oVirt Jenkins CI Server has posted comments on this change.
Change subject: autotools: fix make distcheck
..
Patch Set 1: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4679/ : FAILURE
Dan Kenigsberg has posted comments on this change.
Change subject: lvm: deactivate lvs during bootstrap
..
Patch Set 5:
(1 comment)
File vdsm/storage/lvm.py
Line 660:
Thanks Eyal!
- Original Message -
From: Eyal Edri ee...@redhat.com
To: Dan Kenigsberg dan...@redhat.com
Cc: vdsm-patches@lists.fedorahosted.org, asegu...@redhat.com
Sent: Monday, November 18, 2013 9:31:27 AM
Subject: Re: [oVirt Jenkins] vdsm_create_rpms - Build # 812 - Failure!
Vinzenz Feenstra has posted comments on this change.
Change subject: Migration cancellation replies wrong message format
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/21250
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Migration cancellation replies wrong message format
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4680/ :
On Mon, Nov 18, 2013 at 03:36:45AM -0500, Antoni Segura Puimedon wrote:
Thanks Eyal!
Toni, that's not enough - we should add a BuildRequires line for
something that our build scrtip requires.
___
vdsm-patches mailing list
Nir Soffer has posted comments on this change.
Change subject: sampling: take storageDomains directly from storage subsys
..
Patch Set 2:
(1 comment)
Looks good, but we get do another little cleanup - sorry for not seeing
Nir Soffer has posted comments on this change.
Change subject: lvm: deactivate lvs during bootstrap
..
Patch Set 5:
(2 comments)
Nice. if I understand the logic correctly you have my +1. Although, didn't
you want to run it
Dan Kenigsberg has posted comments on this change.
Change subject: sampling: take storageDomains directly from storage subsys
..
Patch Set 2:
(1 comment)
File vdsm/API.py
Petr Šebek has posted comments on this change.
Change subject: Get rid of mutables(lists) as default parameters
..
Patch Set 5: Verified+1 Code-Review+1
I applied given patch to my host. In webadmin host smoothly went from
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: vdsm.spec: Add python-inotify as buildrequires dep
..
vdsm.spec: Add python-inotify as buildrequires dep
This is needed because now the configure step
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm.spec: Add python-inotify as buildrequires dep
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4681/ :
Nir Soffer has posted comments on this change.
Change subject: sampling: take storageDomains directly from storage subsys
..
Patch Set 2: Code-Review+1
Looks good, would be little better with the cleanup suggested.
--
To
Sent a patch that adds python-inotify as buildrequires (added Dan and Eyal
as reviewers).
In general, anything that is a required by the main vdsm component should
be a buildrequires and a requires and things which are only required for
building should be only in the former category. I say this
Federico Simoncelli has submitted this change and it was merged.
Change subject: domainMonitor: tag pool monitored domains
..
domainMonitor: tag pool monitored domains
As part of the monitoring implementation:
7b1cc6a Adding
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Fail pre-start run after configure libvirt
..
Fail pre-start run after configure libvirt
After configuring libvirt we should restart libvirtd manually. If
Alon Bar-Lev has posted comments on this change.
Change subject: Fail pre-start run after configure libvirt
..
Patch Set 1:
(1 comment)
File init/vdsmd_init_common.sh.in
Yaniv Bronhaim has posted comments on this change.
Change subject: Fail pre-start run after configure libvirt
..
Patch Set 1:
(1 comment)
File init/vdsmd_init_common.sh.in
Alon Bar-Lev has posted comments on this change.
Change subject: Fail pre-start run after configure libvirt
..
Patch Set 1:
(1 comment)
File init/vdsmd_init_common.sh.in
Yaniv Bronhaim has posted comments on this change.
Change subject: Fail pre-start run after configure libvirt
..
Patch Set 1:
(1 comment)
File init/vdsmd_init_common.sh.in
Alon Bar-Lev has posted comments on this change.
Change subject: Fail pre-start run after configure libvirt
..
Patch Set 1:
(1 comment)
File init/vdsmd_init_common.sh.in
Yaniv Bronhaim has posted comments on this change.
Change subject: Fail pre-start run after configure libvirt
..
Patch Set 1:
(1 comment)
File init/vdsmd_init_common.sh.in
Assaf Muller has posted comments on this change.
Change subject: Add unit tests for unified network persistence
..
Patch Set 4:
(2 comments)
File
Assaf Muller has posted comments on this change.
Change subject: Add unit tests for unified network persistence
..
Patch Set 5: Verified+1
--
To view, visit http://gerrit.ovirt.org/21269
To unsubscribe, visit
Hello Ayal Baron,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/21357
to review the following change.
Change subject: domainMonitor: tag pool monitored domains
..
domainMonitor: tag pool
Sandro Bonazzola has posted comments on this change.
Change subject: Adding [start|stop]MonitoringDomain().
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/20194
To unsubscribe, visit
Sandro Bonazzola has posted comments on this change.
Change subject: stats: return domain lockspace status
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/20193
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: Add unit tests for unified network persistence
..
Patch Set 4:
(1 comment)
File
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Get rid of mutables(lists) as default parameters
..
Get rid of mutables(lists) as default parameters
In Python having a mutable as a default method
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm.spec: Add python-inotify as buildrequires dep
..
Patch Set 1: Verified+1 Code-Review+2
not really verfied by me.
--
To view, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vdsm.spec: Add python-inotify as buildrequires dep
..
vdsm.spec: Add python-inotify as buildrequires dep
This is needed because now the configure step
Dan Kenigsberg has posted comments on this change.
Change subject: spec: Don't depend on unreleased RPMs.
..
Patch Set 1: Code-Review-1
We actually want this on master. It should reach ovirt-3.3 only if (and when)
the iscsi
Allon Mureinik has posted comments on this change.
Change subject: lvm: deactivate lvs during bootstrap
..
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21291
To unsubscribe, visit
Darshan N has posted comments on this change.
Change subject: gluster: new verb to remove host using host UUID
..
Patch Set 6: Verified+1
--
To view, visit http://gerrit.ovirt.org/20648
To unsubscribe, visit
Hello Douglas Schilling Landgraf, mooli tayer,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/21363
to review the following change.
Change subject: caps: coarse-grain libvirt.rpm may be missing
..
Dan Kenigsberg has submitted this change and it was merged.
Change subject: gluster: new verb to remove host using host UUID
..
gluster: new verb to remove host using host UUID
This patch adds a new verb
Douglas Schilling Landgraf has posted comments on this change.
Change subject: caps: coarse-grain libvirt.rpm may be missing
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21363
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Report qemu-kvm-rhev if installed
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21364
To unsubscribe, visit
mooli tayer has posted comments on this change.
Change subject: caps: coarse-grain libvirt.rpm may be missing
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21363
To unsubscribe, visit
Humble Devassy Chirammal has posted comments on this change.
Change subject: Report qemu-kvm-rhev if installed
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21364
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: domainMonitor: tag pool monitored domains
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21357
To unsubscribe, visit
Alon Bar-Lev has posted comments on this change.
Change subject: Fail pre-start run after configure libvirt
..
Patch Set 2:
(1 comment)
File init/vdsmd_init_common.sh.in
Federico Simoncelli has posted comments on this change.
Change subject: lvm: deactivate lvs during bootstrap
..
Patch Set 5: Code-Review+1
(3 comments)
Few comments. +1 for now, I still have doubts.
Dan Kenigsberg has posted comments on this change.
Change subject: xmlrpc: Parsing error logging enhancement - vdsClient
..
Patch Set 8: Code-Review-1
ouch, manual rebase needed.
--
To view, visit
Assaf Muller has posted comments on this change.
Change subject: Add unit tests for unified network persistence
..
Patch Set 4:
(1 comment)
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add unit tests for unified network persistence
..
Patch Set 6: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4683/
Assaf Muller has posted comments on this change.
Change subject: Add unit tests for unified network persistence
..
Patch Set 6: Verified+1
The test that fails on Jenkins works on my host.
--
To view, visit
Federico Simoncelli has posted comments on this change.
Change subject: vm: prevent faulty volume extensions
..
Patch Set 3: -Code-Review
(1 comment)
File vdsm/vm.py
Line
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vm: prevent faulty volume extensions
..
vm: prevent faulty volume extensions
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=998443
Change-Id:
Petr Benas has uploaded a new change for review.
Change subject: ipwrapper: add support for veth NICs
..
ipwrapper: add support for veth NICs
Update ipwrapper to consider veth NICs as FakeNICs in the same
way it does with dummy
Hello Ayal Baron, Sergey Gotliv,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/21382
to review the following change.
Change subject: vm: unify _highWrite and _onAbnormalStop
..
vm: unify
Hello Ayal Baron, Yeela Kaplan, Sergey Gotliv, Allon Mureinik,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/21383
to review the following change.
Change subject: vm: prevent faulty volume extensions
Federico Simoncelli has posted comments on this change.
Change subject: vm: unify _highWrite and _onAbnormalStop
..
Patch Set 1: Verified+1
Same as upstream.
--
To view, visit http://gerrit.ovirt.org/21382
To unsubscribe,
Federico Simoncelli has posted comments on this change.
Change subject: vm: prevent faulty volume extensions
..
Patch Set 1: Verified+1
Same as upstream.
--
To view, visit http://gerrit.ovirt.org/21383
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: Add NetworkTest.testSetupNetworksAddDelkDhcp
..
Patch Set 8: Verified-1
Build Failed
Allon Mureinik has posted comments on this change.
Change subject: vm: unify _highWrite and _onAbnormalStop
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21382
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: Fail pre-start run after configure libvirt
..
Patch Set 2:
(1 comment)
File init/vdsmd_init_common.sh.in
Allon Mureinik has posted comments on this change.
Change subject: vm: prevent faulty volume extensions
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21383
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: ipwrapper: add support for veth NICs
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4685/ : SUCCESS
Allon Mureinik has posted comments on this change.
Change subject: vm: unify _highWrite and _onAbnormalStop
..
Patch Set 2: Verified+1 Code-Review+1
Replaced Bug-Url: Bug-Url: in the commit message with Bug-Url: via gerrit.
No
Alon Bar-Lev has posted comments on this change.
Change subject: Fail pre-start run after configure libvirt
..
Patch Set 2:
(1 comment)
File init/vdsmd_init_common.sh.in
Hello Saggi Mizrahi,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/21385
to review the following change.
Change subject: spec: Don't depend on unreleased RPMs.
..
spec: Don't depend on unreleased
Yaniv Bronhaim has posted comments on this change.
Change subject: spec: Don't depend on unreleased RPMs.
..
Patch Set 1:
Saggi - please abandon http://gerrit.ovirt.org/#/c/21300/ .
This is not relevant to ovirt-3.3 branch.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: spec: Don't depend on unreleased RPMs.
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4686/ : SUCCESS
Yaniv Bronhaim has posted comments on this change.
Change subject: Fail pre-start run after configure libvirt
..
Patch Set 2:
(1 comment)
File init/vdsmd_init_common.sh.in
Dan Kenigsberg has submitted this change and it was merged.
Change subject: spec: Don't depend on unreleased RPMs.
..
spec: Don't depend on unreleased RPMs.
The requested package is not yet available in RHEL and will only be
Dan Kenigsberg has posted comments on this change.
Change subject: spec: Don't depend on unreleased RPMs.
..
Patch Set 1: Verified+1 Code-Review+2
(1 comment)
verified by Saggi.
Alon Bar-Lev has posted comments on this change.
Change subject: Fail pre-start run after configure libvirt
..
Patch Set 2:
(1 comment)
File init/vdsmd_init_common.sh.in
Dan Kenigsberg has posted comments on this change.
Change subject: vm: unify _highWrite and _onAbnormalStop
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21382
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: vm: prevent faulty volume extensions
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21383
To unsubscribe, visit
Lee Yarwood has uploaded a new change for review.
Change subject: lvm: Make the isActiveLV() method public.
..
lvm: Make the isActiveLV() method public.
This change makes the private isActiveLV() method public for
use in the
oVirt Jenkins CI Server has posted comments on this change.
Change subject: lvm: Make the isActiveLV() method public.
..
Patch Set 1: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4688/ :
Dan Kenigsberg has posted comments on this change.
Change subject: ipwrapper: add support for veth NICs
..
Patch Set 1:
you are using veth devices in your Add
NetworkTest.testSetupNetworksAddDelkDhcp patch, so this patch
oVirt Jenkins CI Server has posted comments on this change.
Change subject: blockSD: Ensure active volumes are refreshed before use.
..
Patch Set 1: Code-Review-1 Verified-1
Build Failed
Federico Simoncelli has submitted this change and it was merged.
Change subject: vm: unify _highWrite and _onAbnormalStop
..
vm: unify _highWrite and _onAbnormalStop
Both _highWrite and _onAbnormalStop should share the same
Federico Simoncelli has submitted this change and it was merged.
Change subject: vm: prevent faulty volume extensions
..
vm: prevent faulty volume extensions
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=998443
oVirt Jenkins CI Server has posted comments on this change.
Change subject: lvm: Make the isLVActive() method public.
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4690/ : SUCCESS
Dan Kenigsberg has posted comments on this change.
Change subject: tests: Add NetworkTest.testSetupNetworksAddDelkDhcp
..
Patch Set 8: Code-Review-1
(1 comment)
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: blockSD: Ensure active volumes are refreshed before use.
..
Patch Set 2: Code-Review-1 Verified-1
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: blockSD: Ensure active volumes are refreshed before use.
..
Patch Set 3:
Build Successful
Lee Yarwood has posted comments on this change.
Change subject: blockSD: Ensure active volumes are refreshed before use.
..
Patch Set 3:
(1 comment)
File
Nir Soffer has uploaded a new change for review.
Change subject: hsm: wait until lvm bootstrap is done before connecting to pool
..
hsm: wait until lvm bootstrap is done before connecting to pool
When hsm is created, a bootsrap
Petr Benas has posted comments on this change.
Change subject: tests: Add NetworkTest.testSetupNetworksAddDelkDhcp
..
Patch Set 8:
(1 comment)
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: hsm: wait until lvm bootstrap is done before connecting to pool
..
Patch Set 1:
Build Successful
Nir Soffer has posted comments on this change.
Change subject: lvm: Allow multiple LVs to be refreshed at once.
..
Patch Set 7:
(1 comment)
Looks good except wrong call to new function.
Some questions:
- Are all callers
Ayal Baron has posted comments on this change.
Change subject: domainMonitor: tag pool monitored domains
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21357
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: lvm: Make the isLVActive() method public.
..
Patch Set 2:
(1 comment)
Commit Message
Line 6:
Line 7: lvm:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: Add NetworkTest.testSetupNetworksAddDelkDhcp
..
Patch Set 9:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4694/ :
Ayal Baron has posted comments on this change.
Change subject: lvm: deactivate lvs during bootstrap
..
Patch Set 5:
(3 comments)
File vdsm/storage/lvm.py
Line 657:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: ipwrapper: add support for veth NICs
..
Patch Set 2: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4695/ : SUCCESS
Nir Soffer has posted comments on this change.
Change subject: blockSD: Ensure active volumes are refreshed before use.
..
Patch Set 3:
(2 comments)
Looks good, need to check if special lvs are handled in the modified code
Nir Soffer has posted comments on this change.
Change subject: lvm: deactivate lvs during bootstrap
..
Patch Set 5:
(3 comments)
File vdsm/storage/lvm.py
Line 659:
Nir Soffer has posted comments on this change.
Change subject: lvm: Allow multiple LVs to be refreshed at once.
..
Patch Set 7:
Answering my questions about refreshing multiple lvs - it works and the manual
does not say it
Nir Soffer has posted comments on this change.
Change subject: lvm: Allow multiple LVs to be refreshed at once.
..
Patch Set 7:
(1 comment)
Commit Message
Line 8:
Line 9:
Nir Soffer has posted comments on this change.
Change subject: blockSD: Ensure active volumes are refreshed before use.
..
Patch Set 3:
(1 comment)
Commit Message
Line 10:
Nir Soffer has posted comments on this change.
Change subject: lvm: Make the isLVActive() method public.
..
Patch Set 2:
(1 comment)
Commit Message
Line 7: lvm: Make the
Arik Hadas has posted comments on this change.
Change subject: remove irs_enable configuration attribute
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/21141
To unsubscribe, visit
Antoni Segura Puimedon has posted comments on this change.
Change subject: ipwrapper: add support for veth NICs
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21381
To unsubscribe, visit
1 - 100 of 121 matches
Mail list logo
