Assaf Muller has posted comments on this change.
Change subject: netinfo.getRouteTo: always return a device name
..
Patch Set 1: Code-Review-1
Sorry this patch is very confusing for me:
1) The commit message doesn't explain
Doron Fediuck has posted comments on this change.
Change subject: Changed BrokerLink log level to prevent log flooding
..
Patch Set 4: Code-Review+1
Dependency already merged. This can go it.
--
To view, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: Fix syntax error in vdsm.spec
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/22310
To unsubscribe, visit
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: Fix syntax error in vdsm.spec
..
Fix syntax error in vdsm.spec
Which introduced since http://gerrit.ovirt.org/21356
Change-Id:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix syntax error in vdsm.spec
..
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/vdsm_3.3_install_rpm_sanity_gerrit/330/ : SUCCESS
--
Vered Volansky has posted comments on this change.
Change subject: storage: get currImgDir correctly in fileSD.deleteImage()
..
Patch Set 1: Code-Review-1
You've removed the only usage of getImagePath() leaving dead code.
I'd
Sergey Gotliv has posted comments on this change.
Change subject: sp: move reconnection info check to StoragePool
..
Patch Set 8:
This is the bug I mentioned in my comment BZ#1026697
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: storage: get currImgDir correctly in fileSD.deleteImage()
..
Patch Set 2:
No Builds Executed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6084/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: storage: get currImgDir correctly in fileSD.deleteImage()
..
Patch Set 3:
No Builds Executed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6085/ :
Saggi Mizrahi has posted comments on this change.
Change subject: cleanup: drop several unused local variables
..
Patch Set 5:
One of SaggiMizrahi's automated scripts discovered this patch might require his
approval.
Please
Saggi Mizrahi has posted comments on this change.
Change subject: Convert vm status strings to constants
..
Patch Set 4:
One of SaggiMizrahi's automated scripts discovered this patch might require his
approval.
Please wait
Saggi Mizrahi has posted comments on this change.
Change subject: Change mom policy related interface to support multi-policy
..
Patch Set 14:
One of SaggiMizrahi's automated scripts discovered this patch might require his
Saggi Mizrahi has posted comments on this change.
Change subject: Deprecate volume mtime
..
Patch Set 2:
One of SaggiMizrahi's automated scripts discovered this patch might require his
approval.
Please wait until he had time
Saggi Mizrahi has posted comments on this change.
Change subject: Adding [start|stop]MonitoringDomain().
..
Patch Set 3:
One of SaggiMizrahi's automated scripts discovered this patch might require his
approval.
Please wait
Saggi Mizrahi has posted comments on this change.
Change subject: gluster: Add force option to Volume Create command
..
Patch Set 3:
One of SaggiMizrahi's automated scripts discovered this patch might require his
approval.
Saggi Mizrahi has posted comments on this change.
Change subject: sp: remove unused recoveryMode from spmStart
..
Patch Set 6:
One of SaggiMizrahi's automated scripts discovered this patch might require his
approval.
Please
Saggi Mizrahi has posted comments on this change.
Change subject: [WIP]vdsm: add support for TPM device passthrough
..
Patch Set 1:
One of SaggiMizrahi's automated scripts discovered this patch might require his
approval.
Saggi Mizrahi has posted comments on this change.
Change subject: [RFC] storage: Configure multipath using local interfaces
..
Patch Set 3:
One of SaggiMizrahi's automated scripts discovered this patch might require his
Saggi Mizrahi has posted comments on this change.
Change subject: stats: return domain lockspace status
..
Patch Set 3:
One of SaggiMizrahi's automated scripts discovered this patch might require his
approval.
Please wait
Saggi Mizrahi has posted comments on this change.
Change subject: sp: remove unused scsiFencing parameter
..
Patch Set 6:
One of SaggiMizrahi's automated scripts discovered this patch might require his
approval.
Please wait
Saggi Mizrahi has posted comments on this change.
Change subject: gluster: Get size information of a gluster volume
..
Patch Set 7:
One of SaggiMizrahi's automated scripts discovered this patch might require his
approval.
Saggi Mizrahi has posted comments on this change.
Change subject: vdsm: add support for multiple iSCSI interfaces
..
Patch Set 1:
One of SaggiMizrahi's automated scripts discovered this patch might require his
approval.
Saggi Mizrahi has posted comments on this change.
Change subject: autotools: fix make distcheck
..
Patch Set 2:
One of SaggiMizrahi's automated scripts discovered this patch might require his
approval.
Please wait until he
Saggi Mizrahi has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 6:
One of SaggiMizrahi's automated scripts discovered this patch might require his
approval.
Please
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Changed BrokerLink log level to prevent log flooding
..
Changed BrokerLink log level to prevent log flooding
- vdsm imports the BrokerLink lib with
Nir Soffer has posted comments on this change.
Change subject: deactivateSD - perform nothing if the domain is already
deactivated
..
Patch Set 1:
(3 comments)
Commit
Nir Soffer has posted comments on this change.
Change subject: deactivateSD - perform nothing if the domain is already
deactivated
..
Patch Set 1:
(1 comment)
Commit
Nir Soffer has posted comments on this change.
Change subject: deactivateSD - perform nothing if the domain is already
deactivated
..
Patch Set 1:
(1 comment)
File
Nir Soffer has abandoned this change.
Change subject: remoteFileHandler: Remove harmful libvirt dependency
..
Abandoned
libvirtconnection dependency is not harmful any more after
http://gerrit.ovirt.org/22322 was merged.
The
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Run pinger in separate process
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6086/ : SUCCESS
Yaniv Bronhaim has posted comments on this change.
Change subject: remoteFileHandler: Remove harmful libvirt dependency
..
Patch Set 2:
This patch is useful imo, just no need to relate it to the bug or to the
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Testing pinger thread
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6091/ : SUCCESS
Assaf Muller has posted comments on this change.
Change subject: upgrade.log now owned by vdsm:kvm
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/22349
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: upgrade.log now owned by vdsm:kvm
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6092/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Testing pinger thread
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_network_functional_tests/1034/ : SUCCESS
--
To view,
Saggi Mizrahi has posted comments on this change.
Change subject: vdsClient: new option to show VDSM configuration
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21876
To unsubscribe, visit
Nir Soffer has restored this change.
Change subject: remoteFileHandler: Remove harmful libvirt dependency
..
Restored
Yaniv wants this.
--
To view, visit http://gerrit.ovirt.org/22316
To unsubscribe, visit
Sergey Gotliv has posted comments on this change.
Change subject: deactivateSD - perform nothing if the domain is already
deactivated
..
Patch Set 1:
(1 comment)
File
Saggi Mizrahi has posted comments on this change.
Change subject: securable: refactor the scurable implementation
..
Patch Set 2:
(2 comments)
Also, why not just remove the whole securable non-sense.
Let's just explicitly
Dan Kenigsberg has posted comments on this change.
Change subject: vdsClient: new option to show VDSM configuration
..
Patch Set 2: Code-Review-1
(1 comment)
Commit Message
Saggi Mizrahi has posted comments on this change.
Change subject: tests: Add simple mocking library
..
Patch Set 1: Code-Review-1
Sorry to be the one to rain on your parade but I don't really understand what
this is for. I'll
Nir Soffer has posted comments on this change.
Change subject: tests: Add simple mocking library
..
Patch Set 1:
Saggi, please read
http://martinfowler.com/articles/mocksArentStubs.html#TheDifferenceBetweenMocksAndStubs.
--
Assaf Muller has posted comments on this change.
Change subject: hook: extnet: attach a vNIC to a libvirt network defined
outside oVirt
..
Patch Set 5:
(1 comment)
File
Saggi Mizrahi has posted comments on this change.
Change subject: tests: Add simple mocking library
..
Patch Set 1:
Ignoring the fact that you have not answered any of my comments I will sat what
I think about the linked
Assaf Muller has posted comments on this change.
Change subject: hook: extnet: attach a vNIC to a libvirt network defined
outside oVirt
..
Patch Set 5: Code-Review+1
(1 comment)
Nir Soffer has posted comments on this change.
Change subject: tests: Add simple mocking library
..
Patch Set 1:
I don't understand why one would need to check if things are called with
certain paramters.
Because this is
Dan Kenigsberg has submitted this change and it was merged.
Change subject: hook: extnet: attach a vNIC to a libvirt network defined
outside oVirt
..
hook: extnet: attach a vNIC to a libvirt network defined outside oVirt
This
Dan Kenigsberg has posted comments on this change.
Change subject: hook: extnet: attach a vNIC to a libvirt network defined
outside oVirt
..
Patch Set 5: Verified+1 Code-Review+2
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: hook: extnet: attach a vNIC to a libvirt network defined
outside oVirt
..
Patch Set 6:
Build Successful
Nir Soffer has posted comments on this change.
Change subject: tests: Add simple mocking library
..
Patch Set 1:
The article puts Coupling Tests to Implementation as a plus which I
personally disagree with and was the main
Saggi Mizrahi has posted comments on this change.
Change subject: tests: Add simple mocking library
..
Patch Set 1:
The tests you linked are a bunch of tests that test nothing.
You have a method that all it does is call lvs
Nir Soffer has posted comments on this change.
Change subject: tests: Add simple mocking library
..
Patch Set 1:
The tests you linked are a bunch of tests that test nothing. You have a
method that all it does is call lvs
Dan Kenigsberg has posted comments on this change.
Change subject: ifcfg: include HWADDR line only if NM is around
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/22288
To unsubscribe, visit
Assaf Muller has posted comments on this change.
Change subject: ifcfg: include HWADDR line only if NM is around
..
Patch Set 2:
(1 comment)
File vdsm/netconf/ifcfg.py
Line
54 matches
Mail list logo
