Change in vdsm[master]: utils: Moved pgrep and getCmdArgs from storage/misc

Antoni Segura Puimedon has posted comments on this change. Change subject: utils: Moved pgrep and getCmdArgs from storage/misc .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/23040 To unsubscribe,

Change in vdsm[master]: utils: Extend pgrep to accept multiple process names

Antoni Segura Puimedon has posted comments on this change. Change subject: utils: Extend pgrep to accept multiple process names .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/23239/1/lib/vdsm/utils.py File

Change in vdsm[master]: Changing the order of the services management alternatives

Yaniv Bronhaim has posted comments on this change. Change subject: Changing the order of the services management alternatives .. Patch Set 1: You are right and I missed that.. Look at my first comment on

Change in vdsm[master]: Changing the order of the services management alternatives

Yaniv Bronhaim has abandoned this change. Change subject: Changing the order of the services management alternatives .. Abandoned not needed -- To view, visit http://gerrit.ovirt.org/22867 To unsubscribe, visit

Change in vdsm[master]: vdsm: allow hooks to pass down dictionaries in json format

Dan Kenigsberg has posted comments on this change. Change subject: vdsm: allow hooks to pass down dictionaries in json format .. Patch Set 7: Code-Review-1 (2 comments)

Change in vdsm[master]: netinfo: Determine bootproto also without ifcfg files

Antoni Segura Puimedon has posted comments on this change. Change subject: netinfo: Determine bootproto also without ifcfg files .. Patch Set 3: Code-Review-1 (1 comment)

Change in vdsm[master]: utils: Moved pgrep and getCmdArgs from storage/misc

Assaf Muller has posted comments on this change. Change subject: utils: Moved pgrep and getCmdArgs from storage/misc .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/23040 To unsubscribe, visit

Change in vdsm[master]: utils: Extend pgrep to accept multiple process names

Assaf Muller has posted comments on this change. Change subject: utils: Extend pgrep to accept multiple process names .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/23239/1/lib/vdsm/utils.py File lib/vdsm/utils.py:

Change in vdsm[master]: utils: Moved pgrep and getCmdArgs from storage/misc

Yaniv Bronhaim has posted comments on this change. Change subject: utils: Moved pgrep and getCmdArgs from storage/misc .. Patch Set 3: Code-Review+1 thanks! -- To view, visit http://gerrit.ovirt.org/23040 To unsubscribe,

Change in vdsm[master]: tests: use assertIn when applicable

Yaniv Bronhaim has posted comments on this change. Change subject: tests: use assertIn when applicable .. Patch Set 1: assertIn is new in python 2.7 .. don't we need it to work also with 2.6? or from now on we're only rhel6.5

Change in vdsm[master]: netinfo: Determine bootproto also without ifcfg files

Ondřej Svoboda has posted comments on this change. Change subject: netinfo: Determine bootproto also without ifcfg files .. Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/23098/3/lib/vdsm/netinfo.py File

Change in vdsm[master]: tests: use assertIn when applicable

Vinzenz Feenstra has posted comments on this change. Change subject: tests: use assertIn when applicable .. Patch Set 1: It has been implemented in a previous patch. -- To view, visit http://gerrit.ovirt.org/23038 To

Change in vdsm[master]: tests: use assertIn when applicable

Vinzenz Feenstra has posted comments on this change. Change subject: tests: use assertIn when applicable .. Patch Set 1: assertIn implemented here:

Change in vdsm[master]: mkimage: do not create world-readable image

Yaniv Bronhaim has posted comments on this change. Change subject: mkimage: do not create world-readable image .. Patch Set 6: it shouldn't. please speak with eedri and fix the jenkins errors -- To view, visit

Change in vdsm[master]: fix Exception message error in apiTests module

Dan Kenigsberg has submitted this change and it was merged. Change subject: fix Exception message error in apiTests module .. fix Exception message error in apiTests module Change-Id: Ic51b141047dc0490e50a050fd667f63d30f121f2

Change in vdsm[master]: fix Exception message error in apiTests module

Dan Kenigsberg has posted comments on this change. Change subject: fix Exception message error in apiTests module .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/11289 To unsubscribe, visit

Change in vdsm[master]: vdsm: fix RTC offset

Michal Skrivanek has posted comments on this change. Change subject: vdsm: fix RTC offset .. Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/14750/3/vdsm/vm.py File vdsm/vm.py: Line 1813:

Change in vdsm[master]: tests: use assertIn when applicable

Dan Kenigsberg has posted comments on this change. Change subject: tests: use assertIn when applicable .. Patch Set 1: Code-Review+2 Thanks for your reviews! -- To view, visit http://gerrit.ovirt.org/23038 To unsubscribe,

Change in vdsm[master]: netinfo: Determine bootproto also without ifcfg files

Assaf Muller has posted comments on this change. Change subject: netinfo: Determine bootproto also without ifcfg files .. Patch Set 3: Code-Review-1 (5 comments) http://gerrit.ovirt.org/#/c/23098/3//COMMIT_MSG Commit Message:

Change in vdsm[master]: mkimage: do not create world-readable image

oVirt Jenkins CI Server has posted comments on this change. Change subject: mkimage: do not create world-readable image .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6719/ : FAILURE

Change in vdsm[master]: vdsm: fix RTC offset

Dan Kenigsberg has posted comments on this change. Change subject: vdsm: fix RTC offset .. Patch Set 3: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/14750/3/vdsm/vm.py File vdsm/vm.py: Line 1813:

Change in vdsm[master]: utils: cleanup - typos, grammar and comments refinement

Dan Kenigsberg has posted comments on this change. Change subject: utils: cleanup - typos, grammar and comments refinement .. Patch Set 12: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/22862 To unsubscribe, visit

Change in vdsm[master]: utils: cleanup - typos, grammar and comments refinement

Dan Kenigsberg has submitted this change and it was merged. Change subject: utils: cleanup - typos, grammar and comments refinement .. utils: cleanup - typos, grammar and comments refinement Change-Id:

Change in vdsm[master]: mkimage: do not create world-readable image

oVirt Jenkins CI Server has posted comments on this change. Change subject: mkimage: do not create world-readable image .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6720/ : FAILURE

Change in vdsm[master]: Extend Image.move to move and copy subchains

Itamar Heim has posted comments on this change. Change subject: Extend Image.move to move and copy subchains .. Patch Set 2: ping - still relevant? -- To view, visit http://gerrit.ovirt.org/3217 To unsubscribe, visit

Change in vdsm[master]: dump the core of a VM

Adam Litke has posted comments on this change. Change subject: dump the core of a VM .. Patch Set 15: Verified+1 -- To view, visit http://gerrit.ovirt.org/7329 To unsubscribe, visit http://gerrit.ovirt.org/settings

Change in vdsm[master]: ipwrapper: switch link polling to netlink

Antoni Segura Puimedon has uploaded a new change for review. Change subject: ipwrapper: switch link polling to netlink .. ipwrapper: switch link polling to netlink getting the links from iproute2 implied creating a process each

Change in vdsm[master]: get the status of core dump

Adam Litke has posted comments on this change. Change subject: get the status of core dump .. Patch Set 9: Verified+1 -- To view, visit http://gerrit.ovirt.org/11131 To unsubscribe, visit http://gerrit.ovirt.org/settings

Change in vdsm[master]: cancel the core dump of a VM

Adam Litke has posted comments on this change. Change subject: cancel the core dump of a VM .. Patch Set 10: Verified+1 -- To view, visit http://gerrit.ovirt.org/11130 To unsubscribe, visit http://gerrit.ovirt.org/settings

Change in vdsm[master]: dump the core of a VM

Vinzenz Feenstra has posted comments on this change. Change subject: dump the core of a VM .. Patch Set 15: Code-Review-1 (6 comments) http://gerrit.ovirt.org/#/c/7329/15/vdsm/API.py File vdsm/API.py: Line 272:

Change in vdsm[master]: dump the core of a VM

oVirt Jenkins CI Server has posted comments on this change. Change subject: dump the core of a VM .. Patch Set 15: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6723/ : SUCCESS

Change in vdsm[master]: jsonrpc: Vdsm changes

oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpc: Vdsm changes .. Patch Set 17: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6722/ : SUCCESS

Change in vdsm[master]: get the status of core dump

oVirt Jenkins CI Server has posted comments on this change. Change subject: get the status of core dump .. Patch Set 9: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6724/ : SUCCESS

Change in vdsm[master]: schema: Updates based on the current code base

Yaniv Bronhaim has posted comments on this change. Change subject: schema: Updates based on the current code base .. Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/23125/3//COMMIT_MSG Commit Message: Line 3:

Change in vdsm[master]: schema: Updates based on the current code base

oVirt Jenkins CI Server has posted comments on this change. Change subject: schema: Updates based on the current code base .. Patch Set 3: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6721/ :

Change in vdsm[master]: cancel the core dump of a VM

oVirt Jenkins CI Server has posted comments on this change. Change subject: cancel the core dump of a VM .. Patch Set 10: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6725/ : SUCCESS

Change in vdsm[master]: securable: refactor the securable implementation

oVirt Jenkins CI Server has posted comments on this change. Change subject: securable: refactor the securable implementation .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6727/ :

Change in vdsm[master]: get max_tasks and thread_pool_size from config by getint()

oVirt Jenkins CI Server has posted comments on this change. Change subject: get max_tasks and thread_pool_size from config by getint() .. Patch Set 3: Verified-1 Build Failed

Change in vdsm[master]: securable: refactor the securable implementation

Federico Simoncelli has posted comments on this change. Change subject: securable: refactor the securable implementation .. Patch Set 4: Verified+1 Verified with the unit tests, starting/stopping the SPM few times and using

Change in vdsm[master]: get max_tasks and thread_pool_size from config by getint()

oVirt Jenkins CI Server has posted comments on this change. Change subject: get max_tasks and thread_pool_size from config by getint() .. Patch Set 2: Build Successful

Change in vdsm[master]: Changing vdsm-tool and vdsmd pre-tasks outputs to be more me...

Yaniv Bronhaim has uploaded a new change for review. Change subject: Changing vdsm-tool and vdsmd pre-tasks outputs to be more meaningful to user .. Changing vdsm-tool and vdsmd pre-tasks outputs to be more meaningful to user

Change in vdsm[master]: vdsm: Replaced all too generic except: handlers in vm.py

Francesco Romani has posted comments on this change. Change subject: vdsm: Replaced all too generic except: handlers in vm.py .. Patch Set 5: Verified+1 Code-Review+1 looks good to me and it is also a step in the good

Change in vdsm[master]: Changing vdsm-tool and vdsmd pre-tasks outputs to be more me...

Yaniv Bronhaim has posted comments on this change. Change subject: Changing vdsm-tool and vdsmd pre-tasks outputs to be more meaningful to user .. Patch Set 1: Verified+1 It looks much easier to understand now. If you can

Change in vdsm[master]: Changing vdsm-tool and vdsmd pre-tasks outputs to be more me...

oVirt Jenkins CI Server has posted comments on this change. Change subject: Changing vdsm-tool and vdsmd pre-tasks outputs to be more meaningful to user .. Patch Set 1: Build Successful

Change in vdsm[master]: vdsm: Adding guest agent API versioning support

Francesco Romani has posted comments on this change. Change subject: vdsm: Adding guest agent API versioning support .. Patch Set 6: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/17004 To unsubscribe, visit

Change in vdsm[master]: clientIF: prepareVolumePath payload cleanup

oVirt Jenkins CI Server has posted comments on this change. Change subject: clientIF: prepareVolumePath payload cleanup .. Patch Set 6: -Verified Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6731/ :

Change in vdsm[master]: vdsm.spec: specify sysV commands for EL6 only

oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm.spec: specify sysV commands for EL6 only .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6732/ : SUCCESS

Change in vdsm[master]: dump the core of a VM

Adam Litke has posted comments on this change. Change subject: dump the core of a VM .. Patch Set 15: (6 comments) http://gerrit.ovirt.org/#/c/7329/15/vdsm/API.py File vdsm/API.py: Line 272: :param postAction: An

Change in vdsm[master]: dump the core of a VM

oVirt Jenkins CI Server has posted comments on this change. Change subject: dump the core of a VM .. Patch Set 16: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6733/ : SUCCESS

Change in vdsm[master]: get the status of core dump

oVirt Jenkins CI Server has posted comments on this change. Change subject: get the status of core dump .. Patch Set 10: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6734/ : SUCCESS

Change in vdsm[master]: guest: Add support for guest cpu topology

Vinzenz Feenstra has uploaded a new change for review. Change subject: guest: Add support for guest cpu topology .. guest: Add support for guest cpu topology Change-Id: I827ab095ee9270faf27f44e91c7bc998e133351e Signed-off-by:

Change in vdsm[master]: guest: Add support for guest cpu topology

oVirt Jenkins CI Server has posted comments on this change. Change subject: guest: Add support for guest cpu topology .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6736/ : SUCCESS

Change in vdsm[master]: vdsm.spec: specify sysV commands for EL6 only

Douglas Schilling Landgraf has posted comments on this change. Change subject: vdsm.spec: specify sysV commands for EL6 only .. Patch Set 3: Verified+1 vdsm installed/removed under rhel6,rhel7 and fedora no complains. -- To

Change in vdsm[master]: storageTests: Extract storage types and versions to an envir...

Vered Volansky has uploaded a new change for review. Change subject: storageTests: Extract storage types and versions to an environment variable .. storageTests: Extract storage types and versions to an environment variable

Change in vdsm[master]: storageTests: Extract storage types and versions to an envir...

Vered Volansky has posted comments on this change. Change subject: storageTests: Extract storage types and versions to an environment variable .. Patch Set 2: Verified+1 Storage type localfs is verified with versions 0 and 3.

Change in vdsm[master]: storageTests: Extract storage types and versions to an envir...

Allon Mureinik has posted comments on this change. Change subject: storageTests: Extract storage types and versions to an environment variable .. Patch Set 2: (3 comments)

Change in vdsm[master]: storageTests: Extract storage types and versions to an envir...

oVirt Jenkins CI Server has posted comments on this change. Change subject: storageTests: Extract storage types and versions to an environment variable .. Patch Set 2: Build Successful

Change in vdsm[master]: storageTests: Extract storage types and versions to an envir...

oVirt Jenkins CI Server has posted comments on this change. Change subject: storageTests: Extract storage types and versions to an environment variable .. Patch Set 1: Code-Review-1 Verified-1 Build Failed

Change in vdsm[master]: storageTests: Extract storage types and versions to an envir...

Vered Volansky has posted comments on this change. Change subject: storageTests: Extract storage types and versions to an environment variable .. Patch Set 3: Verified+1 Addressed comments from previous patch. Verified in the

Change in vdsm[master]: storageTests: Extract storage types and versions to an envir...

oVirt Jenkins CI Server has posted comments on this change. Change subject: storageTests: Extract storage types and versions to an environment variable .. Patch Set 3: Build Successful

Change in vdsm[master]: changing un-shared treatment in the volume share function

Oved Ourfali has uploaded a new change for review. Change subject: changing un-shared treatment in the volume share function .. changing un-shared treatment in the volume share function This patch changes the share function to

Change in vdsm[master]: changing un-shared treatment in the volume share function

oVirt Jenkins CI Server has posted comments on this change. Change subject: changing un-shared treatment in the volume share function .. Patch Set 1: Verified-1 Build Failed

Change in vdsm[master]: changing un-shared treatment in the volume share function

oVirt Jenkins CI Server has posted comments on this change. Change subject: changing un-shared treatment in the volume share function .. Patch Set 2: Code-Review-1 Verified-1 Build Failed

Change in vdsm[master]: vdsm: Adding guest agent API versioning support

Douglas Schilling Landgraf has posted comments on this change. Change subject: vdsm: Adding guest agent API versioning support .. Patch Set 6: (5 comments) http://gerrit.ovirt.org/#/c/17004/6/vdsm/guestIF.py File

Change in vdsm[master]: changing un-shared treatment in the volume share function

oVirt Jenkins CI Server has posted comments on this change. Change subject: changing un-shared treatment in the volume share function .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6742/

Change in vdsm[master]: changing un-shared treatment in the volume share function

Oved Ourfali has posted comments on this change. Change subject: changing un-shared treatment in the volume share function .. Patch Set 3: Verified+1 Verified that adding VM from template works, both in the use-case in which

Change in vdsm[master]: vdsm: Replaced all too generic except: handlers in vm.py

Dan Kenigsberg has submitted this change and it was merged. Change subject: vdsm: Replaced all too generic except: handlers in vm.py .. vdsm: Replaced all too generic except: handlers in vm.py Change-Id:

Change in vdsm[master]: cancel the core dump of a VM

Adam Litke has posted comments on this change. Change subject: cancel the core dump of a VM .. Patch Set 11: Verified+1 -- To view, visit http://gerrit.ovirt.org/11130 To unsubscribe, visit http://gerrit.ovirt.org/settings

Change in vdsm[master]: dump the core of a VM

Adam Litke has posted comments on this change. Change subject: dump the core of a VM .. Patch Set 16: Verified+1 -- To view, visit http://gerrit.ovirt.org/7329 To unsubscribe, visit http://gerrit.ovirt.org/settings

Change in vdsm[master]: get the status of core dump

Adam Litke has posted comments on this change. Change subject: get the status of core dump .. Patch Set 10: Verified+1 -- To view, visit http://gerrit.ovirt.org/11131 To unsubscribe, visit http://gerrit.ovirt.org/settings

Change in vdsm[master]: sd: add inquireClusterLock method to StorageDomain

Nir Soffer has posted comments on this change. Change subject: sd: add inquireClusterLock method to StorageDomain .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/21426 To unsubscribe, visit

Change in vdsm[master]: securable: refactor the securable implementation

Nir Soffer has posted comments on this change. Change subject: securable: refactor the securable implementation .. Patch Set 4: Code-Review+1 I like that. -- To view, visit http://gerrit.ovirt.org/22115 To unsubscribe, visit

Change in vdsm[master]: changing un-shared treatment in the volume share function

Federico Simoncelli has posted comments on this change. Change subject: changing un-shared treatment in the volume share function .. Patch Set 3: Code-Review+1 Sane. Please verify it using vdsClient getVolumeInfo commands

Change in vdsm[master]: changing un-shared treatment in the volume share function

Federico Simoncelli has posted comments on this change. Change subject: changing un-shared treatment in the volume share function .. Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/23260/3//COMMIT_MSG Commit Message:

Change in vdsm[master]: ipwrapper: switch link polling to netlink

Dan Kenigsberg has posted comments on this change. Change subject: ipwrapper: switch link polling to netlink .. Patch Set 1: Code-Review-1 (9 comments) Few comments and questions.

Change in vdsm[master]: downloadFromStream

Nir Soffer has posted comments on this change. Change subject: downloadFromStream .. Patch Set 4: (20 comments) http://gerrit.ovirt.org/#/c/23131/4/vdsm/API.py File vdsm/API.py: Line 837: def download(self, methodArgs,

Change in vdsm[master]: securable: refactor the securable implementation

Dan Kenigsberg has posted comments on this change. Change subject: securable: refactor the securable implementation .. Patch Set 4: (5 comments) It's a big improvement relative to the existing code, but I think that it can

Change in vdsm[master]: API: return additional Hosted Engine information from vdsStats

Greg Padgett has uploaded a new change for review. Change subject: API: return additional Hosted Engine information from vdsStats .. API: return additional Hosted Engine information from vdsStats Return additional hosted engine

Change in vdsm[master]: API: setHaMaintenanceMode command

Greg Padgett has uploaded a new change for review. Change subject: API: setHaMaintenanceMode command .. API: setHaMaintenanceMode command New API for setting hosted engine maintenance mode. Change-Id:

Change in vdsm[master]: API: return additional Hosted Engine information from vdsStats

oVirt Jenkins CI Server has posted comments on this change. Change subject: API: return additional Hosted Engine information from vdsStats .. Patch Set 1: Build Successful

Change in vdsm[master]: API: setHaMaintenanceMode command

oVirt Jenkins CI Server has posted comments on this change. Change subject: API: setHaMaintenanceMode command .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6744/ : SUCCESS

Change in vdsm[master]: securable: refactor the securable implementation

Nir Soffer has posted comments on this change. Change subject: securable: refactor the securable implementation .. Patch Set 4: (3 comments) http://gerrit.ovirt.org/#/c/22115/4/vdsm/storage/securable.py File

Change in vdsm[master]: changing un-shared treatment in the volume share function

Itamar Heim has posted comments on this change. Change subject: changing un-shared treatment in the volume share function .. Patch Set 3: adding ayal, as noticed federico question in the comment is to him -- To view, visit

Change in vdsm[master]: changing un-shared treatment in the volume share function

Ayal Baron has posted comments on this change. Change subject: changing un-shared treatment in the volume share function .. Patch Set 3: Code-Review+2 (1 comment) http://gerrit.ovirt.org/#/c/23260/3/vdsm/storage/volume.py

Change in vdsm[master]: get the status of core dump

Vinzenz Feenstra has posted comments on this change. Change subject: get the status of core dump .. Patch Set 10: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/11131 To unsubscribe, visit

Change in vdsm[master]: cancel the core dump of a VM

Vinzenz Feenstra has posted comments on this change. Change subject: cancel the core dump of a VM .. Patch Set 11: (1 comment) http://gerrit.ovirt.org/#/c/11130/11/vdsm_api/vdsmapi-schema.json File