Dan Kenigsberg has posted comments on this change. Change subject: vdsm: allow hooks to pass down dictionaries in json format ......................................................................
Patch Set 7: Code-Review-1 (2 comments) http://gerrit.ovirt.org/#/c/20330/7/tests/functional/networkTests.py File tests/functional/networkTests.py: Line 1557: self.assertTrue(os.path.isfile(hook_cookiefile)) Line 1558: Line 1559: with open(hook_cookiefile, 'r') as cookie_file: Line 1560: network_config = json.load(cookie_file) Line 1561: self.assertTrue('networks' in network_config['request']) please use assertIn(), which is available in the base class, and gives better output on failure. Line 1562: self.assertTrue('bondings' in network_config['request']) Line 1563: self.assertTrue(NETWORK_NAME in Line 1564: network_config['request']['networks']) Line 1565: http://gerrit.ovirt.org/#/c/20330/7/vdsm/vdsmd.8.in File vdsm/vdsmd.8.in: Line 91: .B request Line 92: can contain networks, bondings and options, and Line 93: .B current Line 94: only networks and bondings. The request parameters are specified in the Line 95: setupNetworks VDSM API call. Please mention that a before_network_setup hook script may modify the "request" part, as thus affect the operation ultimately taken place by Vdsm. Line 96: Line 97: .nf Line 98: {"request": Line 99: { -- To view, visit http://gerrit.ovirt.org/20330 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie07c511e9740fd19a1c27baf87e91f9a427d0dcd Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Miguel Angel Ajo Pelayo <majop...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Assaf Muller <amul...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Miguel Angel Ajo Pelayo <majop...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
