oVirt Jenkins CI Server has posted comments on this change.
Change subject: hooks: Add hook for fake VM stats
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/400/ :
FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: hooks: Add hook for fake VM stats
..
Patch Set 5:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/401/ :
FAILURE
Francesco Romani has posted comments on this change.
Change subject: vm: consider 'action' when handling I/O errors
..
Patch Set 1: Verified+1
Verification:
- same code as master (no changes in this area)
- re-verified on
oVirt Jenkins CI Server has posted comments on this change.
Change subject: hooks: Add hook for fake VM stats
..
Patch Set 6:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/402/ :
FAILURE
Dan Kenigsberg has posted comments on this change.
Change subject: vm: handle missing domains on recovery
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/25275
To unsubscribe, visit
Vinzenz Feenstra has posted comments on this change.
Change subject: vm: handle missing domains on recovery
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/25275
To unsubscribe, visit
Vinzenz Feenstra has posted comments on this change.
Change subject: vm: consider 'action' when handling I/O errors
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26023
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: vm: handle missing domains on recovery
..
Patch Set 1: -Code-Review
(1 comment)
http://gerrit.ovirt.org/#/c/25275/1//COMMIT_MSG
Commit Message:
Line 7: vm:
Dan Kenigsberg has posted comments on this change.
Change subject: recovery: try to restore VMs from recovery files
..
Patch Set 1: Code-Review-1
(2 comments)
Please include a functional test, that starts a Vm, stops Vdsm,
Francesco Romani has posted comments on this change.
Change subject: vm: handle missing domains on recovery
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/25275/1//COMMIT_MSG
Commit Message:
Line 7: vm: handle
Federico Simoncelli has posted comments on this change.
Change subject: Allow moving of sparse images to a block domains
..
Patch Set 5:
(2 comments)
http://gerrit.ovirt.org/#/c/25778/5/vdsm/storage/image.py
File
Yaniv Bronhaim has posted comments on this change.
Change subject: vm: consider 'action' when handling I/O errors
..
Patch Set 1: Code-Review-1
the bug is not targeted to ovirt-3.4
--
To view, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: hsm: Distinguish between iface and initiator when creating
iSCSI iface
..
hsm: Distinguish between iface and initiator when creating iSCSI iface
VDSM
Dan Kenigsberg has submitted this change and it was merged.
Change subject: hsm: Rename _BCInitiatorNameResolve function
..
hsm: Rename _BCInitiatorNameResolve function
Function _BCInitiatorNameResolve actually resolves the
Dan Kenigsberg has posted comments on this change.
Change subject: pre-start: touch/configure vdsm logs
..
Patch Set 5:
Douglas, could vdsmd be started by vdsm-reg prior to registration?
Isn't
Dan Kenigsberg has posted comments on this change.
Change subject: configurator: move usermod to spec
..
Patch Set 1: Code-Review-1
(2 comments)
http://gerrit.ovirt.org/#/c/26055/1/lib/vdsm/tool/configurator.py
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Allow moving of sparse images to a block domains
..
Patch Set 6: Code-Review-1 Verified-1
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Allow moving of sparse images to a block domains
..
Patch Set 7:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6821/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: Add boot time to the getVdsStats API
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6822/ : SUCCESS
Yaniv Bronhaim has posted comments on this change.
Change subject: core: Add boot time to the getVdsStats API
..
Patch Set 4:
(2 comments)
http://gerrit.ovirt.org/#/c/25877/4/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line
Francesco Romani has posted comments on this change.
Change subject: recovery: try to restore VMs from recovery files
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/25276/1/vdsm/clientIF.py
File vdsm/clientIF.py:
Yaniv Bronhaim has posted comments on this change.
Change subject: configurator: move usermod to spec
..
Patch Set 1:
(2 comments)
http://gerrit.ovirt.org/#/c/26055/1/vdsm.spec.in
File vdsm.spec.in:
Line 689: /usr/bin/getent
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: migration: use contextmanager for monitor
..
Patch Set 7:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6823/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: migration: merge monitor and downtime thread
..
Patch Set 6:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6824/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: migration: add monitor thread control loop
..
Patch Set 5:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6825/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: migration: always run migration monitor
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6827/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: migration: move threads in a separate module
..
Patch Set 5:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6826/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: migration: use contextmanager for monitor
..
Patch Set 8:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6828/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: migration: merge monitor and downtime thread
..
Patch Set 7:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6829/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: migration: always run migration monitor
..
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6831/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: migration: add monitor thread control loop
..
Patch Set 6:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6830/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Move virt things into vdsm/virt
..
Patch Set 9:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6832/ : FAILURE
Dan Kenigsberg has posted comments on this change.
Change subject: core: Add boot time to the getVdsStats API
..
Patch Set 4: Code-Review-1
(2 comments)
http://gerrit.ovirt.org/#/c/25877/4/lib/vdsm/utils.py
File
Dima Kuznetsov has uploaded a new change for review.
Change subject: util: fix execCmd to accept tuples
..
util: fix execCmd to accept tuples
There was an issue when occasionally when flags were given along with a
command in a
Dan Kenigsberg has posted comments on this change.
Change subject: Initial commit for vdsm-tool testing infrastructure
..
Patch Set 16: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/25263/16/tests/toolTests.py
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Move virt things into vdsm/virt
..
Patch Set 10:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6833/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: util: fix execCmd to accept tuples
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6834/ : SUCCESS
Allon Mureinik has posted comments on this change.
Change subject: Allow moving of sparse images to a block domains
..
Patch Set 7: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/25778
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: util: fix execCmd to accept tuples
..
Patch Set 1: Code-Review-1
please add unit tests for that.
--
To view, visit http://gerrit.ovirt.org/26070
To
Allon Mureinik has posted comments on this change.
Change subject: Improve logging on some filesystem operations
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/26046/2//COMMIT_MSG
Commit Message:
Line 6:
Line 7:
Dan Kenigsberg has uploaded a new change for review.
Change subject: fencing: stop using a deprecated command
..
fencing: stop using a deprecated command
Recently, fence-agents stopped supporting the option alias for its
action
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: Add boot time to the getVdsStats API
..
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6835/ : SUCCESS
Douglas Schilling Landgraf has posted comments on this change.
Change subject: configurator: move usermod to spec
..
Patch Set 2:
need to be tested in case looks good to reviewers.
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: configurator: move usermod to spec
..
Patch Set 2:
I mean, tested in the rhev-h
--
To view, visit http://gerrit.ovirt.org/26055
To unsubscribe,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: configurator: use sanlock user constant
..
Patch Set 1: Code-Review-1 Verified-1
Build Failed
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: configurator: use sanlock user constant
..
configurator: use sanlock user constant
Replace the static value with a constant.
Change-Id:
Dan Kenigsberg has posted comments on this change.
Change subject: configurator: move usermod to spec
..
Patch Set 2: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/26055/2/vdsm.spec.in
File vdsm.spec.in:
Line 828:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: configurator: use sanlock user constant
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6838/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: avoid to reply with half-baked statistics
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6839/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: configurator: use sanlock user constant
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6840/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: configurator: use sanlock user constant
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6841/ : SUCCESS
Francesco Romani has posted comments on this change.
Change subject: vm: avoid to reply with half-baked statistics
..
Patch Set 2:
Patch set 1 was a highly-localized band-aid fix.
Patch set 2 (and onwards) tries more
oVirt Jenkins CI Server has posted comments on this change.
Change subject: configurator: move usermod to spec
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6842/ : FAILURE
Douglas Schilling Landgraf has posted comments on this change.
Change subject: configurator: move usermod to spec
..
Patch Set 4:
Requires: http://gerrit.ovirt.org/#/c/26080/ Jenkins said nothing to do with
26080 and I
oVirt Jenkins CI Server has posted comments on this change.
Change subject: configurator: move usermod to spec
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6843/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: configurator: move usermod to spec
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6837/ : FAILURE
Federico Simoncelli has posted comments on this change.
Change subject: Allow moving of sparse images to a block domains
..
Patch Set 7: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/25778
To unsubscribe, visit
mooli tayer has posted comments on this change.
Change subject: Initial commit for vdsm-tool testing infrastructure
..
Patch Set 16:
(1 comment)
http://gerrit.ovirt.org/#/c/25263/16/tests/toolTests.py
File tests/toolTests.py:
Federico Simoncelli has posted comments on this change.
Change subject: Allow moving of sparse images to a block domains
..
Patch Set 7:
(1 comment)
http://gerrit.ovirt.org/#/c/25778/7/vdsm/storage/image.py
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Initial commit for vdsm-tool testing infrastructure
..
Patch Set 17:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6844/ :
Tal Nisan has posted comments on this change.
Change subject: Allow moving of sparse images to a block domains
..
Patch Set 7: Verified+1
Verified moving all different options of format types and sparse/preallocated
from file
Tal Nisan has posted comments on this change.
Change subject: Allow moving of sparse images to a block domains
..
Patch Set 7:
(1 comment)
http://gerrit.ovirt.org/#/c/25778/7/vdsm/storage/image.py
File vdsm/storage/image.py:
Federico Simoncelli has posted comments on this change.
Change subject: Allow moving of sparse images to a block domains
..
Patch Set 8: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/25778
To unsubscribe, visit
Tal Nisan has posted comments on this change.
Change subject: Allow moving of sparse images to a block domains
..
Patch Set 8: Verified+1
Verified moving all different options of format types and sparse/preallocated
from file
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: Add boot time to the getVdsStats API
..
Patch Set 6:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6845/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Allow moving of sparse images to a block domains
..
Patch Set 8:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6846/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: VmStatsThread: make _getNicStats testable
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6847/ : SUCCESS
Dan Kenigsberg has posted comments on this change.
Change subject: vm iface stats: fix arithmetic
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/25960
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vm iface stats: fix arithmetic
..
vm iface stats: fix arithmetic
My commit 672ff43 has a serious arithmetic flaw: the modulu must be
taken on the
Dan Kenigsberg has uploaded a new change for review.
Change subject: vm iface stats: fix arithmetic
..
vm iface stats: fix arithmetic
My commit 672ff43 has a serious arithmetic flaw: the modulu must be
taken on the sample
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: configurator: move usermod to spec
..
configurator: move usermod to spec
vdsm-tool configure --force adds to /etc/group (qemu/kvm) sanlock
but
Douglas Schilling Landgraf has posted comments on this change.
Change subject: configurator: move usermod to spec
..
Patch Set 4: Code-Review-1
Need to be resync, since we are splitting into http://gerrit.ovirt.org/26089
--
Douglas Schilling Landgraf has posted comments on this change.
Change subject: configurator: move usermod to spec
..
Patch Set 1:
If all reviewers agree, need to be tested under ovirt-node.
--
To view, visit
Dan Kenigsberg has posted comments on this change.
Change subject: configurator: move usermod to spec
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/26089
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: configurator: move usermod to spec
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6848/ : SUCCESS
Yaniv Bronhaim has posted comments on this change.
Change subject: configurator: move usermod to spec
..
Patch Set 1: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/26089/1/vdsm.spec.in
File vdsm.spec.in:
Line 692:
Xavi Francisco has posted comments on this change.
Change subject: Improve logging on some filesystem operations
..
Patch Set 2:
In general that's true but in this case we use the logging to check for
successful operations so
Yaniv Bronhaim has posted comments on this change.
Change subject: configurator: use sanlock user constant
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26080
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: configurator: move usermod to spec
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6849/ : SUCCESS
Dan Kenigsberg has uploaded a new change for review.
Change subject: vm iface stats: fix arithmetic
..
vm iface stats: fix arithmetic
My commit 672ff43 has a serious arithmetic flaw: the modulu must be
taken on the sample
oVirt Jenkins CI Server has posted comments on this change.
Change subject: pre-start: touch/configure vdsm logs
..
Patch Set 6:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6850/ : SUCCESS
Barak Azulay has posted comments on this change.
Change subject: hooks: Add hook for fake VM stats
..
Patch Set 6: Code-Review-1
This hook intends to simulate a single fake vm statistics,
Such a hook is required to test hosl
Dan Kenigsberg has uploaded a new change for review.
Change subject: netconfig: set ETHTOOL_OPTS when a NIC goes up
..
netconfig: set ETHTOOL_OPTS when a NIC goes up
There's broken hardware out there where lro needs to to be
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netconfig: set ETHTOOL_OPTS when a NIC goes up
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_network_functional_tests/1178/ :
Francesco Romani has posted comments on this change.
Change subject: performance: switch to cPickle
..
Patch Set 6: -Code-Review Verified-1
-1 is not enough, so un-ticking verified until discussion has taken place
--
To
Dan Kenigsberg has posted comments on this change.
Change subject: configurator: move usermod to spec
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/26089
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: performance: switch to cPickle
..
Patch Set 6: Code-Review-1
self-inflicted -1 until proper discussion on vdsm-devel about performance
benefits
--
To
Douglas Schilling Landgraf has abandoned this change.
Change subject: tools: configurator must persist usermod changes
..
Abandoned
We are going to use http://gerrit.ovirt.org/#/c/26089/
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: Move virt things into vdsm/virt
..
Patch Set 10:
I had the chance to run this code together with 21790 and some other minor
unrelated patches.
I did:
*
Francesco Romani has posted comments on this change.
Change subject: Convert vm status strings to constants
..
Patch Set 9:
I had the chance to run this code together with 21792 and some other minor
unrelated patches.
I did:
Francesco Romani has posted comments on this change.
Change subject: Convert vm status strings to constants
..
Patch Set 9: Code-Review+1
considering also my previous comment, looks fine.
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: configurator: move usermod to spec
..
Patch Set 2: Verified+1
Generated a ISO, after install the groups were added correct.
Second test, registered
Francesco Romani has posted comments on this change.
Change subject: Move virt things into vdsm/virt
..
Patch Set 10: Code-Review+1
considering also my previous comment, looks OK.
--
To view, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: configurator: use sanlock user constant
..
Patch Set 4: Verified+1
--
To view, visit http://gerrit.ovirt.org/26080
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: pre-start: touch/configure vdsm logs
..
Patch Set 7: Verified+1
--
To view, visit http://gerrit.ovirt.org/25912
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: pre-start: touch/configure vdsm logs
..
Patch Set 7:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6851/ : SUCCESS
Dan Kenigsberg has submitted this change and it was merged.
Change subject: configurator: move usermod to spec
..
configurator: move usermod to spec
vdsm-tool configure --force adds to /etc/group (qemu/kvm) sanlock
but doesn't
oVirt Jenkins CI Server has posted comments on this change.
Change subject: configurator: move usermod to spec
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/412/ :
FAILURE
Dan Kenigsberg has submitted this change and it was merged.
Change subject: pre-start: touch/configure vdsm logs
..
pre-start: touch/configure vdsm logs
During pre-start of vdsm we must create vdsm logs files
with proper
Dan Kenigsberg has posted comments on this change.
Change subject: pre-start: touch/configure vdsm logs
..
Patch Set 7: Code-Review+2
According to Douglas, this was verified with http://gerrit.ovirt.org/#/c/26089/
.
I hate
1 - 100 of 117 matches
Mail list logo
