Alon Bar-Lev has posted comments on this change.
Change subject: vdsm_config: move download certificate
..
Patch Set 25:
(2 comments)
http://gerrit.ovirt.org/#/c/26718/25/vdsm_reg/vdsm-reg-setup.in
File
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: vdsm-reg: eliminate the VDSMBRIDGE macro
..
vdsm-reg: eliminate the VDSMBRIDGE macro
VDSMBRIDGE is a historical macro holding the management bridge of
oVirt Jenkins CI Server has posted comments on this change.
Change subject: spice: allow to disable the to clipboard copypaste
..
Patch Set 17:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8516/ :
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: libvirt_configure: persist /etc/libvirt/qemu-sanlock.conf
..
libvirt_configure: persist /etc/libvirt/qemu-sanlock.conf
Fix missing persist of
oVirt Jenkins CI Server has posted comments on this change.
Change subject: spice: allow to disable the agent file transfer
..
Patch Set 17:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8517/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: graphdev: handle ticket for multiple devices
..
Patch Set 18:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8518/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: graphdev: support multiple graphics devices
..
Patch Set 11:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8519/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: graphdev: add the GraphicsDevice class
..
Patch Set 17:
Build Failed
Francesco Romani has posted comments on this change.
Change subject: virt: graphdev: support multiple graphics devices
..
Patch Set 11:
added functional test
--
To view, visit http://gerrit.ovirt.org/27215
To unsubscribe,
Francesco Romani has posted comments on this change.
Change subject: virt: graphdev: handle ticket for multiple devices
..
Patch Set 18:
rebased
--
To view, visit http://gerrit.ovirt.org/26897
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: spice: allow to disable the to clipboard copypaste
..
Patch Set 17:
ensure compatibility with legacy graphic devices (aka display* params)
--
To view,
Francesco Romani has posted comments on this change.
Change subject: spice: allow to disable the agent file transfer
..
Patch Set 17:
ensure compoatibility with legacy display (display* params)
--
To view, visit
Antoni Segura Puimedon has posted comments on this change.
Change subject: bridge_opts: Add ifcfg configurator support
..
Patch Set 12:
Added the requirement for the new initscripts. Waiting for the release of the
package for
oVirt Jenkins CI Server has posted comments on this change.
Change subject: bridge_opts: Add ifcfg configurator support
..
Patch Set 12:
Build Failed
Antoni Segura Puimedon has posted comments on this change.
Change subject: iproute2: Add static and autoconf ipv6 support
..
Patch Set 2:
(2 comments)
http://gerrit.ovirt.org/#/c/27189/2/lib/vdsm/ipwrapper.py
File
Francesco Romani has posted comments on this change.
Change subject: virt: stats: return empty dict when stats disabled
..
Patch Set 6:
rebased against master
--
To view, visit http://gerrit.ovirt.org/26790
To unsubscribe,
Francesco Romani has posted comments on this change.
Change subject: virt: stats: explicitily handle not enough samples
..
Patch Set 6:
rebased against master
--
To view, visit http://gerrit.ovirt.org/26791
To unsubscribe,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: iproute2: Add static and autoconf ipv6 support
..
Patch Set 3:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: stats: explicitily handle not enough samples
..
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8523/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: stats: return empty dict when stats disabled
..
Patch Set 5:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8524/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: stats: explicitily handle not enough samples
..
Patch Set 6:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8525/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: stats: return empty dict when stats disabled
..
Patch Set 6:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8526/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: stats: move core static stats in a method
..
Patch Set 5:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8527/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: stats: move VmStatsThread away from vm.py
..
Patch Set 5:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8528/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: stats: move balloon info in a method
..
Patch Set 5:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8530/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: stats: move dynamic stats in a method
..
Patch Set 5:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8529/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: stats: move vm status detection in a method
..
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8532/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: stats: move the guest stats in a method
..
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8531/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: stats: get rid of _getStatsInternal
..
Patch Set 5:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8533/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: stats: simplify the getStatsInternal flow
..
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8534/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: stats: move migration stats in a method
..
Patch Set 5:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8535/ : SUCCESS
Federico Simoncelli has posted comments on this change.
Change subject: tasks: loadDumpedTasks shouldn't queue tasks
..
Patch Set 1: Verified+1
Verified creating 1 preallocated disk on NFS and restarting vdsm. The task is
Yeela Kaplan has posted comments on this change.
Change subject: Change file permissions using ioprocess
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/27268/1/vdsm/storage/outOfProcess.py
File
Yeela Kaplan has posted comments on this change.
Change subject: Convert file metadata to use ioprocess for read/writes
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/27267/1/vdsm/storage/outOfProcess.py
File
Federico Simoncelli has posted comments on this change.
Change subject: task: prevent tasks with the same id to be queued
..
Patch Set 2:
(2 comments)
http://gerrit.ovirt.org/#/c/26808/2/vdsm/storage/taskManager.py
File
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tasks: loadDumpedTasks shouldn't queue tasks
..
tasks: loadDumpedTasks shouldn't queue tasks
loadDumpedTasks should just load the tasks in the
Yeela Kaplan has posted comments on this change.
Change subject: fileUtils.validateAccess ioprocess implementation
..
Patch Set 2:
(2 comments)
http://gerrit.ovirt.org/#/c/27120/2//COMMIT_MSG
Commit Message:
Line 4: Commit:
Yeela Kaplan has posted comments on this change.
Change subject: glob.glob ioprocess implementation
..
Patch Set 5:
(1 comment)
http://gerrit.ovirt.org/#/c/26967/5/vdsm/storage/outOfProcess.py
File
Yaniv Bronhaim has posted comments on this change.
Change subject: hooks: Add hook for fake VM stats
..
Patch Set 17: Code-Review+1
ok, i would specify the usage somewhere. looks fine to me
--
To view, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: configfile.py utility for common config file editing operations.
..
Patch Set 5:
(2 comments)
http://gerrit.ovirt.org/#/c/27129/5/lib/vdsm/tool/configfile.py
Francesco Romani has posted comments on this change.
Change subject: virt: stats: return empty dict when stats disabled
..
Patch Set 6: Verified+1
Verification:
- verified using vdsClient stats still reported
- verified the
Federico Simoncelli has posted comments on this change.
Change subject: spbackends: do not set spmRole on forceFreeSpm
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/27318/1//COMMIT_MSG
Commit Message:
Line 8:
Line
oVirt Jenkins CI Server has posted comments on this change.
Change subject: spbackends: do not set spmRole on forceFreeSpm
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8536/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: misc: remove recoveryCallback from watchCmd
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8537/ : SUCCESS
Michal Skrivanek has posted comments on this change.
Change subject: virt: stats: return empty dict when stats disabled
..
Patch Set 6: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26790
To unsubscribe, visit
Michal Skrivanek has posted comments on this change.
Change subject: virt: stats: explicitily handle not enough samples
..
Patch Set 6: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26791
To unsubscribe, visit
Ondřej Svoboda has posted comments on this change.
Change subject: ipwrapper, configurators: Wait for bonds to go up
..
Patch Set 6:
(5 comments)
http://gerrit.ovirt.org/#/c/26930/6//COMMIT_MSG
Commit Message:
Line 8:
Line
oVirt Jenkins CI Server has posted comments on this change.
Change subject: spbackends: do not set spmRole on forceFreeSpm
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8538/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: spice: allow to disable the to clipboard copypaste
..
Patch Set 18:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8539/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: spice: allow to disable the agent file transfer
..
Patch Set 18:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8540/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: graphdev: handle ticket for multiple devices
..
Patch Set 19:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8541/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: graphdev: support multiple graphics devices
..
Patch Set 12:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8542/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: graphdev: add the GraphicsDevice class
..
Patch Set 18:
Build Failed
Francesco Romani has posted comments on this change.
Change subject: virt: graphdev: add the GraphicsDevice class
..
Patch Set 19: Verified+1
fixed recovery and migration at the cost to ad more mess and special case
handling
oVirt Jenkins CI Server has posted comments on this change.
Change subject: spice: allow to disable the to clipboard copypaste
..
Patch Set 19:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8544/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: graphdev: handle ticket for multiple devices
..
Patch Set 20:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8545/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: spice: allow to disable the agent file transfer
..
Patch Set 19:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8546/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: graphdev: support multiple graphics devices
..
Patch Set 13:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8547/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: graphdev: add the GraphicsDevice class
..
Patch Set 19:
Build Failed
Francesco Romani has posted comments on this change.
Change subject: virt: graphdev: support multiple graphics devices
..
Patch Set 13: Verified+1
Verification:
* verified the backward compatibility using unaware engine 3.5.0
Francesco Romani has posted comments on this change.
Change subject: spice: allow to disable the agent file transfer
..
Patch Set 19: Verified+1
verified using patched engine and by inspecting the domain XML in the VDSM logs.
Francesco Romani has posted comments on this change.
Change subject: spice: allow to disable the to clipboard copypaste
..
Patch Set 19: Verified+1
verified using patched engine and by inspecting the domain XML in the VDSM
Yaniv Bronhaim has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 3:
(8 comments)
love it ! thanks!! just few comments. please have more reviews now. i think its
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netlink: add route retrieval capability
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1316/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netlink: add route retrieval capability
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_network_functional_tests_gerrit/1317/
Francesco Romani has posted comments on this change.
Change subject: virt: graphdev: handle ticket for multiple devices
..
Patch Set 21:
verified with an old engine (not handling multiple graphic devices) doing a few
Antoni Segura Puimedon has posted comments on this change.
Change subject: sourcerouting: fix _getRoute not to include local routes
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/27262/2//COMMIT_MSG
Commit Message:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: spice: allow to disable the to clipboard copypaste
..
Patch Set 20:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8551/ :
Nir Soffer has posted comments on this change.
Change subject: profile: Add couple of tests
..
Patch Set 2: Verified+1
Changed to use the new config api for setting defaults, so the config object
used by the profile module
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: graphdev: handle ticket for multiple devices
..
Patch Set 21:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8553/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: spice: allow to disable the agent file transfer
..
Patch Set 20:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8552/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: profile: Add couple of tests
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8554/ : SUCCESS
Francesco Romani has posted comments on this change.
Change subject: profile: Add couple of tests
..
Patch Set 2: Code-Review+1
(2 comments)
there is a couple of typos, but not enough to downvote or require a new
patchset.
Francesco Romani has posted comments on this change.
Change subject: agent: Only forward desktopLogin when the agent is responsive
..
Patch Set 1: Code-Review+1
(1 comment)
looks OK to me.
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: net_tc: add support for mirroring all (not just IPv4) traffic
..
net_tc: add support for mirroring all (not just IPv4) traffic
Up until now the filter
oVirt Jenkins CI Server has posted comments on this change.
Change subject: net_tc: add support for mirroring all (not just IPv4) traffic
..
Patch Set 1:
Build Failed
Francesco Romani has posted comments on this change.
Change subject: virt: graphdev: handle ticket for multiple devices
..
Patch Set 22: Verified+1
Verification:
- manually verified the legacy path together with 26895 and
oVirt Jenkins CI Server has posted comments on this change.
Change subject: spice: allow to disable the to clipboard copypaste
..
Patch Set 21:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8556/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: graphdev: handle ticket for multiple devices
..
Patch Set 22:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8558/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: spice: allow to disable the agent file transfer
..
Patch Set 21:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8557/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: net_tc: add support for mirroring all (not just IPv4) traffic
..
Patch Set 2:
Build Failed
Saggi Mizrahi has posted comments on this change.
Change subject: misc: remove recoveryCallback from watchCmd
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26872
To unsubscribe, visit
Nir Soffer has uploaded a new change for review.
Change subject: profile: Introduce profile decorator
..
profile: Introduce profile decorator
The profile decorator can be used for profiling certain code path, where
whole
Nir Soffer has posted comments on this change.
Change subject: profile: Add couple of tests
..
Patch Set 3: Verified+1
Rebase and fix few typos in the tests. No code change.
--
To view, visit http://gerrit.ovirt.org/27328
To
Nir Soffer has posted comments on this change.
Change subject: profile: Introduce profile decorator
..
Patch Set 1: Verified+1
Verified by running the tests.
--
To view, visit http://gerrit.ovirt.org/27389
To unsubscribe,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: profile: Introduce profile decorator
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8561/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: profile: Add couple of tests
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8560/ : SUCCESS
Francesco Romani has posted comments on this change.
Change subject: profile: Add couple of tests
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/27328
To unsubscribe, visit
Federico Simoncelli has uploaded a new change for review.
Change subject: image: remove unused storage_repository attribute
..
image: remove unused storage_repository attribute
Change-Id:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: image: remove unused storage_repository attribute
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8562/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: storage: Add logging on filesystem altering operations
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8563/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: storage: Add logging on filesystem altering operations
..
Patch Set 5:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8564/ :
Dan Kenigsberg has posted comments on this change.
Change subject: misc: remove recoveryCallback from watchCmd
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/26872
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: net_tc: add support for mirroring all (not just IPv4) traffic
..
Patch Set 2: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/27388/2/vdsm/network/tc.py
Dan Kenigsberg has posted comments on this change.
Change subject: image: remove unused storage_repository attribute
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/27392
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: iproute2: Add static and autoconf ipv6 support
..
Patch Set 3: Code-Review+2
Can you do something about these segfaults?
./tests/run_tests_local.sh: line 10:
Dan Kenigsberg has posted comments on this change.
Change subject: iproute2: Add source routing support
..
Patch Set 1:
(1 comment)
not reviewed yet, sorry.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: caps: Repair collect numa information
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8565/ : SUCCESS
Dan Kenigsberg has submitted this change and it was merged.
Change subject: spec: Add numactl dependency in spec file
..
spec: Add numactl dependency in spec file
Add numactl package dependency in vdsm spec files. This package
oVirt Jenkins CI Server has posted comments on this change.
Change subject: spec: Add numactl dependency in spec file
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/554/ :
100 matches
Mail list logo