Federico Simoncelli has posted comments on this change. Change subject: spbackends: do not set spmRole on forceFreeSpm ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/27318/1//COMMIT_MSG Commit Message: Line 8: Line 9: Setting the spmRole to SPM_FREE on forceFreeSpm is harmful. In fact the Line 10: release of the spm role (SPM_ACQUIRED) should go through the stopSpm Line 11: procedure where the master filesystem is unmounted, etc. Line 12: > I wonder if it's worth adding There's no reference to add here since the code is as old as Tabula Rasa. Ok for the bug reference. Line 13: Change-Id: I2bd9a0d9749e49a97a31c535c92dd242eb8f74ec -- To view, visit http://gerrit.ovirt.org/27318 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2bd9a0d9749e49a97a31c535c92dd242eb8f74ec Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
