Change in vdsm[ovirt-3.4]: dmidecode: Handle missing values.

2014-06-10 Thread dkuznets
Hello Yaniv Bronhaim, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/28541 to review the following change. Change subject: dmidecode: Handle missing values. .. dmidecode: Handle missing values.

Change in vdsm[master]: core: GET requests - use Range header

2014-06-10 Thread laravot
Liron Ar has posted comments on this change. Change subject: core: GET requests - use Range header .. Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/28465/3/vdsm/BindingXMLRPC.py File vdsm/BindingXMLRPC.py: Line 272:

Change in vdsm[master]: virt: Specify snapshot type

2014-06-10 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: virt: Specify snapshot type .. Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/28531/1//COMMIT_MSG Commit Message: Line 15: the wrong value to be

Change in vdsm[ovirt-3.4]: dmidecode: Handle missing values.

2014-06-10 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: dmidecode: Handle missing values. .. Patch Set 1: Verified+1 verified with engine built from ovirt-3.4 -- To view, visit http://gerrit.ovirt.org/28541 To

Change in vdsm[master]: jsonrpc: ssl related code moved to single module

2014-06-10 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: jsonrpc: ssl related code moved to single module .. Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/28506/3/lib/vdsm/SecureXMLRPCServer.py File

Change in vdsm[master]: core: GET requests - use Range header

2014-06-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: GET requests - use Range header .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8951/ : SUCCESS

Change in vdsm[master]: jsonrpc: json over stomp available on the same socket

2014-06-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpc: json over stomp available on the same socket .. Patch Set 4: Build Successful

Change in vdsm[master]: jsonrpc: Json processing issues fixed

2014-06-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpc: Json processing issues fixed .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8953/ : SUCCESS

Change in vdsm[master]: jsonrpc: Moving xml rpc related modules in to rpc package

2014-06-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpc: Moving xml rpc related modules in to rpc package .. Patch Set 4: Build Successful

Change in vdsm[master]: jsonrpc: xmlrpc protocol detection

2014-06-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpc: xmlrpc protocol detection .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8955/ : SUCCESS

Change in vdsm[master]: core: GET requests - use Range header

2014-06-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: GET requests - use Range header .. Patch Set 5: Verified-1 Build Unstable http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8957/

Change in vdsm[master]: core: GET requests - use Range header

2014-06-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: core: GET requests - use Range header .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8958/ : SUCCESS

Change in vdsm[master]: jsonrpc: ssl related code moved to single module

2014-06-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpc: ssl related code moved to single module .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8956/ :

Change in vdsm[master]: net_func_tests: add test for reconfiguring broken bridged ne...

2014-06-10 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: net_func_tests: add test for reconfiguring broken bridged network .. Patch Set 2: Verified+1 Passing the jenkins functional test is enough for me. --

Change in vdsm[master]: Refactoring reportError func

2014-06-10 Thread kobi
Kobi Ianko has posted comments on this change. Change subject: Refactoring reportError func .. Patch Set 5: (2 comments) http://gerrit.ovirt.org/#/c/28482/5/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 4492: return

Change in vdsm[master]: Adding updateVmPolicy api

2014-06-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding updateVmPolicy api .. Patch Set 25: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8959/

Change in vdsm[master]: net models: simplify condition

2014-06-10 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: net models: simplify condition .. Patch Set 2: Verified+1 Code-Review+2 verified by running the functional tests on jenkins. -- To view, visit

Change in vdsm[master]: net models: simplify condition

2014-06-10 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: net models: simplify condition .. net models: simplify condition Bond.objectivize() is always called with a non-None bonding name. No need to

Change in vdsm[master]: net models: simplify condition

2014-06-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: net models: simplify condition .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1408/ : SUCCESS -- To

Change in vdsm[master]: net models: simplify error condition

2014-06-10 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: net models: simplify error condition .. Patch Set 2: Code-Review-1 Maybe a small change in the text message. -- To view, visit

Change in vdsm[master]: net: remove last dependency on ifcfg persistence

2014-06-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: net: remove last dependency on ifcfg persistence .. Patch Set 2: -Code-Review -Verified Build Successful

Change in vdsm[master]: Report legacy bond devices instead of actually creating them

2014-06-10 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: Report legacy bond devices instead of actually creating them .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/28455 To

Change in vdsm[master]: vm: Collect vm numa node runtime pin information

2014-06-10 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vm: Collect vm numa node runtime pin information .. Patch Set 4: (1 comment) AFAIR stats are polled from engine every 15 (fifteen) seconds. And if this is

Change in vdsm[master]: virt: migration: add monitor thread control loop

2014-06-10 Thread fromani
Francesco Romani has posted comments on this change. Change subject: virt: migration: add monitor thread control loop .. Patch Set 17: (1 comment) http://gerrit.ovirt.org/#/c/25976/17/vdsm/virt/migration.py File

Change in vdsm[master]: adding API methods for blkio limits MOM integration

2014-06-10 Thread gchaplik
Gilad Chaplik has uploaded a new change for review. Change subject: adding API methods for blkio limits MOM integration .. adding API methods for blkio limits MOM integration Adding API methods to vm.py to integrate with MOM's

Change in vdsm[master]: virt: Filter internal data for getVMList API

2014-06-10 Thread Federico Simoncelli
Federico Simoncelli has posted comments on this change. Change subject: virt: Filter internal data for getVMList API .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/28532/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Line

Change in vdsm[master]: virt: Lookup conf and device by path

2014-06-10 Thread Federico Simoncelli
Federico Simoncelli has posted comments on this change. Change subject: virt: Lookup conf and device by path .. Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/27951/2/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 3167:

Change in vdsm[master]: LiveMerge: Add support for deleting merged volumes

2014-06-10 Thread Federico Simoncelli
Federico Simoncelli has posted comments on this change. Change subject: LiveMerge: Add support for deleting merged volumes .. Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/26768/5/vdsm/storage/blockVolume.py File

Change in vdsm[master]: Adding updateVmPolicy api

2014-06-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding updateVmPolicy api .. Patch Set 26: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8961/ : FAILURE

Change in vdsm[master]: Adding API methods for CPU limit MOM integration

2014-06-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding API methods for CPU limit MOM integration .. Patch Set 5: Build Successful

Change in vdsm[master]: Refactoring reportError func

2014-06-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Refactoring reportError func .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8963/ : SUCCESS

Change in vdsm[master]: Adding utility methods and conf for CPU limit MOM integration

2014-06-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding utility methods and conf for CPU limit MOM integration .. Patch Set 40: Build Failed

Change in vdsm[master]: adding API methods for blkio limits MOM integration

2014-06-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: adding API methods for blkio limits MOM integration .. Patch Set 1: Code-Review-1 Verified-1 Build Failed

Change in vdsm[master]: adding API methods for blkio limits MOM integration

2014-06-10 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: adding API methods for blkio limits MOM integration .. Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/28547/1/vdsm/virt/vm.py File vdsm/virt/vm.py:

Change in vdsm[master]: tests: fix wrong use of assertions

2014-06-10 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: tests: fix wrong use of assertions .. Patch Set 4: (2 comments) http://gerrit.ovirt.org/#/c/28124/4/tests/functional/storageTests.py File

Change in vdsm[master]: Refactoring reportError func

2014-06-10 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Refactoring reportError func .. Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/28482/5/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 4497: This

Change in vdsm[master]: faqemu hook: move memory limitation to config

2014-06-10 Thread mpoledni
Martin Polednik has posted comments on this change. Change subject: faqemu hook: move memory limitation to config .. Patch Set 3: -Verified (1 comment) http://gerrit.ovirt.org/#/c/28320/3/vdsm_hooks/faqemu/before_vm_start.py

Change in vdsm[master]: jsonrpc: Removal of not needed reactors

2014-06-10 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: jsonrpc: Removal of not needed reactors .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/28503/1/tests/jsonRpcTests.py File tests/jsonRpcTests.py: Line

Change in vdsm[master]: jsonrpc: Moving xml rpc related modules in to rpc package

2014-06-10 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: jsonrpc: Moving xml rpc related modules in to rpc package .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/28504 To unsubscribe, visit

Change in vdsm[master]: Refactoring reportError func

2014-06-10 Thread kobi
Kobi Ianko has posted comments on this change. Change subject: Refactoring reportError func .. Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/28482/5/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 4497: This method

Change in vdsm[master]: vdsm-upgrade: adds wrapper to ovirt-node-upgrade

2014-06-10 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: vdsm-upgrade: adds wrapper to ovirt-node-upgrade .. Patch Set 3: (4 comments) http://gerrit.ovirt.org/#/c/28244/3/vdsm_reg/vdsm-upgrade File

Change in vdsm[master]: utils: add isOvirtNode function.

2014-06-10 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: utils: add isOvirtNode function. .. Patch Set 2: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/28486/2/lib/vdsm/utils.py File lib/vdsm/utils.py: Line

Change in vdsm[master]: net models: simplify error condition

2014-06-10 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: net models: simplify error condition .. Patch Set 3: Code-Review+1 thanks for the change! -- To view, visit http://gerrit.ovirt.org/28497 To

Change in vdsm[master]: net models: simplify error condition

2014-06-10 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: net models: simplify error condition .. Patch Set 3: Verified+1 Code-Review+2 Passes functional tests for BONDING_NAME=bond5 -- To view, visit

Change in vdsm[master]: Adding updateVmPolicy api

2014-06-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding updateVmPolicy api .. Patch Set 27: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8969/

Change in vdsm[master]: net models: simplify error condition

2014-06-10 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: net models: simplify error condition .. net models: simplify error condition An attempt to add a bonding device with no nics ends with a different

Change in vdsm[master]: netinfo: Hacked InfiniBand speed.

2014-06-10 Thread osvoboda
Ondřej Svoboda has posted comments on this change. Change subject: netinfo: Hacked InfiniBand speed. .. Patch Set 5: Verified+1 (1 comment) Even with the different way of detecting InfiniBand devices (by checking their

Change in vdsm[master]: net models: simplify error condition

2014-06-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: net models: simplify error condition .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1409/ : SUCCESS

Change in vdsm[master]: netinfo: Hacked InfiniBand speed.

2014-06-10 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: netinfo: Hacked InfiniBand speed. .. Patch Set 5: Thanks. Let's give Markus Stockhausen a couple of days to check this. -- To view, visit

Change in vdsm[master]: iproute2: raise ConfigNetworkError when dhcp fails and block...

2014-06-10 Thread asegurap
Antoni Segura Puimedon has uploaded a new change for review. Change subject: iproute2: raise ConfigNetworkError when dhcp fails and blockingdhcp is set .. iproute2: raise ConfigNetworkError when dhcp fails and blockingdhcp is

Change in vdsm[master]: jsonrpc: Removal of not needed reactors

2014-06-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpc: Removal of not needed reactors .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8978/ :

Change in vdsm[master]: oop: Add an option to configure oop implementation

2014-06-10 Thread smizrahi
Saggi Mizrahi has posted comments on this change. Change subject: oop: Add an option to configure oop implementation .. Patch Set 19: Code-Review+1 I'll +2 once Jenkins is configured properly since pushing this code in would

Change in vdsm[master]: Refactoring reportError func

2014-06-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Refactoring reportError func .. Patch Set 7: Code-Review-1 Verified-1 Build Failed

Change in vdsm[master]: iproute2: raise ConfigNetworkError when dhcp fails and block...

2014-06-10 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: iproute2: raise ConfigNetworkError when dhcp fails and blockingdhcp is set .. Patch Set 2: Verified+1 rhel65_01 tests (bddd141) #

Change in vdsm[master]: iproute2: raise ConfigNetworkError when dhcp fails and block...

2014-06-10 Thread osvoboda
Ondřej Svoboda has posted comments on this change. Change subject: iproute2: raise ConfigNetworkError when dhcp fails and blockingdhcp is set .. Patch Set 2: Code-Review+1 Looks good :-) -- To view, visit

Change in vdsm[master]: net_func_tests: add test for reconfiguring broken bridged ne...

2014-06-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: net_func_tests: add test for reconfiguring broken bridged network .. Patch Set 3: Build Successful

Change in vdsm[master]: Adding API methods for CPU limit MOM integration

2014-06-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding API methods for CPU limit MOM integration .. Patch Set 6: Build Successful

Change in vdsm[master]: virt: Filter internal data for getVMList API

2014-06-10 Thread alitke
Adam Litke has posted comments on this change. Change subject: virt: Filter internal data for getVMList API .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/28532 To unsubscribe, visit

Change in vdsm[master]: virt: Specify snapshot type

2014-06-10 Thread alitke
Adam Litke has posted comments on this change. Change subject: virt: Specify snapshot type .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/28531 To unsubscribe, visit http://gerrit.ovirt.org/settings

Change in vdsm[master]: LiveMerge: Add support for deleting merged volumes

2014-06-10 Thread alitke
Adam Litke has posted comments on this change. Change subject: LiveMerge: Add support for deleting merged volumes .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.ovirt.org/26768 To unsubscribe, visit

Change in vdsm[master]: virt: Filter internal data for getVMList API

2014-06-10 Thread Federico Simoncelli
Federico Simoncelli has posted comments on this change. Change subject: virt: Filter internal data for getVMList API .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/28532 To unsubscribe, visit

Change in vdsm[master]: virt: Specify snapshot type

2014-06-10 Thread Federico Simoncelli
Federico Simoncelli has posted comments on this change. Change subject: virt: Specify snapshot type .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/28531 To unsubscribe, visit

Change in vdsm[master]: virt: Lookup conf and device by path

2014-06-10 Thread Federico Simoncelli
Federico Simoncelli has posted comments on this change. Change subject: virt: Lookup conf and device by path .. Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/27951/3/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 3164:

Change in vdsm[master]: LiveMerge: Add support for deleting merged volumes

2014-06-10 Thread Federico Simoncelli
Federico Simoncelli has posted comments on this change. Change subject: LiveMerge: Add support for deleting merged volumes .. Patch Set 6: Code-Review+1 (1 comment)

Change in vdsm[master]: Adding utility methods and conf for CPU limit MOM integration

2014-06-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding utility methods and conf for CPU limit MOM integration .. Patch Set 41: Code-Review-1 Verified-1 Build Failed

Change in vdsm[master]: faqemu hook: move memory limitation to config

2014-06-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: faqemu hook: move memory limitation to config .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9002/ :

Change in vdsm[master]: clarify why scsiKey parameter is not passed on

2014-06-10 Thread ykleinbe
Yoav Kleinberger has posted comments on this change. Change subject: clarify why scsiKey parameter is not passed on .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/28560 To unsubscribe, visit

Change in vdsm[master]: LiveMerge: Add support for deleting merged volumes

2014-06-10 Thread alitke
Adam Litke has posted comments on this change. Change subject: LiveMerge: Add support for deleting merged volumes .. Patch Set 7: Verified+1 Fixed typo in comment as requested. -- To view, visit http://gerrit.ovirt.org/26768

Change in vdsm[ovirt-3.4]: Setting enum for isconfigured return value and change overri...

2014-06-10 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Setting enum for isconfigured return value and change override semantics .. Patch Set 3: Code-Review+2 Same as master, except for InvalidConfig and

Change in vdsm[master]: net: remove last dependency on ifcfg persistence

2014-06-10 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: net: remove last dependency on ifcfg persistence .. Patch Set 2: Verified+1 Passing the jenkins functional tests and passing rhel65_01 tests (bddd141)

Change in vdsm[master]: netlink: Do not truncate InfiniBand HW addresses anymore

2014-06-10 Thread osvoboda
Ondřej Svoboda has uploaded a new change for review. Change subject: netlink: Do not truncate InfiniBand HW addresses anymore .. netlink: Do not truncate InfiniBand HW addresses anymore Change-Id:

Change in vdsm[master]: netlink: Do not truncate InfiniBand HW addresses anymore

2014-06-10 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: netlink: Do not truncate InfiniBand HW addresses anymore .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/28554 To unsubscribe,

Change in vdsm[master]: adding API methods for blkio limits MOM integration

2014-06-10 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: adding API methods for blkio limits MOM integration .. Patch Set 1: Verified-1 don't review please -- To view, visit http://gerrit.ovirt.org/28547 To

Change in vdsm[master]: net models: simplify error condition

2014-06-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: net models: simplify error condition .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8966/ : SUCCESS

Change in vdsm[master]: Report legacy bond devices instead of actually creating them

2014-06-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Report legacy bond devices instead of actually creating them .. Patch Set 5: Build Successful

Change in vdsm[master]: netlink: Do not truncate InfiniBand HW addresses anymore

2014-06-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: netlink: Do not truncate InfiniBand HW addresses anymore .. Patch Set 1: Build Successful

Change in vdsm[master]: netinfo: Hacked InfiniBand speed.

2014-06-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Hacked InfiniBand speed. .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8970/ : SUCCESS

Change in vdsm[master]: netinfo: Hacked InfiniBand speed.

2014-06-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Hacked InfiniBand speed. .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8979/ : SUCCESS

Change in vdsm[master]: iproute2: raise ConfigNetworkError when dhcp fails and block...

2014-06-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: iproute2: raise ConfigNetworkError when dhcp fails and blockingdhcp is set .. Patch Set 1: Build Failed

Change in vdsm[master]: jsonrpc: vsam-api removal

2014-06-10 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: jsonrpc: vsam-api removal .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/28527 To unsubscribe, visit http://gerrit.ovirt.org/settings

Change in vdsm[master]: Adding API methods for CPU limit MOM integration

2014-06-10 Thread kobi
Kobi Ianko has posted comments on this change. Change subject: Adding API methods for CPU limit MOM integration .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/28462/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 4518:

Change in vdsm[master]: Refactoring reportError func

2014-06-10 Thread msivak
Martin Sivák has posted comments on this change. Change subject: Refactoring reportError func .. Patch Set 8: Code-Review+1 I think this is reasonable. The only thing I am not sure about is the actual default value - I am

Change in vdsm[master]: jsonrpc: xmlrpc protocol detection

2014-06-10 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: jsonrpc: xmlrpc protocol detection .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/28507 To unsubscribe, visit

Change in vdsm[master]: jsonrpc: Removal of not needed reactors

2014-06-10 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: jsonrpc: Removal of not needed reactors .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/28503 To unsubscribe, visit

Change in vdsm[master]: LiveMerge: Add support for deleting merged volumes

2014-06-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: LiveMerge: Add support for deleting merged volumes .. Patch Set 7: Build Successful

Change in vdsm[master]: jsonrpc: Moving xml rpc related modules in to rpc package

2014-06-10 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: jsonrpc: Moving xml rpc related modules in to rpc package .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/28504 To unsubscribe, visit

Change in vdsm[master]: Adding API methods for CPU limit MOM integration

2014-06-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding API methods for CPU limit MOM integration .. Patch Set 7: Verified-1 Build Unstable

Change in vdsm[master]: Adding API methods for CPU limit MOM integration

2014-06-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding API methods for CPU limit MOM integration .. Patch Set 9: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8986/ :

Change in vdsm[master]: Refactoring reportError func

2014-06-10 Thread kobi
Kobi Ianko has posted comments on this change. Change subject: Refactoring reportError func .. Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/28482/5/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 4497: This method

Change in vdsm[master]: LiveMerge: Add support for deleting merged volumes

2014-06-10 Thread alitke
Adam Litke has posted comments on this change. Change subject: LiveMerge: Add support for deleting merged volumes .. Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/26768/5/vdsm/storage/blockVolume.py File

Change in vdsm[master]: Refactoring reportError func

2014-06-10 Thread msivak
Martin Sivák has posted comments on this change. Change subject: Refactoring reportError func .. Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/28482/5/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 4497: This

Change in vdsm[master]: Refactoring reportError func

2014-06-10 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Refactoring reportError func .. Patch Set 8: Code-Review-1 (1 comment) The current semantics of the error code is a bit of a mess: most often, Engine does

Change in vdsm[master]: Refactoring reportError func

2014-06-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Refactoring reportError func .. Patch Set 8: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8981/ : SUCCESS

Change in vdsm[master]: LiveMerge: Add support for deleting merged volumes

2014-06-10 Thread Federico Simoncelli
Federico Simoncelli has posted comments on this change. Change subject: LiveMerge: Add support for deleting merged volumes .. Patch Set 7: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/26768 To unsubscribe, visit

Change in vdsm[ovirt-3.4]: Setting enum for isconfigured return value and change overri...

2014-06-10 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: Setting enum for isconfigured return value and change override semantics .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.ovirt.org/28473 To

Change in vdsm[master]: mount: Check if mount specification is a symlink

2014-06-10 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: mount: Check if mount specification is a symlink .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/27321 To unsubscribe, visit

Change in vdsm[master]: Remove redundant print

2014-06-10 Thread dkuznets
Dima Kuznetsov has posted comments on this change. Change subject: Remove redundant print .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/28406 To unsubscribe, visit http://gerrit.ovirt.org/settings

Change in vdsm[master]: jsonrpc: vsam-api removal

2014-06-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpc: vsam-api removal .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8973/ : SUCCESS

Change in vdsm[master]: Final separation of IOProcess and RFH

2014-06-10 Thread Federico Simoncelli
Federico Simoncelli has posted comments on this change. Change subject: Final separation of IOProcess and RFH .. Patch Set 8: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/28088 To unsubscribe, visit

Change in vdsm[master]: jsonrpc: Json processing issues fixed

2014-06-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpc: Json processing issues fixed .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8974/ : SUCCESS

  1   2   >