Hello Yaniv Bronhaim,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/28541
to review the following change.
Change subject: dmidecode: Handle missing values.
..
dmidecode: Handle missing values.
Liron Ar has posted comments on this change.
Change subject: core: GET requests - use Range header
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/28465/3/vdsm/BindingXMLRPC.py
File vdsm/BindingXMLRPC.py:
Line 272:
Allon Mureinik has posted comments on this change.
Change subject: virt: Specify snapshot type
..
Patch Set 1:
(2 comments)
http://gerrit.ovirt.org/#/c/28531/1//COMMIT_MSG
Commit Message:
Line 15: the wrong value to be
Dima Kuznetsov has posted comments on this change.
Change subject: dmidecode: Handle missing values.
..
Patch Set 1: Verified+1
verified with engine built from ovirt-3.4
--
To view, visit http://gerrit.ovirt.org/28541
To
Dan Kenigsberg has posted comments on this change.
Change subject: jsonrpc: ssl related code moved to single module
..
Patch Set 3:
(2 comments)
http://gerrit.ovirt.org/#/c/28506/3/lib/vdsm/SecureXMLRPCServer.py
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: GET requests - use Range header
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8951/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: jsonrpc: json over stomp available on the same socket
..
Patch Set 4:
Build Successful
oVirt Jenkins CI Server has posted comments on this change.
Change subject: jsonrpc: Json processing issues fixed
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8953/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: jsonrpc: Moving xml rpc related modules in to rpc package
..
Patch Set 4:
Build Successful
oVirt Jenkins CI Server has posted comments on this change.
Change subject: jsonrpc: xmlrpc protocol detection
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8955/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: GET requests - use Range header
..
Patch Set 5: Verified-1
Build Unstable
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8957/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: GET requests - use Range header
..
Patch Set 6:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8958/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: jsonrpc: ssl related code moved to single module
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8956/ :
Antoni Segura Puimedon has posted comments on this change.
Change subject: net_func_tests: add test for reconfiguring broken bridged
network
..
Patch Set 2: Verified+1
Passing the jenkins functional test is enough for me.
--
Kobi Ianko has posted comments on this change.
Change subject: Refactoring reportError func
..
Patch Set 5:
(2 comments)
http://gerrit.ovirt.org/#/c/28482/5/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 4492: return
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Adding updateVmPolicy api
..
Patch Set 25: Code-Review-1 Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8959/
Dan Kenigsberg has posted comments on this change.
Change subject: net models: simplify condition
..
Patch Set 2: Verified+1 Code-Review+2
verified by running the functional tests on jenkins.
--
To view, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net models: simplify condition
..
net models: simplify condition
Bond.objectivize() is always called with a non-None bonding name. No
need to
oVirt Jenkins CI Server has posted comments on this change.
Change subject: net models: simplify condition
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1408/ : SUCCESS
--
To
Antoni Segura Puimedon has posted comments on this change.
Change subject: net models: simplify error condition
..
Patch Set 2: Code-Review-1
Maybe a small change in the text message.
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: net: remove last dependency on ifcfg persistence
..
Patch Set 2: -Code-Review -Verified
Build Successful
Antoni Segura Puimedon has posted comments on this change.
Change subject: Report legacy bond devices instead of actually creating them
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/28455
To
Francesco Romani has posted comments on this change.
Change subject: vm: Collect vm numa node runtime pin information
..
Patch Set 4:
(1 comment)
AFAIR stats are polled from engine every 15 (fifteen) seconds. And if this is
Francesco Romani has posted comments on this change.
Change subject: virt: migration: add monitor thread control loop
..
Patch Set 17:
(1 comment)
http://gerrit.ovirt.org/#/c/25976/17/vdsm/virt/migration.py
File
Gilad Chaplik has uploaded a new change for review.
Change subject: adding API methods for blkio limits MOM integration
..
adding API methods for blkio limits MOM integration
Adding API methods to vm.py to integrate with MOM's
Federico Simoncelli has posted comments on this change.
Change subject: virt: Filter internal data for getVMList API
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/28532/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line
Federico Simoncelli has posted comments on this change.
Change subject: virt: Lookup conf and device by path
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/27951/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 3167:
Federico Simoncelli has posted comments on this change.
Change subject: LiveMerge: Add support for deleting merged volumes
..
Patch Set 5:
(1 comment)
http://gerrit.ovirt.org/#/c/26768/5/vdsm/storage/blockVolume.py
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Adding updateVmPolicy api
..
Patch Set 26:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8961/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Adding API methods for CPU limit MOM integration
..
Patch Set 5:
Build Successful
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Refactoring reportError func
..
Patch Set 6:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8963/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Adding utility methods and conf for CPU limit MOM integration
..
Patch Set 40:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: adding API methods for blkio limits MOM integration
..
Patch Set 1: Code-Review-1 Verified-1
Build Failed
Gilad Chaplik has posted comments on this change.
Change subject: adding API methods for blkio limits MOM integration
..
Patch Set 1:
(2 comments)
http://gerrit.ovirt.org/#/c/28547/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Dan Kenigsberg has posted comments on this change.
Change subject: tests: fix wrong use of assertions
..
Patch Set 4:
(2 comments)
http://gerrit.ovirt.org/#/c/28124/4/tests/functional/storageTests.py
File
Dan Kenigsberg has posted comments on this change.
Change subject: Refactoring reportError func
..
Patch Set 5:
(1 comment)
http://gerrit.ovirt.org/#/c/28482/5/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 4497: This
Martin Polednik has posted comments on this change.
Change subject: faqemu hook: move memory limitation to config
..
Patch Set 3: -Verified
(1 comment)
http://gerrit.ovirt.org/#/c/28320/3/vdsm_hooks/faqemu/before_vm_start.py
Nir Soffer has posted comments on this change.
Change subject: jsonrpc: Removal of not needed reactors
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/28503/1/tests/jsonRpcTests.py
File tests/jsonRpcTests.py:
Line
Dan Kenigsberg has posted comments on this change.
Change subject: jsonrpc: Moving xml rpc related modules in to rpc package
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/28504
To unsubscribe, visit
Kobi Ianko has posted comments on this change.
Change subject: Refactoring reportError func
..
Patch Set 5:
(1 comment)
http://gerrit.ovirt.org/#/c/28482/5/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 4497: This method
Alon Bar-Lev has posted comments on this change.
Change subject: vdsm-upgrade: adds wrapper to ovirt-node-upgrade
..
Patch Set 3:
(4 comments)
http://gerrit.ovirt.org/#/c/28244/3/vdsm_reg/vdsm-upgrade
File
Dan Kenigsberg has posted comments on this change.
Change subject: utils: add isOvirtNode function.
..
Patch Set 2: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/28486/2/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line
Antoni Segura Puimedon has posted comments on this change.
Change subject: net models: simplify error condition
..
Patch Set 3: Code-Review+1
thanks for the change!
--
To view, visit http://gerrit.ovirt.org/28497
To
Dan Kenigsberg has posted comments on this change.
Change subject: net models: simplify error condition
..
Patch Set 3: Verified+1 Code-Review+2
Passes functional tests for BONDING_NAME=bond5
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Adding updateVmPolicy api
..
Patch Set 27: Code-Review-1 Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8969/
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net models: simplify error condition
..
net models: simplify error condition
An attempt to add a bonding device with no nics ends with a different
Ondřej Svoboda has posted comments on this change.
Change subject: netinfo: Hacked InfiniBand speed.
..
Patch Set 5: Verified+1
(1 comment)
Even with the different way of detecting InfiniBand devices (by checking their
oVirt Jenkins CI Server has posted comments on this change.
Change subject: net models: simplify error condition
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1409/ : SUCCESS
Dan Kenigsberg has posted comments on this change.
Change subject: netinfo: Hacked InfiniBand speed.
..
Patch Set 5:
Thanks. Let's give Markus Stockhausen a couple of days to check this.
--
To view, visit
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: iproute2: raise ConfigNetworkError when dhcp fails and
blockingdhcp is set
..
iproute2: raise ConfigNetworkError when dhcp fails and blockingdhcp is
oVirt Jenkins CI Server has posted comments on this change.
Change subject: jsonrpc: Removal of not needed reactors
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8978/ :
Saggi Mizrahi has posted comments on this change.
Change subject: oop: Add an option to configure oop implementation
..
Patch Set 19: Code-Review+1
I'll +2 once Jenkins is configured properly since pushing this code in would
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Refactoring reportError func
..
Patch Set 7: Code-Review-1 Verified-1
Build Failed
Antoni Segura Puimedon has posted comments on this change.
Change subject: iproute2: raise ConfigNetworkError when dhcp fails and
blockingdhcp is set
..
Patch Set 2: Verified+1
rhel65_01 tests (bddd141) #
Ondřej Svoboda has posted comments on this change.
Change subject: iproute2: raise ConfigNetworkError when dhcp fails and
blockingdhcp is set
..
Patch Set 2: Code-Review+1
Looks good :-)
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: net_func_tests: add test for reconfiguring broken bridged
network
..
Patch Set 3:
Build Successful
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Adding API methods for CPU limit MOM integration
..
Patch Set 6:
Build Successful
Adam Litke has posted comments on this change.
Change subject: virt: Filter internal data for getVMList API
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/28532
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: virt: Specify snapshot type
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/28531
To unsubscribe, visit http://gerrit.ovirt.org/settings
Adam Litke has posted comments on this change.
Change subject: LiveMerge: Add support for deleting merged volumes
..
Patch Set 6: Verified+1
--
To view, visit http://gerrit.ovirt.org/26768
To unsubscribe, visit
Federico Simoncelli has posted comments on this change.
Change subject: virt: Filter internal data for getVMList API
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/28532
To unsubscribe, visit
Federico Simoncelli has posted comments on this change.
Change subject: virt: Specify snapshot type
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/28531
To unsubscribe, visit
Federico Simoncelli has posted comments on this change.
Change subject: virt: Lookup conf and device by path
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/27951/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 3164:
Federico Simoncelli has posted comments on this change.
Change subject: LiveMerge: Add support for deleting merged volumes
..
Patch Set 6: Code-Review+1
(1 comment)
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Adding utility methods and conf for CPU limit MOM integration
..
Patch Set 41: Code-Review-1 Verified-1
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: faqemu hook: move memory limitation to config
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9002/ :
Yoav Kleinberger has posted comments on this change.
Change subject: clarify why scsiKey parameter is not passed on
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/28560
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: LiveMerge: Add support for deleting merged volumes
..
Patch Set 7: Verified+1
Fixed typo in comment as requested.
--
To view, visit http://gerrit.ovirt.org/26768
Dan Kenigsberg has posted comments on this change.
Change subject: Setting enum for isconfigured return value and change override
semantics
..
Patch Set 3: Code-Review+2
Same as master, except for InvalidConfig and
Antoni Segura Puimedon has posted comments on this change.
Change subject: net: remove last dependency on ifcfg persistence
..
Patch Set 2: Verified+1
Passing the jenkins functional tests and passing
rhel65_01 tests (bddd141)
Ondřej Svoboda has uploaded a new change for review.
Change subject: netlink: Do not truncate InfiniBand HW addresses anymore
..
netlink: Do not truncate InfiniBand HW addresses anymore
Change-Id:
Antoni Segura Puimedon has posted comments on this change.
Change subject: netlink: Do not truncate InfiniBand HW addresses anymore
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/28554
To unsubscribe,
Gilad Chaplik has posted comments on this change.
Change subject: adding API methods for blkio limits MOM integration
..
Patch Set 1: Verified-1
don't review please
--
To view, visit http://gerrit.ovirt.org/28547
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: net models: simplify error condition
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8966/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Report legacy bond devices instead of actually creating them
..
Patch Set 5:
Build Successful
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netlink: Do not truncate InfiniBand HW addresses anymore
..
Patch Set 1:
Build Successful
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netinfo: Hacked InfiniBand speed.
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8970/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netinfo: Hacked InfiniBand speed.
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8979/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: iproute2: raise ConfigNetworkError when dhcp fails and
blockingdhcp is set
..
Patch Set 1:
Build Failed
Dan Kenigsberg has posted comments on this change.
Change subject: jsonrpc: vsam-api removal
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/28527
To unsubscribe, visit http://gerrit.ovirt.org/settings
Kobi Ianko has posted comments on this change.
Change subject: Adding API methods for CPU limit MOM integration
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/28462/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 4518:
Martin Sivák has posted comments on this change.
Change subject: Refactoring reportError func
..
Patch Set 8: Code-Review+1
I think this is reasonable. The only thing I am not sure about is the actual
default value - I am
Dan Kenigsberg has posted comments on this change.
Change subject: jsonrpc: xmlrpc protocol detection
..
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/28507
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: jsonrpc: Removal of not needed reactors
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/28503
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: LiveMerge: Add support for deleting merged volumes
..
Patch Set 7:
Build Successful
Dan Kenigsberg has posted comments on this change.
Change subject: jsonrpc: Moving xml rpc related modules in to rpc package
..
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/28504
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Adding API methods for CPU limit MOM integration
..
Patch Set 7: Verified-1
Build Unstable
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Adding API methods for CPU limit MOM integration
..
Patch Set 9:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8986/ :
Kobi Ianko has posted comments on this change.
Change subject: Refactoring reportError func
..
Patch Set 5:
(1 comment)
http://gerrit.ovirt.org/#/c/28482/5/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 4497: This method
Adam Litke has posted comments on this change.
Change subject: LiveMerge: Add support for deleting merged volumes
..
Patch Set 5:
(1 comment)
http://gerrit.ovirt.org/#/c/26768/5/vdsm/storage/blockVolume.py
File
Martin Sivák has posted comments on this change.
Change subject: Refactoring reportError func
..
Patch Set 5:
(1 comment)
http://gerrit.ovirt.org/#/c/28482/5/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 4497: This
Dan Kenigsberg has posted comments on this change.
Change subject: Refactoring reportError func
..
Patch Set 8: Code-Review-1
(1 comment)
The current semantics of the error code is a bit of a mess: most often, Engine
does
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Refactoring reportError func
..
Patch Set 8:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8981/ : SUCCESS
Federico Simoncelli has posted comments on this change.
Change subject: LiveMerge: Add support for deleting merged volumes
..
Patch Set 7: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26768
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: Setting enum for isconfigured return value and change override
semantics
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/28473
To
Allon Mureinik has posted comments on this change.
Change subject: mount: Check if mount specification is a symlink
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/27321
To unsubscribe, visit
Dima Kuznetsov has posted comments on this change.
Change subject: Remove redundant print
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/28406
To unsubscribe, visit http://gerrit.ovirt.org/settings
oVirt Jenkins CI Server has posted comments on this change.
Change subject: jsonrpc: vsam-api removal
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8973/ : SUCCESS
Federico Simoncelli has posted comments on this change.
Change subject: Final separation of IOProcess and RFH
..
Patch Set 8: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/28088
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: jsonrpc: Json processing issues fixed
..
Patch Set 5:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8974/ : SUCCESS
1 - 100 of 185 matches
Mail list logo