Francesco Romani has posted comments on this change.
Change subject: utils: Add stopwatch for timing operations
..
Patch Set 1: Code-Review+1
Code is nice and simple. A few possible open points because I was rumbling
about
Francesco Romani has posted comments on this change.
Change subject: libvirt: Log time spent in libvirt calls
..
Patch Set 1: Code-Review+1
I did this (and not published) at domain level, but on second thought here it
is
Francesco Romani has posted comments on this change.
Change subject: schedule: Introduce scheduling libary
..
Patch Set 3:
At glance looks really nice code, probably deserves its own private package
(like zombiereaper). Will
Martin Polednik has posted comments on this change.
Change subject: virt: move XML processing in a module
..
Patch Set 3: Code-Review+1
I'd say the name itself sounds better, I'm only afraid not to start naming
everything vm*
Yaniv Bronhaim has posted comments on this change.
Change subject: hsm: deleteImage - lock image by imgUUID and sdUUID
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/29656
To unsubscribe, visit
Francesco Romani has uploaded a new change for review.
Change subject: vm: replace minidom.Element for memory snapshots
..
vm: replace minidom.Element for memory snapshots
The _memorySnapshot method used to manipulate directly
Francesco Romani has uploaded a new change for review.
Change subject: virt: move _DomXML into the xml module
..
virt: move _DomXML into the xml module
Move virt.vm._DomXML into virt.vmxml.Domain
Fix paths and imports (e.g.
Francesco Romani has uploaded a new change for review.
Change subject: virt: move __hacked_writexml in the vmxml module
..
virt: move __hacked_writexml in the vmxml module
No reason to keep this hack under the spotlight,
and
Francesco Romani has uploaded a new change for review.
Change subject: vm: use vmxml.Element in setLinkAndNetwork
..
vm: use vmxml.Element in setLinkAndNetwork
Use vmxml.Element instead of xml.dom.minidom.Element
in
Francesco Romani has uploaded a new change for review.
Change subject: vm: use vmxml.Element in snapshot method
..
vm: use vmxml.Element in snapshot method
Use vmxml.Element instead of xml.dom.minidom.Element
in vm.snapshot
No
Francesco Romani has posted comments on this change.
Change subject: virt: introduce a XML processing module
..
Patch Set 4:
split into a patchset to make review easier and faster and to not needlessly
block the QoS patchset
Michal Skrivanek has posted comments on this change.
Change subject: utils: Add stopwatch for timing operations
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/29685/1//COMMIT_MSG
Commit Message:
Line 14: Will log
Martin Sivák has posted comments on this change.
Change subject: Add soft dependency on libvirt's metadata support to stats
collector
..
Patch Set 8:
(3 comments)
http://gerrit.ovirt.org/#/c/29504/8/vdsm/virt/vm.py
File
Martin Sivák has posted comments on this change.
Change subject: Refactor updateVmPolicy to use DOM manipulation
..
Patch Set 14: Verified+1
Commit message added...
--
To view, visit http://gerrit.ovirt.org/28895
To
Michal Skrivanek has posted comments on this change.
Change subject: libvirt: Log time spent in libvirt calls
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/29686/1/lib/vdsm/libvirtconnection.py
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: hsm: deleteImage - lock image by imgUUID and sdUUID
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms_merged/16/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: introduce a XML processing module
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10039/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: move __hacked_writexml in the vmxml module
..
Patch Set 1:
Build Successful
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add setIoTune and getIoTunePolicy to the xml-rpc API
..
Patch Set 14:
Build Successful
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: replace minidom.Element for memory snapshots
..
Patch Set 1:
Build Successful
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: xml: add function to iterate over devices
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10044/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix the return value definition of updateVmPolicy
..
Patch Set 10:
Build Successful
Federico Simoncelli has posted comments on this change.
Change subject: utils: Add stopwatch for timing operations
..
Patch Set 1: Code-Review-1
This seems redundant since we already have the profiling support now.
I don't
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: use vmxml.Element in setLinkAndNetwork
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10042/ :
Dan Kenigsberg has posted comments on this change.
Change subject: netinfo: replace the last dependency on ethtool with netlink
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/29601
To unsubscribe,
Dan Kenigsberg has submitted this change and it was merged.
Change subject: netinfo: replace the last dependency on ethtool with netlink
..
netinfo: replace the last dependency on ethtool with netlink
After the last work on
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: use vmxml.Element in snapshot method
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10043/ :
mooli tayer has posted comments on this change.
Change subject: configurator.py: fix _removeFile to do as described in it's doc
string.
..
Patch Set 9: Verified+1
--
To view, visit http://gerrit.ovirt.org/28782
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netinfo: replace the last dependency on ethtool with netlink
..
Patch Set 4:
Build Successful
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: move _DomXML into the xml module
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10045/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Refactor updateVmPolicy to use DOM manipulation
..
Patch Set 14:
Build Successful
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Refactor XMLElement to virt.utils
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10048/ : SUCCESS
Dan Kenigsberg has posted comments on this change.
Change subject: configurator.py: call Node's delete() for file deletion on node.
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/28821
To unsubscribe,
Nir Soffer has posted comments on this change.
Change subject: init: Normalize shutdown timeout
..
Patch Set 1: Verified+1
Tested with engine 3.5 from test day.
--
To view, visit http://gerrit.ovirt.org/29674
To unsubscribe,
Nir Soffer has posted comments on this change.
Change subject: profiling: Add an application wide profile
..
Patch Set 1: Verified+1
Tested with engine 3.5 from test day on top of the other profiling patches.
--
To view,
Nir Soffer has posted comments on this change.
Change subject: clientIF: Clean up shutdown process
..
Patch Set 1: Verified+1
Tested with engine 3.5 from test day on top of the other profiling patches.
--
To view, visit
mooli tayer has posted comments on this change.
Change subject: configurator.py: call Node's delete() for file deletion on node.
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/28821
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add soft dependency on libvirt's metadata support to stats
collector
..
Patch Set 9:
Build Successful
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add API.VM.getIoTunePolicy
..
Patch Set 18:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10051/ : SUCCESS
mooli tayer has posted comments on this change.
Change subject: configurator.py: call Node's delete() for file deletion on node.
..
Patch Set 3: Verified-1
Manual testing needed
--
To view, visit
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: init: Normalize shutdown timeout
..
init: Normalize shutdown timeout
On sysvinit, vdsm was killed 2 seconds after receiving a SIGTERM.
Currently
Yaniv Bronhaim has posted comments on this change.
Change subject: profiling: Add an application wide profile
..
Patch Set 1: Code-Review+2 Verified+1
--
To view, visit http://gerrit.ovirt.org/29676
To unsubscribe, visit
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: clientIF: Clean up shutdown process
..
clientIF: Clean up shutdown process
clientIF.serve used to check if shutdown process has started once every
3
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: profiling: Add an application wide profile
..
profiling: Add an application wide profile
The built in Python profilers are good for single thread
Yaniv Bronhaim has posted comments on this change.
Change subject: clientIF: Clean up shutdown process
..
Patch Set 1: Code-Review+2 Verified+1
--
To view, visit http://gerrit.ovirt.org/29675
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: models: Reorder bonding options so the mode is applied first
..
Patch Set 4:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: init: Normalize shutdown timeout
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_3.4_create-rpms_merged/239/ : FAILURE
--
To view,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: clientIF: Clean up shutdown process
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_3.4_create-rpms_merged/240/ : FAILURE
--
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add IO tunables support to updateVmPolicy
..
Patch Set 21:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10052/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: profiling: Add an application wide profile
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_3.4_install_rpm_sanity_gerrit/43/ :
Dan Kenigsberg has posted comments on this change.
Change subject: tests: add simple balloon functional testcase
..
Patch Set 7: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/12820/7/tests/functional/virtTests.py
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add API.VM.setIoTune
..
Patch Set 20:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10053/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: Shuting down protocol detector fails
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10055/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: models: Reorder bonding options so the mode is applied first
..
Patch Set 5:
Build Successful
oVirt Jenkins CI Server has posted comments on this change.
Change subject: jsonrpc: Accept all stomp commands
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10057/ : SUCCESS
Antoni Segura Puimedon has posted comments on this change.
Change subject: eliminate sampling.BaseSample
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/29687
To unsubscribe, visit
Antoni Segura Puimedon has posted comments on this change.
Change subject: HostStats: recalculate total line rate every time
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/29688
To unsubscribe, visit
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: Adding requirement for cyrus-sasl-lib and modify the default
path
..
Adding requirement for cyrus-sasl-lib and modify the default path
Change-Id:
Antoni Segura Puimedon has posted comments on this change.
Change subject: introduce connectivity log
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/29690
To unsubscribe, visit
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: ifcfg: make default route network be started by sysV
..
ifcfg: make default route network be started by sysV
With the change to unified persistence,
Antoni Segura Puimedon has posted comments on this change.
Change subject: ifcfg: make default route network be started by sysV
..
Patch Set 1: Verified+1
Copying score as it was verified in http://gerrit.ovirt.org/#/c/29312/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: ifcfg: make default route network be started by sysV
..
Patch Set 1:
Build Failed
Nir Soffer has posted comments on this change.
Change subject: libvirt: Log time spent in libvirt calls
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/29686/1/lib/vdsm/libvirtconnection.py
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: lastclient info in jsonrpc
..
Patch Set 15:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10058/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Adding requirement for cyrus-sasl-lib and modify the default
path
..
Patch Set 2:
Build Failed
Yaniv Bronhaim has posted comments on this change.
Change subject: utils: Remove unused code
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/29534
To unsubscribe, visit http://gerrit.ovirt.org/settings
oVirt Jenkins CI Server has posted comments on this change.
Change subject: net: skip network restoration if its physical devs are missing
..
Patch Set 3:
Build Failed
Nir Soffer has posted comments on this change.
Change subject: utils: Add stopwatch for timing operations
..
Patch Set 1:
Federico, we can get the same information from a profile with hard work:
- Build and install yappi
-
Nir Soffer has posted comments on this change.
Change subject: vdsm: lastclient info in jsonrpc
..
Patch Set 15:
(1 comment)
http://gerrit.ovirt.org/#/c/28817/15/lib/yajsonrpc/__init__.py
File lib/yajsonrpc/__init__.py:
Line
Adam Litke has posted comments on this change.
Change subject: Live Merge: fix race between libvirt event and vm stats
..
Patch Set 2: -Verified
(6 comments)
http://gerrit.ovirt.org/#/c/29309/2/vdsm/virt/vm.py
File
Adam Litke has posted comments on this change.
Change subject: Live Merge: support active layer commit
..
Patch Set 6: -Verified
(3 comments)
http://gerrit.ovirt.org/#/c/28598/6//COMMIT_MSG
Commit Message:
Line 13: snapshot.
Dan Kenigsberg has posted comments on this change.
Change subject: utils: Remove unused code
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/29534
To unsubscribe, visit http://gerrit.ovirt.org/settings
Dan Kenigsberg has submitted this change and it was merged.
Change subject: utils: Remove unused code
..
utils: Remove unused code
Change-Id: Ied92a81bcf9d932e2942e0cb341248eacae61b50
Signed-off-by: Nir Soffer
oVirt Jenkins CI Server has posted comments on this change.
Change subject: utils: Remove unused code
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1589/ : SUCCESS
Nir Soffer has posted comments on this change.
Change subject: jsonrpc: Accept all stomp commands
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/29652
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: vdsm: Shuting down protocol detector fails
..
Patch Set 4:
(5 comments)
http://gerrit.ovirt.org/#/c/29556/4//COMMIT_MSG
Commit Message:
Line 7: vdsm: Shuting
Saggi Mizrahi has posted comments on this change.
Change subject: schedule: Introduce scheduling libary
..
Patch Set 3: Code-Review-1
(13 comments)
I also prefer using_underscores but mixedCase is how things are in VDSM.
Saggi Mizrahi has posted comments on this change.
Change subject: fix error handling in isdir and islink
..
Patch Set 1: Code-Review-1
(2 comments)
http://gerrit.ovirt.org/#/c/29633/1/vdsm/storage/outOfProcess.py
File
Saggi Mizrahi has posted comments on this change.
Change subject: oop: add missing utils.forceLink
..
Patch Set 3: Code-Review-1
(2 comments)
http://gerrit.ovirt.org/#/c/29634/3/vdsm/storage/outOfProcess.py
File
Saggi Mizrahi has posted comments on this change.
Change subject: utils: re-implement rotateFiles()
..
Patch Set 1:
(2 comments)
http://gerrit.ovirt.org/#/c/28464/1/lib/vdsm/tool/configurator.py
File
Adam Litke has posted comments on this change.
Change subject: Live Merge: support active layer commit
..
Patch Set 6:
(1 comment)
http://gerrit.ovirt.org/#/c/28598/6//COMMIT_MSG
Commit Message:
Line 13: snapshot. Once the
Dan Kenigsberg has posted comments on this change.
Change subject: models: Reorder bonding options so the mode is applied first
..
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/27572
To unsubscribe,
Michal Skrivanek has posted comments on this change.
Change subject: utils: Add stopwatch for timing operations
..
Patch Set 1: Code-Review-1
After further talks with Toni my concern only increased..
libvirt does log/stamp
Francesco Romani has posted comments on this change.
Change subject: utils: Add stopwatch for timing operations
..
Patch Set 1:
I see Federico's point. There is some overlap with more general yappi profiling
support, this is
Saggi Mizrahi has posted comments on this change.
Change subject: utils: Add stopwatch for timing operations
..
Patch Set 1: Code-Review-1
seems like a testing only feature
should be in testrunner or a new testUtils
--
To
Antoni Segura Puimedon has posted comments on this change.
Change subject: models: Reorder bonding options so the mode is applied first
..
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/27572
To
Dan Kenigsberg has posted comments on this change.
Change subject: models: Reorder bonding options so the mode is applied first
..
Patch Set 6:
11:32:04 Ran 97 tests in 785.706s
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: models: Reorder bonding options so the mode is applied first
..
Patch Set 6:
Build Successful
Dan Kenigsberg has submitted this change and it was merged.
Change subject: models: Reorder bonding options so the mode is applied first
..
models: Reorder bonding options so the mode is applied first
The option lacp_rate, for
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: disable virtio-rng on rhel 7.1
..
Patch Set 4: Code-Review-1
I'd drop QEMU requirement as it is supported in QEMU since EL 6.4 (which I
believe we
Saggi Mizrahi has posted comments on this change.
Change subject: vdsm: Shuting down protocol detector fails
..
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/29556/4/vdsm/protocoldetector.py
File
Saggi Mizrahi has posted comments on this change.
Change subject: jsonrpc: Accept all stomp commands
..
Patch Set 3: Code-Review-1
I still don't understand why this is not handled in the client side.
Sending a CONNECT frame is
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: disable virtio-rng on rhel 7.1
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10062/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: disable virtio-rng on rhel 7.1
..
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10063/ :
Dan Kenigsberg has posted comments on this change.
Change subject: jsonrpc: Accept all stomp commands
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/29652/3/lib/yajsonrpc/stompReactor.py
File
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: disable virtio-rng on rhel 7.1
..
Patch Set 5: Code-Review-1
copying Michal's score to ps5.
--
To view, visit http://gerrit.ovirt.org/28838
To
Nir Soffer has posted comments on this change.
Change subject: jsonrpc: Accept all stomp commands
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/29652/3/lib/yajsonrpc/stompReactor.py
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm: lastclient info in jsonrpc
..
Patch Set 16:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10061/ : SUCCESS
Nir Soffer has posted comments on this change.
Change subject: vdsm: lastclient info in jsonrpc
..
Patch Set 16: Code-Review-1
You get the active nic on for every request, but we need it only for one
request - this seems
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: add simple balloon functional testcase
..
Patch Set 8:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10065/ :
1 - 100 of 128 matches
Mail list logo