Change in vdsm[master]: utils: Add stopwatch for timing operations

2014-07-08 Thread fromani
Francesco Romani has posted comments on this change. Change subject: utils: Add stopwatch for timing operations .. Patch Set 1: Code-Review+1 Code is nice and simple. A few possible open points because I was rumbling about

Change in vdsm[master]: libvirt: Log time spent in libvirt calls

2014-07-08 Thread fromani
Francesco Romani has posted comments on this change. Change subject: libvirt: Log time spent in libvirt calls .. Patch Set 1: Code-Review+1 I did this (and not published) at domain level, but on second thought here it is

Change in vdsm[master]: schedule: Introduce scheduling libary

2014-07-08 Thread fromani
Francesco Romani has posted comments on this change. Change subject: schedule: Introduce scheduling libary .. Patch Set 3: At glance looks really nice code, probably deserves its own private package (like zombiereaper). Will

Change in vdsm[master]: virt: move XML processing in a module

2014-07-08 Thread mpoledni
Martin Polednik has posted comments on this change. Change subject: virt: move XML processing in a module .. Patch Set 3: Code-Review+1 I'd say the name itself sounds better, I'm only afraid not to start naming everything vm*

Change in vdsm[ovirt-3.5]: hsm: deleteImage - lock image by imgUUID and sdUUID

2014-07-08 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: hsm: deleteImage - lock image by imgUUID and sdUUID .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/29656 To unsubscribe, visit

Change in vdsm[master]: vm: replace minidom.Element for memory snapshots

2014-07-08 Thread fromani
Francesco Romani has uploaded a new change for review. Change subject: vm: replace minidom.Element for memory snapshots .. vm: replace minidom.Element for memory snapshots The _memorySnapshot method used to manipulate directly

Change in vdsm[master]: virt: move _DomXML into the xml module

2014-07-08 Thread fromani
Francesco Romani has uploaded a new change for review. Change subject: virt: move _DomXML into the xml module .. virt: move _DomXML into the xml module Move virt.vm._DomXML into virt.vmxml.Domain Fix paths and imports (e.g.

Change in vdsm[master]: virt: move __hacked_writexml in the vmxml module

2014-07-08 Thread fromani
Francesco Romani has uploaded a new change for review. Change subject: virt: move __hacked_writexml in the vmxml module .. virt: move __hacked_writexml in the vmxml module No reason to keep this hack under the spotlight, and

Change in vdsm[master]: vm: use vmxml.Element in setLinkAndNetwork

2014-07-08 Thread fromani
Francesco Romani has uploaded a new change for review. Change subject: vm: use vmxml.Element in setLinkAndNetwork .. vm: use vmxml.Element in setLinkAndNetwork Use vmxml.Element instead of xml.dom.minidom.Element in

Change in vdsm[master]: vm: use vmxml.Element in snapshot method

2014-07-08 Thread fromani
Francesco Romani has uploaded a new change for review. Change subject: vm: use vmxml.Element in snapshot method .. vm: use vmxml.Element in snapshot method Use vmxml.Element instead of xml.dom.minidom.Element in vm.snapshot No

Change in vdsm[master]: virt: introduce a XML processing module

2014-07-08 Thread fromani
Francesco Romani has posted comments on this change. Change subject: virt: introduce a XML processing module .. Patch Set 4: split into a patchset to make review easier and faster and to not needlessly block the QoS patchset

Change in vdsm[master]: utils: Add stopwatch for timing operations

2014-07-08 Thread michal . skrivanek
Michal Skrivanek has posted comments on this change. Change subject: utils: Add stopwatch for timing operations .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/29685/1//COMMIT_MSG Commit Message: Line 14: Will log

Change in vdsm[master]: Add soft dependency on libvirt's metadata support to stats c...

2014-07-08 Thread msivak
Martin Sivák has posted comments on this change. Change subject: Add soft dependency on libvirt's metadata support to stats collector .. Patch Set 8: (3 comments) http://gerrit.ovirt.org/#/c/29504/8/vdsm/virt/vm.py File

Change in vdsm[master]: Refactor updateVmPolicy to use DOM manipulation

2014-07-08 Thread msivak
Martin Sivák has posted comments on this change. Change subject: Refactor updateVmPolicy to use DOM manipulation .. Patch Set 14: Verified+1 Commit message added... -- To view, visit http://gerrit.ovirt.org/28895 To

Change in vdsm[master]: libvirt: Log time spent in libvirt calls

2014-07-08 Thread michal . skrivanek
Michal Skrivanek has posted comments on this change. Change subject: libvirt: Log time spent in libvirt calls .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/29686/1/lib/vdsm/libvirtconnection.py File

Change in vdsm[ovirt-3.5]: hsm: deleteImage - lock image by imgUUID and sdUUID

2014-07-08 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: hsm: deleteImage - lock image by imgUUID and sdUUID .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms_merged/16/ :

Change in vdsm[master]: virt: introduce a XML processing module

2014-07-08 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: introduce a XML processing module .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10039/ : SUCCESS

Change in vdsm[master]: virt: move __hacked_writexml in the vmxml module

2014-07-08 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: move __hacked_writexml in the vmxml module .. Patch Set 1: Build Successful

Change in vdsm[master]: Add setIoTune and getIoTunePolicy to the xml-rpc API

2014-07-08 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Add setIoTune and getIoTunePolicy to the xml-rpc API .. Patch Set 14: Build Successful

Change in vdsm[master]: vm: replace minidom.Element for memory snapshots

2014-07-08 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: replace minidom.Element for memory snapshots .. Patch Set 1: Build Successful

Change in vdsm[master]: virt: xml: add function to iterate over devices

2014-07-08 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: xml: add function to iterate over devices .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10044/ :

Change in vdsm[master]: Fix the return value definition of updateVmPolicy

2014-07-08 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Fix the return value definition of updateVmPolicy .. Patch Set 10: Build Successful

Change in vdsm[master]: utils: Add stopwatch for timing operations

2014-07-08 Thread Federico Simoncelli
Federico Simoncelli has posted comments on this change. Change subject: utils: Add stopwatch for timing operations .. Patch Set 1: Code-Review-1 This seems redundant since we already have the profiling support now. I don't

Change in vdsm[master]: vm: use vmxml.Element in setLinkAndNetwork

2014-07-08 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: use vmxml.Element in setLinkAndNetwork .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10042/ :

Change in vdsm[master]: netinfo: replace the last dependency on ethtool with netlink

2014-07-08 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: netinfo: replace the last dependency on ethtool with netlink .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/29601 To unsubscribe,

Change in vdsm[master]: netinfo: replace the last dependency on ethtool with netlink

2014-07-08 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: netinfo: replace the last dependency on ethtool with netlink .. netinfo: replace the last dependency on ethtool with netlink After the last work on

Change in vdsm[master]: vm: use vmxml.Element in snapshot method

2014-07-08 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: use vmxml.Element in snapshot method .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10043/ :

Change in vdsm[master]: configurator.py: fix _removeFile to do as described in it's ...

2014-07-08 Thread mtayer
mooli tayer has posted comments on this change. Change subject: configurator.py: fix _removeFile to do as described in it's doc string. .. Patch Set 9: Verified+1 -- To view, visit http://gerrit.ovirt.org/28782 To

Change in vdsm[master]: netinfo: replace the last dependency on ethtool with netlink

2014-07-08 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: replace the last dependency on ethtool with netlink .. Patch Set 4: Build Successful

Change in vdsm[master]: virt: move _DomXML into the xml module

2014-07-08 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: move _DomXML into the xml module .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10045/ :

Change in vdsm[master]: Refactor updateVmPolicy to use DOM manipulation

2014-07-08 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Refactor updateVmPolicy to use DOM manipulation .. Patch Set 14: Build Successful

Change in vdsm[master]: Refactor XMLElement to virt.utils

2014-07-08 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Refactor XMLElement to virt.utils .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10048/ : SUCCESS

Change in vdsm[master]: configurator.py: call Node's delete() for file deletion on n...

2014-07-08 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: configurator.py: call Node's delete() for file deletion on node. .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/28821 To unsubscribe,

Change in vdsm[ovirt-3.4]: init: Normalize shutdown timeout

2014-07-08 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: init: Normalize shutdown timeout .. Patch Set 1: Verified+1 Tested with engine 3.5 from test day. -- To view, visit http://gerrit.ovirt.org/29674 To unsubscribe,

Change in vdsm[ovirt-3.4]: profiling: Add an application wide profile

2014-07-08 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: profiling: Add an application wide profile .. Patch Set 1: Verified+1 Tested with engine 3.5 from test day on top of the other profiling patches. -- To view,

Change in vdsm[ovirt-3.4]: clientIF: Clean up shutdown process

2014-07-08 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: clientIF: Clean up shutdown process .. Patch Set 1: Verified+1 Tested with engine 3.5 from test day on top of the other profiling patches. -- To view, visit

Change in vdsm[master]: configurator.py: call Node's delete() for file deletion on n...

2014-07-08 Thread mtayer
mooli tayer has posted comments on this change. Change subject: configurator.py: call Node's delete() for file deletion on node. .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.ovirt.org/28821 To unsubscribe, visit

Change in vdsm[master]: Add soft dependency on libvirt's metadata support to stats c...

2014-07-08 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Add soft dependency on libvirt's metadata support to stats collector .. Patch Set 9: Build Successful

Change in vdsm[master]: Add API.VM.getIoTunePolicy

2014-07-08 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Add API.VM.getIoTunePolicy .. Patch Set 18: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10051/ : SUCCESS

Change in vdsm[master]: configurator.py: call Node's delete() for file deletion on n...

2014-07-08 Thread mtayer
mooli tayer has posted comments on this change. Change subject: configurator.py: call Node's delete() for file deletion on node. .. Patch Set 3: Verified-1 Manual testing needed -- To view, visit

Change in vdsm[ovirt-3.4]: init: Normalize shutdown timeout

2014-07-08 Thread ybronhei
Yaniv Bronhaim has submitted this change and it was merged. Change subject: init: Normalize shutdown timeout .. init: Normalize shutdown timeout On sysvinit, vdsm was killed 2 seconds after receiving a SIGTERM. Currently

Change in vdsm[ovirt-3.4]: profiling: Add an application wide profile

2014-07-08 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: profiling: Add an application wide profile .. Patch Set 1: Code-Review+2 Verified+1 -- To view, visit http://gerrit.ovirt.org/29676 To unsubscribe, visit

Change in vdsm[ovirt-3.4]: clientIF: Clean up shutdown process

2014-07-08 Thread ybronhei
Yaniv Bronhaim has submitted this change and it was merged. Change subject: clientIF: Clean up shutdown process .. clientIF: Clean up shutdown process clientIF.serve used to check if shutdown process has started once every 3

Change in vdsm[ovirt-3.4]: profiling: Add an application wide profile

2014-07-08 Thread ybronhei
Yaniv Bronhaim has submitted this change and it was merged. Change subject: profiling: Add an application wide profile .. profiling: Add an application wide profile The built in Python profilers are good for single thread

Change in vdsm[ovirt-3.4]: clientIF: Clean up shutdown process

2014-07-08 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: clientIF: Clean up shutdown process .. Patch Set 1: Code-Review+2 Verified+1 -- To view, visit http://gerrit.ovirt.org/29675 To unsubscribe, visit

Change in vdsm[master]: models: Reorder bonding options so the mode is applied first

2014-07-08 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: models: Reorder bonding options so the mode is applied first .. Patch Set 4: Build Failed

Change in vdsm[ovirt-3.4]: init: Normalize shutdown timeout

2014-07-08 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: init: Normalize shutdown timeout .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_3.4_create-rpms_merged/239/ : FAILURE -- To view,

Change in vdsm[ovirt-3.4]: clientIF: Clean up shutdown process

2014-07-08 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: clientIF: Clean up shutdown process .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_3.4_create-rpms_merged/240/ : FAILURE -- To

Change in vdsm[master]: Add IO tunables support to updateVmPolicy

2014-07-08 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Add IO tunables support to updateVmPolicy .. Patch Set 21: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10052/ :

Change in vdsm[ovirt-3.4]: profiling: Add an application wide profile

2014-07-08 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: profiling: Add an application wide profile .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_3.4_install_rpm_sanity_gerrit/43/ :

Change in vdsm[master]: tests: add simple balloon functional testcase

2014-07-08 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: tests: add simple balloon functional testcase .. Patch Set 7: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/12820/7/tests/functional/virtTests.py File

Change in vdsm[master]: Add API.VM.setIoTune

2014-07-08 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Add API.VM.setIoTune .. Patch Set 20: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10053/ : SUCCESS

Change in vdsm[master]: vdsm: Shuting down protocol detector fails

2014-07-08 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: Shuting down protocol detector fails .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10055/ :

Change in vdsm[master]: models: Reorder bonding options so the mode is applied first

2014-07-08 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: models: Reorder bonding options so the mode is applied first .. Patch Set 5: Build Successful

Change in vdsm[master]: jsonrpc: Accept all stomp commands

2014-07-08 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpc: Accept all stomp commands .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10057/ : SUCCESS

Change in vdsm[ovirt-3.4]: eliminate sampling.BaseSample

2014-07-08 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: eliminate sampling.BaseSample .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/29687 To unsubscribe, visit

Change in vdsm[ovirt-3.4]: HostStats: recalculate total line rate every time

2014-07-08 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: HostStats: recalculate total line rate every time .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/29688 To unsubscribe, visit

Change in vdsm[ovirt-3.5]: Adding requirement for cyrus-sasl-lib and modify the default...

2014-07-08 Thread ybronhei
Yaniv Bronhaim has submitted this change and it was merged. Change subject: Adding requirement for cyrus-sasl-lib and modify the default path .. Adding requirement for cyrus-sasl-lib and modify the default path Change-Id:

Change in vdsm[ovirt-3.4]: introduce connectivity log

2014-07-08 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: introduce connectivity log .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/29690 To unsubscribe, visit

Change in vdsm[master]: ifcfg: make default route network be started by sysV

2014-07-08 Thread asegurap
Antoni Segura Puimedon has uploaded a new change for review. Change subject: ifcfg: make default route network be started by sysV .. ifcfg: make default route network be started by sysV With the change to unified persistence,

Change in vdsm[master]: ifcfg: make default route network be started by sysV

2014-07-08 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: ifcfg: make default route network be started by sysV .. Patch Set 1: Verified+1 Copying score as it was verified in http://gerrit.ovirt.org/#/c/29312/

Change in vdsm[master]: ifcfg: make default route network be started by sysV

2014-07-08 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: ifcfg: make default route network be started by sysV .. Patch Set 1: Build Failed

Change in vdsm[master]: libvirt: Log time spent in libvirt calls

2014-07-08 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: libvirt: Log time spent in libvirt calls .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/29686/1/lib/vdsm/libvirtconnection.py File

Change in vdsm[master]: vdsm: lastclient info in jsonrpc

2014-07-08 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: lastclient info in jsonrpc .. Patch Set 15: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10058/ : SUCCESS

Change in vdsm[ovirt-3.5]: Adding requirement for cyrus-sasl-lib and modify the default...

2014-07-08 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding requirement for cyrus-sasl-lib and modify the default path .. Patch Set 2: Build Failed

Change in vdsm[master]: utils: Remove unused code

2014-07-08 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: utils: Remove unused code .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/29534 To unsubscribe, visit http://gerrit.ovirt.org/settings

Change in vdsm[master]: net: skip network restoration if its physical devs are missing

2014-07-08 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: net: skip network restoration if its physical devs are missing .. Patch Set 3: Build Failed

Change in vdsm[master]: utils: Add stopwatch for timing operations

2014-07-08 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: utils: Add stopwatch for timing operations .. Patch Set 1: Federico, we can get the same information from a profile with hard work: - Build and install yappi -

Change in vdsm[master]: vdsm: lastclient info in jsonrpc

2014-07-08 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: vdsm: lastclient info in jsonrpc .. Patch Set 15: (1 comment) http://gerrit.ovirt.org/#/c/28817/15/lib/yajsonrpc/__init__.py File lib/yajsonrpc/__init__.py: Line

Change in vdsm[master]: Live Merge: fix race between libvirt event and vm stats

2014-07-08 Thread alitke
Adam Litke has posted comments on this change. Change subject: Live Merge: fix race between libvirt event and vm stats .. Patch Set 2: -Verified (6 comments) http://gerrit.ovirt.org/#/c/29309/2/vdsm/virt/vm.py File

Change in vdsm[master]: Live Merge: support active layer commit

2014-07-08 Thread alitke
Adam Litke has posted comments on this change. Change subject: Live Merge: support active layer commit .. Patch Set 6: -Verified (3 comments) http://gerrit.ovirt.org/#/c/28598/6//COMMIT_MSG Commit Message: Line 13: snapshot.

Change in vdsm[master]: utils: Remove unused code

2014-07-08 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: utils: Remove unused code .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/29534 To unsubscribe, visit http://gerrit.ovirt.org/settings

Change in vdsm[master]: utils: Remove unused code

2014-07-08 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: utils: Remove unused code .. utils: Remove unused code Change-Id: Ied92a81bcf9d932e2942e0cb341248eacae61b50 Signed-off-by: Nir Soffer

Change in vdsm[master]: utils: Remove unused code

2014-07-08 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: utils: Remove unused code .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged/1589/ : SUCCESS

Change in vdsm[master]: jsonrpc: Accept all stomp commands

2014-07-08 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: jsonrpc: Accept all stomp commands .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/29652 To unsubscribe, visit

Change in vdsm[master]: vdsm: Shuting down protocol detector fails

2014-07-08 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: vdsm: Shuting down protocol detector fails .. Patch Set 4: (5 comments) http://gerrit.ovirt.org/#/c/29556/4//COMMIT_MSG Commit Message: Line 7: vdsm: Shuting

Change in vdsm[master]: schedule: Introduce scheduling libary

2014-07-08 Thread smizrahi
Saggi Mizrahi has posted comments on this change. Change subject: schedule: Introduce scheduling libary .. Patch Set 3: Code-Review-1 (13 comments) I also prefer using_underscores but mixedCase is how things are in VDSM.

Change in vdsm[master]: fix error handling in isdir and islink

2014-07-08 Thread smizrahi
Saggi Mizrahi has posted comments on this change. Change subject: fix error handling in isdir and islink .. Patch Set 1: Code-Review-1 (2 comments) http://gerrit.ovirt.org/#/c/29633/1/vdsm/storage/outOfProcess.py File

Change in vdsm[master]: oop: add missing utils.forceLink

2014-07-08 Thread smizrahi
Saggi Mizrahi has posted comments on this change. Change subject: oop: add missing utils.forceLink .. Patch Set 3: Code-Review-1 (2 comments) http://gerrit.ovirt.org/#/c/29634/3/vdsm/storage/outOfProcess.py File

Change in vdsm[master]: utils: re-implement rotateFiles()

2014-07-08 Thread smizrahi
Saggi Mizrahi has posted comments on this change. Change subject: utils: re-implement rotateFiles() .. Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/28464/1/lib/vdsm/tool/configurator.py File

Change in vdsm[master]: Live Merge: support active layer commit

2014-07-08 Thread alitke
Adam Litke has posted comments on this change. Change subject: Live Merge: support active layer commit .. Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/28598/6//COMMIT_MSG Commit Message: Line 13: snapshot. Once the

Change in vdsm[master]: models: Reorder bonding options so the mode is applied first

2014-07-08 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: models: Reorder bonding options so the mode is applied first .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/27572 To unsubscribe,

Change in vdsm[master]: utils: Add stopwatch for timing operations

2014-07-08 Thread michal . skrivanek
Michal Skrivanek has posted comments on this change. Change subject: utils: Add stopwatch for timing operations .. Patch Set 1: Code-Review-1 After further talks with Toni my concern only increased.. libvirt does log/stamp

Change in vdsm[master]: utils: Add stopwatch for timing operations

2014-07-08 Thread fromani
Francesco Romani has posted comments on this change. Change subject: utils: Add stopwatch for timing operations .. Patch Set 1: I see Federico's point. There is some overlap with more general yappi profiling support, this is

Change in vdsm[master]: utils: Add stopwatch for timing operations

2014-07-08 Thread smizrahi
Saggi Mizrahi has posted comments on this change. Change subject: utils: Add stopwatch for timing operations .. Patch Set 1: Code-Review-1 seems like a testing only feature should be in testrunner or a new testUtils -- To

Change in vdsm[master]: models: Reorder bonding options so the mode is applied first

2014-07-08 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: models: Reorder bonding options so the mode is applied first .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/27572 To

Change in vdsm[master]: models: Reorder bonding options so the mode is applied first

2014-07-08 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: models: Reorder bonding options so the mode is applied first .. Patch Set 6: 11:32:04 Ran 97 tests in 785.706s -- To view, visit

Change in vdsm[master]: models: Reorder bonding options so the mode is applied first

2014-07-08 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: models: Reorder bonding options so the mode is applied first .. Patch Set 6: Build Successful

Change in vdsm[master]: models: Reorder bonding options so the mode is applied first

2014-07-08 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: models: Reorder bonding options so the mode is applied first .. models: Reorder bonding options so the mode is applied first The option lacp_rate, for

Change in vdsm[master]: vdsm: disable virtio-rng on rhel 7.1

2014-07-08 Thread michal . skrivanek
Michal Skrivanek has posted comments on this change. Change subject: vdsm: disable virtio-rng on rhel 7.1 .. Patch Set 4: Code-Review-1 I'd drop QEMU requirement as it is supported in QEMU since EL 6.4 (which I believe we

Change in vdsm[master]: vdsm: Shuting down protocol detector fails

2014-07-08 Thread smizrahi
Saggi Mizrahi has posted comments on this change. Change subject: vdsm: Shuting down protocol detector fails .. Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/29556/4/vdsm/protocoldetector.py File

Change in vdsm[master]: jsonrpc: Accept all stomp commands

2014-07-08 Thread smizrahi
Saggi Mizrahi has posted comments on this change. Change subject: jsonrpc: Accept all stomp commands .. Patch Set 3: Code-Review-1 I still don't understand why this is not handled in the client side. Sending a CONNECT frame is

Change in vdsm[master]: vdsm: disable virtio-rng on rhel 7.1

2014-07-08 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: disable virtio-rng on rhel 7.1 .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10062/ :

Change in vdsm[master]: vdsm: disable virtio-rng on rhel 7.1

2014-07-08 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: disable virtio-rng on rhel 7.1 .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10063/ :

Change in vdsm[master]: jsonrpc: Accept all stomp commands

2014-07-08 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: jsonrpc: Accept all stomp commands .. Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/29652/3/lib/yajsonrpc/stompReactor.py File

Change in vdsm[master]: vdsm: disable virtio-rng on rhel 7.1

2014-07-08 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vdsm: disable virtio-rng on rhel 7.1 .. Patch Set 5: Code-Review-1 copying Michal's score to ps5. -- To view, visit http://gerrit.ovirt.org/28838 To

Change in vdsm[master]: jsonrpc: Accept all stomp commands

2014-07-08 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: jsonrpc: Accept all stomp commands .. Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/29652/3/lib/yajsonrpc/stompReactor.py File

Change in vdsm[master]: vdsm: lastclient info in jsonrpc

2014-07-08 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: lastclient info in jsonrpc .. Patch Set 16: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10061/ : SUCCESS

Change in vdsm[master]: vdsm: lastclient info in jsonrpc

2014-07-08 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: vdsm: lastclient info in jsonrpc .. Patch Set 16: Code-Review-1 You get the active nic on for every request, but we need it only for one request - this seems

Change in vdsm[master]: tests: add simple balloon functional testcase

2014-07-08 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: add simple balloon functional testcase .. Patch Set 8: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/10065/ :

  1   2   >