oVirt Jenkins CI Server has posted comments on this change.
Change subject: mkimage: more robust content signature
..
Patch Set 2: Code-Review-1 Verified-1
Build Failed
Saggi Mizrahi has posted comments on this change.
Change subject: hba: Rescan using SCSI layer
..
Patch Set 2: Code-Review-1
This patch is going in a loop.
I admit I haven't been following the changes trusting that someone was
oVirt Jenkins CI Server has posted comments on this change.
Change subject: mkimage: more robust content signature
..
Patch Set 3: Code-Review-1 Verified-1
Build Failed
Francesco Romani has posted comments on this change.
Change subject: mkimage: more robust content signature
..
Patch Set 3:
Automation failure unrelated:
==
Francesco Romani has posted comments on this change.
Change subject: debug: Integrate manhole debugging service
..
Patch Set 6: Code-Review+1
Useful and helpful addition for debugging, seems harmless in other scenarios,
so
Francesco Romani has posted comments on this change.
Change subject: vdsm: fix typo: vcpuLimit - 'limit' was in lower-case
..
Patch Set 1:
this patch seems correct to me. However, the CPU QoS should have been covered
by unit
Francesco Romani has posted comments on this change.
Change subject: supervdsmServer: Do not use udev to set permissions on external
luns
..
Patch Set 1: Code-Review+1
seems same {code,change} as master, and seems OK to me.
Saggi Mizrahi has posted comments on this change.
Change subject: ioprocess: Have tests check ioprocess and not RFH
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/34083
To unsubscribe, visit
Saggi Mizrahi has posted comments on this change.
Change subject: core: Add python warnings boilerplate
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/34034
To unsubscribe, visit
Saggi Mizrahi has posted comments on this change.
Change subject: ioprocess: Move and reword rename() warning
..
Patch Set 4: Verified+1
--
To view, visit http://gerrit.ovirt.org/32194
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: mkimage: more robust content signature
..
Patch Set 4: Code-Review-1 Verified-1
Build Failed
Saggi Mizrahi has posted comments on this change.
Change subject: vdsm-infra: zombie-reaper refactor
..
Patch Set 6:
(1 comment)
http://gerrit.ovirt.org/#/c/31301/6/vdsm.spec.in
File vdsm.spec.in:
Line 320: %description
Dima Kuznetsov has posted comments on this change.
Change subject: vdsm-infra: zombie-reaper refactor
..
Patch Set 7: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/31301
To unsubscribe, visit
Dima Kuznetsov has posted comments on this change.
Change subject: supervdsm: Add zombiereaper to supervdsm
..
Patch Set 17:
sorry, encountered some very bad git trickery
--
To view, visit http://gerrit.ovirt.org/28915
To
Dima Kuznetsov has posted comments on this change.
Change subject: supervdsm: Add zombiereaper to supervdsm
..
Patch Set 17: -Verified Code-Review-1
--
To view, visit http://gerrit.ovirt.org/28915
To unsubscribe, visit
Dima Kuznetsov has posted comments on this change.
Change subject: signals: Handle signals to non-main threads
..
Patch Set 15: -Verified Code-Review-1
--
To view, visit http://gerrit.ovirt.org/29392
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: hba: Rescan using SCSI layer
..
Patch Set 2:
Saggi, how writing to sysfs can block? The driver suspend the caller until the
scan is complete?
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm-infra: zombie-reaper refactor
..
Patch Set 7:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13000/ : SUCCESS
Federico Simoncelli has posted comments on this change.
Change subject: hba: Rescan using SCSI layer
..
Patch Set 2:
We've already seen in the past that we need to send the requests in parallel.
What I suggested was to write
Nir Soffer has posted comments on this change.
Change subject: hba: Rescan using SCSI layer
..
Patch Set 2:
I'll check how isciadm is implementing this - from the trace it seems that it
is using O_NOBLOCK for writing to the
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: move sound device to vmdevices
..
Patch Set 6:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13001/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: move redir device to vmdevices.py
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13002/ : SUCCESS
Antoni Segura Puimedon has posted comments on this change.
Change subject: setupNetworks: doesn't remove broken nw from runningConfig
..
Patch Set 8:
(1 comment)
http://gerrit.ovirt.org/#/c/33995/8//COMMIT_MSG
Commit Message:
Martin Polednik has uploaded a new change for review.
Change subject: virt: move redir device to vmdevices.py
..
virt: move redir device to vmdevices.py
No real code changes
Change-Id: I0a5cb5140302b9b909750c7f5df4d257958bab3d
Nir Soffer has posted comments on this change.
Change subject: signals: Handle signals to non-main threads
..
Patch Set 15:
(4 comments)
Need to remove the return value of register.
Other than that, it can be simpler. This
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: move redir device to vmdevices.py
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13003/ : SUCCESS
Martin Polednik has uploaded a new change for review.
Change subject: virt: move console device to vmdevices.py
..
virt: move console device to vmdevices.py
No real code changes
Change-Id:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: move console device to vmdevices.py
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13005/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: move smartcard device to vmdevices.py
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13004/ :
Francesco Romani has posted comments on this change.
Change subject: mkimage: more robust content signature
..
Patch Set 5:
make pep 1.4.6 happy
--
To view, visit http://gerrit.ovirt.org/34203
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: mkimage: more robust content signature
..
Patch Set 5:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13006/ : SUCCESS
Dan Kenigsberg has posted comments on this change.
Change subject: tc tests: Fix icmp test frame to have payload
..
Patch Set 2: Code-Review+2
I still do not understand the issue, but it happens too often and troubles more
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tc tests: Fix icmp test frame to have payload
..
tc tests: Fix icmp test frame to have payload
In Ic6c5684ca8833807cf1dc05e9ccc4d97391c6168 I changed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tc tests: Fix icmp test frame to have payload
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4089/ :
Dan Kenigsberg has posted comments on this change.
Change subject: Sysctl to allow iSCSI multipath with multiple NICs in the same
subnet
..
Patch Set 17: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/31529
To
Dan Kenigsberg has submitted this change and it was merged.
Change subject: core: Add python warnings boilerplate
..
core: Add python warnings boilerplate
In order to use python's built-in warnings module there some things you
Dan Kenigsberg has posted comments on this change.
Change subject: core: Add python warnings boilerplate
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/34034
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: ioprocess: Move and reword rename() warning
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/32194
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: ioprocess: Move and reword rename() warning
..
ioprocess: Move and reword rename() warning
The warning was appearing even when people use the function
oVirt Jenkins CI Server has posted comments on this change.
Change subject: core: Add python warnings boilerplate
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4090/ : SUCCESS
Antoni Segura Puimedon has posted comments on this change.
Change subject: Sysctl to allow iSCSI multipath with multiple NICs in the same
subnet
..
Patch Set 17:
(1 comment)
Nir Soffer has posted comments on this change.
Change subject: hba: Rescan using SCSI layer
..
Patch Set 2:
I found bug 844180, that was the trigger for adding scsi timeouts and writing
to sysfs using multiple dd proceses.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: ioprocess: Move and reword rename() warning
..
Patch Set 5:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4091/ : SUCCESS
Antoni Segura Puimedon has posted comments on this change.
Change subject: mkimage: more robust content signature
..
Patch Set 5: Code-Review-1
(2 comments)
http://gerrit.ovirt.org/#/c/34203/5//COMMIT_MSG
Commit Message:
Antoni Segura Puimedon has posted comments on this change.
Change subject: virt: move sound device to vmdevices
..
Patch Set 6: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/29265
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netinfo, tool: Add a vdsm-tool to determine bonding defaults
offline
..
Patch Set 2:
Build Failed
Dan Kenigsberg has posted comments on this change.
Change subject: setupNetworks: doesn't remove broken nw from runningConfig
..
Patch Set 8:
(1 comment)
http://gerrit.ovirt.org/#/c/33995/8//COMMIT_MSG
Commit Message:
Line
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: move console device to vmdevices.py
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13007/ : SUCCESS
Dan Kenigsberg has posted comments on this change.
Change subject: netinfo, tool: Add a vdsm-tool to determine bonding defaults
offline
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/33528
To
Antoni Segura Puimedon has posted comments on this change.
Change subject: netinfo, tool: Add a vdsm-tool to determine bonding defaults
offline
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/33528
To
Antoni Segura Puimedon has posted comments on this change.
Change subject: netinfotests: Do not assume the existence of
/var/lib/vdsm/bonding-defaults.json
..
Patch Set 3: Code-Review+1
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: mkimage: more robust content signature
..
Patch Set 5:
(2 comments)
http://gerrit.ovirt.org/#/c/34203/5//COMMIT_MSG
Commit Message:
Line 60: The proper fix
Antoni Segura Puimedon has posted comments on this change.
Change subject: VDSM hook for random network allocation during VM power on
..
Patch Set 3:
(4 comments)
http://gerrit.ovirt.org/#/c/34114/3//COMMIT_MSG
Commit
Antoni Segura Puimedon has posted comments on this change.
Change subject: VDSM hook for random network allocation during VM power on
..
Patch Set 4: Code-Review-1
please see my comments to the previous patch set
--
To view,
Francesco Romani has posted comments on this change.
Change subject: mkimage: more robust content signature
..
Patch Set 6:
addressed comments from Toni
--
To view, visit http://gerrit.ovirt.org/34203
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: mkimage: more robust content signature
..
Patch Set 6:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13009/ : SUCCESS
Martin Polednik has posted comments on this change.
Change subject: vdsm: add functionality to detach host devices
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/32389/3/vdsm/hostdev.py
File vdsm/hostdev.py:
Line
Martin Polednik has posted comments on this change.
Change subject: virt: move console device to vmdevices.py
..
Patch Set 2: Verified+1
ran
[ok] unit tests
[ok] functional tests
[ok] manually created and started a VM with
oVirt Jenkins CI Server has posted comments on this change.
Change subject: VDSM hook for random network allocation during VM power on
..
Patch Set 4:
Build Failed
Ido Barkan has posted comments on this change.
Change subject: VDSM hook for random network allocation during VM power on
..
Patch Set 3: Verified+1
(3 comments)
Ido Barkan has posted comments on this change.
Change subject: VDSM hook for random network allocation during VM power on
..
Patch Set 5: Verified+1
--
To view, visit http://gerrit.ovirt.org/34114
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: VDSM hook for random network allocation during VM power on
..
Patch Set 5: Code-Review-1 Verified-1
Build Failed
Dima Kuznetsov has posted comments on this change.
Change subject: signals: Handle signals to non-main threads
..
Patch Set 15:
(4 comments)
Thanks for the review
http://gerrit.ovirt.org/#/c/29392/15/lib/vdsm/sigutils.py
Ido Barkan has posted comments on this change.
Change subject: VDSM hook for random network allocation during VM power on
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/34114/3//COMMIT_MSG
Commit Message:
Line 13:
Antoni Segura Puimedon has posted comments on this change.
Change subject: VDSM hook for random network allocation during VM power on
..
Patch Set 6: Code-Review-1
(2 comments)
Antoni Segura Puimedon has posted comments on this change.
Change subject: virt: move console device to vmdevices.py
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/34252
To unsubscribe, visit
Antoni Segura Puimedon has posted comments on this change.
Change subject: virt: move redir device to vmdevices.py
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/32608
To unsubscribe, visit
Antoni Segura Puimedon has posted comments on this change.
Change subject: virt: move smartcard device to vmdevices.py
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/34250
To unsubscribe, visit
Antoni Segura Puimedon has posted comments on this change.
Change subject: virt: move controller device to vmdevices.py
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/29261
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: VDSM hook for random network allocation during VM power on
..
Patch Set 6:
Build Failed
Antoni Segura Puimedon has posted comments on this change.
Change subject: mkimage: more robust content signature
..
Patch Set 6: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/34203
To unsubscribe, visit
Antoni Segura Puimedon has posted comments on this change.
Change subject: network: ConfigurationApplier parent object
..
Patch Set 4: Code-Review-1
ifcfg, iproute2 and pyroute_two decided to have config appliers. That is not
Antoni Segura Puimedon has posted comments on this change.
Change subject: netinfo, tool: Make the bonding defaults a proper Python file
..
Patch Set 4:
any update on the selinux context?
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: signals: Handle signals to non-main threads
..
Patch Set 15:
(2 comments)
http://gerrit.ovirt.org/#/c/29392/15/lib/vdsm/sigutils.py
File lib/vdsm/sigutils.py:
Antoni Segura Puimedon has posted comments on this change.
Change subject: netinfo.getIpInfo: handle slashless address
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/34137
To unsubscribe, visit
Antoni Segura Puimedon has posted comments on this change.
Change subject: libvirt: do not always log failed libvirt calls
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/33937
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: netinfo.getIpInfo: handle slashless address
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/34137
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: netinfo.getIpInfo: handle slashless address
..
netinfo.getIpInfo: handle slashless address
Apparently, 32 bit prefix is not reported within the
Saggi Mizrahi has posted comments on this change.
Change subject: hba: Rescan using SCSI layer
..
Patch Set 2:
fscimonce, I don't think nbio has any effect on sysfs. It's not the same path
as file IO. It's not that the kernel
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netinfo.getIpInfo: handle slashless address
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4092/ : SUCCESS
Saggi Mizrahi has posted comments on this change.
Change subject: hba: Rescan using SCSI layer
..
Patch Set 2:
nsoffer the patch you found was pushed bypassing authority. It caused a lot of
problems and is less than ideal. I
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm-infra: zombie-reaper refactor
..
Patch Set 8:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13012/ : SUCCESS
Francesco Romani has posted comments on this change.
Change subject: mkimage: more robust content signature
..
Patch Set 6: Verified+1
verified the same way as I did for http://gerrit.ovirt.org/#/c/34201/
highltights of the
Vinzenz Feenstra has uploaded a new change for review.
Change subject: virt: Configurable actions on console disconnect
..
virt: Configurable actions on console disconnect
We're now introducing configurable actions to be
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm-infra: zombie-reaper refactor
..
Patch Set 8: Code-Review+2
You want vdsm.infra - you got it.
--
To view, visit http://gerrit.ovirt.org/31301
To
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm-infra: zombie-reaper refactor
..
Patch Set 8: Code-Review-1
apparently not yet - manual rebase needed.
--
To view, visit http://gerrit.ovirt.org/31301
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: Configurable actions on console disconnect
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13013/ :
Francesco Romani has posted comments on this change.
Change subject: virt: move controller device to vmdevices.py
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/29261
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: virt: move console device to vmdevices.py
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/34252
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: virt: move sound device to vmdevices
..
Patch Set 6: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/29265
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: caps: Do not memoize CPU topology
..
Patch Set 1:
Un-draft this patch to make sure it is reviewed, when you feel it is ready.
As for the patch itself, can
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm-infra: zombie-reaper refactor
..
Patch Set 9:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13014/ : SUCCESS
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm-infra: zombie-reaper refactor
..
Patch Set 9: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/31301
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vdsm-infra: zombie-reaper refactor
..
vdsm-infra: zombie-reaper refactor
In a general intent to better organize how infra libraries and utilities
are
Nir Soffer has posted comments on this change.
Change subject: jsonrpc: Bridge.py reducing logging level
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/34097/1/vdsm/rpc/Bridge.py
File vdsm/rpc/Bridge.py:
Line 208:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm-infra: zombie-reaper refactor
..
Patch Set 10:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4093/ : FAILURE
Francesco Romani has posted comments on this change.
Change subject: vm: hold config lock while replying status
..
Patch Set 1: Code-Review-1 Verified-1
--
To view, visit http://gerrit.ovirt.org/34147
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: vm: hold config lock while replying status
..
Patch Set 1:
obviously wrong approach as it would badly break into the saveStatusInternal()
flow.
Will fix.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: jsonrpc: Bridge.py reducing logging level
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13015/ : SUCCESS
Dan Kenigsberg has posted comments on this change.
Change subject: virt: sampling: more cautious disk stats check
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/33623
To unsubscribe, visit
1 - 100 of 121 matches
Mail list logo
