Change in vdsm[master]: vm: move device setup into __init__

2014-11-04 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vm: move device setup into __init__ .. Patch Set 4: just reformatted the stacktrace into the commit message to make it readable -- To view, visit

Change in vdsm[master]: vm: move device setup into __init__

2014-11-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: move device setup into __init__ .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13357/ : FAILURE

Change in vdsm[master]: vm: move device setup into __init__

2014-11-04 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vm: move device setup into __init__ .. Patch Set 4: Succesful partial verification with 34752: * survived an excess of 550 VM startup without issues (stress

Change in vdsm[master]: tests: added NFS support to functional tests

2014-11-04 Thread ykleinbe
Yoav Kleinberger has uploaded a new change for review. Change subject: tests: added NFS support to functional tests .. tests: added NFS support to functional tests In this patch, I introduce a new NFS storage context for the

Change in vdsm[master]: tests: added NFS support to functional tests

2014-11-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: added NFS support to functional tests .. Patch Set 1: -Code-Review -Verified Build Successful

Change in vdsm[master]: gluster: volume snapshot create and delete verbs.

2014-11-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: volume snapshot create and delete verbs. .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13358/ :

Change in vdsm[master]: gluster: volume snapshot activate and deactivate verbs.

2014-11-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: volume snapshot activate and deactivate verbs. .. Patch Set 2: Build Failed

Change in vdsm[master]: gluster: volume snapshot list, restore and status verbs.

2014-11-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: volume snapshot list, restore and status verbs. .. Patch Set 2: Build Failed

Change in vdsm[master]: gluster: volume snapshot config set and get verbs.

2014-11-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: gluster: volume snapshot config set and get verbs. .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13362/ :

Change in vdsm[master]: cache: Replace utils.memoized with cache.memoized()

2014-11-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: cache: Replace utils.memoized with cache.memoized() .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13354/

Change in vdsm[master]: vm: return displayIp as a string in default case

2014-11-04 Thread fkobzik
Frank Kobzik has posted comments on this change. Change subject: vm: return displayIp as a string in default case .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/34675 To unsubscribe, visit

Change in vdsm[master]: virt: move vm.GraphicsDevice - vmdevices.Graphics

2014-11-04 Thread fromani
Francesco Romani has posted comments on this change. Change subject: virt: move vm.GraphicsDevice - vmdevices.Graphics .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/34557/1/vdsm/virt/vmdevices.py File

Change in vdsm[master]: devices: move Graphics Device utility functions

2014-11-04 Thread fromani
Francesco Romani has posted comments on this change. Change subject: devices: move Graphics Device utility functions .. Patch Set 1: I was planning to go in the opposite direction, removing the staticmethod from Graphics

Change in vdsm[master]: vmdevices: vm.${NAME}_DEVICES - vmdevices.${NAME}

2014-11-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vmdevices: vm.${NAME}_DEVICES - vmdevices.${NAME} .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13366/ :

Change in vdsm[master]: virt: move Drive into vmdevices

2014-11-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: move Drive into vmdevices .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13365/ : FAILURE

Change in vdsm[master]: virt: move NetworkInterface into vmdevices

2014-11-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: move NetworkInterface into vmdevices .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13364/ : FAILURE

Change in vdsm[master]: devices: move Graphics Device utility functions

2014-11-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: devices: move Graphics Device utility functions .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13363/ :

Change in vdsm[master]: vmdevices: vm.${NAME}_DEVICES - vmdevices.${NAME}

2014-11-04 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vmdevices: vm.${NAME}_DEVICES - vmdevices.${NAME} .. Patch Set 2: rebased -- To view, visit http://gerrit.ovirt.org/34556 To unsubscribe, visit

Change in vdsm[master]: virt: move vm.GraphicsDevice - vmdevices.Graphics

2014-11-04 Thread fromani
Francesco Romani has posted comments on this change. Change subject: virt: move vm.GraphicsDevice - vmdevices.Graphics .. Patch Set 2: rebased. No code changes. -- To view, visit http://gerrit.ovirt.org/34557 To unsubscribe,

Change in vdsm[master]: virt: move Drive into vmdevices

2014-11-04 Thread fromani
Francesco Romani has posted comments on this change. Change subject: virt: move Drive into vmdevices .. Patch Set 2: rebased -- To view, visit http://gerrit.ovirt.org/34560 To unsubscribe, visit

Change in vdsm[master]: virt: move NetworkInterface into vmdevices

2014-11-04 Thread fromani
Francesco Romani has posted comments on this change. Change subject: virt: move NetworkInterface into vmdevices .. Patch Set 2: rebased -- To view, visit http://gerrit.ovirt.org/34559 To unsubscribe, visit

Change in vdsm[master]: devices: move Graphics Device utility functions

2014-11-04 Thread fromani
Francesco Romani has posted comments on this change. Change subject: devices: move Graphics Device utility functions .. Patch Set 2: moved *LegacyConf as staticmethods reordered methods in Graphics class for the sake of

Change in vdsm[ovirt-3.5]: Adding the possibility to skip checks on rpmbuild

2014-11-04 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: Adding the possibility to skip checks on rpmbuild .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/34766 To unsubscribe, visit

Change in vdsm[ovirt-3.5]: Adding the possibility to skip checks on rpmbuild

2014-11-04 Thread ybronhei
Yaniv Bronhaim has submitted this change and it was merged. Change subject: Adding the possibility to skip checks on rpmbuild .. Adding the possibility to skip checks on rpmbuild This way you can build the rpms skipping the

Change in vdsm[ovirt-3.5.0]: Adding the possibility to skip checks on rpmbuild

2014-11-04 Thread ybronhei
Hello Douglas Schilling Landgraf, David Caro, Dan Kenigsberg, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/34773 to review the following change. Change subject: Adding the possibility to skip checks on rpmbuild

Change in vdsm[master]: jsonrpc: deepcopy result in response

2014-11-04 Thread fromani
Francesco Romani has posted comments on this change. Change subject: jsonrpc: deepcopy result in response .. Patch Set 2: Code-Review-1 misplaced fix -- To view, visit http://gerrit.ovirt.org/34580 To unsubscribe, visit

Change in vdsm[master]: utils: Use ovirt node for persist and unpersist files

2014-11-04 Thread ykaplan
Yeela Kaplan has abandoned this change. Change subject: utils: Use ovirt node for persist and unpersist files .. Abandoned -- To view, visit http://gerrit.ovirt.org/31584 To unsubscribe, visit http://gerrit.ovirt.org/settings

Change in vdsm[master]: utils: Add logs to rotateFiles

2014-11-04 Thread ykaplan
Yeela Kaplan has abandoned this change. Change subject: utils: Add logs to rotateFiles .. Abandoned -- To view, visit http://gerrit.ovirt.org/32605 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType:

Change in vdsm[ovirt-3.5]: Adding the possibility to skip checks on rpmbuild

2014-11-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Adding the possibility to skip checks on rpmbuild .. Patch Set 2: Build Failed

Change in vdsm[master]: tests: added NFS support to functional tests

2014-11-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: tests: added NFS support to functional tests .. Patch Set 2: Code-Review-1 Verified-1 Build Failed

Change in vdsm[master]: vm: migration: exponential downtime increment

2014-11-04 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vm: migration: exponential downtime increment .. Patch Set 9: Verified+1 re-verified while running a few migration, both with idle and busy VM:

Change in vdsm[ovirt-3.5.0]: Adding the possibility to skip checks on rpmbuild

2014-11-04 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: Adding the possibility to skip checks on rpmbuild .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/34773 To unsubscribe, visit

Change in vdsm[master]: vm: migration: exponential downtime increment

2014-11-04 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: vm: migration: exponential downtime increment .. vm: migration: exponential downtime increment Migration downtime is calculated using an interpolation

Change in vdsm[master]: netinfo: Displays active slave for the bond in getVdsCaps vd...

2014-11-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: netinfo: Displays active slave for the bond in getVdsCaps vdsmapi-schema: Adding Active slave support networkTests: Test to check if active slave exists

Change in vdsm[master]: vm: migration: exponential downtime increment

2014-11-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: migration: exponential downtime increment .. Patch Set 10: Build Failed

Change in vdsm[master]: netinfo: Displays active slave for the bond in getVdsCaps vd...

2014-11-04 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: netinfo: Displays active slave for the bond in getVdsCaps vdsmapi-schema: Adding Active slave support networkTests: Test to check if active slave exists

Change in vdsm[master]: tool: persist selinux booleans on ovirt node.

2014-11-04 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: tool: persist selinux booleans on ovirt node. .. Patch Set 2: Code-Review+1 Douglas, please review.. -- To view, visit http://gerrit.ovirt.org/34518 To

Change in vdsm[ovirt-3.5]: caps: Report online logical CPUs

2014-11-04 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: caps: Report online logical CPUs .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/34768 To unsubscribe, visit

Change in vdsm[master]: tool: persist selinux booleans on ovirt node.

2014-11-04 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change. Change subject: tool: persist selinux booleans on ovirt node. .. Patch Set 2: Looks good to me. Question Mooli, have you verified this patch on node? -- To view,

Change in vdsm[ovirt-3.5.0]: Adding the possibility to skip checks on rpmbuild

2014-11-04 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change. Change subject: Adding the possibility to skip checks on rpmbuild .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/34773 To unsubscribe,

Change in vdsm[master]: vm: move device setup into __init__

2014-11-04 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vm: move device setup into __init__ .. Patch Set 4: (6 comments) Since this is a quite obscure patch changing quite obscure code, added a few comments with

Change in vdsm[ovirt-3.5.0]: Adding the possibility to skip checks on rpmbuild

2014-11-04 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: Adding the possibility to skip checks on rpmbuild .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/34773 To unsubscribe, visit

Change in vdsm[master]: tool: persist selinux booleans on ovirt node.

2014-11-04 Thread mtayer
mooli tayer has posted comments on this change. Change subject: tool: persist selinux booleans on ovirt node. .. Patch Set 2: To be honest I have never been able to test anything that required creating a node iso out of a

Change in vdsm[ovirt-3.5.0]: Adding the possibility to skip checks on rpmbuild

2014-11-04 Thread ybronhei
Yaniv Bronhaim has submitted this change and it was merged. Change subject: Adding the possibility to skip checks on rpmbuild .. Adding the possibility to skip checks on rpmbuild This way you can build the rpms skipping the

Change in vdsm[ovirt-3.5.0]: Adding the possibility to skip checks on rpmbuild

2014-11-04 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Adding the possibility to skip checks on rpmbuild .. Patch Set 1: Code-Review+1 but if you need this for building in mock, go ahead. -- To view, visit

Change in vdsm[master]: spec: require latest version of IOProcess

2014-11-04 Thread smizrahi
Saggi Mizrahi has posted comments on this change. Change subject: spec: require latest version of IOProcess .. Patch Set 1: Code-Review+2 Verified+1 There is no need to wait until it is in stable. This is master and it's meant

Change in vdsm[ovirt-3.5.0]: Adding the possibility to skip checks on rpmbuild

2014-11-04 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Adding the possibility to skip checks on rpmbuild .. Patch Set 1: It's not REALLY important, since 3.5.0 is a dead branch (already built and released)... --

Change in vdsm[master]: spec: require latest version of IOProcess

2014-11-04 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: spec: require latest version of IOProcess .. spec: require latest version of IOProcess This version includes an important fix for IOProcess being

Change in vdsm[master]: vmdevices: vm.${NAME}_DEVICES - vmdevices.${NAME}

2014-11-04 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vmdevices: vm.${NAME}_DEVICES - vmdevices.${NAME} .. Patch Set 2: Verified+1 Verification: booted a few VMs, also did a couple of recovery and migration,

Change in vdsm[ovirt-3.5]: caps: Report online logical CPUs

2014-11-04 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: caps: Report online logical CPUs .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/34768/1/vdsm/rpc/vdsmapi-schema.json File

Change in vdsm[master]: utils: Use ovirt node for persist files

2014-11-04 Thread smizrahi
Saggi Mizrahi has posted comments on this change. Change subject: utils: Use ovirt node for persist files .. Patch Set 4: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/33468/4/lib/vdsm/utils.py File lib/vdsm/utils.py:

Change in vdsm[ovirt-3.5]: caps: Report online logical CPUs

2014-11-04 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: caps: Report online logical CPUs .. Patch Set 1: Code-Review-1 please add added in version xxx next to the new attribute. both in master and the backport .

Change in vdsm[master]: vmdevices: vm.${NAME}_DEVICES - vmdevices.${NAME}

2014-11-04 Thread mpolednik
Martin Polednik has posted comments on this change. Change subject: vmdevices: vm.${NAME}_DEVICES - vmdevices.${NAME} .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/34556 To unsubscribe, visit

Change in vdsm[master]: utils: Use ovirt node for persist files

2014-11-04 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change. Change subject: utils: Use ovirt node for persist files .. Patch Set 4: Code-Review-1 nice catch saggi -- To view, visit http://gerrit.ovirt.org/33468 To

Change in vdsm[master]: spec: require latest version of IOProcess

2014-11-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: spec: require latest version of IOProcess .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/156/

Change in vdsm[master]: cache: Add caching decorator with invalidation

2014-11-04 Thread smizrahi
Saggi Mizrahi has posted comments on this change. Change subject: cache: Add caching decorator with invalidation .. Patch Set 4: Code-Review-1 Really sorry for bothering you again but you didn't update 'doc/infra/index.rst'

Change in vdsm[master]: cache: Add caching decorator with invalidation

2014-11-04 Thread smizrahi
Saggi Mizrahi has posted comments on this change. Change subject: cache: Add caching decorator with invalidation .. Patch Set 4: Also noticed it's under lib/vdsm and not lib/vdsm/infra where it should be -- To view, visit

Change in vdsm[master]: hba: Rescan using SCSI layer

2014-11-04 Thread smizrahi
Saggi Mizrahi has posted comments on this change. Change subject: hba: Rescan using SCSI layer .. Patch Set 4: Code-Review-1 Original comments about writing to device directly from VDSM still not being addressed. -- To

Change in vdsm[master]: hba: Parallel hba scanning

2014-11-04 Thread smizrahi
Saggi Mizrahi has posted comments on this change. Change subject: hba: Parallel hba scanning .. Patch Set 2: Code-Review-1 (1 comment) As I've already discussed. You can't have that be done in multiple threads. It's

Change in vdsm[master]: utils: move nice ionice sid and sudo out of execCmd

2014-11-04 Thread smizrahi
Saggi Mizrahi has posted comments on this change. Change subject: utils: move nice ionice sid and sudo out of execCmd .. Patch Set 2: Code-Review-1 We are already doing work on moving those out of execCmd. dkuznets should have

Change in vdsm[master]: Use utils.persist instead of importing ovirt-node Config

2014-11-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: Use utils.persist instead of importing ovirt-node Config .. Patch Set 3: Build Failed

Change in vdsm[master]: utils: change persistFile to persist

2014-11-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: utils: change persistFile to persist .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13372/ : FAILURE

Change in vdsm[master]: utils: add unpersist for symmetry

2014-11-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: utils: add unpersist for symmetry .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13371/ : FAILURE

Change in vdsm[master]: utils: Use ovirt node for persist files

2014-11-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: utils: Use ovirt node for persist files .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13373/ : FAILURE

Change in vdsm[master]: misc: use utils.persist/unpersist instead of execcmd

2014-11-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: misc: use utils.persist/unpersist instead of execcmd .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13374/

Change in vdsm[master]: spec: bump policycoreutils-python version to 2.0.83-19.47.

2014-11-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: spec: bump policycoreutils-python version to 2.0.83-19.47. .. Patch Set 7: Build Failed

Change in vdsm[master]: Revised the format of output from the vdsm-tool vdsm-id comm...

2014-11-04 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Revised the format of output from the vdsm-tool vdsm-id command. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/34583 To unsubscribe,

Change in vdsm[master]: Sysctl to allow iSCSI multipath with multiple NICs in the sa...

2014-11-04 Thread apahim
Amador Pahim has posted comments on this change. Change subject: Sysctl to allow iSCSI multipath with multiple NICs in the same subnet .. Patch Set 17: -Verified (1 comment) setting rp_filter=2 from second session on will

Change in vdsm[master]: utils: Use ovirt node for persist files

2014-11-04 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change. Change subject: utils: Use ovirt node for persist files .. Patch Set 5: Code-Review+1 jenkins issues doesn't seem related to the patch.

Change in vdsm[master]: libvirtconnection: add function to create a new connection

2014-11-04 Thread shavivi
Shahar Havivi has posted comments on this change. Change subject: libvirtconnection: add function to create a new connection .. Patch Set 9: Verified that the new open_connection is working with no parameters (the default)

Change in vdsm[master]: virt: make domain_descriptor.py API pep8-friendly

2014-11-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: make domain_descriptor.py API pep8-friendly .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13376/ :

Change in vdsm[master]: Sysctl to allow iSCSI multipath with multiple NICs in the sa...

2014-11-04 Thread apahim
Amador Pahim has posted comments on this change. Change subject: Sysctl to allow iSCSI multipath with multiple NICs in the same subnet .. Patch Set 17: (1 comment) http://gerrit.ovirt.org/#/c/31529/17/vdsm/storage/iscsi.py

Change in vdsm[master]: virt: make domain_descriptor.py API pep8-friendly

2014-11-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: make domain_descriptor.py API pep8-friendly .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13377/ :

Change in vdsm[master]: virt: make domain_descriptor.py API pep8-friendly

2014-11-04 Thread fromani
Francesco Romani has posted comments on this change. Change subject: virt: make domain_descriptor.py API pep8-friendly .. Patch Set 5: Verified+1 rev 5, 6: rebased, fixed tests Verification: booted a few VMs without any

Change in vdsm[master]: tests: added NFS support to functional tests

2014-11-04 Thread ykleinbe
Yoav Kleinberger has posted comments on this change. Change subject: tests: added NFS support to functional tests .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/32990 To unsubscribe, visit

Change in vdsm[master]: libnl: make link_cache optional for route_info

2014-11-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: libnl: make link_cache optional for route_info .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13378/ :

Change in vdsm[master]: libnl: make link cache optional for link_info and addr_info

2014-11-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: libnl: make link cache optional for link_info and addr_info .. Patch Set 6: Build Failed

Change in vdsm[master]: libnl: make link_cache optional for route_info

2014-11-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: libnl: make link_cache optional for route_info .. Patch Set 7: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13380/ :

Change in vdsm[master]: libnl: make link_cache optional for route_info

2014-11-04 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: libnl: make link_cache optional for route_info .. Patch Set 7: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/32950 To unsubscribe, visit

Change in vdsm[master]: Revised the format of output from the vdsm-tool vdsm-id comm...

2014-11-04 Thread mtayer
mooli tayer has posted comments on this change. Change subject: Revised the format of output from the vdsm-tool vdsm-id command. .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/34583 To unsubscribe,

Change in vdsm[master]: libnl: make link cache optional for link_info and addr_info

2014-11-04 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: libnl: make link cache optional for link_info and addr_info .. Patch Set 7: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/32949 To unsubscribe, visit

Change in vdsm[master]: vm: migration: move wait countdown in a function

2014-11-04 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vm: migration: move wait countdown in a function .. Patch Set 5: (2 comments) http://gerrit.ovirt.org/#/c/32706/5//COMMIT_MSG Commit Message: Line 9: The

Change in vdsm[master]: libnl: drop libnl-1 dependency

2014-11-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: libnl: drop libnl-1 dependency .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13381/ : FAILURE

Change in vdsm[master]: libnl: make link cache optional for link_info and addr_info

2014-11-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: libnl: make link cache optional for link_info and addr_info .. Patch Set 7: Build Failed

Change in vdsm[master]: netlink: event monitor

2014-11-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: netlink: event monitor .. Patch Set 20: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13383/ : FAILURE

Change in vdsm[master]: virt: make domain_descriptor.py API pep8-friendly

2014-11-04 Thread fromani
Francesco Romani has posted comments on this change. Change subject: virt: make domain_descriptor.py API pep8-friendly .. Patch Set 6: Verified+1 rev 5, 6: rebased, fixed tests Verification: booted a few VMs without any

Change in vdsm[master]: vm: migration: move wait countdown in a function

2014-11-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: migration: move wait countdown in a function .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13384/ :

Change in vdsm[master]: spec: bump policycoreutils-python version to 2.0.83-19.47.

2014-11-04 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: spec: bump policycoreutils-python version to 2.0.83-19.47. .. Patch Set 7: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/33771 To unsubscribe, visit

Change in vdsm[master]: spec: remove redundant check.

2014-11-04 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: spec: remove redundant check. .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/34610 To unsubscribe, visit

Change in vdsm[master]: spec: remove redundant 'Requires(X): policycoreutils-python'.

2014-11-04 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: spec: remove redundant 'Requires(X): policycoreutils-python'. .. Patch Set 1: Code-Review+1 :) thanks for the detailed explanation -- To view, visit

Change in vdsm[master]: utils: Use ovirt node for persist and unpersist files

2014-11-04 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: utils: Use ovirt node for persist and unpersist files .. Patch Set 4: Why abandon? Do we have another patch replacing this? -- To view, visit

Change in vdsm[master]: cache: Add caching decorator with invalidation

2014-11-04 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: cache: Add caching decorator with invalidation .. Patch Set 4: The module is currently not in the infra package, so there is no need to update doc/infra.rst. As

Change in vdsm[master]: netlink: event monitor

2014-11-04 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: netlink: event monitor .. Patch Set 20: Code-Review-1 (17 comments) http://gerrit.ovirt.org/#/c/32626/20/lib/vdsm/netlink/__init__.py File

Change in vdsm[master]: hba: Parallel hba scanning

2014-11-04 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: hba: Parallel hba scanning .. Patch Set 2: (1 comment) Why do you think this is expensive? This also used only in supervdsm, so it cannot caused vdsm to get

Change in vdsm[master]: hba: Rescan using SCSI layer

2014-11-04 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: hba: Rescan using SCSI layer .. Patch Set 4: This is addressed by the next patch. We can squash them if you like. -- To view, visit http://gerrit.ovirt.org/34245

Change in vdsm[master]: Sysctl to allow iSCSI multipath with multiple NICs in the sa...

2014-11-04 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: Sysctl to allow iSCSI multipath with multiple NICs in the same subnet .. Patch Set 17: (1 comment) http://gerrit.ovirt.org/#/c/31529/17/vdsm/storage/iscsi.py

Change in vdsm[master]: vm: move device setup into __init__

2014-11-04 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: vm: move device setup into __init__ .. Patch Set 4: (8 comments) The nature of the error is very clear, and it is easy to fix by iterating over a copy of the

Change in vdsm[master]: spec: remove redundant check.

2014-11-04 Thread mtayer
mooli tayer has posted comments on this change. Change subject: spec: remove redundant check. .. Patch Set 2: verified on fe19: $ which hostname /bin/hostname $ rpm -qa vdsm vdsm-4.16.0-489.git6eac12d.el6.x86_64 $ cat

Change in vdsm[master]: spec: bump policycoreutils-python version to 2.0.83-19.47.

2014-11-04 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: spec: bump policycoreutils-python version to 2.0.83-19.47. .. Patch Set 7: Code-Review-1 (1 comment) -1 for visibility

Change in vdsm[master]: vm: split slow disk access from normalization

2014-11-04 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: vm: split slow disk access from normalization .. Patch Set 2: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/34752/2/vdsm/virt/vm.py File vdsm/virt/vm.py:

  1   2   >