Francesco Romani has posted comments on this change.
Change subject: vm: move device setup into __init__
..
Patch Set 4:
just reformatted the stacktrace into the commit message to make it readable
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: move device setup into __init__
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13357/ : FAILURE
Francesco Romani has posted comments on this change.
Change subject: vm: move device setup into __init__
..
Patch Set 4:
Succesful partial verification with 34752:
* survived an excess of 550 VM startup without issues (stress
Yoav Kleinberger has uploaded a new change for review.
Change subject: tests: added NFS support to functional tests
..
tests: added NFS support to functional tests
In this patch, I introduce a new NFS storage context for the
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: added NFS support to functional tests
..
Patch Set 1: -Code-Review -Verified
Build Successful
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster: volume snapshot create and delete verbs.
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13358/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster: volume snapshot activate and deactivate verbs.
..
Patch Set 2:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster: volume snapshot list, restore and status verbs.
..
Patch Set 2:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster: volume snapshot config set and get verbs.
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13362/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: cache: Replace utils.memoized with cache.memoized()
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13354/
Frank Kobzik has posted comments on this change.
Change subject: vm: return displayIp as a string in default case
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/34675
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: virt: move vm.GraphicsDevice - vmdevices.Graphics
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/34557/1/vdsm/virt/vmdevices.py
File
Francesco Romani has posted comments on this change.
Change subject: devices: move Graphics Device utility functions
..
Patch Set 1:
I was planning to go in the opposite direction, removing the staticmethod from
Graphics
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vmdevices: vm.${NAME}_DEVICES - vmdevices.${NAME}
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13366/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: move Drive into vmdevices
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13365/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: move NetworkInterface into vmdevices
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13364/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: devices: move Graphics Device utility functions
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13363/ :
Francesco Romani has posted comments on this change.
Change subject: vmdevices: vm.${NAME}_DEVICES - vmdevices.${NAME}
..
Patch Set 2:
rebased
--
To view, visit http://gerrit.ovirt.org/34556
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: virt: move vm.GraphicsDevice - vmdevices.Graphics
..
Patch Set 2:
rebased. No code changes.
--
To view, visit http://gerrit.ovirt.org/34557
To unsubscribe,
Francesco Romani has posted comments on this change.
Change subject: virt: move Drive into vmdevices
..
Patch Set 2:
rebased
--
To view, visit http://gerrit.ovirt.org/34560
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: virt: move NetworkInterface into vmdevices
..
Patch Set 2:
rebased
--
To view, visit http://gerrit.ovirt.org/34559
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: devices: move Graphics Device utility functions
..
Patch Set 2:
moved *LegacyConf as staticmethods
reordered methods in Graphics class for the sake of
Yaniv Bronhaim has posted comments on this change.
Change subject: Adding the possibility to skip checks on rpmbuild
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/34766
To unsubscribe, visit
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: Adding the possibility to skip checks on rpmbuild
..
Adding the possibility to skip checks on rpmbuild
This way you can build the rpms skipping the
Hello Douglas Schilling Landgraf, David Caro, Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/34773
to review the following change.
Change subject: Adding the possibility to skip checks on rpmbuild
Francesco Romani has posted comments on this change.
Change subject: jsonrpc: deepcopy result in response
..
Patch Set 2: Code-Review-1
misplaced fix
--
To view, visit http://gerrit.ovirt.org/34580
To unsubscribe, visit
Yeela Kaplan has abandoned this change.
Change subject: utils: Use ovirt node for persist and unpersist files
..
Abandoned
--
To view, visit http://gerrit.ovirt.org/31584
To unsubscribe, visit http://gerrit.ovirt.org/settings
Yeela Kaplan has abandoned this change.
Change subject: utils: Add logs to rotateFiles
..
Abandoned
--
To view, visit http://gerrit.ovirt.org/32605
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Adding the possibility to skip checks on rpmbuild
..
Patch Set 2:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: added NFS support to functional tests
..
Patch Set 2: Code-Review-1 Verified-1
Build Failed
Francesco Romani has posted comments on this change.
Change subject: vm: migration: exponential downtime increment
..
Patch Set 9: Verified+1
re-verified while running a few migration, both with idle and busy VM:
Yaniv Bronhaim has posted comments on this change.
Change subject: Adding the possibility to skip checks on rpmbuild
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/34773
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vm: migration: exponential downtime increment
..
vm: migration: exponential downtime increment
Migration downtime is calculated using an interpolation
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netinfo: Displays active slave for the bond in getVdsCaps
vdsmapi-schema: Adding Active slave support networkTests: Test to check if
active slave exists
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: migration: exponential downtime increment
..
Patch Set 10:
Build Failed
Antoni Segura Puimedon has posted comments on this change.
Change subject: netinfo: Displays active slave for the bond in getVdsCaps
vdsmapi-schema: Adding Active slave support networkTests: Test to check if
active slave exists
Yaniv Bronhaim has posted comments on this change.
Change subject: tool: persist selinux booleans on ovirt node.
..
Patch Set 2: Code-Review+1
Douglas, please review..
--
To view, visit http://gerrit.ovirt.org/34518
To
Yaniv Bronhaim has posted comments on this change.
Change subject: caps: Report online logical CPUs
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/34768
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: tool: persist selinux booleans on ovirt node.
..
Patch Set 2:
Looks good to me. Question Mooli, have you verified this patch on node?
--
To view,
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Adding the possibility to skip checks on rpmbuild
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/34773
To unsubscribe,
Francesco Romani has posted comments on this change.
Change subject: vm: move device setup into __init__
..
Patch Set 4:
(6 comments)
Since this is a quite obscure patch changing quite obscure code, added a few
comments with
Yaniv Bronhaim has posted comments on this change.
Change subject: Adding the possibility to skip checks on rpmbuild
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/34773
To unsubscribe, visit
mooli tayer has posted comments on this change.
Change subject: tool: persist selinux booleans on ovirt node.
..
Patch Set 2:
To be honest I have never been able to test anything that required creating a
node iso out of a
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: Adding the possibility to skip checks on rpmbuild
..
Adding the possibility to skip checks on rpmbuild
This way you can build the rpms skipping the
Dan Kenigsberg has posted comments on this change.
Change subject: Adding the possibility to skip checks on rpmbuild
..
Patch Set 1: Code-Review+1
but if you need this for building in mock, go ahead.
--
To view, visit
Saggi Mizrahi has posted comments on this change.
Change subject: spec: require latest version of IOProcess
..
Patch Set 1: Code-Review+2 Verified+1
There is no need to wait until it is in stable.
This is master and it's meant
Dan Kenigsberg has posted comments on this change.
Change subject: Adding the possibility to skip checks on rpmbuild
..
Patch Set 1:
It's not REALLY important, since 3.5.0 is a dead branch (already built and
released)...
--
Dan Kenigsberg has submitted this change and it was merged.
Change subject: spec: require latest version of IOProcess
..
spec: require latest version of IOProcess
This version includes an important fix for
IOProcess being
Francesco Romani has posted comments on this change.
Change subject: vmdevices: vm.${NAME}_DEVICES - vmdevices.${NAME}
..
Patch Set 2: Verified+1
Verification: booted a few VMs, also did a couple of recovery and migration,
Yaniv Bronhaim has posted comments on this change.
Change subject: caps: Report online logical CPUs
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/34768/1/vdsm/rpc/vdsmapi-schema.json
File
Saggi Mizrahi has posted comments on this change.
Change subject: utils: Use ovirt node for persist files
..
Patch Set 4: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/33468/4/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Yaniv Bronhaim has posted comments on this change.
Change subject: caps: Report online logical CPUs
..
Patch Set 1: Code-Review-1
please add added in version xxx next to the new attribute. both in master and
the backport .
Martin Polednik has posted comments on this change.
Change subject: vmdevices: vm.${NAME}_DEVICES - vmdevices.${NAME}
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/34556
To unsubscribe, visit
Douglas Schilling Landgraf has posted comments on this change.
Change subject: utils: Use ovirt node for persist files
..
Patch Set 4: Code-Review-1
nice catch saggi
--
To view, visit http://gerrit.ovirt.org/33468
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: spec: require latest version of IOProcess
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/156/
Saggi Mizrahi has posted comments on this change.
Change subject: cache: Add caching decorator with invalidation
..
Patch Set 4: Code-Review-1
Really sorry for bothering you again but you didn't update
'doc/infra/index.rst'
Saggi Mizrahi has posted comments on this change.
Change subject: cache: Add caching decorator with invalidation
..
Patch Set 4:
Also noticed it's under lib/vdsm and not lib/vdsm/infra where it should be
--
To view, visit
Saggi Mizrahi has posted comments on this change.
Change subject: hba: Rescan using SCSI layer
..
Patch Set 4: Code-Review-1
Original comments about writing to device directly from VDSM still not being
addressed.
--
To
Saggi Mizrahi has posted comments on this change.
Change subject: hba: Parallel hba scanning
..
Patch Set 2: Code-Review-1
(1 comment)
As I've already discussed. You can't have that be done in multiple threads.
It's
Saggi Mizrahi has posted comments on this change.
Change subject: utils: move nice ionice sid and sudo out of execCmd
..
Patch Set 2: Code-Review-1
We are already doing work on moving those out of execCmd. dkuznets should have
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Use utils.persist instead of importing ovirt-node Config
..
Patch Set 3:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: utils: change persistFile to persist
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13372/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: utils: add unpersist for symmetry
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13371/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: utils: Use ovirt node for persist files
..
Patch Set 5:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13373/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: misc: use utils.persist/unpersist instead of execcmd
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13374/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: spec: bump policycoreutils-python version to 2.0.83-19.47.
..
Patch Set 7:
Build Failed
Dan Kenigsberg has posted comments on this change.
Change subject: Revised the format of output from the vdsm-tool vdsm-id command.
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/34583
To unsubscribe,
Amador Pahim has posted comments on this change.
Change subject: Sysctl to allow iSCSI multipath with multiple NICs in the same
subnet
..
Patch Set 17: -Verified
(1 comment)
setting rp_filter=2 from second session on will
Douglas Schilling Landgraf has posted comments on this change.
Change subject: utils: Use ovirt node for persist files
..
Patch Set 5: Code-Review+1
jenkins issues doesn't seem related to the patch.
Shahar Havivi has posted comments on this change.
Change subject: libvirtconnection: add function to create a new connection
..
Patch Set 9:
Verified that the new open_connection is working with no parameters (the
default)
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: make domain_descriptor.py API pep8-friendly
..
Patch Set 5:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13376/ :
Amador Pahim has posted comments on this change.
Change subject: Sysctl to allow iSCSI multipath with multiple NICs in the same
subnet
..
Patch Set 17:
(1 comment)
http://gerrit.ovirt.org/#/c/31529/17/vdsm/storage/iscsi.py
oVirt Jenkins CI Server has posted comments on this change.
Change subject: virt: make domain_descriptor.py API pep8-friendly
..
Patch Set 6:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13377/ :
Francesco Romani has posted comments on this change.
Change subject: virt: make domain_descriptor.py API pep8-friendly
..
Patch Set 5: Verified+1
rev 5, 6: rebased, fixed tests
Verification: booted a few VMs without any
Yoav Kleinberger has posted comments on this change.
Change subject: tests: added NFS support to functional tests
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/32990
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: libnl: make link_cache optional for route_info
..
Patch Set 6:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13378/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: libnl: make link cache optional for link_info and addr_info
..
Patch Set 6:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: libnl: make link_cache optional for route_info
..
Patch Set 7:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13380/ :
Petr Horáček has posted comments on this change.
Change subject: libnl: make link_cache optional for route_info
..
Patch Set 7: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/32950
To unsubscribe, visit
mooli tayer has posted comments on this change.
Change subject: Revised the format of output from the vdsm-tool vdsm-id command.
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/34583
To unsubscribe,
Petr Horáček has posted comments on this change.
Change subject: libnl: make link cache optional for link_info and addr_info
..
Patch Set 7: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/32949
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: vm: migration: move wait countdown in a function
..
Patch Set 5:
(2 comments)
http://gerrit.ovirt.org/#/c/32706/5//COMMIT_MSG
Commit Message:
Line 9: The
oVirt Jenkins CI Server has posted comments on this change.
Change subject: libnl: drop libnl-1 dependency
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13381/ : FAILURE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: libnl: make link cache optional for link_info and addr_info
..
Patch Set 7:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netlink: event monitor
..
Patch Set 20:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13383/ : FAILURE
Francesco Romani has posted comments on this change.
Change subject: virt: make domain_descriptor.py API pep8-friendly
..
Patch Set 6: Verified+1
rev 5, 6: rebased, fixed tests Verification: booted a few VMs without any
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: migration: move wait countdown in a function
..
Patch Set 6:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13384/ :
Yaniv Bronhaim has posted comments on this change.
Change subject: spec: bump policycoreutils-python version to 2.0.83-19.47.
..
Patch Set 7: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/33771
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: spec: remove redundant check.
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/34610
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: spec: remove redundant 'Requires(X): policycoreutils-python'.
..
Patch Set 1: Code-Review+1
:) thanks for the detailed explanation
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: utils: Use ovirt node for persist and unpersist files
..
Patch Set 4:
Why abandon? Do we have another patch replacing this?
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: cache: Add caching decorator with invalidation
..
Patch Set 4:
The module is currently not in the infra package, so there is no need to update
doc/infra.rst.
As
Antoni Segura Puimedon has posted comments on this change.
Change subject: netlink: event monitor
..
Patch Set 20: Code-Review-1
(17 comments)
http://gerrit.ovirt.org/#/c/32626/20/lib/vdsm/netlink/__init__.py
File
Nir Soffer has posted comments on this change.
Change subject: hba: Parallel hba scanning
..
Patch Set 2:
(1 comment)
Why do you think this is expensive?
This also used only in supervdsm, so it cannot caused vdsm to get
Nir Soffer has posted comments on this change.
Change subject: hba: Rescan using SCSI layer
..
Patch Set 4:
This is addressed by the next patch. We can squash them if you like.
--
To view, visit http://gerrit.ovirt.org/34245
Nir Soffer has posted comments on this change.
Change subject: Sysctl to allow iSCSI multipath with multiple NICs in the same
subnet
..
Patch Set 17:
(1 comment)
http://gerrit.ovirt.org/#/c/31529/17/vdsm/storage/iscsi.py
Nir Soffer has posted comments on this change.
Change subject: vm: move device setup into __init__
..
Patch Set 4:
(8 comments)
The nature of the error is very clear, and it is easy to fix by iterating over
a copy of the
mooli tayer has posted comments on this change.
Change subject: spec: remove redundant check.
..
Patch Set 2:
verified on fe19:
$ which hostname
/bin/hostname
$ rpm -qa vdsm
vdsm-4.16.0-489.git6eac12d.el6.x86_64
$ cat
Dan Kenigsberg has posted comments on this change.
Change subject: spec: bump policycoreutils-python version to 2.0.83-19.47.
..
Patch Set 7: Code-Review-1
(1 comment)
-1 for visibility
Nir Soffer has posted comments on this change.
Change subject: vm: split slow disk access from normalization
..
Patch Set 2: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/34752/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:
1 - 100 of 107 matches
Mail list logo