Dan Kenigsberg has posted comments on this change.
Change subject: lvm:moved metadatasize as an optional param for pv create in
lvm module
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/38188
To
Dan Kenigsberg has posted comments on this change.
Change subject: hostdev: fix creation and deletion of multiple udev rules
..
Patch Set 6: Code-Review-1
--
To view, visit https://gerrit.ovirt.org/38208
To unsubscribe, visit
Ondřej Svoboda has posted comments on this change.
Change subject: models: move IpConfig's members to NetDevice
..
Patch Set 1: Verified+1
There was no regression also on iproute2 and pyroute2 configurators.
Tests that failed
Dan Kenigsberg has posted comments on this change.
Change subject: RFE: Report downtime for each live migration
..
Patch Set 7: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/37075/7/vdsm.spec.in
File vdsm.spec.in:
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: getVMList: using internal function instead of vm.status
..
getVMList: using internal function instead of vm.status
Bug-Url:
Yaniv Bronhaim has posted comments on this change.
Change subject: getVMList: using internal function instead of vm.status
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/38513
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: hostdev: fix creation and deletion of multiple udev rules
..
Patch Set 4:
(3 comments)
https://gerrit.ovirt.org/#/c/38208/4//COMMIT_MSG
Commit Message:
Line
Michal Skrivanek has posted comments on this change.
Change subject: hostdev: fix creation and deletion of multiple udev rules
..
Patch Set 6:
please add bug url to all the patches in the series...
Michal Skrivanek has posted comments on this change.
Change subject: v2v: Convert VM from external source to Data Domain
..
Patch Set 7:
can you please add unit tests for the new stuff?
--
To view, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vm: stats: cache metadata value
..
vm: stats: cache metadata value
vcpuLimit can be set only by Engine (or anyone else
impersonating it using the
Dan Kenigsberg has posted comments on this change.
Change subject: vm: stats: cache metadata value
..
Patch Set 15: Code-Review+2
Copy and raise Sivak's score.
--
To view, visit https://gerrit.ovirt.org/37592
To unsubscribe,
Dan Kenigsberg has submitted this change and it was merged.
Change subject: lvm:moved metadatasize as an optional param for pv create in
lvm module
..
lvm:moved metadatasize as an optional param for pv create in lvm module
Sandro Bonazzola has posted comments on this change.
Change subject: lvm: Adds autobackup param in changelv and set the default
value to false
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/38195/2//COMMIT_MSG
Dan Kenigsberg has posted comments on this change.
Change subject: hostdev: display directed-passthrough status in caps
..
Patch Set 4: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/37701/4/vdsm/caps.py
File
Ondřej Svoboda has posted comments on this change.
Change subject: ifcfg: make _getIfaceConfValues pass ipv4, ipv6 to
_createConfFile
..
Patch Set 1: Verified+1
Verified with models: move IpConfig's members to NetDevice,
Ondřej Svoboda has posted comments on this change.
Change subject: models: move dynamic IP configuration parameters to IPv4 and
IPv6
..
Patch Set 3: Verified+1
Verified with models: move IpConfig's members to NetDevice, there
Ondřej Svoboda has posted comments on this change.
Change subject: ifcfg: use _to_ifcfg_bool to shorten yes/no assignments
..
Patch Set 2: Verified-1
Verified with models: move IpConfig's members to NetDevice, there was no
oVirt Jenkins CI Server has posted comments on this change.
Change subject: lvm:moved metadatasize as an optional param for pv create in
lvm module
..
Patch Set 5:
Build Successful
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: sos plugin: collect /var/lib/vdsm
..
sos plugin: collect /var/lib/vdsm
ovirt-3.5's vdsm started placing important persistent information under
Nir Soffer has posted comments on this change.
Change subject: storage: Add multipath-resize command line tool
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/38467/1/vdsm/storage/multipath-resize
File
Ondřej Svoboda has posted comments on this change.
Change subject: ifcfg: stop reading from NetDevice.ipConfig namedtuple in
_getIfaceConfValues
..
Patch Set 7: Verified+1
Verified with models: move IpConfig's members to
Ondřej Svoboda has posted comments on this change.
Change subject: network: order 'ipv4' before 'ipv6' and rename 'blocking' to
'blockingdhcp'
..
Patch Set 1: Verified+1
Verified with models: move IpConfig's members to
Ondřej Svoboda has posted comments on this change.
Change subject: models: remove IpConfig's namedtuple (NetDevice.ipConfig)
..
Patch Set 7: Verified+1
Verified with models: move IpConfig's members to NetDevice, there was no
Ondřej Svoboda has posted comments on this change.
Change subject: ifcfg: stop using IpConfig's namedtuple altogether
..
Patch Set 7: Verified+1
Verified with models: move IpConfig's members to NetDevice, there was no
Ondřej Svoboda has posted comments on this change.
Change subject: ifcfg: use IpConfig in _createConfFile instead of its namedtuple
..
Patch Set 9: Verified+1
Verified with models: move IpConfig's members to NetDevice, there
Ondřej Svoboda has posted comments on this change.
Change subject: iproute2, pyroute_two: use IpConfig directly
(NetDevice.ipconfig)
..
Patch Set 9: Verified+1
Verified with models: move IpConfig's members to NetDevice, there
Ondřej Svoboda has posted comments on this change.
Change subject: ifcfg: use _to_ifcfg_bool to shorten yes/no assignments
..
Patch Set 2: Verified+1
My bad, +1 is on the right.
--
To view, visit
Dan Kenigsberg has posted comments on this change.
Change subject: vm: add 'name' property
..
Patch Set 14: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/37824
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: network: support PCI passthrough of SR-IOV network interfaces.
..
Patch Set 8:
Build Failed
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vm: add 'name' property
..
vm: add 'name' property
add a 'name' property, to Vm class, and add it to the
Vm.getStats() output.
This is needed to
Francesco Romani has posted comments on this change.
Change subject: stomp: Optimize stomp encoder\decoder
..
Patch Set 6: Code-Review-1
(1 comment)
seems nice, but we need better documentation (commit message) to start
Francesco Romani has posted comments on this change.
Change subject: jsonrpc: Properly initialize RuntimeError for JsonRpcError
..
Patch Set 5: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/35934/5//COMMIT_MSG
Commit
Francesco Romani has posted comments on this change.
Change subject: stomp: Remove redundant code
..
Patch Set 5:
seems ok at glance, but test(s) will help gaining confidence
--
To view, visit https://gerrit.ovirt.org/35939
oVirt Jenkins CI Server has posted comments on this change.
Change subject: hostdev: fix creation and deletion of multiple udev rules
..
Patch Set 5:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16475/ :
Martin Sivák has posted comments on this change.
Change subject: vm: do not poll for scheduler parameters
..
Patch Set 2:
There is one issue that might appear with this change.
Libvirt might change the values when setting, so
Yaniv Bronhaim has posted comments on this change.
Change subject: libvirt configurator: listen to ipv6, too
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/38328
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: asyncore: Move ssl buffer handling to dispatcher
..
Patch Set 9: Code-Review-1
(2 comments)
couple of questions inside for my understanding, -1 for
Francesco Romani has posted comments on this change.
Change subject: stomp: Make sure the \0 is read before slicing the buffer
..
Patch Set 5: Code-Review-1
see Yaniv's comment in v1
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: qemu-img: check/use -T src_cache option in convert/rebase
when available
..
Patch Set 3:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: build: Update required device-mapper-multipath version
..
Patch Set 5:
Build Failed
Michal Skrivanek has posted comments on this change.
Change subject: hostdev: add hostdev device definition
..
Patch Set 12:
(1 comment)
https://gerrit.ovirt.org/#/c/37700/12/vdsm/virt/vmdevices/hostdevice.py
File
Shahar Havivi has posted comments on this change.
Change subject: RFE: Report downtime for each live migration
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/37075/7/vdsm.spec.in
File vdsm.spec.in:
Line 185:
Francesco Romani has posted comments on this change.
Change subject: jsonrpc: Fix callMethod in JsonRpcClient
..
Patch Set 5: Code-Review-1
(1 comment)
-1 for visibility
https://gerrit.ovirt.org/#/c/35935/5//COMMIT_MSG
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sos plugin: collect /var/lib/vdsm
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el6-x86_64_merged/181/ :
Francesco Romani has posted comments on this change.
Change subject: packaging: bump libvirt requirements
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/38538/2/vdsm.spec.in
File vdsm.spec.in:
Line 195: %if
Dan Kenigsberg has submitted this change and it was merged.
Change subject: iproute2, pyroute_two: use IpConfig directly
(NetDevice.ipconfig)
..
iproute2, pyroute_two: use IpConfig directly (NetDevice.ipconfig)
NetDevice.ip
Dan Kenigsberg has posted comments on this change.
Change subject: network: order 'ipv4' before 'ipv6' and rename 'blocking' to
'blockingdhcp'
..
Patch Set 1: Code-Review+2
harmless
--
To view, visit
Shahar Havivi has posted comments on this change.
Change subject: RFE: Report downtime for each live migration
..
Patch Set 8:
when Francescos patch https://gerrit.ovirt.org/#/c/38538 will merged I will
remove the version
Adam Litke has posted comments on this change.
Change subject: block: use the contextmanager for getVolumeMetadataSlot
..
Patch Set 6:
(2 comments)
https://gerrit.ovirt.org/#/c/25988/6//COMMIT_MSG
Commit Message:
Line 3:
Dan Kenigsberg has posted comments on this change.
Change subject: asyncore: Move AsyncoreEvent to betterAsyncore
..
Patch Set 10: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/37053
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: asyncore: Move AsyncoreEvent to betterAsyncore
..
asyncore: Move AsyncoreEvent to betterAsyncore
Change-Id: Icd3dc881091535328646ca1eeaac85f711885fc6
Dan Kenigsberg has submitted this change and it was merged.
Change subject: stomp: use monotonic timer instead of clock
..
stomp: use monotonic timer instead of clock
Change-Id: I58fa9009c72422f28065282cdb3b5d20f010ec80
Dan Kenigsberg has posted comments on this change.
Change subject: stomp: use monotonic timer instead of clock
..
Patch Set 10: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/37056
To unsubscribe, visit
Darshan N has posted comments on this change.
Change subject: net upgrade: log missing bonds
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/38472/1/lib/vdsm/tool/unified_persistence.py
File
Dan Kenigsberg has posted comments on this change.
Change subject: network: support PCI passthrough of SR-IOV network interfaces.
..
Patch Set 8: Code-Review-1
(1 comment)
Shahar Havivi has posted comments on this change.
Change subject: v2v: Convert VM from external source to Data Domain
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/37509/8/vdsm/v2v.py
File vdsm/v2v.py:
Line 262:
Yaniv Bronhaim has posted comments on this change.
Change subject: libvirt configurator: listen to ipv6, too
..
Patch Set 1: Verified+1
works for me with f20, I didn't check upgrade but it shouldn't be different
--
To view,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm: add 'name' property
..
Patch Set 15:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/720/ :
SUCCESS
Dan Kenigsberg has submitted this change and it was merged.
Change subject: ifcfg: stop reading from NetDevice.ipConfig namedtuple in
_getIfaceConfValues
..
ifcfg: stop reading from NetDevice.ipConfig namedtuple in
Dan Kenigsberg has posted comments on this change.
Change subject: ifcfg: stop using IpConfig's namedtuple altogether
..
Patch Set 7: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/37795
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: iproute2, pyroute_two: use IpConfig directly
(NetDevice.ipconfig)
..
Patch Set 9: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/36726
To
Francesco Romani has uploaded a new change for review.
Change subject: packaging: bump libvirt requirements
..
packaging: bump libvirt requirements
With RHEL/Centos 7.1 out of the door, it is
time to bump our libvirt
Dan Kenigsberg has posted comments on this change.
Change subject: network: support PCI passthrough of SR-IOV network interfaces.
..
Patch Set 8:
(1 comment)
Michal Skrivanek has posted comments on this change.
Change subject: [WIP]Use jsonrpc during migration of vms
..
Patch Set 4:
(3 comments)
https://gerrit.ovirt.org/#/c/36701/4/vdsm/virt/migration.py
File
Francesco Romani has posted comments on this change.
Change subject: [WIP]Use jsonrpc during migration of vms
..
Patch Set 4:
(5 comments)
not sure all the comments (mine and from other reviewers) in v3 are been
addressed.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: [WIP]Use jsonrpc during migration of vms
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16478/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: RFE: Report downtime for each live migration
..
Patch Set 8:
Build Failed
Dan Kenigsberg has submitted this change and it was merged.
Change subject: network: order 'ipv4' before 'ipv6' and rename 'blocking' to
'blockingdhcp'
..
network: order 'ipv4' before 'ipv6' and rename 'blocking' to
Francesco Romani has posted comments on this change.
Change subject: packaging: bump libvirt requirements
..
Patch Set 2:
Quickly verified with no issues on F21 and on RHEL7.1 - needs another check on
the letter.
--
To
Michal Skrivanek has posted comments on this change.
Change subject: packaging: bump libvirt requirements
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/38538/2/vdsm.spec.in
File vdsm.spec.in:
Line 195: %if
Shahar Havivi has posted comments on this change.
Change subject: packaging: bump libvirt requirements
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/38538
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: getVMList: using internal function instead of vm.status
..
Patch Set 2:
Build Successful
Dan Kenigsberg has posted comments on this change.
Change subject: ifcfg: use IpConfig in _createConfFile instead of its namedtuple
..
Patch Set 9: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/37794
To
Dan Kenigsberg has submitted this change and it was merged.
Change subject: ifcfg: use IpConfig in _createConfFile instead of its namedtuple
..
ifcfg: use IpConfig in _createConfFile instead of its namedtuple
Note that
Dan Kenigsberg has submitted this change and it was merged.
Change subject: ifcfg: stop using IpConfig's namedtuple altogether
..
ifcfg: stop using IpConfig's namedtuple altogether
Change-Id:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: models: remove IpConfig's namedtuple (NetDevice.ipConfig)
..
models: remove IpConfig's namedtuple (NetDevice.ipConfig)
Change-Id:
Francesco Romani has posted comments on this change.
Change subject: vm: do not poll for scheduler parameters
..
Patch Set 2:
Thanks Martin, I didn't know about that. I'll do explicit check, and take
countermeasures in code
oVirt Jenkins CI Server has posted comments on this change.
Change subject: hostdev: fix creation and deletion of multiple udev rules
..
Patch Set 6:
Build Successful
Dan Kenigsberg has posted comments on this change.
Change subject: ifcfg: stop reading from NetDevice.ipConfig namedtuple in
_getIfaceConfValues
..
Patch Set 7: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/37793
Shahar Havivi has posted comments on this change.
Change subject: v2v: Convert VM from external source to Data Domain
..
Patch Set 8:
Need to add unit test
--
To view, visit https://gerrit.ovirt.org/37509
To unsubscribe,
Yaniv Bronhaim has posted comments on this change.
Change subject: v2v: Convert VM from external source to Data Domain
..
Patch Set 8: Code-Review-1
(1 comment)
please try and see if proc.blocking helps to remove the sleep
oVirt Jenkins CI Server has posted comments on this change.
Change subject: lvm: Enhance changelv function to fix option repeated error
..
Patch Set 5:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16493/
Martin Polednik has posted comments on this change.
Change subject: hostdev: remove rom, file and bar settings from API
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/38551/2/vdsm/rpc/vdsmapi-schema.json
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: v2v: Convert VM from external source to Data Domain
..
Patch Set 9:
Build Failed
Dan Kenigsberg has posted comments on this change.
Change subject: getAllVmStats: failing to parse vmids
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/38546
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: hostdev: remove rom, file and bar settings from API
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16484/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: packaging: bump libvirt requirements
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el7_created/568/ :
Francesco Romani has posted comments on this change.
Change subject: hostdev: remove rom, file and bar settings from API
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/38551
To unsubscribe, visit
Martin Polednik has abandoned this change.
Change subject: hostdev: add check for hostdev passthrough to caps
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/30471
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Move NUMA collecting code to stats thread
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16485/ : SUCCESS
Francesco Romani has posted comments on this change.
Change subject: hostdev: remove rom, file and bar settings from API
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/38551/2/vdsm/rpc/vdsmapi-schema.json
File
Martin Polednik has posted comments on this change.
Change subject: hostdev: remove rom, file and bar settings from API
..
Patch Set 2: Verified+1
works as before (apart from rom/file/bar)
--
To view, visit
Adam Litke has posted comments on this change.
Change subject: block: use the contextmanager for getVolumeMetadataSlot
..
Patch Set 6: -Code-Review
--
To view, visit https://gerrit.ovirt.org/25988
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: block: use the contextmanager for getVolumeMetadataSlot
..
Patch Set 6: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/25988
To unsubscribe, visit
Adam Litke has uploaded a new change for review.
Change subject: clusterLock: Make inquire retval consistent
..
clusterLock: Make inquire retval consistent
Callers of clusterLock.inquire() expect a tuple with two values to be
Francesco Romani has posted comments on this change.
Change subject: getAllVmStats: failing to parse vmids
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/38546
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: getAllVmStats: failing to parse vmids
..
getAllVmStats: failing to parse vmids
Bug-Url: https://bugzilla.redhat.com/1196735
Change-Id:
Martin Polednik has posted comments on this change.
Change subject: hostdev: fix creation and deletion of multiple udev rules
..
Patch Set 8: Verified+1
--
To view, visit https://gerrit.ovirt.org/38208
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: getAllVmStats: failing to parse vmids
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el6-x86_64_merged/182/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: network: support PCI passthrough of SR-IOV network interfaces.
..
Patch Set 9:
Build Successful
1 - 100 of 139 matches
Mail list logo
