Francesco Romani has posted comments on this change. Change subject: asyncore: Move ssl buffer handling to dispatcher ......................................................................
Patch Set 9: Code-Review-1 (2 comments) couple of questions inside for my understanding, -1 for visibility only https://gerrit.ovirt.org/#/c/37097/9/lib/yajsonrpc/betterAsyncore.py File lib/yajsonrpc/betterAsyncore.py: Line 92: self.handle_connect_event() Line 93: Line 94: self.handle_read() Line 95: Line 96: if hasattr(self.socket, "pending"): can you please remind me when does the socket not have the "pending" attribute? and when it does? Line 97: while self.socket.pending() > 0: Line 98: self.handle_read() Line 99: Line 100: def recv(self, buffer_size): https://gerrit.ovirt.org/#/c/37097/9/lib/yajsonrpc/stomp.py File lib/yajsonrpc/stomp.py: Line 416: return Line 417: Line 418: parser = self._parser Line 419: Line 420: if data is not None: what will happen if parser is fed with None? Line 421: parser.parse(data) Line 422: Line 423: frameHandler = self._frameHandler Line 424: if hasattr(frameHandler, "handle_frame"): -- To view, visit https://gerrit.ovirt.org/37097 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id5b75c8cdcaf1ddb63b499619153c4df4772af4d Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
