Ido Barkan has posted comments on this change.
Change subject: More logging for missing nics.
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/41782/4/vdsm/network/models.py
File vdsm/network/models.py:
Line 87:
automat...@ovirt.org has posted comments on this change.
Change subject: net: during boot, restore only networks that were actually
changed.
..
Patch Set 2:
* Update tracker::#1203422::OK
* Check Bug-Url::OK
* Check Public
automat...@ovirt.org has posted comments on this change.
Change subject: net: tests: wrap setupNetworks calls
..
Patch Set 2: Verified-1
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::ERROR, At least one bug-url
automat...@ovirt.org has posted comments on this change.
Change subject: net: tests: do not use KernelConfig.__eq__ in tests
..
Patch Set 2: Verified-1
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::ERROR, At
automat...@ovirt.org has posted comments on this change.
Change subject: net: introducing KernelConfig
..
Patch Set 2:
* Update tracker::#1203422::OK
* Check Bug-Url::OK
* Check Public Bug::#1203422::OK, public bug
* Check
automat...@ovirt.org has posted comments on this change.
Change subject: net: tests: only test kernel config if unified persistence
..
Patch Set 2:
* Update tracker::#1203422::OK
* Check Bug-Url::OK
* Check Public
automat...@ovirt.org has posted comments on this change.
Change subject: net: ifcfg: ONBOOT=yes on all persisted network files.
..
Patch Set 2:
* Update tracker::#1203422::OK
* Check Bug-Url::OK
* Check Public
automat...@ovirt.org has posted comments on this change.
Change subject: net: Drop default bonding options
..
Patch Set 2: Verified-1
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::ERROR, At least one bug-url is
automat...@ovirt.org has posted comments on this change.
Change subject: Move _stpBooleanize to netinfo.
..
Patch Set 3:
* Update tracker::#1203422::OK
* Check Bug-Url::OK
* Check Public Bug::#1203422::OK, public bug
* Check
automat...@ovirt.org has posted comments on this change.
Change subject: net: during boot, restore only networks that were actually
changed.
..
Patch Set 3:
* Update tracker::#1203422::OK
* Check Bug-Url::OK
* Check Public
automat...@ovirt.org has posted comments on this change.
Change subject: net: Drop default bonding options
..
Patch Set 3:
* Update tracker::#1203422::OK
* Check Bug-Url::OK
* Check Public Bug::#1203422::OK, public bug
* Check
automat...@ovirt.org has posted comments on this change.
Change subject: net: reset bonding options to defaults.
..
Patch Set 3:
* Update tracker::#1203422::OK
* Check Bug-Url::OK
* Check Public Bug::#1203422::OK, public bug
*
automat...@ovirt.org has posted comments on this change.
Change subject: net: ifcfg: ONBOOT=yes on all persisted network files.
..
Patch Set 3:
* Update tracker::#1203422::OK
* Check Bug-Url::OK
* Check Public
automat...@ovirt.org has posted comments on this change.
Change subject: net: introducing KernelConfig
..
Patch Set 3:
* Update tracker::#1203422::OK
* Check Bug-Url::OK
* Check Public Bug::#1203422::OK, public bug
* Check
automat...@ovirt.org has posted comments on this change.
Change subject: v2v: add mount windows iso drivers
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/42358
To
Dan Kenigsberg has posted comments on this change.
Change subject: hook: diskunmap: To include UNMAP support for disk and lun
devices
..
Patch Set 7: Code-Review+2
(1 comment)
raising score
Dan Kenigsberg has submitted this change and it was merged.
Change subject: hook: diskunmap: To include UNMAP support for disk and lun
devices
..
hook: diskunmap: To include UNMAP support for disk and lun devices
This hook
automat...@ovirt.org has posted comments on this change.
Change subject: jsonrpc: vdscli: return raw error description
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: jsonrpc: vdscli: migration: fix migrationCreate
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: gluster: Verify volume is Replica 3
..
Patch Set 41:
* Update tracker::#1123052::OK
* Check Bug-Url::OK
* Check Public Bug::#1123052::OK, public bug
*
Francesco Romani has posted comments on this change.
Change subject: tests: Record fake domain calls in a list
..
Patch Set 1: Code-Review+1
codewise I'm OK. Designwise, we're slowly transforming our fake in mocks :)
--
To
Nir Soffer has posted comments on this change.
Change subject: gluster:refactor: Refactor GlusterFSConnection class
..
Patch Set 3: Code-Review+1
(1 comment)
Nice
https://gerrit.ovirt.org/#/c/42952/3//COMMIT_MSG
Commit
automat...@ovirt.org has posted comments on this change.
Change subject: Fix logging in LiveMergeCleanupThread
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Adam Litke has uploaded a new change for review.
Change subject: Fix logging in LiveMergeCleanupThread
..
Fix logging in LiveMergeCleanupThread
The log object is located in the vm object, not in the
LiveMergeCleanupThread.
Amador Pahim has posted comments on this change.
Change subject: hook: diskunmap: To include UNMAP support for disk and lun
devices
..
Patch Set 7:
(1 comment)
Arik Hadas has posted comments on this change.
Change subject: v2v: enable to use external virtio drivers for virtio
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/42996
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: jsonrpc: vdscli: migration: fix migrationCreate
..
Patch Set 2: Verified+1
verified doing a couple of succesfull migrations
--
To view, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: fix functional test graphics device for ppc64le
..
virt: fix functional test graphics device for ppc64le
The functional tests use qxl graphics
Dan Kenigsberg has posted comments on this change.
Change subject: virt: fix functional test graphics device for ppc64le
..
Patch Set 1: Code-Review+2
raising score
--
To view, visit https://gerrit.ovirt.org/42727
To
automat...@ovirt.org has posted comments on this change.
Change subject: virt: fix functional test graphics device for ppc64le
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url
Shahar Havivi has uploaded a new change for review.
Change subject: v2v: enable to use external virtio drivers for virtio
..
v2v: enable to use external virtio drivers for virtio
virt-v2v new feature enable user to set drivers
automat...@ovirt.org has posted comments on this change.
Change subject: supervdsm: Add zombiereaper to supervdsm
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: tests: Record fake domain calls in a list
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Nir Soffer has uploaded a new change for review.
Change subject: tests: Record fake domain calls in a list
..
tests: Record fake domain calls in a list
Keeping calls in a list allows testing of multiple calls. We can check
how
Francesco Romani has posted comments on this change.
Change subject: jsonrpc: vdscli: return raw error description
..
Patch Set 2: Verified+1
verified injecting failure on destination side (forcing vm.migrationCreate to
fail
Ala Hino has posted comments on this change.
Change subject: gluster:refactor: Refactor GlusterFSConnection class
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/42952/1/vdsm/storage/storageServer.py
File
automat...@ovirt.org has posted comments on this change.
Change subject: gluster:refactor: Refactor GlusterFSConnection class
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Ala Hino has posted comments on this change.
Change subject: gluster: Verify volume is Replica 3
..
Patch Set 41: Verified+1
--
To view, visit https://gerrit.ovirt.org/41931
To unsubscribe, visit
Ala Hino has posted comments on this change.
Change subject: gluster:refactor: Refactor GlusterFSConnection class
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/42952
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: virt: use new mocking in hostdevTests
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/40905/3/tests/hostdevTests.py
File tests/hostdevTests.py:
Line
Dan Kenigsberg has posted comments on this change.
Change subject: net: tests: only test kernel config if unified persistence
..
Patch Set 3: Code-Review-1
Please post on master branch first.
--
To view, visit
Dan Kenigsberg has posted comments on this change.
Change subject: net: tests: wrap setupNetworks calls
..
Patch Set 3: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/42957/3/tests/functional/utils.py
File
Nir Soffer has posted comments on this change.
Change subject: gluster: Verify volume is Replica 3
..
Patch Set 41: Code-Review+1
This is so much nicer now!
--
To view, visit https://gerrit.ovirt.org/41931
To unsubscribe,
Anton Marchukov has posted comments on this change.
Change subject: Fixed scratchpad hook's image permissions and virtio device name
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/42573
To unsubscribe,
automat...@ovirt.org has posted comments on this change.
Change subject: Fixed scratchpad hook's image permissions and virtio device name
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug
Francesco Romani has posted comments on this change.
Change subject: Fixed scratchpad hook's image permissions and virtio device name
..
Patch Set 3:
(1 comment)
Shahar Havivi has abandoned this change.
Change subject: v2v: add mount windows iso drivers
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/42358
To unsubscribe, visit https://gerrit.ovirt.org/settings
automat...@ovirt.org has posted comments on this change.
Change subject: v2v: enable to use external virtio drivers for virtio
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Dan Kenigsberg has posted comments on this change.
Change subject: hook: diskunmap: To include UNMAP support for disk and lun
devices
..
Patch Set 7: Continuous-Integration+1
--
To view, visit https://gerrit.ovirt.org/29770
automat...@ovirt.org has posted comments on this change.
Change subject: hook: diskunmap: To include UNMAP support for disk and lun
devices
..
Patch Set 8:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no
Nir Soffer has posted comments on this change.
Change subject: gluster: Verify volume is Replica 3
..
Patch Set 40:
(1 comment)
https://gerrit.ovirt.org/#/c/41931/40/vdsm/storage/storageServer.py
File
Nir Soffer has posted comments on this change.
Change subject: tests: Record fake domain calls in a list
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/42998
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: net: bondingOptions should not be a part of runningConfig
networks
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/42146
To
Dan Kenigsberg has posted comments on this change.
Change subject: net: missing Exception formatting value
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/42955
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: Move _stpBooleanize to netinfo.
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/42956
To unsubscribe, visit
Francesco Romani has abandoned this change.
Change subject: lib: jsonrpc: add function to copy responses
..
Abandoned
obsoleted by last changes in 42969 (response.error_raw)
--
To view, visit https://gerrit.ovirt.org/42971
automat...@ovirt.org has posted comments on this change.
Change subject: lib: jsonrpc: add function to copy responses
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
--
To view, visit
Ala Hino has posted comments on this change.
Change subject: gluster: Verify volume is Replica 3
..
Patch Set 40:
(2 comments)
https://gerrit.ovirt.org/#/c/41931/40/tests/storageServerTests.py
File
Martin Polednik has posted comments on this change.
Change subject: tests: Record fake domain calls in a list
..
Patch Set 1: Code-Review-1
I'll play the opposite role: I don't have any issue with the code as is, but I
Dan Kenigsberg has posted comments on this change.
Change subject: virt: use new mocking in hostdevTests
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/40905
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: Fixed scratchpad hook's image permissions and virtio device name
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/42573
To
Anton Marchukov has posted comments on this change.
Change subject: Fixed scratchpad hook's image permissions and virtio device name
..
Patch Set 3:
Updated the README with information than non-virtio systems are not
Francesco Romani has posted comments on this change.
Change subject: executor: allow caller to resize TaskQueue
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/41658/6/lib/vdsm/executor.py
File lib/vdsm/executor.py:
Vinzenz Feenstra has posted comments on this change.
Change subject: virt: Only filter guest agent data, only on XMLRPC
..
Patch Set 13:
(1 comment)
https://gerrit.ovirt.org/#/c/36949/13/vdsm/rpc/bindingxmlrpc.py
File
automat...@ovirt.org has posted comments on this change.
Change subject: net: missing Exception formatting value
..
Patch Set 3: -Verified
* Update tracker::#1203422::OK
* Check Bug-Url::OK
* Check Public Bug::#1203422::OK,
automat...@ovirt.org has posted comments on this change.
Change subject: net: tests: wrap setupNetworks calls
..
Patch Set 3:
* Update tracker::#1203422::OK
* Check Bug-Url::OK
* Check Public Bug::#1203422::OK, public bug
*
Martin Polednik has posted comments on this change.
Change subject: virt: fix functional test graphics device for ppc64le
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/42727/1/tests/functional/virtTests.py
File
Dan Kenigsberg has posted comments on this change.
Change subject: virt: use new mocking in hostdevTests
..
Patch Set 4:
unrelated failure
DEBUG util.py:378:
Francesco Romani has posted comments on this change.
Change subject: executor: allow caller to resize TaskQueue
..
Patch Set 9: Code-Review-1
must address Nir's comment in v6
--
To view, visit https://gerrit.ovirt.org/41658
automat...@ovirt.org has posted comments on this change.
Change subject: virt: don't log password in update graphic device
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Francesco Romani has posted comments on this change.
Change subject: virt: don't log password in update graphic device
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/41073/1/vdsm/rpc/BindingXMLRPC.py
File
automat...@ovirt.org has posted comments on this change.
Change subject: virt: don't log password in update graphic device
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Francesco Romani has posted comments on this change.
Change subject: virt: Only filter guest agent data, only on XMLRPC
..
Patch Set 13: Code-Review+1
(1 comment)
automat...@ovirt.org has posted comments on this change.
Change subject: Move _stpBooleanize to netinfo.
..
Patch Set 2: Verified-1
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::ERROR, At least one bug-url is
automat...@ovirt.org has posted comments on this change.
Change subject: net: reset bonding options to defaults.
..
Patch Set 2: Verified-1
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::ERROR, At least one
automat...@ovirt.org has posted comments on this change.
Change subject: net: bondingOptions should not be a part of runningConfig
networks
..
Patch Set 3: Verified-1
* Update tracker::IGNORE, no Bug-Url found
* Check
automat...@ovirt.org has posted comments on this change.
Change subject: net: missing Exception formatting value
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::ERROR, At least one bug-url is
Timothy Asir has posted comments on this change.
Change subject: gluster: create pv with custom dataalignment value
..
Patch Set 5: Verified+1
--
To view, visit https://gerrit.ovirt.org/42782
To unsubscribe, visit
automat...@ovirt.org has posted comments on this change.
Change subject: gluster: create pv with custom dataalignment value
..
Patch Set 5:
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1225831::ERROR, private
automat...@ovirt.org has posted comments on this change.
Change subject: lib: jsonrpc: add function to copy responses
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
automat...@ovirt.org has posted comments on this change.
Change subject: jsonrpc: vdscli: migration: fix migrationCreate
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
Martin Polednik has posted comments on this change.
Change subject: virt: use new mocking in hostdevTests
..
Patch Set 4: Verified+1
Verified manually, but jenkins would be awesome to have.
--
To view, visit
Ido Barkan has posted comments on this change.
Change subject: net: Drop default bonding options
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/42959
To unsubscribe, visit
Ido Barkan has posted comments on this change.
Change subject: net: tests: only test kernel config if unified persistence
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/42964
To unsubscribe, visit
Ido Barkan has posted comments on this change.
Change subject: net: ifcfg: ONBOOT=yes on all persisted network files.
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/42962
To unsubscribe, visit
Ido Barkan has posted comments on this change.
Change subject: net: introducing KernelConfig
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/42960
To unsubscribe, visit https://gerrit.ovirt.org/settings
Ido Barkan has posted comments on this change.
Change subject: net: during boot, restore only networks that were actually
changed.
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/42961
To unsubscribe,
Ido Barkan has posted comments on this change.
Change subject: net: reset bonding options to defaults.
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/42958
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: gluster:refactor: Refactor GlusterFSConnection class
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/42952/1/vdsm/storage/storageServer.py
File
Martin Polednik has posted comments on this change.
Change subject: virt: use new mocking in hostdevTests
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/40905/3/tests/hostdevTests.py
File tests/hostdevTests.py:
Martin Sivák has posted comments on this change.
Change subject: Balloon should not work when guest agent is not present
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/42968
To unsubscribe, visit
automat...@ovirt.org has posted comments on this change.
Change subject: Revert node hack to avoid searching for libvirt upstart script
..
Patch Set 2: -Verified
* Update tracker::#1236489::OK
* Check Bug-Url::OK
* Check
automat...@ovirt.org has posted comments on this change.
Change subject: net: tests: do not use KernelConfig.__eq__ in tests
..
Patch Set 3:
* Update tracker::#1203422::OK
* Check Bug-Url::OK
* Check Public Bug::#1203422::OK,
Ido Barkan has posted comments on this change.
Change subject: Move _stpBooleanize to netinfo.
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/42956
To unsubscribe, visit
Ido Barkan has posted comments on this change.
Change subject: net: tests: wrap setupNetworks calls
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/42957
To unsubscribe, visit
Ido Barkan has posted comments on this change.
Change subject: net: bondingOptions should not be a part of runningConfig
networks
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/42146
To unsubscribe,
Ido Barkan has posted comments on this change.
Change subject: net: missing Exception formatting value
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/42955
To unsubscribe, visit
Ido Barkan has posted comments on this change.
Change subject: net: tests: do not use KernelConfig.__eq__ in tests
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/42963
To unsubscribe, visit
automat...@ovirt.org has posted comments on this change.
Change subject: net: bondingOptions should not be a part of runningConfig
networks
..
Patch Set 4:
* Update tracker::#1203422::OK
* Check Bug-Url::OK
* Check Public
automat...@ovirt.org has posted comments on this change.
Change subject: net: tests: only test kernel config if unified persistence
..
Patch Set 3:
* Update tracker::#1203422::OK
* Check Bug-Url::OK
* Check Public
1 - 100 of 196 matches
Mail list logo
