Vinzenz Feenstra has posted comments on this change. Change subject: virt: Only filter guest agent data, only on XMLRPC ......................................................................
Patch Set 13: (1 comment) https://gerrit.ovirt.org/#/c/36949/13/vdsm/rpc/bindingxmlrpc.py File vdsm/rpc/bindingxmlrpc.py: Line 506: return api.getStats() Line 507: Line 508: def vmGetStats(self, vmId): Line 509: vm = API.VM(vmId) Line 510: return vm._getStats(filtered=True) > I don't like this. Calling private function is a greater evil than add this well the reason for this is, as I already previously said, that we've added this way, to prevent problems with the jsonrpc implementation. When we stop supporting XMLRPC all together with ovirt 4.0 then we could get rid of this all together including all the filtering parameters Line 511: Line 512: def getAllVmStats(self): Line 513: api = API.Global() Line 514: return api._getAllVmStats(filtered=True) -- To view, visit https://gerrit.ovirt.org/36949 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9ee2a8f1cc6784c619ce68da3cb9342b0d72cfc Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
