Milan Zamazal has posted comments on this change.
Change subject: virt: do not use status after getStat()
..
Patch Set 15: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/40522
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: tests: refactor manifest_tests fake env setup
..
Patch Set 1: Verified+1
This patch only affects tests. Verified by running the manifest_tests.
--
To view,
Dan Kenigsberg has posted comments on this change.
Change subject: Add vmfex-dev hook to default RPMs for install
..
Patch Set 1: Code-Review-1
Please first backport Iebc2e345877ff704b16af611edda404e2b773528 first and
include
gerrit-hooks has posted comments on this change.
Change subject: vdsm standard CI arrangement
..
Patch Set 25:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Adam Litke has posted comments on this change.
Change subject: storage: add a context manager for the domainLock
..
Patch Set 1: Verified+1
Verified by running unit tests. This is new code so there are not yet any
users.
--
gerrit-hooks has posted comments on this change.
Change subject: Makefile: use tox to run make pep8 and pyflakes
..
Patch Set 3:
* #1182088::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1182088::OK, public bug
*
gerrit-hooks has posted comments on this change.
Change subject: vdsm.conf: Add drop-in dir
..
Patch Set 5:
* #1279555::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1279555::OK, public bug
* Check
Francesco Romani has posted comments on this change.
Change subject: virt: Add support for vgamem attribute
..
Patch Set 2: -Code-Review
temporary changing score to highlight Nir's comments about the schema. Other
than that
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: sampling: reduce host averaging window
..
virt: sampling: reduce host averaging window
Host samples are stored into a SampleWindow of
size 5 for
gerrit-hooks has posted comments on this change.
Change subject: virt: sampling: reduce host averaging window
..
Patch Set 2:
* #1261457::Update tracker: OK
* Set MODIFIED::bug 1261457#1261457OK
--
To view, visit
Dan Kenigsberg has posted comments on this change.
Change subject: net: clean CachingNetInfo API.
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/4
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: net: clean CachingNetInfo API.
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: clean CachingNetInfo API.
..
net: clean CachingNetInfo API.
The object should have a clean API regarding its cache changes.
Change-Id:
gerrit-hooks has posted comments on this change.
Change subject: net: rename NetInfo to CachingNetInfo
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Dan Kenigsberg has posted comments on this change.
Change subject: net: rename NetInfo to CachingNetInfo
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/49998
To unsubscribe, visit
Vinzenz Feenstra has posted comments on this change.
Change subject: virt: Forcibly unregister fds with errors from epoll
..
Patch Set 9:
(5 comments)
https://gerrit.ovirt.org/#/c/42570/9/vdsm/virt/vmchannels.py
File
Fabian Deutsch has abandoned this change.
Change subject: vdsm-tool: Ensure that the vdsm uuid is a string
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/46970
To unsubscribe, visit https://gerrit.ovirt.org/settings
gerrit-hooks has posted comments on this change.
Change subject: vdsm-tool: Ensure that the vdsm uuid is a string
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/46970
To
Francesco Romani has posted comments on this change.
Change subject: executor: Rename self._callabale to self._task
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/50228/1//COMMIT_MSG
Commit Message:
Line 3:
gerrit-hooks has posted comments on this change.
Change subject: Makefile: use tox to run make pep8 and pyflakes
..
Patch Set 2:
* #1182088::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1182088::OK, public bug
*
Dan Kenigsberg has posted comments on this change.
Change subject: Remove koji build flag and use specific one for vhostmd
..
Patch Set 3: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/49427/3/configure.ac
File
gerrit-hooks has posted comments on this change.
Change subject: Adding to vdsm automation lago env setup for functional tests
..
Patch Set 19:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: rename NetInfo to CachingNetInfo
..
net: rename NetInfo to CachingNetInfo
This explains more of what it should do- caching network information.
gerrit-hooks has posted comments on this change.
Change subject: v2v: test get_ova_info with tar zip and dir format
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: Adding to vdsm automation lago env setup for functional tests
..
Patch Set 18:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
Ala Hino has posted comments on this change.
Change subject: gluster: Warn instead of failing for unsupported gluster
replica modes
..
Patch Set 8:
(1 comment)
Nir Soffer has posted comments on this change.
Change subject: virt: vm: Update time on VM after resume
..
Patch Set 7:
Milan, can you document the delay (if qemu-guest-agent is not installed) in the
commit message and
Nir Soffer has posted comments on this change.
Change subject: vdsm standard CI arrangement
..
Patch Set 25: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/48268/25/automation/check-merged.sh
File
Nir Soffer has posted comments on this change.
Change subject: gluster: Warn instead of failing for unsupported gluster
replica modes
..
Patch Set 1:
Ala, correction, why gerrit hooks are unhappy.
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: code coverage: change approach how to enable it
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/50263
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: gluster: Warn instead of failing for unsupported gluster
replica modes
..
Patch Set 1: Code-Review-1
Gerrit is not happy because you uploaded this when the master
Nir Soffer has posted comments on this change.
Change subject: gluster: Warn instead of failing for unsupported gluster
replica modes
..
Patch Set 1: Code-Review+1
Ala, please check why jenkins in unhappy.
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: properties: Add properties module
..
Patch Set 6:
(8 comments)
https://gerrit.ovirt.org/#/c/40822/6/lib/vdsm/properties.py
File lib/vdsm/properties.py:
Line 119:
Nir Soffer has posted comments on this change.
Change subject: storage: perform image deletion in task
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/48477/4/vdsm/storage/fileSD.py
File vdsm/storage/fileSD.py:
Line
Nir Soffer has posted comments on this change.
Change subject: v2v: Use tarfile instead of running tar process
..
Patch Set 4: Code-Review+2
Waiting for the test patch.
--
To view, visit https://gerrit.ovirt.org/50106
To
Nir Soffer has posted comments on this change.
Change subject: v2v: refactor get_external_vms
..
Patch Set 3: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/49636/3/vdsm/v2v.py
File vdsm/v2v.py:
Line 641: for vm
Nir Soffer has posted comments on this change.
Change subject: spec: Align RHEL and CentOS qemu* requiments
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/49974
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: v2v: test get_ova_info with tar zip and dir format
..
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/50158/4/tests/v2vTests.py
File tests/v2vTests.py:
Nir Soffer has posted comments on this change.
Change subject: build: Align Fedora and EL qemu requirements
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/50071
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: spec: Align RHEL and CentOS qemu* requiments
..
Patch Set 5:
* #1248400::Update tracker: OK
* Set MODIFIED::bug 1248400#1248400OK
--
To view, visit
Nir Soffer has submitted this change and it was merged.
Change subject: spec: Align RHEL and CentOS qemu* requiments
..
spec: Align RHEL and CentOS qemu* requiments
Since qemu-kvm-ev-2.3 is now build by the oVirt project,
Nir Soffer has posted comments on this change.
Change subject: v2v: externalVMList Xen+Kvm support
..
Patch Set 17: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/48672
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: virt: Add support for vgamem attribute
..
Patch Set 3: Code-Review+2
Can we have another review?
--
To view, visit https://gerrit.ovirt.org/50091
To unsubscribe,
Nir Soffer has posted comments on this change.
Change subject: Makefile: use tox to run make pep8 and pyflakes
..
Patch Set 3:
(6 comments)
Nice, just need to cleanup up the tabs and fix the quoting.
gerrit-hooks has posted comments on this change.
Change subject: build: Align Fedora and EL qemu requirements
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
Nir Soffer has posted comments on this change.
Change subject: storage: add a context manager for the domainLock
..
Patch Set 1: Code-Review-1
(3 comments)
Nice, the tests can be simplified.
Jenkins CI has posted comments on this change.
Change subject: vdsm standard CI arrangement
..
Patch Set 20: Continuous-Integration+1
Propagate review hook: Continuous Integration value inherited from patch 18
--
To view,
gerrit-hooks has posted comments on this change.
Change subject: vdsm standard CI arrangement
..
Patch Set 21:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Francesco Romani has posted comments on this change.
Change subject: vdsm: introduce cpuinfo module
..
Patch Set 16: Code-Review+1
(2 comments)
https://gerrit.ovirt.org/#/c/46912/16//COMMIT_MSG
Commit Message:
Line 12: more
Piotr Kliczewski has posted comments on this change.
Change subject: executor: Rename self._callabale to self._task
..
Patch Set 1:
I am would change this otherwise. Form jsonrpc perspective it is not a task but
callable. I
Ido Barkan has posted comments on this change.
Change subject: api: support multiple 'ipv6addrs' per network
..
Patch Set 10:
(1 comment)
https://gerrit.ovirt.org/#/c/39307/10/vdsm/rpc/vdsmapi-schema.json
File
gerrit-hooks has posted comments on this change.
Change subject: hooks: ovs: use a class instead of NamedTuple for IPConfig
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Jenkins CI has posted comments on this change.
Change subject: vdsm standard CI arrangement
..
Patch Set 21:
Propagate review hook: Continuous Integration value inherited from patch 19
--
To view, visit
Piotr Kliczewski has posted comments on this change.
Change subject: netinfo: report whether the kernel supports IPv6
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/50126
To unsubscribe, visit
Ido Barkan has posted comments on this change.
Change subject: sourceroute: move exception handling to the respective
configurator
..
Patch Set 5:
was this patch dead for 6 months?
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: lib: executor: report worker status in __repr__
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/49722/3/lib/vdsm/executor.py
File lib/vdsm/executor.py:
Ido Barkan has posted comments on this change.
Change subject: hooks: ovs: drop initial bonds' slaves IP config
..
Patch Set 3: Code-Review-1
(1 comment)
gerrit-hooks has posted comments on this change.
Change subject: init: configure multipath on upgrade from ovirt-3.3 and 3.4
..
Patch Set 2: -Verified
* #1290372::Update tracker: OK
* Check Bug-Url::OK
* Check Public
Nir Soffer has posted comments on this change.
Change subject: vdsm standard CI arrangement
..
Patch Set 23: Code-Review-2
The ci is fragile today, this can make it even worse, slowing us down.
This should be added as daily
gerrit-hooks has posted comments on this change.
Change subject: net: Mapping bonding option value names to numerics
..
Patch Set 14:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
Piotr Kliczewski has posted comments on this change.
Change subject: move hooks.py under lib/vdsm
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/50173
To unsubscribe, visit
Amit Aviram has uploaded a new change for review.
Change subject: fileSD,blockSD: typo fix in createImageLinks comment.
..
fileSD,blockSD: typo fix in createImageLinks comment.
Change-Id:
gerrit-hooks has posted comments on this change.
Change subject: fileSD,blockSD: typo fix in createImageLinks comment.
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: vdsm standard CI arrangement
..
Patch Set 22:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Jenkins CI has posted comments on this change.
Change subject: vdsm standard CI arrangement
..
Patch Set 23: Continuous-Integration-1
Propagate review hook: Continuous Integration value inherited from patch 22
--
To view,
Francesco Romani has posted comments on this change.
Change subject: nettestlib: use cpuarch module
..
Patch Set 1: Code-Review+1
trivial changes
--
To view, visit https://gerrit.ovirt.org/49992
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: nettestlib: add ppc64le TUNSETIFF value
..
Patch Set 9: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/46955
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: nettestlib: add ppc64le TUNSETIFF value
..
Patch Set 9:
copied score from past revision (v3)
--
To view, visit https://gerrit.ovirt.org/46955
To
Francesco Romani has posted comments on this change.
Change subject: caps: use cpuarch module
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/49991
To unsubscribe, visit
Michal Skrivanek has posted comments on this change.
Change subject: virt: vm: Update time on VM after resume
..
Patch Set 7: Code-Review-1
(1 comment)
I don't want to get stuck for 5s when agent is not there. Any solution
Nir Soffer has posted comments on this change.
Change subject: API: Add api for getting host jobs info
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/49451/1/lib/api/vdsmapi-schema.json
File
Nir Soffer has posted comments on this change.
Change subject: executor: Rename self._callabale to self._task
..
Patch Set 1:
Piotr, jsonrpc point of view is not relevant the internals of the executor. The
executor manage a
gerrit-hooks has posted comments on this change.
Change subject: vdsm standard CI arrangement
..
Patch Set 20:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: vdsm standard CI arrangement
..
Patch Set 23:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Yeela Kaplan has posted comments on this change.
Change subject: init: configure multipath on upgrade from ovirt-3.3 and 3.4
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/49510
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: vdsm: introduce cpuinfo module
..
Patch Set 16:
(1 comment)
https://gerrit.ovirt.org/#/c/46912/16/lib/vdsm/cpuinfo.py
File lib/vdsm/cpuinfo.py:
Line 18: #
Piotr Kliczewski has posted comments on this change.
Change subject: API: Add api for getting host jobs info
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/49451/1/lib/api/vdsmapi-schema.json
File
gerrit-hooks has posted comments on this change.
Change subject: net: Mapping bonding option value names to numerics
..
Patch Set 15:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
Edward Haas has posted comments on this change.
Change subject: Add vmfex-dev hook to default RPMs for install
..
Patch Set 1:
Please add the bug number in the commit.
--
To view, visit https://gerrit.ovirt.org/50270
To
gerrit-hooks has posted comments on this change.
Change subject: build: Add dependencies for generated .py files
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Nir Soffer has posted comments on this change.
Change subject: build: Add dependencies for generated .py files
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/50299
To unsubscribe, visit
Nir Soffer has uploaded a new change for review.
Change subject: build: Add dependencies for generated .py files
..
build: Add dependencies for generated .py files
In the past we checked .py.in files with pep8 and pyflakes.
Jenkins CI has posted comments on this change.
Change subject: build: Add dependencies for generated .py files
..
Patch Set 2: Continuous-Integration+1
Propagate review hook: Continuous Integration value inherited from patch 1
gerrit-hooks has posted comments on this change.
Change subject: build: Add dependencies for generated .py files
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: executor: Fix the task-callable mismtach
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: net: Mapping bonding option value names to numerics
..
Patch Set 17:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: ovs: super: tests: draft
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
Nir Soffer has posted comments on this change.
Change subject: executor: Fix the task-callable mismtach
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/50228/1//COMMIT_MSG
Commit Message:
Line 3: AuthorDate:
Nir Soffer has posted comments on this change.
Change subject: vdsm standard CI arrangement
..
Patch Set 23: Code-Review-1
Yaniv, how can you run this on the ci when this runs only when merging a patch?
--
To view, visit
Ramesh N has posted comments on this change.
Change subject: gluster: fix brick devices are created with incorrect data
alignment
..
Patch Set 3: Code-Review+1 Verified+1
I have manually verified this patch in Fedora 22 and
gerrit-hooks has posted comments on this change.
Change subject: hooks: ovs: use network lib instead of hardcoded path hack
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Yaniv Bronhaim has posted comments on this change.
Change subject: vdsm standard CI arrangement
..
Patch Set 23:
your -2 is redundant, nobody planed to merge it as is. too bad I don't work
with drafts.
anyway, ill send mail
Nir Soffer has posted comments on this change.
Change subject: fileSD,blockSD: typo fix in createImageLinks comment.
..
Patch Set 1: Code-Review+2 Continuous-Integration+1 Verified+1
Thanks
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: fileSD,blockSD: typo fix in createImageLinks comment.
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
Nir Soffer has submitted this change and it was merged.
Change subject: fileSD,blockSD: typo fix in createImageLinks comment.
..
fileSD,blockSD: typo fix in createImageLinks comment.
Change-Id:
Milan Zamazal has posted comments on this change.
Change subject: virt: Add support for vgamem attribute
..
Patch Set 3:
Improved doc in schema.
--
To view, visit https://gerrit.ovirt.org/50091
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: virt: Add support for vgamem attribute
..
Patch Set 3:
* #1275539::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1275539::OK, public bug
* Check
Dan Kenigsberg has submitted this change and it was merged.
Change subject: move hooks.py under lib/vdsm
..
move hooks.py under lib/vdsm
This module is used from within lib/vdsm/network/ files so must not be
located under
gerrit-hooks has posted comments on this change.
Change subject: move hooks.py under lib/vdsm
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Piotr Kliczewski has posted comments on this change.
Change subject: move hooks.py under lib/vdsm
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/50173
To unsubscribe, visit
1 - 100 of 169 matches
Mail list logo