Change in vdsm[master]: migration: Added support for setting the convergenceSchedule

Tomas Jelinek has posted comments on this change. Change subject: migration: Added support for setting the convergenceSchedule .. Patch Set 8: Verified+1 -- To view, visit https://gerrit.ovirt.org/47734 To unsubscribe, visit

Change in vdsm[master]: migration: added support for convergance schedule

Tomas Jelinek has posted comments on this change. Change subject: migration: added support for convergance schedule .. Patch Set 9: Verified+1 -- To view, visit https://gerrit.ovirt.org/46940 To unsubscribe, visit

Change in vdsm[master]: migration added migrateChangeParams verb

Tomas Jelinek has posted comments on this change. Change subject: migration added migrateChangeParams verb .. Patch Set 10: Verified+1 -- To view, visit https://gerrit.ovirt.org/46934 To unsubscribe, visit

Change in vdsm[master]: virt: s/vm._dom.XMLDesc(0)/vm.xml/g

gerrit-hooks has posted comments on this change. Change subject: virt: s/vm._dom.XMLDesc(0)/vm.xml/g .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: migration: Added support for setting the convergenceSchedule

gerrit-hooks has posted comments on this change. Change subject: migration: Added support for setting the convergenceSchedule .. Patch Set 11: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found,

Change in vdsm[master]: migration: added support for convergance schedule

gerrit-hooks has posted comments on this change. Change subject: migration: added support for convergance schedule .. Patch Set 11: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: virt: s/vm._dom.XMLDesc(0)/vm.xml/g

gerrit-hooks has posted comments on this change. Change subject: virt: s/vm._dom.XMLDesc(0)/vm.xml/g .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: virt: s/vm._dom.XMLDesc(0)/vm.xml/g

Martin Betak has posted comments on this change. Change subject: virt: s/vm._dom.XMLDesc(0)/vm.xml/g .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/52882 To unsubscribe, visit

Change in vdsm[master]: virt: s/vm._dom.XMLDesc(0)/vm.xml/g

Martin Betak has posted comments on this change. Change subject: virt: s/vm._dom.XMLDesc(0)/vm.xml/g .. Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/52882/1//COMMIT_MSG Commit Message: Line 10: it's > ... its ...

Change in vdsm[master]: migration: Added support for setting the convergenceSchedule

gerrit-hooks has posted comments on this change. Change subject: migration: Added support for setting the convergenceSchedule .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found,

Change in vdsm[master]: migration: Added support for setting the convergenceSchedule

gerrit-hooks has posted comments on this change. Change subject: migration: Added support for setting the convergenceSchedule .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found,

Change in vdsm[master]: migration: added support for convergance schedule

gerrit-hooks has posted comments on this change. Change subject: migration: added support for convergance schedule .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: virt: s/vm._dom.XMLDesc(0)/vm.xml/g

Martin Betak has uploaded a new change for review. Change subject: virt: s/vm._dom.XMLDesc(0)/vm.xml/g .. virt: s/vm._dom.XMLDesc(0)/vm.xml/g Added small helper property to avoid accessing private state of VM to get it's XML

Change in vdsm[master]: [wip] Dynamic load of supervdsm_api funcs

Yaniv Bronhaim has posted comments on this change. Change subject: [wip] Dynamic load of supervdsm_api funcs .. Patch Set 3: please don't leave your code-review -1 if you don't have any code comments that deserve -1... lets

Change in vdsm[master]: migration: added support for convergance schedule

gerrit-hooks has posted comments on this change. Change subject: migration: added support for convergance schedule .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: migration: Add support for max migration bandwidth setting

gerrit-hooks has posted comments on this change. Change subject: migration: Add support for max migration bandwidth setting .. Patch Set 11: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found,

Change in vdsm[master]: migration: Added support for setting the convergenceSchedule

gerrit-hooks has posted comments on this change. Change subject: migration: Added support for setting the convergenceSchedule .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found,

Change in vdsm[master]: migration: Add support for max migration bandwidth setting

Tomas Jelinek has posted comments on this change. Change subject: migration: Add support for max migration bandwidth setting .. Patch Set 11: Verified+1 -- To view, visit https://gerrit.ovirt.org/46846 To unsubscribe, visit

Change in vdsm[master]: WIP DONTMERGE: migrationLimit retry

gerrit-hooks has posted comments on this change. Change subject: WIP DONTMERGE: migrationLimit retry .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: virt: s/vm._dom.XMLDesc(0)/vm.xml/g

Milan Zamazal has posted comments on this change. Change subject: virt: s/vm._dom.XMLDesc(0)/vm.xml/g .. Patch Set 1: (2 comments) Nice change! Just a question about using @property.

Change in vdsm[master]: [wip] Dynamic load of supervdsm_api funcs

Yaniv Bronhaim has uploaded a new change for review. Change subject: [wip] Dynamic load of supervdsm_api funcs .. [wip] Dynamic load of supervdsm_api funcs The patch adds supervdsm_api folder (which will move later once all

Change in vdsm[master]: [wip] Dynamic load of supervdsm_api funcs

gerrit-hooks has posted comments on this change. Change subject: [wip] Dynamic load of supervdsm_api funcs .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: migration: Add incoming migration semaphore

gerrit-hooks has posted comments on this change. Change subject: migration: Add incoming migration semaphore .. Patch Set 23: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: [wip] Dynamic load of supervdsm_api funcs

Nir Soffer has posted comments on this change. Change subject: [wip] Dynamic load of supervdsm_api funcs .. Patch Set 2: Code-Review-1 Why do we need this? -- To view, visit https://gerrit.ovirt.org/52875 To unsubscribe,

Change in vdsm[master]: [wip] Dynamic load of supervdsm_api funcs

gerrit-hooks has posted comments on this change. Change subject: [wip] Dynamic load of supervdsm_api funcs .. Patch Set 3: * #1182092::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1182092::OK, public bug * Check

Change in vdsm[master]: [wip] Dynamic load of supervdsm_api funcs

Yaniv Bronhaim has posted comments on this change. Change subject: [wip] Dynamic load of supervdsm_api funcs .. Patch Set 2: its RFE for 4.0 - https://bugzilla.redhat.com/show_bug.cgi?id=1182092 -- To view, visit

Change in vdsm[master]: [wip] Dynamic load of supervdsm_api funcs

Yaniv Bronhaim has posted comments on this change. Change subject: [wip] Dynamic load of supervdsm_api funcs .. Patch Set 2: there are still some gaps, and I want to move the rest of the functions to separate modules.. feel

Change in vdsm[master]: setupNetworks: moving nics between bonds

Marcin Mirecki has posted comments on this change. Change subject: setupNetworks: moving nics between bonds .. Patch Set 9: (3 comments) https://gerrit.ovirt.org/#/c/50596/9/lib/vdsm/network/api.py File

Change in vdsm[master]: [wip] Dynamic load of supervdsm_api funcs

gerrit-hooks has posted comments on this change. Change subject: [wip] Dynamic load of supervdsm_api funcs .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: virt: add run_async helper

gerrit-hooks has posted comments on this change. Change subject: virt: add run_async helper .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:

Change in vdsm[master]: setupNetworks: moving nics between bonds

gerrit-hooks has posted comments on this change. Change subject: setupNetworks: moving nics between bonds .. Patch Set 10: * #1269175::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1269175::OK, public bug * Check

Change in vdsm[master]: setupNetworks: moving nics between bonds

Francesco Romani has posted comments on this change. Change subject: setupNetworks: moving nics between bonds .. Patch Set 9: Code-Review+1 (3 comments) only minor nits in case you need to resubmit.

Change in vdsm[master]: hooks: use the `terminating' decorator

gerrit-hooks has posted comments on this change. Change subject: hooks: use the `terminating' decorator .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: virt: add load() method to the recovery.File class

gerrit-hooks has posted comments on this change. Change subject: virt: add load() method to the recovery.File class .. Patch Set 12: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: tests: start proper recovery.py tests

Francesco Romani has uploaded a new change for review. Change subject: tests: start proper recovery.py tests .. tests: start proper recovery.py tests Change-Id: Ib09937448a04a6c10f33b7f23c0aed71eafc12d2 Signed-off-by: Francesco

Change in vdsm[master]: tests: start proper recovery.py tests

gerrit-hooks has posted comments on this change. Change subject: tests: start proper recovery.py tests .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: virtsparsify: remove useless deathSignal

gerrit-hooks has posted comments on this change. Change subject: virtsparsify: remove useless deathSignal .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: supervdsm: moving nics between bonds

Marcin Mirecki has posted comments on this change. Change subject: supervdsm: moving nics between bonds .. Patch Set 8: (5 comments) https://gerrit.ovirt.org/#/c/50596/8//COMMIT_MSG Commit Message: Line 7: supervdsm: >

Change in vdsm[master]: virtsparsify: remove useless deathSignal

gerrit-hooks has posted comments on this change. Change subject: virtsparsify: remove useless deathSignal .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: setupNetworks: moving nics between bonds

Marcin Mirecki has posted comments on this change. Change subject: setupNetworks: moving nics between bonds .. Patch Set 9: Verified+1 -- To view, visit https://gerrit.ovirt.org/50596 To unsubscribe, visit

Change in vdsm[master]: setupNetworks: moving nics between bonds

gerrit-hooks has posted comments on this change. Change subject: setupNetworks: moving nics between bonds .. Patch Set 9: * #1269175::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1269175::OK, public bug * Check

Change in vdsm[master]: periodic: remove useless log

Francesco Romani has uploaded a new change for review. Change subject: periodic: remove useless log .. periodic: remove useless log Periodic sampling code used to log a warning when trying to sample a domain not connected. This

Change in vdsm[master]: periodic: remove useless log

gerrit-hooks has posted comments on this change. Change subject: periodic: remove useless log .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: vmstats: remove useless short stacktrace

Francesco Romani has uploaded a new change for review. Change subject: vmstats: remove useless short stacktrace .. vmstats: remove useless short stacktrace There is no point in dump a stacktrace when we miss cpu samples. Only

Change in vdsm[master]: vmstats: remove useless short stacktrace

gerrit-hooks has posted comments on this change. Change subject: vmstats: remove useless short stacktrace .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: periodic: ignore known-benign libvirt errors

gerrit-hooks has posted comments on this change. Change subject: periodic: ignore known-benign libvirt errors .. Patch Set 1: * #1299480::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1299480::OK, public bug *

Change in vdsm[master]: periodic: ignore known-benign libvirt errors

Francesco Romani has uploaded a new change for review. Change subject: periodic: ignore known-benign libvirt errors .. periodic: ignore known-benign libvirt errors perioric sampling threads and migration thread are (and need to

Change in vdsm[master]: migration: added support for convergance schedule

Francesco Romani has posted comments on this change. Change subject: migration: added support for convergance schedule .. Patch Set 11: Code-Review+1 (1 comment) At first glance looks OK. I'd like to do another pass, but I

Change in vdsm[master]: WIP DONTMERGE: migrationLimit retry

gerrit-hooks has posted comments on this change. Change subject: WIP DONTMERGE: migrationLimit retry .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: periodic: ignore known-benign libvirt errors

gerrit-hooks has posted comments on this change. Change subject: periodic: ignore known-benign libvirt errors .. Patch Set 2: * #1299480::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1299480::OK, public bug *

Change in vdsm[master]: migration: added support for convergance schedule

Francesco Romani has posted comments on this change. Change subject: migration: added support for convergance schedule .. Patch Set 11: also, could be worth to split in smaller patches? -- To view, visit

Change in vdsm[master]: migration added migrateChangeParams verb

Francesco Romani has posted comments on this change. Change subject: migration added migrateChangeParams verb .. Patch Set 10: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/46934 To unsubscribe, visit

Change in vdsm[master]: periodic: ignore known-benign libvirt errors

gerrit-hooks has posted comments on this change. Change subject: periodic: ignore known-benign libvirt errors .. Patch Set 3: * #1299480::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1299480::OK, public bug *

Change in vdsm[master]: periodic: ignore known-benign libvirt errors

Francesco Romani has posted comments on this change. Change subject: periodic: ignore known-benign libvirt errors .. Patch Set 3: Code-Review-1 Verified+1 works, tested - setting unlikely high rate for periodic samplings (NUMA

Change in vdsm[master]: storageServer: Normalize local path before escaping

Martin Sivák has posted comments on this change. Change subject: storageServer: Normalize local path before escaping .. Patch Set 1: Code-Review+1 Thanks Nir. -- To view, visit https://gerrit.ovirt.org/52873 To unsubscribe,

Change in vdsm[master]: imagetickets: Support image tickets

gerrit-hooks has posted comments on this change. Change subject: imagetickets: Support image tickets .. Patch Set 17: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit

Change in vdsm[master]: sp: update domain links on state change

Nir Soffer has submitted this change and it was merged. Change subject: sp: update domain links on state change .. sp: update domain links on state change In some situations (e.g. after a reconstructMaster command) the domain

Change in vdsm[master]: sp: update domain links on state change

gerrit-hooks has posted comments on this change. Change subject: sp: update domain links on state change .. Patch Set 10: * #1271771::Update tracker: OK * Set MODIFIED::bug 1271771#1271771OK -- To view, visit

Change in vdsm[master]: imagetickets: Support image tickets

Nir Soffer has submitted this change and it was merged. Change subject: imagetickets: Support image tickets .. imagetickets: Support image tickets The introduced module is part of the image transfers implementation, which lets