Dan Kenigsberg has posted comments on this change.
Change subject: ssl: common name differences on f23
..
Patch Set 1: -Code-Review
(1 comment)
https://gerrit.ovirt.org/#/c/53231/1/tests/integration/jsonRpcHelper.py
File
Dan Kenigsberg has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 2: Code-Review+1
(1 comment)
David Caro has posted comments on this change.
Change subject: Adding vdsm functional tests
..
Patch Set 52:
(1 comment)
https://gerrit.ovirt.org/#/c/48268/52/automation/check-merged.sh
File automation/check-merged.sh:
Line
gerrit-hooks has posted comments on this change.
Change subject: Adding vdsm functional tests
..
Patch Set 53:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Francesco Romani has posted comments on this change.
Change subject: vmfex hook: hold a ref for a virDomain object
..
Patch Set 1: Code-Review+1
(4 comments)
I think this patch in itself is good enough, but we surely need
Dan Kenigsberg has posted comments on this change.
Change subject: net: add documentation for setupNetworks rollback mechanism.
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/50261
To unsubscribe,
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: add documentation for setupNetworks rollback mechanism.
..
net: add documentation for setupNetworks rollback mechanism.
Since Ifcfg is both the
gerrit-hooks has posted comments on this change.
Change subject: net: add documentation for setupNetworks rollback mechanism.
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
Yaniv Bronhaim has posted comments on this change.
Change subject: contrib: schema converter
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/52864/2//COMMIT_MSG
Commit Message:
Line 3: AuthorDate: 2016-01-28
Yaniv Bronhaim has posted comments on this change.
Change subject: Dynamic load of supervdsm_api funcs
..
Patch Set 8: Verified+1
--
To view, visit https://gerrit.ovirt.org/52875
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: Adding dynamic_package_load util module for reuseability
..
Patch Set 4:
(3 comments)
https://gerrit.ovirt.org/#/c/53016/4/lib/vdsm/dynamic_package_load.py
Piotr Kliczewski has posted comments on this change.
Change subject: contrib: schema converter
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/52864/2//COMMIT_MSG
Commit Message:
Line 3: AuthorDate: 2016-01-28
Dan Kenigsberg has posted comments on this change.
Change subject: migration: Added support for setting the convergenceSchedule
..
Patch Set 13: Code-Review-1
(1 comment)
Dan Kenigsberg has posted comments on this change.
Change subject: Adding vdsm functional tests
..
Patch Set 52:
(1 comment)
https://gerrit.ovirt.org/#/c/48268/52/automation/check-merged.sh
File automation/check-merged.sh:
gerrit-hooks has posted comments on this change.
Change subject: ssl: common name different than host info from socket during
tests
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
Piotr Kliczewski has posted comments on this change.
Change subject: ssl: common name different than host info from socket during
tests
..
Patch Set 1:
(1 comment)
Dan Kenigsberg has posted comments on this change.
Change subject: hooks: Remove dead code from before_vm_migrate_destination
..
Patch Set 3: Code-Review+2
(1 comment)
gerrit-hooks has posted comments on this change.
Change subject: hooks: Remove dead code from before_vm_migrate_destination
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: hooks: Remove dead code from before_vm_migrate_destination
..
hooks: Remove dead code from before_vm_migrate_destination
Change-Id:
David Caro has posted comments on this change.
Change subject: Adding vdsm functional tests
..
Patch Set 52:
> (1 comment)
That's actually not the issue, we are not properly mounting the libvirt socket
over to the chroot...
Edward Haas has posted comments on this change.
Change subject: ssl: common name differences on f23
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/53231
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: numa: only use libvirt for memory info
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Francesco Romani has posted comments on this change.
Change subject: v2v: drop old el6 test code
..
Patch Set 1: Code-Review+1
(1 comment)
partial ACK, please see inline comments.
gerrit-hooks has posted comments on this change.
Change subject: numa: only use libvirt for memory info
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Francesco Romani has posted comments on this change.
Change subject: numa: only use libvirt for memory info
..
Patch Set 4: Code-Review+1
(2 comments)
partial ACK. Conceptually and codewise looks fine, but I'd like better
Francesco Romani has posted comments on this change.
Change subject: vmfex hook: hold a ref for a virDomain object
..
Patch Set 2: Code-Review+2
This is more virt (hooks) than network it seems, hence +2.
--
To view, visit
Jenkins CI has posted comments on this change.
Change subject: numa: only use libvirt for memory info
..
Patch Set 4: Continuous-Integration+1
Propagate review hook: Continuous Integration value inherited from patch 3
--
To
Dan Kenigsberg has posted comments on this change.
Change subject: vmfex hook: hold a ref for a virDomain object
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/53202
To unsubscribe, visit
Dan Kenigsberg has uploaded a new change for review.
Change subject: vmfex hook: hold a ref for a virDomain object
..
vmfex hook: hold a ref for a virDomain object
commit 93feb1c introduced a weakref to virDomain object to
Dan Kenigsberg has posted comments on this change.
Change subject: vmfex hook: hold a ref for a virDomain object
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/53200
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: xmlrpc: retry when flushing socket
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/47637/6/vdsm/rpc/bindingxmlrpc.py
File
Piotr Kliczewski has posted comments on this change.
Change subject: contrib: schema converter
..
Patch Set 4:
Once we finalize conversion the code from this patch is not needed. I just
wanted people to play with generated
Jenkins CI has posted comments on this change.
Change subject: numa: only use libvirt for memory info
..
Patch Set 4: Continuous-Integration-1
Propagate review hook: Continuous Integration value inherited from patch 2
--
To
gerrit-hooks has posted comments on this change.
Change subject: vmfex hook: hold a ref for a virDomain object
..
Patch Set 3:
* #1305338::Update tracker: OK
* Set MODIFIED::bug 1305338#1305338IGNORE, not oVirt
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vmfex hook: hold a ref for a virDomain object
..
vmfex hook: hold a ref for a virDomain object
commit 93feb1c introduced a weakref to virDomain object
gerrit-hooks has posted comments on this change.
Change subject: virt: Make VM._correctGraphicsConfiguration use DomainDescriptor
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
gerrit-hooks has posted comments on this change.
Change subject: virt: Use XML API in VM._getUnderlyingDeviceAddress
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: virt: Network device code switched to XML API in Vm
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: virt: Convert Vm._getVmPolicy to XML API
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: virt: Switch the rest of Vm code to XML API
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: virt: XML helper for virt introduced
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: virt: Use XML API in some simpler VM devices
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: virt: Switch remaining graphics code in Vm to XML API
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: virt: Drive handling switched to XML API in Vm
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: virt: Make DomainDescriptor use new XML API
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: virt: Use XML API in Vm._correctDiskVolumes
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: virt: Use XML API in more VM devices
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Martin Polednik has posted comments on this change.
Change subject: numa: only use libvirt for memory info
..
Patch Set 5: Verified+1
--
To view, visit https://gerrit.ovirt.org/53091
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: xmlrpc: retry when flushing socket
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/47637/6/vdsm/rpc/bindingxmlrpc.py
File vdsm/rpc/bindingxmlrpc.py:
Dan Kenigsberg has uploaded a new change for review.
Change subject: vmfex hook: hold a ref for a virDomain object
..
vmfex hook: hold a ref for a virDomain object
commit 93feb1c introduced a weakref to virDomain object to
gerrit-hooks has posted comments on this change.
Change subject: vmfex hook: hold a ref for a virDomain object
..
Patch Set 1: Verified-1
* #1305338::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1305338::OK,
gerrit-hooks has posted comments on this change.
Change subject: lib: fix too early collection with weakmethod
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: xmlrpc: retry when flushing socket
..
Patch Set 7:
* #1261255::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1261255::OK, public bug
* Check
Piotr Kliczewski has posted comments on this change.
Change subject: xmlrpc: retry when flushing socket
..
Patch Set 7: Verified+1
--
To view, visit https://gerrit.ovirt.org/47637
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: numa: only use libvirt for memory info
..
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/53091
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: vmfex hook: hold a ref for a virDomain object
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/53200
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: network: tests do not check OVS devices operstate
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/53130
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: contrib: schema converter
..
Patch Set 4:
can you change the names such that we'll be able to understand what handles
yaml schema and what handles the json
Piotr Kliczewski has posted comments on this change.
Change subject: Dynamic load of supervdsm_api funcs
..
Patch Set 8: Code-Review-1
(1 comment)
Please provide tests to cover to logic that you introduce here.
Dan Kenigsberg has posted comments on this change.
Change subject: vmfex hook: hold a ref for a virDomain object
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/53160
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: vmfex hook: hold a ref for a virDomain object
..
Patch Set 2:
* #1305338::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1305338::OK, public bug
*
Yaniv Bronhaim has posted comments on this change.
Change subject: Dynamic load of supervdsm_api funcs
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/52875/8/vdsm/supervdsm_api/hwinfo.py
File
Dan Kenigsberg has posted comments on this change.
Change subject: network: don't log missing brif files
..
Patch Set 2: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/53095/2/lib/vdsm/netinfo/bridges.py
File
Dan Kenigsberg has uploaded a new change for review.
Change subject: vmfex hook: hold a ref for a virDomain object
..
vmfex hook: hold a ref for a virDomain object
commit 93feb1c introduced a weakref to virDomain object to
gerrit-hooks has posted comments on this change.
Change subject: vmfex hook: hold a ref for a virDomain object
..
Patch Set 1:
* #1305338::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1305338::OK, public bug
*
Yaniv Bronhaim has posted comments on this change.
Change subject: xmlrpc: retry when flushing socket
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/47637/6/vdsm/rpc/bindingxmlrpc.py
File vdsm/rpc/bindingxmlrpc.py:
gerrit-hooks has posted comments on this change.
Change subject: hooks: ovs: fix bonded network change problem
..
Patch Set 4:
* #1234867::Update tracker: OK
* Set MODIFIED::bug 1234867#1234867IGNORE, not all related
Francesco Romani has posted comments on this change.
Change subject: vmfex hook: hold a ref for a virDomain object
..
Patch Set 1:
please get another ACK
--
To view, visit https://gerrit.ovirt.org/53202
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: vmfex hook: hold a ref for a virDomain object
..
Patch Set 1:
please find another ack
--
To view, visit https://gerrit.ovirt.org/53200
To unsubscribe,
Francesco Romani has posted comments on this change.
Change subject: vmfex hook: hold a ref for a virDomain object
..
Patch Set 1: Code-Review+2
same code as 3.6 branch, will run jenkins checks manually.
--
To view, visit
Roman Mohr has posted comments on this change.
Change subject: numa: only use libvirt for memory info
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/53091
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: numa: only use libvirt for memory info
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/53091/4//COMMIT_MSG
Commit Message:
Line 10: depending on the
Dan Kenigsberg has posted comments on this change.
Change subject: vmfex hook: hold a ref for a virDomain object
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/53203
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: vmfex hook: hold a ref for a virDomain object
..
Patch Set 1:
* #1305338::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1305338::OK, public bug
*
gerrit-hooks has posted comments on this change.
Change subject: virt: Switch vmtune.py to XML API
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Martin Betak has posted comments on this change.
Change subject: numa: only use libvirt for memory info
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/53091
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: xmlrpc: retry when flushing socket
..
Patch Set 6:
* #1261255::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1261255::OK, public bug
* Check
Piotr Kliczewski has posted comments on this change.
Change subject: xmlrpc: retry when flushing socket
..
Patch Set 6: Verified+1
Fixed Yaniv's comments + rebase.
--
To view, visit https://gerrit.ovirt.org/47637
To
Martin Polednik has posted comments on this change.
Change subject: numa: only use libvirt for memory info
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/53091/3/tests/capsTests.py
File tests/capsTests.py:
Line
gerrit-hooks has posted comments on this change.
Change subject: numa: only use libvirt for memory info
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Piotr Kliczewski has posted comments on this change.
Change subject: contrib: schema converter
..
Patch Set 3: Verified+1
Comments fixed. Script verified with python3 (it requires python3-PyYAML).
--
To view, visit
Piotr Kliczewski has posted comments on this change.
Change subject: contrib: schema converter
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/52864/2//COMMIT_MSG
Commit Message:
Line 3: AuthorDate: 2016-01-28
gerrit-hooks has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Using pkgutil instead of redundant private funcs in configurator
Change-Id:
Martin Polednik has posted comments on this change.
Change subject: numa: only use libvirt for memory info
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/53091/4//COMMIT_MSG
Commit Message:
Line 7: numa: only use
gerrit-hooks has posted comments on this change.
Change subject: numa: only use libvirt for memory info
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Piotr Kliczewski has posted comments on this change.
Change subject: xmlrpc: retry when flushing socket
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/47637/6/vdsm/rpc/bindingxmlrpc.py
File
Francesco Romani has posted comments on this change.
Change subject: migration: added support for convergance schedule
..
Patch Set 12: Code-Review+2
(1 comment)
ok seems good
Piotr Kliczewski has posted comments on this change.
Change subject: Adding vdsm functional tests
..
Patch Set 51: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/48268
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: vmfex hook: hold a ref for a virDomain object
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/53160
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: contrib: schema converter
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
gerrit-hooks has posted comments on this change.
Change subject: v2v: drop old el6 test code
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Yaniv Bronhaim has posted comments on this change.
Change subject: contrib: schema converter
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/52864/2//COMMIT_MSG
Commit Message:
Line 3: AuthorDate: 2016-01-28
gerrit-hooks has posted comments on this change.
Change subject: contrib: schema converter
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: hooks: ovs: fix bonded network change problem
..
hooks: ovs: fix bonded network change problem
When we try to change bonded network, it explodes every
Sandro Bonazzola has uploaded a new change for review.
Change subject: automation: drop fc21 support
..
automation: drop fc21 support
Fedora 21 reached EOL long ago.
Dropping support for it
Change-Id:
Sandro Bonazzola has posted comments on this change.
Change subject: CI automation: Trigger post merge tests
..
Patch Set 1: -Verified
--
To view, visit https://gerrit.ovirt.org/53263
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: automation: drop fc21 support
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: Dynamic load of supervdsm_api funcs
..
Patch Set 13:
* #1182092::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1182092::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
1 - 100 of 147 matches
Mail list logo