gerrit-hooks has posted comments on this change.
Change subject: hooks:checkips: add checkips hook
..
Patch Set 8:
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#994170::ERROR, private bug
* Check Public
Martin Betak has posted comments on this change.
Change subject: migration: Add DynamicThrottling semaphores
..
Patch Set 17: Verified+1
--
To view, visit https://gerrit.ovirt.org/53304
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 22: Verified+1
--
To view, visit https://gerrit.ovirt.org/52799
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: migration: Enable lazy setting of incoming/outgoing limits
..
Patch Set 18: Verified+1
--
To view, visit https://gerrit.ovirt.org/53305
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: hooks:checkips: add checkips hook
..
Patch Set 7: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/54102/7/vdsm_hooks/checkips/Makefile.am
File
Dan Kenigsberg has posted comments on this change.
Change subject: commands: import StringIO only on Python 2
..
Patch Set 2: Verified+1
Passes all tests on f23 and el7
--
To view, visit https://gerrit.ovirt.org/55380
To
Dan Kenigsberg has posted comments on this change.
Change subject: compat: mock CPopen for Python 3 testing
..
Patch Set 1: Verified+1
Passes all tests on f23 and el7
--
To view, visit https://gerrit.ovirt.org/55379
To
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Remove blkid
..
Remove blkid
Engine has never used the UUID argument for storage specification.
We drop _getUUIDSpecPath and blkid to avoid carrying
gerrit-hooks has posted comments on this change.
Change subject: Remove blkid
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Dan Kenigsberg has posted comments on this change.
Change subject: Generate coverage report only over fedora which runs unittests
..
Patch Set 1: Code-Review+2
Unbreak ci
--
To view, visit https://gerrit.ovirt.org/55423
To
Nir Soffer has posted comments on this change.
Change subject: Remove blkid
..
Patch Set 8: Continuous-Integration+1
Tried git clean -dxf && ./autogen --sytem && make && make check && make rpm
All tests pass.
--
To view,
Jenkins CI has posted comments on this change.
Change subject: Remove blkid
..
Patch Set 8:
Propagate review hook: Continuous Integration value inherited from patch 7
--
To view, visit https://gerrit.ovirt.org/53872
To
Petr Horáček has posted comments on this change.
Change subject: net: native ovs [1]: ovs switch skeleton
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/55308/1/lib/vdsm/network/netswitch.py
File
Nir Soffer has posted comments on this change.
Change subject: Remove blkid
..
Patch Set 8:
Yaniv, can you check why jenkins is unhappy?
--
To view, visit https://gerrit.ovirt.org/53872
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: Remove blkid
..
Patch Set 8: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/53872
To unsubscribe, visit https://gerrit.ovirt.org/settings
Jenkins CI has posted comments on this change.
Change subject: Remove blkid
..
Patch Set 8:
Propagate review hook: Continuous Integration value inherited from patch 6
--
To view, visit https://gerrit.ovirt.org/53872
To
gerrit-hooks has posted comments on this change.
Change subject: net: native ovs [7]: configure basic ovs nets and bonds
..
Patch Set 3:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK,
Jenkins CI has posted comments on this change.
Change subject: Remove blkid
..
Patch Set 8: Continuous-Integration-1
Propagate review hook: Continuous Integration value inherited from patch 5
--
To view, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: Remove blkid
..
Patch Set 8:
Finally I found the Edit button in gerrit :) cool feature
--
To view, visit https://gerrit.ovirt.org/53872
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: Remove blkid
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is a
Petr Horáček has posted comments on this change.
Change subject: net: native ovs [6]: split to-be-removed and to-be-added
..
Patch Set 2: Verified+1
Passed network tests OK
--
To view, visit https://gerrit.ovirt.org/55313
To
Yaniv Bronhaim has posted comments on this change.
Change subject: Generate coverage report only over fedora which runs unittests
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/55423
To unsubscribe,
Edward Haas has posted comments on this change.
Change subject: net: native ovs [1]: ovs switch skeleton
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/55308/1/lib/vdsm/network/netswitch.py
File
gerrit-hooks has posted comments on this change.
Change subject: vm: destroy: retry to gracefully destroy
..
Patch Set 5:
* #1309884::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1309884::OK, public bug
* Check
Petr Horáček has posted comments on this change.
Change subject: net: native ovs [2]: split ovs and legacy networks
..
Patch Set 5: Verified+1
Passed network test OK
--
To view, visit https://gerrit.ovirt.org/55309
To
Petr Horáček has posted comments on this change.
Change subject: net: native ovs [4]: move RollbackIncomplete to network errors
..
Patch Set 4: Verified+1
Passed network test OK
--
To view, visit
Petr Horáček has posted comments on this change.
Change subject: net: native ovs [5]: rollback trigger
..
Patch Set 4: Verified+1
Passed network test OK
--
To view, visit https://gerrit.ovirt.org/55312
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: test: Use mock module for testing
..
Patch Set 3:
(4 comments)
https://gerrit.ovirt.org/#/c/55342/3/tests/network/netswitch_test.py
File
gerrit-hooks has posted comments on this change.
Change subject: net: native ovs [6]: split to-be-removed and to-be-added
..
Patch Set 2:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK,
Francesco Romani has posted comments on this change.
Change subject: vm: destroy: try harder destroying a Vm
..
Patch Set 7: Verified+1
trivial change verified discussing with libvirt devs (see RHBZ) and checking
the libvirt
gerrit-hooks has posted comments on this change.
Change subject: vm: destroy: retry to gracefully destroy
..
Patch Set 4:
* #1309884::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1309884::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: vm: destroy: try harder destroying a Vm
..
Patch Set 7:
* #1309884::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1309884::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: vm: destroy: retry to gracefully destroy
..
Patch Set 3:
* #1309884::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1309884::OK, public bug
* Check
Edward Haas has posted comments on this change.
Change subject: test: Use mock module for testing
..
Patch Set 3: Verified+1
Previous suppress patch has been fixed, tests now are passing.
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: test: Use mock module for testing
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: fileUtils: tarCopy - avoid extracting the file modified time
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
gerrit-hooks has posted comments on this change.
Change subject: net: native ovs [5]: rollback trigger
..
Patch Set 4:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check
Nir Soffer has posted comments on this change.
Change subject: Remove blkid
..
Patch Set 7: Code-Review+1
Thanks for this cleanup!
I would only make the commit message more clear as Dan suggested.
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: commands: import StringIO only on Python 2
..
Patch Set 2:
I don't think we should do this. We are creating a bigger mess.
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: compat: mock CPopen for Python 3 testing
..
Patch Set 1:
(7 comments)
https://gerrit.ovirt.org/#/c/55379/1//COMMIT_MSG
Commit Message:
Line 8:
Line 9: I would
gerrit-hooks has posted comments on this change.
Change subject: net: native ovs [5]: rollback trigger
..
Patch Set 3:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: net: native ovs [4]: move RollbackIncomplete to network errors
..
Patch Set 4:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public
Francesco Romani has posted comments on this change.
Change subject: vm: use the new response handling
..
Patch Set 9:
(1 comment)
https://gerrit.ovirt.org/#/c/54799/9/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 2559:
Francesco Romani has posted comments on this change.
Change subject: vm: use the new response handling
..
Patch Set 9:
(6 comments)
https://gerrit.ovirt.org/#/c/54799/9/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 3937
Line
David Caro has posted comments on this change.
Change subject: Generate coverage report only over fedora which runs unittests
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55423
To unsubscribe,
gerrit-hooks has posted comments on this change.
Change subject: Generate coverage report only over fedora which runs unittests
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Generate coverage report only over fedora which runs unittests
..
Generate coverage report only over fedora which runs unittests
No reports return 1 and mock
Francesco Romani has posted comments on this change.
Change subject: vm: use the new response handling
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/54799/8//COMMIT_MSG
Commit Message:
Line 8:
Line 9: Let's start
gerrit-hooks has posted comments on this change.
Change subject: net: native ovs [4]: move RollbackIncomplete to network errors
..
Patch Set 3:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public
Petr Horáček has posted comments on this change.
Change subject: net: native ovs [3]: validate networks and bonds
..
Patch Set 3: Verified+1
Passed network tests OK
--
To view, visit https://gerrit.ovirt.org/55310
To
Jenkins CI has posted comments on this change.
Change subject: suppress for python2
..
Patch Set 9:
Propagate review hook: Continuous Integration value inherited from patch 8
--
To view, visit https://gerrit.ovirt.org/55065
gerrit-hooks has posted comments on this change.
Change subject: net: native ovs [4]: move RollbackIncomplete to net api
..
Patch Set 2:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK,
gerrit-hooks has posted comments on this change.
Change subject: net: native ovs [5]: rollback trigger
..
Patch Set 2:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: net: native ovs [3]: validate networks and bonds
..
Patch Set 3:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
gerrit-hooks has posted comments on this change.
Change subject: net: native ovs [2]: split ovs and legacy networks
..
Patch Set 5:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public
Francesco Romani has posted comments on this change.
Change subject: vm: Move saveState() out of constructor
..
Patch Set 7: Code-Review+1
seems fine. I will do another deeper review later, hopefully with no surprises
--
To
Martin Betak has posted comments on this change.
Change subject: vm: Move saveState() out of constructor
..
Patch Set 7: Verified+1
Verified using standard mass migration process with extreme throttling to
trigger multiple
Jenkins CI has posted comments on this change.
Change subject: suppress for python2
..
Patch Set 9: Continuous-Integration-1
Propagate review hook: Continuous Integration value inherited from patch 7
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: net: native ovs [3]: validate networks and bonds
..
Patch Set 2:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
gerrit-hooks has posted comments on this change.
Change subject: net: native ovs [2]: split ovs and legacy networks
..
Patch Set 4:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public
Ondřej Svoboda has posted comments on this change.
Change subject: net: native ovs [5]: rollback manager
..
Patch Set 1: -Code-Review
Never mind.
--
To view, visit https://gerrit.ovirt.org/55312
To unsubscribe, visit
Ondřej Svoboda has posted comments on this change.
Change subject: net: native ovs [5]: rollback manager
..
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/55312/1/tests/network/ovs_test.py
File
Francesco Romani has posted comments on this change.
Change subject: supervdsm_udev: generalize rule removal
..
Patch Set 1:
general note:
I of course agree that code should be covered by tests before refactoring. But
with
Ondřej Svoboda has posted comments on this change.
Change subject: net: native ovs [2]: split ovs and legacy networks
..
Patch Set 3: Code-Review-1
(1 comment)
A little thing about str.split()
Dan Kenigsberg has posted comments on this change.
Change subject: bridge: data verification
..
Patch Set 15: Code-Review+1 Verified+1
network functional tests passed with no error and no problem in the log
--
To view, visit
Dan Kenigsberg has posted comments on this change.
Change subject: Remove blkid
..
Patch Set 7: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/53872/7//COMMIT_MSG
Commit Message:
Line 5: CommitDate: 2016-03-29
gerrit-hooks has posted comments on this change.
Change subject: vm: Move saveState() out of constructor
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: migration: Add DynamicThrottling semaphores
..
Patch Set 17:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Martin Betak has posted comments on this change.
Change subject: vm: Move saveState() out of constructor
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/53950/6/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 685:
gerrit-hooks has posted comments on this change.
Change subject: migration: Enable lazy setting of incoming/outgoing limits
..
Patch Set 18:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
gerrit-hooks has posted comments on this change.
Change subject: migration: Add retry on full capacity
..
Patch Set 22:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: virt: recovery: refactor entry points
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: HACK: virt: override vm type from custom property
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: containers: make sure directory are ready
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: network: supervdsm: configure container networks
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: sudo: add permissions to run containers
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: containers: initial support
..
Patch Set 12:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: hook: add imagerepo feed containers
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: containers: always add emulator to XML
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Adam Litke has posted comments on this change.
Change subject: virt: Use libvirt to get drive size
..
Patch Set 1:
(3 comments)
https://gerrit.ovirt.org/#/c/55399/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 3498
Line 3499
gerrit-hooks has posted comments on this change.
Change subject: net: native ovs [2]: split ovs and legacy networks
..
Patch Set 3:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public
Francesco Romani has posted comments on this change.
Change subject: vm: events: don't abort creation if event fails
..
Patch Set 3: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/54933/3/vdsm/virt/vm.py
File
Petr Horáček has posted comments on this change.
Change subject: net: native ovs [1]: ovs switch skeleton
..
Patch Set 2: Verified+1
Passed network test OK (did not brake legacy networking)
--
To view, visit
Sandro Bonazzola has posted comments on this change.
Change subject: jsonrpc: set default timeout value
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55397
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: net: native ovs [2]: split ovs and legacy networks
..
Patch Set 2:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public
Yaniv Bronhaim has posted comments on this change.
Change subject: Remove blkid
..
Patch Set 7: Verified+1
tried some general flows over fc23
--
To view, visit https://gerrit.ovirt.org/53872
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: tests: add tests for sampling.VMBulkSampler
..
Patch Set 47:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Francesco Romani has posted comments on this change.
Change subject: Remove blkid
..
Patch Set 7: Code-Review+1
codewise seems fine, just document how you verify this :)
--
To view, visit https://gerrit.ovirt.org/53872
To
gerrit-hooks has posted comments on this change.
Change subject: Remove blkid
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is a
Yaniv Bronhaim has posted comments on this change.
Change subject: Move numaUtils content to numa module
..
Patch Set 4:
ran it over f23, verified caps report and log
--
To view, visit https://gerrit.ovirt.org/51409
To
gerrit-hooks has posted comments on this change.
Change subject: Remove blkid
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is a
Amit Aviram has posted comments on this change.
Change subject: image: add a flag for preparing with illegal volumes.
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/55199/2/vdsm/storage/hsm.py
File
gerrit-hooks has posted comments on this change.
Change subject: Remove blkid
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is a
Yaniv Bronhaim has restored this change.
Change subject: move blkid to lib
..
Restored
--
To view, visit https://gerrit.ovirt.org/53872
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: restore
Petr Horáček has posted comments on this change.
Change subject: net: Adding the netswitch module
..
Patch Set 8: Verified+1
Passing network test OK.
--
To view, visit https://gerrit.ovirt.org/55131
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: net: native ovs [1]: ovs switch skeleton
..
Patch Set 2:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check
Yaniv Bronhaim has posted comments on this change.
Change subject: Move numaUtils content to numa module
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/51409
To unsubscribe, visit
Martin Polednik has posted comments on this change.
Change subject: Move numaUtils content to numa module
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/51409
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: Move numaUtils content to numa module
..
Patch Set 4: Code-Review+1
thanks for the update
--
To view, visit https://gerrit.ovirt.org/51409
To unsubscribe,
gerrit-hooks has posted comments on this change.
Change subject: net: Adding the netswitch module
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
1 - 100 of 222 matches
Mail list logo
