Milan Zamazal has posted comments on this change.
Change subject: rng: allow urandom as virtio rng entropy source
..
Patch Set 10: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/59031
To unsubscribe, visit https://ge
gerrit-hooks has posted comments on this change.
Change subject: net libvirt hook: Adjust hook to vmList report change.
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make su
Edward Haas has uploaded a new change for review.
Change subject: net libvirt hook: Adjust hook to vmList report change.
..
net libvirt hook: Adjust hook to vmList report change.
Patch 78ea853e131da3b91b812315a0656b8f99d7fef4 ha
Dan Kenigsberg has posted comments on this change.
Change subject: net: dhclient kill - early exit if iface does not exists
..
Patch Set 7: Code-Review-1
Please add the motivation for this patch in your commit message.
I don't
gerrit-hooks has posted comments on this change.
Change subject: tests: fix testGetBondingOptions
..
Patch Set 1:
* #1374328::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1374328::OK, public bug
* Check Product::
gerrit-hooks has posted comments on this change.
Change subject: tests: introducting broken_on_ci decorator
..
Patch Set 1:
* #1374328::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1374328::OK, public bug
* Check
Hello Dan Kenigsberg,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/63539
to review the following change.
Change subject: net tests: fix test_events_keys
..
net tests: fix test_events_keys
On Je
gerrit-hooks has posted comments on this change.
Change subject: net tests: fix test_events_keys
..
Patch Set 1:
* #1374328::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1374328::OK, public bug
* Check Product::#
Hello Dan Kenigsberg, Edward Haas,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/63541
to review the following change.
Change subject: tests: fix testGetBondingOptions
..
tests: fix testGetBondin
Hello Dan Kenigsberg, Martin Polednik, Edward Haas,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/63540
to review the following change.
Change subject: tests: introducting broken_on_ci decorator
.
gerrit-hooks has posted comments on this change.
Change subject: net tests: raise specific MonitorError on IPv6 timeout
..
Patch Set 2:
* #1374328::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1374328::OK, public
gerrit-hooks has posted comments on this change.
Change subject: net draft: bond was bridged and now it's not, wow
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure he
gerrit-hooks has posted comments on this change.
Change subject: fc-scan: Rename host scanning threads
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: misc: Rename event threads to event/N
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: task: Rename cleanup threads
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url
gerrit-hooks has posted comments on this change.
Change subject: monitor: Rename storage domain monitor threads
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure heade
gerrit-hooks has posted comments on this change.
Change subject: check: Rename check event loop thread
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: sp: Rename storage domain upgrade threads
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header mat
gerrit-hooks has posted comments on this change.
Change subject: net: Introduce iface.exists and start using it in ip.dhclient
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
gerrit-hooks has posted comments on this change.
Change subject: hsm: Rename init thread
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
gerrit-hooks has posted comments on this change.
Change subject: mailbox: Rename storage mailbox threads
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header match
gerrit-hooks has posted comments on this change.
Change subject: resourceManager: Rename cleanup threads
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header match
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: Introduce iface.exists and start using it in ip.dhclient
..
net: Introduce iface.exists and start using it in ip.dhclient
Change-Id: Ifcece92726e7
gerrit-hooks has posted comments on this change.
Change subject: net: ifcfg - dhclient should always be stopped
..
Patch Set 14:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
Dan Kenigsberg has posted comments on this change.
Change subject: net: Introduce iface.exists and start using it in ip.dhclient
..
Patch Set 6: Code-Review+2
raising score
--
To view, visit https://gerrit.ovirt.org/63086
To
gerrit-hooks has posted comments on this change.
Change subject: net draft: bond was bridged and now it's not, wow
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure he
Dan Kenigsberg has posted comments on this change.
Change subject: net: ifcfg - dhclient should always be stopped
..
Patch Set 13: Code-Review+2
horrible!
raising score regardless...
--
To view, visit https://gerrit.ovirt.org
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: ifcfg - dhclient should always be stopped
..
net: ifcfg - dhclient should always be stopped
While running functional tests, it has been observed t
gerrit-hooks has posted comments on this change.
Change subject: net: Expose disable IPv6 through ip.address module
..
Patch Set 13:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To v
Dan Kenigsberg has posted comments on this change.
Change subject: net: Expose disable IPv6 through ip.address module
..
Patch Set 12: Code-Review+2
raising score
--
To view, visit https://gerrit.ovirt.org/62830
To unsubscrib
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: Expose disable IPv6 through ip.address module
..
net: Expose disable IPv6 through ip.address module
Change-Id: I0673da939d575ab43d53cdb1fced4273db
gerrit-hooks has posted comments on this change.
Change subject: hostdev: properly set is_hostdevice
..
Patch Set 7:
* #1356161::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1356161::OK, public bug
* Check Produc
gerrit-hooks has posted comments on this change.
Change subject: hostdev: prefer numa nodes close to device MMIO
..
Patch Set 15:
* #1356161::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1356161::OK, public bug
*
gerrit-hooks has posted comments on this change.
Change subject: hostdev: expose numa_node in host device
..
Patch Set 13:
* #1356161::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1356161::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: hostdev: report device MMIO numa node
..
Patch Set 13:
* #1356161::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1356161::OK, public bug
* Check Pro
gerrit-hooks has posted comments on this change.
Change subject: vmxml: move condition from appendNumaTune to buildDomainXML
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, ma
gerrit-hooks has posted comments on this change.
Change subject: devices: add is_hostdevice attribute
..
Patch Set 7:
* #1356161::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1356161::OK, public bug
* Check Produ
gerrit-hooks has posted comments on this change.
Change subject: rng: allow urandom as virtio rng entropy source
..
Patch Set 10:
* #1347669::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1347669::OK, public bug
*
Nir Soffer has posted comments on this change.
Change subject: hsm: Rename init thread
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/63525
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit
Nir Soffer has posted comments on this change.
Change subject: monitor: Rename storage domain monitor threads
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/63524
To unsubscribe, visit https://gerrit.ovi
Nir Soffer has posted comments on this change.
Change subject: fc-scan: Rename host scanning threads
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/63523
To unsubscribe, visit https://gerrit.ovirt.org/se
Nir Soffer has posted comments on this change.
Change subject: sd: Remove unused variable and evil thread
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/63520
To unsubscribe, visit https://gerrit.ovirt.o
gerrit-hooks has posted comments on this change.
Change subject: net draft: bond was bridged and now it's not, wow
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure he
gerrit-hooks has posted comments on this change.
Change subject: net draft: bond was bridged and now it's not, wow
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure he
Allon Mureinik has posted comments on this change.
Change subject: storage: Remove unneeded multipath call
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/63427
To unsubscribe, visit https://gerrit.ovi
Nir Soffer has posted comments on this change.
Change subject: resourceManager: Rename cleanup threads
..
Patch Set 2: Continuous-Integration+1
CI failures not relevant
--
To view, visit https://gerrit.ovirt.org/63527
To unsu
Nir Soffer has posted comments on this change.
Change subject: fc-scan: Rename host scanning threads
..
Patch Set 2: Continuous-Integration+1
CI failures not relevant
--
To view, visit https://gerrit.ovirt.org/63523
To unsubs
Petr Horáček has posted comments on this change.
Change subject: net test: Clean lease files on setup-cleanup
..
Patch Set 8: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/63089/8/tests/network/netfunctestlib.py
File
Tomas Golembiovsky has posted comments on this change.
Change subject: v2v: Support for ova exported from AWS
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/63517
To unsubscribe, visit https://gerrit.
gerrit-hooks has posted comments on this change.
Change subject: v2v: Support for ova exported from AWS
..
Patch Set 2:
* #1371843::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1371843::OK, public bug
* Check Pro
Shahar Havivi has posted comments on this change.
Change subject: v2v: Support for ova exported from AWS
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/63517/1//COMMIT_MSG
Commit Message:
Line 8:
Line 9: When expor
Nir Soffer has posted comments on this change.
Change subject: Live Merge: Refresh base volume before live merge
..
Patch Set 1: Code-Review+1 Continuous-Integration+1
Test failures are not relevant.
--
To view, visit https:/
Nir Soffer has posted comments on this change.
Change subject: Live Merge: Refresh base volume before live merge
..
Patch Set 1: Code-Review+1 Continuous-Integration+1
--
To view, visit https://gerrit.ovirt.org/63532
To unsubs
Tomas Golembiovsky has posted comments on this change.
Change subject: v2v: Support for ova exported from AWS
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/63517/1//COMMIT_MSG
Commit Message:
Line 8:
Line 9: When
Ramesh N has posted comments on this change.
Change subject: gluster: set selinux labels while creating bricks
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/62773/4/lib/vdsm/gluster/exception.py
File lib/vdsm/gluste
gerrit-hooks has posted comments on this change.
Change subject: Live Merge: Refresh base volume before live merge
..
Patch Set 1:
* #1367281::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1367281::OK, public bug
Hello Nir Soffer,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/63532
to review the following change.
Change subject: Live Merge: Refresh base volume before live merge
..
Live Merge: Refresh base
Ala Hino has posted comments on this change.
Change subject: Live Merge: Refresh base volume before live merge
..
Patch Set 1: Verified+1
Verified on master
--
To view, visit https://gerrit.ovirt.org/63532
To unsubscribe, vis
gerrit-hooks has posted comments on this change.
Change subject: net: Bond - Add logging to the bond driver.
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header m
gerrit-hooks has posted comments on this change.
Change subject: net: Bond - preserve original slaves link state.
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure hea
gerrit-hooks has posted comments on this change.
Change subject: net: Bond - add refresh method to update bond config
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: net test: Clean lease files on setup-cleanup
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: net: Bond - adding a transaction context.
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header mat
gerrit-hooks has posted comments on this change.
Change subject: net: Expose owned_device method through the configurator
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: net: Link setup module - includes bond setup logic.
..
Patch Set 17:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: net: Use Linux bonds with OVS networks
..
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header match
gerrit-hooks has posted comments on this change.
Change subject: net: Bond - Expose the (kernel) bond list.
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header ma
gerrit-hooks has posted comments on this change.
Change subject: check: Rename check event loop thread
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: monitor: Rename storage domain monitor threads
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure heade
gerrit-hooks has posted comments on this change.
Change subject: sd: Remove unused variable and evil thread
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header ma
gerrit-hooks has posted comments on this change.
Change subject: task: Rename cleanup threads
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url
gerrit-hooks has posted comments on this change.
Change subject: misc: Rename event threads to event/N
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: hsm: Rename init thread
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
gerrit-hooks has posted comments on this change.
Change subject: fc-scan: Rename host scanning threads
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: resourceManager: Rename cleanup threads
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header match
gerrit-hooks has posted comments on this change.
Change subject: mailbox: Rename storage mailbox threads
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header match
gerrit-hooks has posted comments on this change.
Change subject: sp: Rename storage domain upgrade threads
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header mat
Nir Soffer has posted comments on this change.
Change subject: storage: py3: misc.py compliance
..
Patch Set 10:
Who is verifying this?
--
To view, visit https://gerrit.ovirt.org/63192
To unsubscribe, visit https://gerrit.ovi
gerrit-hooks has posted comments on this change.
Change subject: monitor: Rename storage domain monitor threads
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure heade
gerrit-hooks has posted comments on this change.
Change subject: sp: Rename storage domain upgrade threads
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header mat
gerrit-hooks has posted comments on this change.
Change subject: check: Rename check event loop thread
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: mailbox: Rename storage mailbox threads
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header match
gerrit-hooks has posted comments on this change.
Change subject: sd: Remove unused variable and evil thread
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header ma
gerrit-hooks has posted comments on this change.
Change subject: misc: Rename event threads to event/N
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: fc-scan: Rename host scanning threads
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: hsm: Rename init thread
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
gerrit-hooks has posted comments on this change.
Change subject: task: Rename cleanup threads
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url
gerrit-hooks has posted comments on this change.
Change subject: resourceManager: Rename cleanup threads
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header match
Nir Soffer has uploaded a new change for review.
Change subject: fc-scan: Rename host scanning threads
..
fc-scan: Rename host scanning threads
Use the scsi host name (e.g. host6) instead of default Thread-N for the
scanning thr
Nir Soffer has uploaded a new change for review.
Change subject: misc: Rename event threads to event/N
..
misc: Rename event threads to event/N
Each time we submit an event using storage.misc.Event, we start one or
tow threads.
Nir Soffer has uploaded a new change for review.
Change subject: hsm: Rename init thread
..
hsm: Rename init thread
HSM init thread was named "storageRefresh", now it is named "hsm/init"
to match other thread names.
Change-Id:
Nir Soffer has uploaded a new change for review.
Change subject: mailbox: Rename storage mailbox threads
..
mailbox: Rename storage mailbox threads
Previously mailbox threads were named "mailbox.SPMMonitor" and
"mailbox.HSMMonit
Nir Soffer has uploaded a new change for review.
Change subject: check: Rename check event loop thread
..
check: Rename check event loop thread
Until now, the check event loop thread was named "Thread-12", now it is
named "check
Nir Soffer has uploaded a new change for review.
Change subject: resourceManager: Rename cleanup threads
..
resourceManager: Rename cleanup threads
Resources cleanup threads used the standard names (Thread-N), now they
use "rm/s
Nir Soffer has uploaded a new change for review.
Change subject: sp: Rename storage domain upgrade threads
..
sp: Rename storage domain upgrade threads
Previously the threads used the default name (Thread-N). Using now
"upgrade/
Nir Soffer has uploaded a new change for review.
Change subject: monitor: Rename storage domain monitor threads
..
monitor: Rename storage domain monitor threads
These threads used the default names (Thread-N), making it hard to
Nir Soffer has uploaded a new change for review.
Change subject: task: Rename cleanup threads
..
task: Rename cleanup threads
Task cleanup threads used the default names (Thread-N), now they are
named "task/short-uuid". Short-uu
Nir Soffer has uploaded a new change for review.
Change subject: sd: Remove unused variable and evil thread
..
sd: Remove unused variable and evil thread
If storage domain had a non-null start instance variable, we used to
start
Dan Kenigsberg has posted comments on this change.
Change subject: rng: allow urandom as virtio rng entropy source
..
Patch Set 9: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/59031/9/lib/vdsm/host/rngsources.py
File
Dan Kenigsberg has posted comments on this change.
Change subject: rng: allow urandom as virtio rng entropy source
..
Patch Set 9: Continuous-Integration+1
FAIL: test_ip_info (network.netinfo_test.TestNetinfo)
indeed unrelated
101 - 200 of 259 matches
Mail list logo