Ramesh N has posted comments on this change.

Change subject: gluster: set selinux labels while creating bricks
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/62773/4/lib/vdsm/gluster/exception.py
File lib/vdsm/gluster/exception.py:

Line 481: 
Line 482: class GlusterHostFailedToSetSelinuxContext(GlusterHostException):
Line 483:     code = 4420
Line 484: 
Line 485:     def __init__(self, brickMountPoint=None, rc=0, out=(), err=()):
> actually it can't be done. Let me remove the default.
Looks like we need the default arguments because of an issue in python. 

see for more info on this. https://gerrit.ovirt.org/#/c/45001
Line 486:         self.rc = rc
Line 487:         self.out = out
Line 488:         self.err = err
Line 489:         self.message = "Failed to set selinux context on the brick : 
%s" \


-- 
To view, visit https://gerrit.ovirt.org/62773
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ca5fec80831073643635875095b88c1c4c2132e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ramesh N <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: gerrit-hooks <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/admin/lists/[email protected]

Reply via email to