Change in vdsm[master]: net: tests: use nics in test_add_bond_with_bad_name_fails

2017-08-06 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79968 ) Change subject: net: tests: use nics in test_add_bond_with_bad_name_fails .. net: tests: use nics in test_add

Change in vdsm[master]: net: sb validator: raise on missing sb device.

2017-08-06 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79953 ) Change subject: net: sb validator: raise on missing sb device. .. net: sb validator: raise on missing sb devi

Change in vdsm[master]: net: tests: Add the missing switch parameter to *bond_with_n...

2017-08-06 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79955 ) Change subject: net: tests: Add the missing switch parameter to *bond_with_no_nics_fails .. net: tests: Add

Change in vdsm[master]: lvs-stats: Analyze sosreport lvm commands output

2017-08-06 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: lvs-stats: Analyze sosreport lvm commands output .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/79698/2//COMMIT_MSG Commit Mes

Change in vdsm[master]: Change syslog logger format

2017-08-06 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has uploaded a new change for review. Change subject: Change syslog logger format .. Change syslog logger format This patches modifies the logger to use for standard format for syslog print.

Change in vdsm[master]: Handling fatal fail in supervdsm when log conf is invalid

2017-08-06 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has uploaded a new change for review. Change subject: Handling fatal fail in supervdsm when log conf is invalid .. Handling fatal fail in supervdsm when log conf is invalid Copying same trea

Change in vdsm[master]: net: Introduce ipv4 config validator

2017-08-06 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79951 ) Change subject: net: Introduce ipv4 config validator .. net: Introduce ipv4 config validator ipv4 configurat

Change in vdsm[master]: net: tests: Remove func_net_ip_test.py

2017-08-06 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79954 ) Change subject: net: tests: Remove func_net_ip_test.py .. net: tests: Remove func_net_ip_test.py There alrea

Change in vdsm[master]: net: sb validator: raise on missing sb device.

2017-08-06 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: sb validator: raise on missing sb device. .. Patch Set 20: (1 comment) https://gerrit.ovirt.org/#/c/79953/20//COMMIT_MSG Commit Mes

Change in vdsm[master]: net: Centralize call to pre-config validation

2017-08-06 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80015 ) Change subject: net: Centralize call to pre-config validation .. net: Centralize call to pre-config validatio

Change in vdsm[master]: net: sb validator: raise on missing sb device.

2017-08-05 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: sb validator: raise on missing sb device. .. Patch Set 20: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/79953/20

Change in vdsm[master]: net: Centralize call to pre-config validation

2017-08-05 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: Centralize call to pre-config validation .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/80015 To

Change in vdsm[master]: drop execCmd(raw)

2017-08-05 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: drop execCmd(raw) .. Patch Set 2: Code-Review-1 nope, there's still plenty of code using the depending on raw=False. -- To view,

Change in vdsm[master]: Openstacknet hooks must check provider type to run

2017-08-05 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: Openstacknet hooks must check provider type to run .. Patch Set 1: (3 comments) https://gerrit.ovirt.org/#/c/80155/1//COMMIT_MSG Commit

Change in vdsm[master]: tool.service: avoid execCmd(raw=False)

2017-08-05 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has uploaded a new change for review. Change subject: tool.service: avoid execCmd(raw=False) .. tool.service: avoid execCmd(raw=False) tool.service is the only place where we use raw=False t

Change in vdsm[master]: checkimages hook: avoid using execCmd(sync=False)

2017-08-05 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has uploaded a new change for review. Change subject: checkimages hook: avoid using execCmd(sync=False) .. checkimages hook: avoid using execCmd(sync=False) I would like to move hooking.py t

Change in vdsm[master]: drop execCmd(raw)

2017-08-05 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has uploaded a new change for review. Change subject: drop execCmd(raw) .. drop execCmd(raw) The `raw` argument was ill-conceived, as it modified the type of the output of execCmd. Nowadays

Change in vdsm[master]: RPC: Add missing return statement when handling messages

2017-08-04 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79308 ) Change subject: RPC: Add missing return statement when handling messages .. RPC: Add missing return statement

Change in vdsm[master]: RPC: Add missing return statement

2017-08-04 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79328 ) Change subject: RPC: Add missing return statement .. RPC: Add missing return statement In the current code,

Change in vdsm[master]: jsonrpc tests: Discard the dependency on the network package

2017-08-04 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: jsonrpc tests: Discard the dependency on the network package .. Patch Set 1: Code-Review+2 raising scores -- To view, visit https

Change in vdsm[master]: jsonrpc tests: Discard the dependency on the network package

2017-08-04 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79950 ) Change subject: jsonrpc tests: Discard the dependency on the network package .. jsonrpc tests: Discard the de

Change in vdsm[master]: tool: remove dummy bridge

2017-08-04 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79596 ) Change subject: tool: remove dummy bridge .. tool: remove dummy bridge Add a command that removes libvirt du

Change in vdsm[master]: net build, take 2: Unify module collection on the network dir

2017-08-04 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80178 ) Change subject: net build, take 2: Unify module collection on the network dir .. net build, take 2: Unify mod

Change in vdsm[master]: tool: list/clear networks configured by VDSM

2017-08-04 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79495 ) Change subject: tool: list/clear networks configured by VDSM .. tool: list/clear networks configured by VDSM

Change in vdsm[master]: tool: remove dummy bridge

2017-08-04 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: tool: remove dummy bridge .. Patch Set 6: Code-Review-1 my fault! test_commit('0.10', 0

Change in vdsm[master]: lvs-stats: Analyze sosreport lvm commands output

2017-08-04 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: lvs-stats: Analyze sosreport lvm commands output .. Patch Set 2: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/79698/2

Change in vdsm[master]: net: Raise a meaningful exception for multiple sb nics

2017-08-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79625 ) Change subject: net: Raise a meaningful exception for multiple sb nics .. net: Raise a meaningful exception f

Change in vdsm[master]: net: Allow QoS caps to ignore nets with multiple sb nics

2017-08-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79621 ) Change subject: net: Allow QoS caps to ignore nets with multiple sb nics .. net: Allow QoS caps to ignore net

Change in vdsm[master]: net: Raise a meaningful exception for multiple sb nics

2017-08-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: Raise a meaningful exception for multiple sb nics .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/79625

Change in vdsm[master]: net: Allow QoS caps to ignore nets with multiple sb nics

2017-08-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: Allow QoS caps to ignore nets with multiple sb nics .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/79621

Change in vdsm[master]: net: Add info lldp to lldp

2017-08-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79405 ) Change subject: net: Add info lldp to lldp .. net: Add info lldp to lldp lldp is extended to provide informa

Change in vdsm[master]: net: Report lldp through new getLldp command

2017-08-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79093 ) Change subject: net: Report lldp through new getLldp command .. net: Report lldp through new getLldp command

Change in vdsm[master]: net: Enable LLDP on NICs

2017-08-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79824 ) Change subject: net: Enable LLDP on NICs .. net: Enable LLDP on NICs lldpad has to be configured to provide

Change in vdsm[master]: net: Introduce the LLDPAD driver with an LLDP interface

2017-08-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/78117 ) Change subject: net: Introduce the LLDPAD driver with an LLDP interface .. net: Introduce the LLDPAD driver w

Change in vdsm[master]: net build, take 2: Unify module collection on the network dir

2017-08-03 Thread Code Review
From Dan Kenigsberg : Hello Jenkins CI, gerrit-hooks, Petr Horáček, Leon Goldberg, Edward Haas, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/80178 to review the following change. Change subject: net build, take 2: Unify module collection on the networ

Change in vdsm[master]: net build, take 2: Unify module collection on the network dir

2017-08-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has reverted this change. ( https://gerrit.ovirt.org/80178 ) Change subject: net build, take 2: Unify module collection on the network dir .. Uploaded patch set 1. -- To view, visit https

Change in vdsm[master]: Revert "net build: Unify module collection on the network dir"

2017-08-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: Revert "net build: Unify module collection on the network dir" .. Patch Set 1: Continuous-Integration+1 -- To view, visit https://gerrit

Change in vdsm[master]: Revert "net build: Unify module collection on the network dir"

2017-08-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80177 ) Change subject: Revert "net build: Unify module collection on the network dir" .. Revert "net build: Unify mo

Change in vdsm[master]: Revert "net build: Unify module collection on the network dir"

2017-08-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: Revert "net build: Unify module collection on the network dir" .. Patch Set 1: Code-Review+2 Verified+1 -- To view, v

Change in vdsm[master]: Revert "net build: Unify module collection on the network dir"

2017-08-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has reverted this change. ( https://gerrit.ovirt.org/80177 ) Change subject: Revert "net build: Unify module collection on the network dir" .. Uploaded patch set 1. -- To view, visit https

Change in vdsm[master]: Revert "net build: Unify module collection on the network dir"

2017-08-03 Thread Code Review
From Dan Kenigsberg : Hello Jenkins CI, gerrit-hooks, Petr Horáček, Leon Goldberg, Edward Haas, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/80177 to review the following change. Change subject: Revert "net build: Unify module collection on the n

Change in vdsm[master]: net build: Unify module collection on the network dir

2017-08-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80014 ) Change subject: net build: Unify module collection on the network dir .. net build: Unify module collection o

Change in vdsm[master]: net build: Unify module collection on the network dir

2017-08-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net build: Unify module collection on the network dir .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/80014 To

Change in vdsm[master]: tool: list/clear networks configured by VDSM

2017-08-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: tool: list/clear networks configured by VDSM .. Patch Set 7: Eddy, what's the remaining problem? Why did you not grant +2? -- To view,

Change in vdsm[master]: move hooks to common

2017-08-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: move hooks to common .. Patch Set 12: (1 comment) https://gerrit.ovirt.org/#/c/79695/12/lib/vdsm/common/hook/hooking.py File lib/vdsm/co

Change in vdsm[master]: cmdutils: add env to exec_cmd()'s args

2017-08-03 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: cmdutils: add env to exec_cmd()'s args .. Patch Set 10: (1 comment) https://gerrit.ovirt.org/#/c/79694/10/tests/common/cmdutils_test.py

Change in vdsm[master]: RPC client: Add methods to subscribe, unsubscribe and notify

2017-08-03 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: RPC client: Add methods to subscribe, unsubscribe and notify .. Patch Set 46: Code-Review+1 -- To view, visit https://gerrit.ovirt.org

Change in vdsm[master]: RPC: Add some unit tests for JsonRpcClient

2017-08-03 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: RPC: Add some unit tests for JsonRpcClient .. Patch Set 2: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/80048/2//COMMIT_MSG

Change in vdsm[master]: RPC: JsonRpcClient supports multiple subscriptions

2017-08-03 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: RPC: JsonRpcClient supports multiple subscriptions .. Patch Set 51: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/78656 To

Change in vdsm[master]: RPC: Add missing return statement

2017-08-03 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: RPC: Add missing return statement .. Patch Set 13: ready for merge -- To view, visit https://gerrit.ovirt.org/79328 To unsubscribe, vis

Change in vdsm[master]: RPC: Add missing return statement when handling messages

2017-08-03 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: RPC: Add missing return statement when handling messages .. Patch Set 13: Code-Review+1 ready for merge -- To view, visit https

Change in vdsm[master]: stomp: fix AsyncDispatcher next_check_interval

2017-08-02 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: stomp: fix AsyncDispatcher next_check_interval .. Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/79384 To

Change in vdsm[master]: move exec_sync_bytes to common.cmdutils.exec_cmd

2017-08-01 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: move exec_sync_bytes to common.cmdutils.exec_cmd .. Patch Set 10: Verified+1 OST passes http://jenkins.ovirt.org/view/oVirt%20system%20t

Change in vdsm[master]: cmdutils: add env to exec_cmd()'s args

2017-08-01 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: cmdutils: add env to exec_cmd()'s args .. Patch Set 10: Verified+1 OST passes http://jenkins.ovirt.org/view/oVirt%20system%20tests/job/o

Change in vdsm[master]: move hooks to common

2017-07-31 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: move hooks to common .. Patch Set 12: http://jenkins.ovirt.org/view/oVirt%20system%20tests/job/ovirt-system-tests_manual/899/ -- To vie

Change in vdsm[master]: pytest: Set locale properly for pytest based tests

2017-07-31 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: pytest: Set locale properly for pytest based tests .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/80027 To

Change in vdsm[master]: move hooks to common

2017-07-31 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: move hooks to common .. Patch Set 12: ci please build -- To view, visit https://gerrit.ovirt.org/79695 To unsubscribe, visit https://ge

Change in vdsm[master]: build: remove constants.py from dist package

2017-07-31 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: build: remove constants.py from dist package .. Patch Set 1: Tomas, it does not have to be part of `make check`. If it helps you, you can

Change in vdsm[master]: api: log only external pings

2017-07-31 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: api: log only external pings .. Patch Set 13: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/78142/13//COMMIT_MSG Commit

Change in vdsm[master]: move vdsm.config to common

2017-07-30 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has uploaded a new change for review. Change subject: move vdsm.config to common .. move vdsm.config to common vdsm.config is used by all subsystems. It should thus sit in common. This patch

Change in vdsm[master]: net: import config from vdsm.common.config

2017-07-30 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has uploaded a new change for review. Change subject: net: import config from vdsm.common.config .. net: import config from vdsm.common.config Change-Id: Id1fc5799d93e4328da288875b9b48d920ea

Change in vdsm[master]: move exec_sync_bytes to common.cmdutils.exec_cmd

2017-07-30 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: move exec_sync_bytes to common.cmdutils.exec_cmd .. Patch Set 8: (1 comment) https://gerrit.ovirt.org/#/c/79693/8/lib/vdsm/network/cmd.p

Change in vdsm[master]: dockerfile: Remove Fedora 24 image

2017-07-30 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79946 ) Change subject: dockerfile: Remove Fedora 24 image .. dockerfile: Remove Fedora 24 image We stopped using th

Change in vdsm[master]: gluster: Disable blivet tests also on Fedora 26

2017-07-30 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79948 ) Change subject: gluster: Disable blivet tests also on Fedora 26 .. gluster: Disable blivet tests also on Fedo

Change in vdsm[master]: dockerfile: Remove Fedora 24 image

2017-07-30 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: dockerfile: Remove Fedora 24 image .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/79946 To unsubscribe, visit

Change in vdsm[master]: travis: Add Fedora 26 build

2017-07-30 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79947 ) Change subject: travis: Add Fedora 26 build .. travis: Add Fedora 26 build Change-Id: Ie036c6d6ac92821067046

Change in vdsm[master]: net: sb validator: raise on missing sb device.

2017-07-29 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: sb validator: raise on missing sb device. .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/79953/1//COMMIT_MSG Commit Messa

Change in vdsm[master]: net: tests: add "param" to test_add_net_missing_sb_device_fails

2017-07-29 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: tests: add "param" to test_add_net_missing_sb_device_fails .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/79952/1//COMMIT

Change in vdsm[master]: dockerfile: Add Fedora 26 image

2017-07-29 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79945 ) Change subject: dockerfile: Add Fedora 26 image .. dockerfile: Add Fedora 26 image Change-Id: Ia63d38c578094

Change in vdsm[master]: net: Introduce the LLDPAD driver with an LLDP interface

2017-07-29 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: Introduce the LLDPAD driver with an LLDP interface .. Patch Set 18: CI-1 due to ./lib/vdsm/network/lldpad/lldptool.py:126:80: E501 l

Change in vdsm[ovirt-4.1]: m2c: uses different protocol constant names

2017-07-29 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: m2c: uses different protocol constant names .. Patch Set 4: Code-Review+2 (1 comment) https://gerrit.ovirt.org/#/c/79664/4/lib/vdsm

Change in vdsm[ovirt-4.1]: m2c: uses different protocol constant names

2017-07-29 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79664 ) Change subject: m2c: uses different protocol constant names .. m2c: uses different protocol constant names M

Change in vdsm[master]: ssl: handle handshake errors

2017-07-29 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: ssl: handle handshake errors .. Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/79668/7/lib/vdsm/sslutils.py File lib/vdsm/sslutil

Change in vdsm[master]: jsonrpc tests: Discard the dependency on the network package

2017-07-29 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: jsonrpc tests: Discard the dependency on the network package .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org

Change in vdsm[master]: gluster: Disable blivet tests also on Fedora 26

2017-07-29 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: gluster: Disable blivet tests also on Fedora 26 .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/79948 To

Change in vdsm[master]: travis: Add Fedora 26 build

2017-07-29 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: travis: Add Fedora 26 build .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/79947 To unsubscribe, visit https

Change in vdsm[master]: dockerfile: Remove Fedora 24 image

2017-07-29 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: dockerfile: Remove Fedora 24 image .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/79946/2//COMMIT_MSG Commit Message: Line 3:

Change in vdsm[master]: dockerfile: Add Fedora 26 image

2017-07-29 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: dockerfile: Add Fedora 26 image .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/79945 To unsubscribe, visit

Change in vdsm[master]: net: tests: Migrate testFailWithInvalidParams to the new fun...

2017-07-28 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79905 ) Change subject: net: tests: Migrate testFailWithInvalidParams to the new func tests .. net: tests: Migrate t

Change in vdsm[master]: cmdutils: add env to exec_cmd()'s args

2017-07-28 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: cmdutils: add env to exec_cmd()'s args .. Patch Set 8: Verified+1 -- To view, visit https://gerrit.ovirt.org/79694 To unsubscribe, visit

Change in vdsm[master]: hooking: move to lib

2017-07-28 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79638 ) Change subject: hooking: move to lib .. hooking: move to lib As part of broader migration we move hooking.py

Change in vdsm[master]: hooking: move to lib

2017-07-28 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: hooking: move to lib .. Patch Set 9: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/79638 To unsubscribe, visit https

Change in vdsm[master]: RPC: Fix tests in integration/jsonRpcTests.py

2017-07-28 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79744 ) Change subject: RPC: Fix tests in integration/jsonRpcTests.py .. RPC: Fix tests in integration/jsonRpcTests.p

Change in vdsm[master]: RPC: Fix tests in integration/jsonRpcTests.py

2017-07-28 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: RPC: Fix tests in integration/jsonRpcTests.py .. Patch Set 7: so very sorry, I forgot all about these tests. -- To view, visit https://

Change in vdsm[master]: move exec_sync_bytes to common.cmdutils.exec_cmd

2017-07-28 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: move exec_sync_bytes to common.cmdutils.exec_cmd .. Patch Set 8: Verified+1 -- To view, visit https://gerrit.ovirt.org/79693 To unsubscr

Change in vdsm[master]: build: remove constants.py from dist package

2017-07-28 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: build: remove constants.py from dist package .. Patch Set 1: Tomas, can you suggest a test that would make sure we do not break your use

Change in vdsm[master]: net: tests: Migrate testFailWithInvalidParams to the new fun...

2017-07-28 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: tests: Migrate testFailWithInvalidParams to the new func tests .. Patch Set 2: Code-Review-1 requires manual rebase -- To view

Change in vdsm[master]: net: tests: Migrate testFailWithInvalidIpConfig to the new f...

2017-07-28 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79438 ) Change subject: net: tests: Migrate testFailWithInvalidIpConfig to the new func tests .. net: tests: Migrate

Change in vdsm[master]: move hooks to common

2017-07-28 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: move hooks to common .. Patch Set 6: -Verified Thanks, I agree that my verification was a bit lazy. I'll do something more serious next

Change in vdsm[master]: net: place bonding defaults under /var/run

2017-07-27 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79436 ) Change subject: net: place bonding defaults under /var/run .. net: place bonding defaults under /var/run vds

Change in vdsm[master]: net test: use static bonding defaults if dump fails

2017-07-27 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79889 ) Change subject: net test: use static bonding defaults if dump fails .. net test: use static bonding defaults

Change in vdsm[master]: net test: use static bonding defaults if dump fails

2017-07-27 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net test: use static bonding defaults if dump fails .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/79889 To unsub

Change in vdsm[master]: testrunner: mock vdsm.common.constants.P_VDSM

2017-07-27 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: testrunner: mock vdsm.common.constants.P_VDSM .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/79911 To unsubscribe

Change in vdsm[master]: testrunner: mock vdsm.common.constants.P_VDSM

2017-07-27 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79911 ) Change subject: testrunner: mock vdsm.common.constants.P_VDSM .. testrunner: mock vdsm.common.constants.P_VDS

Change in vdsm[master]: net test: use static bonding defaults if dump fails

2017-07-27 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net test: use static bonding defaults if dump fails .. Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/79889/2/tests/network/nett

Change in vdsm[master]: cmdutils: add env to exec_cmd()'s args

2017-07-27 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: cmdutils: add env to exec_cmd()'s args .. Patch Set 6: Verified+1 -- To view, visit https://gerrit.ovirt.org/79694 To unsubscribe, visit

Change in vdsm[master]: move exec_sync_bytes to common.cmdutils.exec_cmd

2017-07-27 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: move exec_sync_bytes to common.cmdutils.exec_cmd .. Patch Set 6: Verified+1 OST http://jenkins.ovirt.org/view/oVirt%20system%20tests/job

Change in vdsm[master]: net: place bonding defaults under /var/run

2017-07-27 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: place bonding defaults under /var/run .. Patch Set 10: Verified+1 OST http://jenkins.ovirt.org/view/oVirt%20system%20tests/job/ovir

Change in vdsm[master]: net test: use static bonding defaults if dump fails

2017-07-27 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net test: use static bonding defaults if dump fails .. Patch Set 2: Verified+1 OST http://jenkins.ovirt.org/view/oVirt%20system%20tests/

Change in vdsm[master]: move hooks to common

2017-07-27 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: move hooks to common .. Patch Set 6: Verified+1 OST http://jenkins.ovirt.org/view/oVirt%20system%20tests/job/ovirt-system-tests_manual/8

<    1   2   3   4   5   6   7   8   9   10   >