Change in vdsm[master]: tool: remove dummy bridge

2017-07-20 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: tool: remove dummy bridge .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/79596 To unsubscribe, visit https

Change in vdsm[master]: RPC: Refactor JSON RPC exceptions

2017-07-20 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: RPC: Refactor JSON RPC exceptions .. Patch Set 29: (1 comment) https://gerrit.ovirt.org/#/c/78660/29//COMMIT_MSG Commit Message: Line 1

Change in vdsm[master]: net: Allow QoS caps to ignore nets with multiple sb nics

2017-07-19 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: Allow QoS caps to ignore nets with multiple sb nics .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/79621

Change in vdsm[master]: hooks: support to read/write the raw domain XML

2017-07-19 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: hooks: support to read/write the raw domain XML .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/79489 To

Change in vdsm[master]: net: Get iface mtu using netlink instead of sysfs

2017-07-19 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: Get iface mtu using netlink instead of sysfs .. Patch Set 2: Code-Review+2 no sure about efficiency, but new code looks nicer

Change in vdsm[master]: tool: clear networks configured by oVirt

2017-07-18 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: tool: clear networks configured by oVirt .. Patch Set 1: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/79495/1/lib/vdsm/tool

Change in vdsm[master]: network: remove ip from a nic used by a removed network

2017-07-18 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/76937 ) Change subject: network: remove ip from a nic used by a removed network .. network: remove ip from a nic used

Change in vdsm[ovirt-3.6]: sos: fix addCopySpecLimit call

2017-07-18 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: sos: fix addCopySpecLimit call .. Patch Set 2: Code-Review+2 Verified+1 ran sosreport -o vdsm -v debug with sos-3.3.5 and 3.4-6 -- To

Change in vdsm[ovirt-3.6]: sos: fix addCopySpecLimit call

2017-07-18 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has submitted this change and it was merged. ( https://gerrit.ovirt.org/79542 ) Change subject: sos: fix addCopySpecLimit call .. sos: fix addCopySpecLimit call sosreport 3.4 replace add_c

Change in vdsm[ovirt-3.6]: sos: fix addCopySpecLimit call

2017-07-18 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: sos: fix addCopySpecLimit call .. Patch Set 2: Continuous-Integration+1 -- To view, visit https://gerrit.ovirt.org/79542 To unsubscribe,

Change in vdsm[master]: static: use tabs for indetation in Makefile

2017-07-18 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: static: use tabs for indetation in Makefile .. Patch Set 1: Code-Review+2 Verified+1 Sorry! -- To view, visit https://gerrit.ovirt.org

Change in vdsm[master]: static: use tabs for indetation in Makefile

2017-07-18 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79494 ) Change subject: static: use tabs for indetation in Makefile .. static: use tabs for indetation in Makefile C

Change in vdsm[ovirt-4.1]: sos: fix addCopySpecLimit call

2017-07-18 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: sos: fix addCopySpecLimit call .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/79541 To unsubscribe, visit https:/

Change in vdsm[master]: sos: fix addCopySpecLimit call

2017-07-18 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79510 ) Change subject: sos: fix addCopySpecLimit call .. sos: fix addCopySpecLimit call sosreport 3.4 replace add_c

Change in vdsm[ovirt-3.6]: sos: fix addCopySpecLimit call

2017-07-18 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: sos: fix addCopySpecLimit call .. Patch Set 1: we need 3.6 bug for that -- To view, visit https://gerrit.ovirt.org/79542 To unsubscribe

Change in vdsm[master]: sos: fix addCopySpecLimit call

2017-07-18 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: sos: fix addCopySpecLimit call .. Patch Set 4: Code-Review+1 Verified+1 added REQUIRED_FOR in the comment - danken requested. didn&#

Change in vdsm[master]: sos: fix addCopySpecLimit call

2017-07-18 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: sos: fix addCopySpecLimit call .. Patch Set 2: verified with sos-3.4-1 and 3.3-5 -- To view, visit https://gerrit.ovirt.org/79510 To un

Change in vdsm[ovirt-3.6]: sos: fix addCopySpecLimit call

2017-07-18 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has uploaded a new change for review. Change subject: sos: fix addCopySpecLimit call .. sos: fix addCopySpecLimit call sosreport 3.4 replace add_copy_spec_limit with add_copy_spec. commit 2e

Change in vdsm[ovirt-4.1]: sos: fix addCopySpecLimit call

2017-07-18 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has uploaded a new change for review. Change subject: sos: fix addCopySpecLimit call .. sos: fix addCopySpecLimit call sosreport 3.4 replace add_copy_spec_limit with add_copy_spec. commit 2e

Change in vdsm[master]: sos: fix addCopySpecLimit call

2017-07-18 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: sos: fix addCopySpecLimit call .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/79510 To unsubscribe, visit https:/

Change in vdsm[master]: sos: fix addCopySpecLimit call

2017-07-17 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: sos: fix addCopySpecLimit call .. Patch Set 2: Code-Review+1 great. thanks! -- To view, visit https://gerrit.ovirt.org/79510 To

Change in vdsm[master]: spec: move libvirt-hook.sh to its static location

2017-07-16 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: spec: move libvirt-hook.sh to its static location .. Patch Set 3: Verified+1 $ rpmdiff /home/danken/.rpm/RPMS/x86_64/vdsm-4.20.1-200.git

Change in vdsm[master]: stomp: fix AsyncDispatcher next_check_interval

2017-07-16 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: stomp: fix AsyncDispatcher next_check_interval .. Patch Set 4: Code-Review+1 Irit's comment is correct - The discussion we have i

Change in vdsm[master]: spec: install libvirt-hook.sh in Makefile.am

2017-07-16 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: spec: install libvirt-hook.sh in Makefile.am .. Patch Set 2: Code-Review-1 we should instead move libvirt-hook.sh to static/etc/libvirt

Change in vdsm[master]: spec: install libvirt-hook.sh in Makefile.am

2017-07-15 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: spec: install libvirt-hook.sh in Makefile.am .. Patch Set 2: Verified+1 simple rename vs former version -- To view, visit https://gerri

Change in vdsm[master]: net.api: expose updateTimestamp as cancel_rollback()

2017-07-15 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net.api: expose updateTimestamp as cancel_rollback() .. Patch Set 5: Code-Review-1 I think that the args of setupNetworks and

Change in vdsm[master]: net.api: expose updateTimestamp as cancel_rollback()

2017-07-15 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net.api: expose updateTimestamp as cancel_rollback() .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/79299/4/lib/vdsm/network/a

Change in vdsm[master]: stomp: fix AsyncDispatcher next_check_interval

2017-07-14 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: stomp: fix AsyncDispatcher next_check_interval .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/79384/4/lib/yajsonrpc/stomp.py F

Change in vdsm[master]: net.api: expose cancel_rollback()

2017-07-14 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net.api: expose cancel_rollback() .. Patch Set 4: Verified+1 copying score -- To view, visit https://gerrit.ovirt.org/79299 To unsubscr

Change in vdsm[master]: net: place bonding defaults under /var/lib

2017-07-14 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has uploaded a new change for review. Change subject: net: place bonding defaults under /var/lib .. net: place bonding defaults under /var/lib vdsm-tool places bonding-defaults.json under /u

Change in vdsm[master]: introduce network.constants

2017-07-14 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has uploaded a new change for review. Change subject: introduce network.constants .. introduce network.constants This patch places a copy of autoconf-generated P_VDSM_RUN and P_VDSM_LIB insi

Change in vdsm[master]: spec: install libvirt-hook.sh in Makefile.am

2017-07-14 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: spec: install libvirt-hook.sh in Makefile.am .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/79435 To unsubscribe,

Change in vdsm[master]: spec: install libvirt-hook.sh in Makefile.am

2017-07-14 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has uploaded a new change for review. Change subject: spec: install libvirt-hook.sh in Makefile.am .. spec: install libvirt-hook.sh in Makefile.am Another step to clean %install in the spec

Change in vdsm[master]: gitignore: remove needless line

2017-07-14 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: gitignore: remove needless line .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/79427 To unsubscribe, visit https:

Change in vdsm[master]: gitignore: remove needless line

2017-07-14 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has uploaded a new change for review. Change subject: gitignore: remove needless line .. gitignore: remove needless line commit 930686 removed this script, but forgot to clean .gitignore of

Change in vdsm[master]: RPC: JsonRpcClient supports multiple subscriptions

2017-07-13 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: RPC: JsonRpcClient supports multiple subscriptions .. Patch Set 31: (1 comment) https://gerrit.ovirt.org/#/c/78656/31/lib/yajsonrpc/stom

Change in vdsm[ovirt-3.6]: virt net: Interface default driver name set to 'vhost'

2017-07-13 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: virt net: Interface default driver name set to 'vhost' .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt

Change in vdsm[ovirt-4.1]: net: NM acquire should ignore duplicate ifcfg files

2017-07-13 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: NM acquire should ignore duplicate ifcfg files .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/79378 To

Change in vdsm[ovirt-4.1]: net: NM acquire should ignore duplicate ifcfg files

2017-07-13 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has removed gerrit-hooks from this change. ( https://gerrit.ovirt.org/79378 ) Change subject: net: NM acquire should ignore duplicate ifcfg files .. Removed reviewer gerrit-hooks with the f

Change in vdsm[ovirt-4.1]: net: NM acquire should ignore duplicate ifcfg files

2017-07-13 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79378 ) Change subject: net: NM acquire should ignore duplicate ifcfg files .. net: NM acquire should ignore duplicat

Change in vdsm[master]: net: NM acquire should ignore duplicate ifcfg files

2017-07-13 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: NM acquire should ignore duplicate ifcfg files .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/79349 To

Change in vdsm[master]: net: NM acquire should ignore duplicate ifcfg files

2017-07-13 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79349 ) Change subject: net: NM acquire should ignore duplicate ifcfg files .. net: NM acquire should ignore duplicat

Change in vdsm[master]: RPC: JsonRpcClient supports multiple subscriptions

2017-07-13 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: RPC: JsonRpcClient supports multiple subscriptions .. Patch Set 31: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/78656/31/lib

Change in vdsm[master]: net: move EXT_TC into vdsm.network.tc

2017-07-13 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79295 ) Change subject: net: move EXT_TC into vdsm.network.tc .. net: move EXT_TC into vdsm.network.tc The only user

Change in vdsm[master]: RPC: Small refactor of ClientRpcTransportAdapter

2017-07-13 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: RPC: Small refactor of ClientRpcTransportAdapter .. Patch Set 24: (1 comment) https://gerrit.ovirt.org/#/c/78655/24/lib/yajsonrpc/stompr

Change in vdsm[master]: RPC: Small refactor of ClientRpcTransportAdapter

2017-07-13 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: RPC: Small refactor of ClientRpcTransportAdapter .. Patch Set 24: why don't you squeeze between this patch to https://gerrit.ovirt.org/#

Change in vdsm[master]: RPC: Add missing return statement when handling messages

2017-07-13 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: RPC: Add missing return statement when handling messages .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/79308

Change in vdsm[master]: RPC: Small refactor of ClientRpcTransportAdapter

2017-07-13 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: RPC: Small refactor of ClientRpcTransportAdapter .. Patch Set 24: (1 comment) https://gerrit.ovirt.org/#/c/78655/24/lib/yajsonrpc/stompr

Change in vdsm[master]: RPC: Add missing return statement

2017-07-13 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: RPC: Add missing return statement .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/79328 To unsubscribe, visit

Change in vdsm[master]: lib: move API

2017-07-13 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/77571 ) Change subject: lib: move API .. lib: move API As part of bigger effort we move modules from vdsm to lib.vds

Change in vdsm[master]: move vdsmd from vdsm dir

2017-07-13 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/69447 ) Change subject: move vdsmd from vdsm dir .. move vdsmd from vdsm dir vdsmd.py moved to lib/vdsm and vdsmd sc

Change in vdsm[master]: lib: move clientIF

2017-07-13 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/77570 ) Change subject: lib: move clientIF .. lib: move clientIF As part of bigger effort we move modules from vdsm

Change in vdsm[master]: lib: move API

2017-07-13 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: lib: move API .. Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/77571 To unsubscribe, visit https

Change in vdsm[master]: lib: move clientIF

2017-07-13 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: lib: move clientIF .. Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/77570 To unsubscribe, visit https

Change in vdsm[master]: net: move EXT_TC into vdsm.network.tc

2017-07-13 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: move EXT_TC into vdsm.network.tc .. Patch Set 3: Verified+1 Only change vs former version touched tests, which still pass -- To vi

Change in vdsm[master]: API: drop no-longer-needed calls to updateTimestamp

2017-07-12 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79298 ) Change subject: API: drop no-longer-needed calls to updateTimestamp .. API: drop no-longer-needed calls to up

Change in vdsm[master]: virt.sampling: drop dead code

2017-07-12 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79296 ) Change subject: virt.sampling: drop dead code .. virt.sampling: drop dead code recentClient was used by the

Change in vdsm[master]: net: remove vintage ovirt-node code piece

2017-07-12 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79293 ) Change subject: net: remove vintage ovirt-node code piece .. net: remove vintage ovirt-node code piece ovirt

Change in vdsm[master]: net: move EXT_TC into vdsm.network.tc

2017-07-12 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: move EXT_TC into vdsm.network.tc .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/79295/2/lib/vdsm/network/tc/_wrapper.py F

Change in vdsm[master]: net: NM acquire should ignore duplicate ifcfg files

2017-07-12 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: NM acquire should ignore duplicate ifcfg files .. Patch Set 1: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/79349/1/lib

Change in vdsm[master]: virt: remove vdsm/virt directory

2017-07-12 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: virt: remove vdsm/virt directory .. Patch Set 2: Code-Review+2 ! -- To view, visit https://gerrit.ovirt.org/79339 To unsubscribe

Change in vdsm[master]: net: move EXT_TC into vdsm.network.tc

2017-07-12 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: move EXT_TC into vdsm.network.tc .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/79295 To unsubscribe, visit

Change in vdsm[master]: virt.sampling: drop dead code

2017-07-12 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: virt.sampling: drop dead code .. Patch Set 3: Verified+1 OST passes http://jenkins.ovirt.org/view/oVirt%20system%20tests/job/ovirt-syste

Change in vdsm[master]: API: drop no-longer-needed calls to updateTimestamp

2017-07-12 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: API: drop no-longer-needed calls to updateTimestamp .. Patch Set 2: Verified+1 Ran 70 tests in 419.325s OK (SKIP=1) -- To view, visit

Change in vdsm[master]: [WIP] net.api: expose cancel_rollback()

2017-07-12 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: [WIP] net.api: expose cancel_rollback() .. Patch Set 3: ci please build -- To view, visit https://gerrit.ovirt.org/79299 To unsubscribe

Change in vdsm[master]: net: remove vintage ovirt-node code piece

2017-07-12 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: remove vintage ovirt-node code piece .. Patch Set 1: Verified+1 Ran 70 tests in 419.325s OK (SKIP=1) -- To view, visit https://ge

Change in vdsm[master]: net: move EXT_TC into vdsm.network.tc

2017-07-12 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: move EXT_TC into vdsm.network.tc .. Patch Set 2: Ran 70 tests in 419.325s OK (SKIP=1) -- To view, visit https://gerrit.ovirt.org/

Change in vdsm[master]: [WIP] net.api: expose cancel_rollback()

2017-07-12 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: [WIP] net.api: expose cancel_rollback() .. Patch Set 3: Verified+1 Ran 70 tests in 419.325s OK (SKIP=1) -- To view, visit https://gerr

Change in vdsm[master]: net: Report lldp through new getLldp command

2017-07-12 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: Report lldp through new getLldp command .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/79093/5/lib/vdsm/network/api.py Fi

Change in vdsm[master]: RPC: JsonRpcClient supports multiple subscriptions

2017-07-12 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: RPC: JsonRpcClient supports multiple subscriptions .. Patch Set 28: Code-Review-1 (4 comments) https://gerrit.ovirt.org/#/c/78656/28

Change in vdsm[master]: RPC: Small refactor of ClientRpcTransportAdapter

2017-07-12 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: RPC: Small refactor of ClientRpcTransportAdapter .. Patch Set 22: Code-Review-1 (3 comments) https://gerrit.ovirt.org/#/c/78655/22/lib

Change in vdsm[master]: RPC: Add missing return statement when handling messages

2017-07-12 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: RPC: Add missing return statement when handling messages .. Patch Set 1: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/79308/1

Change in vdsm[master]: RPC client: Add methods to subscribe, unsubscribe and notify

2017-07-12 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: RPC client: Add methods to subscribe, unsubscribe and notify .. Patch Set 21: I like the tests, but it sounds odd that we don't have clie

Change in vdsm[master]: RPC client: Add methods to subscribe, unsubscribe and notify

2017-07-12 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: RPC client: Add methods to subscribe, unsubscribe and notify .. Patch Set 21: Code-Review+1 -- To view, visit https://gerrit.ovirt.org

Change in vdsm[master]: RPC: Recieve and parse messages from multiple subscriptions

2017-07-12 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: RPC: Recieve and parse messages from multiple subscriptions .. Patch Set 23: (1 comment) https://gerrit.ovirt.org/#/c/78656/23//COMMIT_M

Change in vdsm[master]: [WIP] net.api: expose cancel_rollback()

2017-07-11 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has uploaded a new change for review. Change subject: [WIP] net.api: expose cancel_rollback() .. [WIP] net.api: expose cancel_rollback() When connectivityCheck=True is passed to the setupNet

Change in vdsm[master]: API: drop needless code

2017-07-11 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has uploaded a new change for review. Change subject: API: drop needless code .. API: drop needless code The code dropped in this patch was required for ancient Engine versions (pre 3.1), wh

Change in vdsm[master]: api: log only external pings

2017-07-11 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: api: log only external pings .. Patch Set 6: omg, we had quite the same thing in the past: http://gerrit.ovirt.org/30178 -- To view, vi

Change in vdsm[master]: virt.sampling: drop dead code

2017-07-11 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has uploaded a new change for review. Change subject: virt.sampling: drop dead code .. virt.sampling: drop dead code recentClient was used by the connectivity log, and should have been dropp

Change in vdsm[master]: net: move EXT_TC into vdsm.network.tc

2017-07-11 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has uploaded a new change for review. Change subject: net: move EXT_TC into vdsm.network.tc .. net: move EXT_TC into vdsm.network.tc The only users of EXT_TC is the tc package and its tests.

Change in vdsm[master]: net: remove vintage ovirt-node code piece

2017-07-11 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has uploaded a new change for review. Change subject: net: remove vintage ovirt-node code piece .. net: remove vintage ovirt-node code piece ovirt-node vintage is not with us since ovirt 3.

Change in vdsm[master]: net: move IFDOWN and IFUP into ifcfg

2017-07-11 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79251 ) Change subject: net: move IFDOWN and IFUP into ifcfg .. net: move IFDOWN and IFUP into ifcfg Nobody outside

Change in vdsm[master]: net: keep our own BRCTL constant

2017-07-11 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: keep our own BRCTL constant .. Patch Set 1: Verified+1 Ran 70 tests in 425.611s OK (SKIP=1) -- To view, visit https://gerrit.ovir

Change in vdsm[master]: net: keep our own BRCTL constant

2017-07-11 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79277 ) Change subject: net: keep our own BRCTL constant .. net: keep our own BRCTL constant BRCTL has two usages: i

Change in vdsm[master]: openstacknet hook: do not use vdsm-internal constants

2017-07-11 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79254 ) Change subject: openstacknet hook: do not use vdsm-internal constants .. openstacknet hook: do not use vdsm-i

Change in vdsm[master]: openstacknet hook: do not use vdsm-internal constants

2017-07-11 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: openstacknet hook: do not use vdsm-internal constants .. Patch Set 1: Code-Review+2 Verified+1 too simple to wait. -- To view, visit

Change in vdsm[master]: net: move IFDOWN and IFUP into ifcfg

2017-07-11 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: move IFDOWN and IFUP into ifcfg .. Patch Set 2: Verified+1 Ran 70 tests in 425.611s OK (SKIP=1) -- To view, visit https://gerrit.

Change in vdsm[master]: RPC client: Add methods to subscribe, unsubscribe and notify

2017-07-11 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: RPC client: Add methods to subscribe, unsubscribe and notify .. Patch Set 21: (1 comment) https://gerrit.ovirt.org/#/c/78657/21/lib/vdsm

Change in vdsm[master]: RPC: Recieve and parse messages from multiple subscriptions

2017-07-11 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: RPC: Recieve and parse messages from multiple subscriptions .. Patch Set 23: (6 comments) https://gerrit.ovirt.org/#/c/78656/23//COMMIT_

Change in vdsm[master]: RPC: Refactor ClientRpcTransportAdapter

2017-07-11 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: RPC: Refactor ClientRpcTransportAdapter .. Patch Set 18: (1 comment) https://gerrit.ovirt.org/#/c/78655/18//COMMIT_MSG Commit Message:

Change in vdsm[master]: RPC: Refactor ClientRpcTransportAdapter

2017-07-11 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: RPC: Refactor ClientRpcTransportAdapter .. Patch Set 18: (1 comment) https://gerrit.ovirt.org/#/c/78655/18//COMMIT_MSG Commit Message:

Change in vdsm[master]: RPC: Refactor ClientRpcTransportAdapter

2017-07-11 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: RPC: Refactor ClientRpcTransportAdapter .. Patch Set 18: Code-Review-1 (3 comments) https://gerrit.ovirt.org/#/c/78655/18/lib/yajsonrpc

Change in vdsm[master]: RPC: Refactor JSON RPC exceptions

2017-07-11 Thread Code Review
From Yaniv Bronhaim : Yaniv Bronhaim has posted comments on this change. Change subject: RPC: Refactor JSON RPC exceptions .. Patch Set 17: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/78660 To unsubscribe, visit

Change in vdsm[master]: net: keep our own BRCTL constant

2017-07-11 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has uploaded a new change for review. Change subject: net: keep our own BRCTL constant .. net: keep our own BRCTL constant BRCTL has two usages: in vdsm-tool, and in the ifcfg network config

Change in vdsm[master]: openstacknet hook: do not use vdsm-internal constants

2017-07-11 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has uploaded a new change for review. Change subject: openstacknet hook: do not use vdsm-internal constants .. openstacknet hook: do not use vdsm-internal constants Hooks should avoid vdsm i

Change in vdsm[master]: spec: install 85-vdsm-hook-fcoe.preset in Makefile

2017-07-11 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79218 ) Change subject: spec: install 85-vdsm-hook-fcoe.preset in Makefile .. spec: install 85-vdsm-hook-fcoe.preset

Change in vdsm[master]: spec: install 85-vdsmd.preset in Makefile

2017-07-11 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79217 ) Change subject: spec: install 85-vdsmd.preset in Makefile .. spec: install 85-vdsmd.preset in Makefile Chang

Change in vdsm[master]: spec: install tmpfiles.d/vdsm.conf and libvirtd.service.d/un...

2017-07-11 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79216 ) Change subject: spec: install tmpfiles.d/vdsm.conf and libvirtd.service.d/unlimited-core.conf in Makefile ..

Change in vdsm[master]: vdsm: hooks: reduce scope for after_disk_prepare

2017-07-11 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: vdsm: hooks: reduce scope for after_disk_prepare .. Patch Set 7: (4 comments) https://gerrit.ovirt.org/#/c/78529/7//COMMIT_MSG Commit Me

Change in vdsm[master]: net: move IFDOWN into ifcfg

2017-07-11 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has uploaded a new change for review. Change subject: net: move IFDOWN into ifcfg .. net: move IFDOWN into ifcfg Nobody outside the ifcfg configurator needs IFDOWN. It resolves to /sbin/ifdo

<    1   2   3   4   5   6   7   8   9   10   >