Allon Mureinik has posted comments on this change.
Change subject: Live Merge: Teardown volume on HSM after live merge
..
Patch Set 3: Code-Review+1
@Francesco, can we move forwards with this patch please?
--
To view, visit
Allon Mureinik has posted comments on this change.
Change subject: Live Merge: Remove volume run link after live merge
..
Patch Set 3:
@Francesco, based on Nir's comments on the CI, can we move forwards with this
patch
Allon Mureinik has posted comments on this change.
Change subject: sp: Remove double dict key
..
Patch Set 5: Code-Review+1
(1 comment)
+1 on the code, see inline comment wrt the commit message.
Allon Mureinik has posted comments on this change.
Change subject: sp: Sort dict literal by key
..
Patch Set 5: Code-Review+1
(2 comments)
+1 on the code, minor corrections to the commit message
Allon Mureinik has posted comments on this change.
Change subject: spec: Require selinux-policy-targeted for CephFS
..
Patch Set 1:
@Francesco:
- RHEL delivers this update with errata RHBA-2016:1863-1 (see
Allon Mureinik has posted comments on this change.
Change subject: spec: Clean up the initscripts requirement
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/65055
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: spec: Require selinux-policy-targeted for CephFS
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/65054
To unsubscribe, visit
Allon Mureinik has uploaded a new change for review.
Change subject: spec: Clean up the initscripts requirement
..
spec: Clean up the initscripts requirement
Centos has delivered initscripts >= 9.49.30-1.el7_2.3 since August
Hello Nir Soffer, Freddy Rolland,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/65054
to review the following change.
Change subject: spec: Require selinux-policy-targeted for CephFS
..
spec:
Allon Mureinik has posted comments on this change.
Change subject: spec: Require selinux-policy-targeted for CephFS
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/64505
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: spec: Bump Fedora selinux-policy-targeted req
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/64504
To unsubscribe, visit
Allon Mureinik has uploaded a new change for review.
Change subject: spec: Require selinux-policy-targeted for CephFS
..
spec: Require selinux-policy-targeted for CephFS
RHEL bug https://bugzilla.redhat.com/1365640 describes an
Allon Mureinik has uploaded a new change for review.
Change subject: spec: Bump Fedora selinux-policy-targeted req
..
spec: Bump Fedora selinux-policy-targeted req
Bump the selinux-policy-targeted requirement on Fedora to
Allon Mureinik has posted comments on this change.
Change subject: Live Merge: Remove volume run link after live merge
..
Patch Set 9: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/59725/9/vdsm/storage/blockSD.py
Allon Mureinik has posted comments on this change.
Change subject: Live Merge: teardown volume on HSM after live merge
..
Patch Set 3: Code-Review+1
(2 comments)
https://gerrit.ovirt.org/#/c/64301/3//COMMIT_MSG
Commit
Allon Mureinik has posted comments on this change.
Change subject: vm: Remove unneeded fallback to blockRebase
..
Patch Set 1: Code-Review+1
Seems pretty straight forward, and it doesn't seem like you've left anything
over.
Allon Mureinik has posted comments on this change.
Change subject: Live Merge: Refresh base volume before live merge
..
Patch Set 2:
Rerun-hooks: all
--
To view, visit https://gerrit.ovirt.org/63634
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: Live Merge: Refresh base volume before live merge
..
Patch Set 2:
Rerun-hooks: All
--
To view, visit https://gerrit.ovirt.org/63634
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: storageServer: Remove dead code
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56552
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: formatConverter: Use module logger
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/63630
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: upgrade: Support upgrade to v4 from v3
..
Patch Set 7: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/63547/7//COMMIT_MSG
Commit Message:
PS7, Line
Allon Mureinik has posted comments on this change.
Change subject: storage: Unify stoage logger name
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61261
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: formatConverter: Use module logger
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/63630
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: upgrade: Support upgrade to v4 from v3
..
Patch Set 4: Code-Review+1
(1 comment)
Looks like a good skeleton. If we ever want to add something there )(e.g.,
Allon Mureinik has posted comments on this change.
Change subject: Live Merge: Refresh base volume before live merge
..
Patch Set 2: Verified+1
Fixed commit message to the 3.6 bug. Note that
Allon Mureinik has posted comments on this change.
Change subject: mount: Don't un-escape mount options
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56546
To unsubscribe, visit
Hello Nir Soffer, Ala Hino,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/63634
to review the following change.
Change subject: Live Merge: Refresh base volume before live merge
..
Live Merge:
Allon Mureinik has posted comments on this change.
Change subject: upgrade: Support upgrade to v4 from v3
..
Patch Set 1: Code-Review-1
(3 comments)
Allon Mureinik has posted comments on this change.
Change subject: storage: Remove unneeded multipath call
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/63427
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: Live Merge: Refresh base volume before live merge
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/63454/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:
PS2,
Allon Mureinik has posted comments on this change.
Change subject: misc: Remove log skipping infrastructure
..
Patch Set 3: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/63267/3//COMMIT_MSG
Commit Message:
Line 8:
Allon Mureinik has posted comments on this change.
Change subject: lvm: Fix error handling when resizing lvs
..
Patch Set 1: Verified+1
Marking VERIFIED as per automation tier 1 run.
--
To view, visit
Allon Mureinik has posted comments on this change.
Change subject: lvm: Separate lv reduce and extend
..
Patch Set 2: Verified+1
Marking VERIFIED as per automation tier 1 run.
--
To view, visit https://gerrit.ovirt.org/62735
Allon Mureinik has posted comments on this change.
Change subject: lvm: Refresh lvs during activation
..
Patch Set 1: Verified+1
Marking VERIFIED as per automation tier 1 run.
--
To view, visit https://gerrit.ovirt.org/62731
Allon Mureinik has posted comments on this change.
Change subject: lvm: Improve logging lv activation logging
..
Patch Set 1: Verified+1
Marking VERIFIED as per automation tier 1 run.
--
To view, visit
Allon Mureinik has posted comments on this change.
Change subject: lvm: Never hide lvm errors
..
Patch Set 1: Verified+1
Marking VERIFIED as per automation tier 1 run.
--
To view, visit https://gerrit.ovirt.org/62733
To
Allon Mureinik has posted comments on this change.
Change subject: lvm: Do not rely on return code when handling extendLV errors
..
Patch Set 1:
Adam, can you abandon this patch please? If we agree it's not the right
Allon Mureinik has posted comments on this change.
Change subject: hsm: add getVGInfo discard related fields
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/62800
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: multipath: getDeviceDiscardMaxBytes return type
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/62799/2//COMMIT_MSG
Commit Message:
Line 9: Since
Allon Mureinik has posted comments on this change.
Change subject: multipath: Do not fail I/O after short outage
..
Patch Set 1: Verified+1
Marking as verified based on Elad Ben Aharon's comment on
Allon Mureinik has posted comments on this change.
Change subject: lvm: Fix error handling when resizing lvs
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/62338
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: lvm: Separate lv reduce and extend
..
Patch Set 3: Code-Review+1
I love the over-engineering in the removed code. Thanks for getting rid of that.
--
To view,
Allon Mureinik has posted comments on this change.
Change subject: dump_volume_chains: migrate to jsonrpcvdscli
..
Patch Set 6:
(2 comments)
https://gerrit.ovirt.org/#/c/62324/6/lib/vdsm/tool/dump_volume_chains.py
File
Allon Mureinik has posted comments on this change.
Change subject: lvm: Fix error handling when resizing lvs
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/62338
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: lvm: Fix error handling when resizing lvs
..
Patch Set 1:
Just to be clear - the theoretical performance penalty here is that we're
invalidating caches on
Allon Mureinik has posted comments on this change.
Change subject: Remove _udevrulesdir global macro
..
Patch Set 4: Code-Review+1
The CI error seems unrelated to the patch. Needs to be fixed, but shouldn't
block a critical
Allon Mureinik has posted comments on this change.
Change subject: lvm: Do not rely on return code when handling extendLV errors
..
Patch Set 1: Code-Review-1
Error messages are not stable APIs, while RCs are *supposed* to be.
Allon Mureinik has posted comments on this change.
Change subject: spec: Require sanlock version handling EINTR
..
Patch Set 6: Code-Review+1
(1 comment)
Huh! The CI failure, oddly enough, proves that the patch is correct :-)
Allon Mureinik has posted comments on this change.
Change subject: spec: Require sanlock version handling EINTR
..
Patch Set 5: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/61200/5/vdsm.spec.in
File vdsm.spec.in:
Allon Mureinik has posted comments on this change.
Change subject: lvm: Never hide lvm errors
..
Patch Set 2: Code-Review+1
+1 on the concept, but this needs to be tested VERY carefully
--
To view, visit
Allon Mureinik has posted comments on this change.
Change subject: lvm: Improve logging lv activation logging
..
Patch Set 2: Code-Review+1
Definitely +1 on the concept. I'm on the fence on whether this should be
log.info or
Allon Mureinik has posted comments on this change.
Change subject: spec: Clean up fedora >= 23 conditions
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/61060
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: spec: Remove Fedora 22 libvirt requirement
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/61059
To unsubscribe, visit
Allon Mureinik has uploaded a new change for review.
Change subject: spec: Remove Fedora 22 libvirt requirement
..
spec: Remove Fedora 22 libvirt requirement
As Fedora 22 is End of Life [1], there no longer a need to explicitly
Allon Mureinik has uploaded a new change for review.
Change subject: spec: Clean up fedora >= 23 conditions
..
spec: Clean up fedora >= 23 conditions
As Fedora 22 is End of Life [1], any Fedora we support would be 23 or
newer,
Allon Mureinik has posted comments on this change.
Change subject: spec: Require qemu-kvm-ev to fix aio_bh_poll hang
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/60931/1/vdsm.spec.in
File vdsm.spec.in:
Line 242:
Allon Mureinik has posted comments on this change.
Change subject: spec: Require qemu-kvm-ev to fix aio_bh_poll hang
..
Patch Set 1: Verified+1
Marking as verified. The EL CI has passed, and the FC24 failure is the regular
CI
Allon Mureinik has posted comments on this change.
Change subject: spec: Require qemu-kvm-ev to fix aio_bh_poll hang
..
Patch Set 1: Verified+1
Marking as verified. The EL CI has passed, and the FC24 failure is the regular
CI
Allon Mureinik has posted comments on this change.
Change subject: spec: Require qemu-kvm-ev to fix aio_bh_poll hang
..
Patch Set 1:
https://gerrit.ovirt.org/#/c/60931/ should be merged before this one.
--
To view, visit
Allon Mureinik has posted comments on this change.
Change subject: spec: Require qemu-kvm-ev to fix aio_bh_poll hang
..
Patch Set 1:
Same patch as upstream. Pending CI to run.
Note this BZ is targeted to 3.6.9. The change has
Hello Nir Soffer,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/60932
to review the following change.
Change subject: spec: Require qemu-kvm-ev to fix aio_bh_poll hang
..
spec: Require
Hello Nir Soffer,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/60931
to review the following change.
Change subject: spec: Require qemu-kvm-ev to fix aio_bh_poll hang
..
spec: Require
Allon Mureinik has posted comments on this change.
Change subject: spec: Require python-ioprocess-0.16.1-1
..
Patch Set 1: Verified+1
Marking as VERIFIED as it passes when I build/test this locally and the CI
failure is fixed
Allon Mureinik has posted comments on this change.
Change subject: Adding python-setuptools to required ci packages
..
Patch Set 4: Code-Review+1
"Assumption is the mother of all.."
--
To view, visit
Allon Mureinik has posted comments on this change.
Change subject: spec: Require python-ioprocess-0.16.1-1
..
Patch Set 1:
While the failure is consistent, it doesn't seem to be related to the patch.
Instead
14:13:07
Allon Mureinik has posted comments on this change.
Change subject: storage: Support new dd output
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/60857
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: spec: Require python-ioprocess-0.16.1-1
..
Patch Set 1:
CI failure doesn't seem to be related to the patch. Attempting to retrigger.
--
To view, visit
Allon Mureinik has posted comments on this change.
Change subject: spec: Require python-ioprocess-0.16.1-1
..
Patch Set 1:
Same patch as master, pending CI to mark as verified.
--
To view, visit
Hello Nir Soffer,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/60860
to review the following change.
Change subject: spec: Require python-ioprocess-0.16.1-1
..
spec: Require
Allon Mureinik has posted comments on this change.
Change subject: spec: Require qemu-kvm-ev to fix aio_bh_poll hang
..
Patch Set 1: Verified+1
Build passes on both Fedora and EL CI, as does on my tests.
--
To view, visit
Allon Mureinik has uploaded a new change for review.
Change subject: spec: Require qemu-kvm-ev to fix aio_bh_poll hang
..
spec: Require qemu-kvm-ev to fix aio_bh_poll hang
This qemu-kvm-ev build fixes a hang experienced during
Allon Mureinik has posted comments on this change.
Change subject: spec: Require python-ioprocess-0.16.1-1
..
Patch Set 2: Verified+1
CI passes, as do the builds I've tried locally. Nir, can you merge please?
--
To view,
Allon Mureinik has posted comments on this change.
Change subject: spec: Require python-ioprocess-0.16.1-1
..
Patch Set 2:
And now with the right Bug-Url...
--
To view, visit https://gerrit.ovirt.org/60858
To unsubscribe,
Allon Mureinik has posted comments on this change.
Change subject: spec: Require python-ioprocess-0.16.1-1
..
Patch Set 1:
This should be available in all o/s we support:
F23:
Allon Mureinik has uploaded a new change for review.
Change subject: spec: Require python-ioprocess-0.16.1-1
..
spec: Require python-ioprocess-0.16.1-1
ioprocess-0.16.1-1 solves a bug where ioprocess keeps a file open
after
Allon Mureinik has posted comments on this change.
Change subject: Revert "spbackends: Remove StoragePoolDiskBackend"
..
Patch Set 1: Verified+1
trivial git revert
--
To view, visit https://gerrit.ovirt.org/60256
To
Allon Mureinik has uploaded a new change for review.
Change subject: Revert "spbackends: Remove StoragePoolDiskBackend"
..
Revert "spbackends: Remove StoragePoolDiskBackend"
This reverts commit
Allon Mureinik has posted comments on this change.
Change subject: spbackends: Remove StoragePoolDiskBackend
..
Patch Set 9: Verified+1
Addressed Nir's comments on vdsm-api.yml
--
To view, visit
Allon Mureinik has posted comments on this change.
Change subject: spbackends: Remove StoragePoolDiskBackend
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/55859/8/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml:
Allon Mureinik has posted comments on this change.
Change subject: spec: Update Fedora lvm requirement
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/60009
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: spec: Require lvm version fixing filter
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/59907/3//COMMIT_MSG
Commit Message:
PS3, Line 21: Fedora 23
Allon Mureinik has posted comments on this change.
Change subject: spec: Require sanlock 2.8-3
..
Patch Set 1: Code-Review+1
Can we move forwards with this one?
--
To view, visit https://gerrit.ovirt.org/59656
To
Allon Mureinik has posted comments on this change.
Change subject: spbackends: Remove StoragePoolDiskBackend
..
Patch Set 8: Verified+1
--
To view, visit https://gerrit.ovirt.org/55859
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: vm: Remove useless volume size monitoring
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/59801
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: qemuimg.py: Don't check -T support
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/55926
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: qemuimg.py: Don't check compat support
..
Patch Set 3: Verified+1
The CI failure, while consistent, doesn't seem relevant:
20:44:13 testGetDeviceByIP
Allon Mureinik has posted comments on this change.
Change subject: build: support imageio in rhev
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/59696
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: vdsm: adding support for version 4.1
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/59308
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: vdsm: adding support for version 4.1
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/59308/3/lib/vdsm/dsaversion.py.in
File
Allon Mureinik has posted comments on this change.
Change subject: vdsm: adding support for version 4.1
..
Patch Set 2:
The patch's subject is "adding support for version 4.1", which is an
understatement on what this patch
Allon Mureinik has posted comments on this change.
Change subject: qemuimg: Add missing validation for qcow2 format
..
Patch Set 3: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/57456/3/lib/vdsm/qemuimg.py
File
Allon Mureinik has posted comments on this change.
Change subject: mounts: Use more meaningful names
..
Patch Set 7: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56551
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: storage: Do not reference image dir in backing volume path
..
Patch Set 2:
Was looking at the wrong window, disregard this asinine comment
--
To view, visit
Allon Mureinik has posted comments on this change.
Change subject: storage: Do not reference image dir in backing volume path
..
Patch Set 2:
Nir, can we move forward and merge this before the 4.0 branching please?
--
To
Allon Mureinik has posted comments on this change.
Change subject: mount: Remove pointless force=True usage
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56524
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: qemuimg.py: Don't check -T support
..
Patch Set 2:
Rebased, no changes in this patchset.
--
To view, visit https://gerrit.ovirt.org/55926
To unsubscribe,
Allon Mureinik has posted comments on this change.
Change subject: qemuimg.py: Don't check compat support
..
Patch Set 2: Verified+1
Rebased and incorporated the qcow2_compat config version
--
To view, visit
Allon Mureinik has posted comments on this change.
Change subject: blockSD: Avoid stale lvs
..
Patch Set 2:
(11 comments)
https://gerrit.ovirt.org/#/c/56876/2//COMMIT_MSG
Commit Message:
PS2, Line 9: activate
activated
Allon Mureinik has posted comments on this change.
Change subject: spec: qemu-kvm-img to handle unaligned images
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/56630
To unsubscribe, visit
Hello Nir Soffer,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/56630
to review the following change.
Change subject: spec: qemu-kvm-img to handle unaligned images
..
spec: qemu-kvm-img to
1 - 100 of 1045 matches
Mail list logo
