Change in vdsm[master]: storage: iscsiadm parses IPv6 iSCSI addresses

2016-10-29 Thread edwardh
Edward Haas has posted comments on this change. Change subject: storage: iscsiadm parses IPv6 iSCSI addresses .. Patch Set 15: (1 comment) https://gerrit.ovirt.org/#/c/65707/14/tests/iscsiTests.py File tests/iscsiTests.py:

Change in vdsm[master]: storage: Extend the API for IPv6 iSCSI targets

2016-10-28 Thread edwardh
Edward Haas has posted comments on this change. Change subject: storage: Extend the API for IPv6 iSCSI targets .. Patch Set 1: (2 comments) Just some naming comments. https://gerrit.ovirt.org/#/c/65794/1/lib/api/vdsm-api.yml

Change in vdsm[master]: storage: Enable IPv6 encapsulation in HSM

2016-10-28 Thread edwardh
Edward Haas has posted comments on this change. Change subject: storage: Enable IPv6 encapsulation in HSM .. Patch Set 10: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65736 To unsubscribe, visit

Change in vdsm[master]: storage: prepare iscsi for IPv6 targets

2016-10-28 Thread edwardh
Edward Haas has posted comments on this change. Change subject: storage: prepare iscsi for IPv6 targets .. Patch Set 12: Code-Review+1 I suggest changing the 'getTargetString' func to something nicer, but I leave this to your

Change in vdsm[master]: storage: Enable IPv6 encapsulation in HSM

2016-10-28 Thread edwardh
Edward Haas has posted comments on this change. Change subject: storage: Enable IPv6 encapsulation in HSM .. Patch Set 9: (1 comment) https://gerrit.ovirt.org/#/c/65736/9/vdsm/storage/hsm.py File vdsm/storage/hsm.py: PS9,

Change in vdsm[master]: storage: iscsiadm parses IPv6 iSCSI addresses

2016-10-27 Thread edwardh
Edward Haas has posted comments on this change. Change subject: storage: iscsiadm parses IPv6 iSCSI addresses .. Patch Set 11: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65707 To unsubscribe, visit

Change in vdsm[master]: storage: prepare iscsi for IPv6 targets

2016-10-27 Thread edwardh
Edward Haas has posted comments on this change. Change subject: storage: prepare iscsi for IPv6 targets .. Patch Set 11: (2 comments) https://gerrit.ovirt.org/#/c/65696/11/vdsm/storage/iscsi.py File vdsm/storage/iscsi.py:

Change in vdsm[master]: storage: prepare iscsi for IPv6 targets

2016-10-26 Thread edwardh
Edward Haas has posted comments on this change. Change subject: storage: prepare iscsi for IPv6 targets .. Patch Set 11: (3 comments) https://gerrit.ovirt.org/#/c/65696/11/vdsm/storage/iscsi.py File vdsm/storage/iscsi.py:

Change in vdsm[ovirt-3.6]: net: edit nic detached from bridge but still attached to a vlan

2016-10-26 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: edit nic detached from bridge but still attached to a vlan .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65233 To unsubscribe,

Change in vdsm[ovirt-3.6]: net: edit bond detached from bridge but still attached to a ...

2016-10-26 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: edit bond detached from bridge but still attached to a vlan .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65219 To unsubscribe,

Change in vdsm[master]: storage: prepare iscsi for IPv6 targets

2016-10-26 Thread edwardh
Edward Haas has posted comments on this change. Change subject: storage: prepare iscsi for IPv6 targets .. Patch Set 6: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/65696/6/vdsm/storage/iscsi.py File

Change in vdsm[master]: net: support nameserver address with %iface tail

2016-10-25 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: support nameserver address with %iface tail .. Patch Set 3: Nothing changed in the reporting or setup itself, only in the validation. It is not practical to

Change in vdsm[master]: net: support nameserver address with %iface tail

2016-10-25 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: support nameserver address with %iface tail .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/65693 To unsubscribe, visit

Change in vdsm[master]: net: support nameserver address with %iface tail

2016-10-25 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: support nameserver address with %iface tail .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/65693/1/tests/network/ip_test.py File

Change in vdsm[master]: net: support nameserver address with %iface tail

2016-10-25 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: support nameserver address with %iface tail .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/65693/1/tests/network/ip_test.py File

Change in vdsm[master]: net: support nameserver address with %iface tail

2016-10-24 Thread edwardh
Edward Haas has uploaded a new change for review. Change subject: net: support nameserver address with %iface tail .. net: support nameserver address with %iface tail The nameserver address may include an % tail, to specify on

Change in vdsm[master]: net: edit nic detached from bridge but still attached to a vlan

2016-10-19 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: edit nic detached from bridge but still attached to a vlan .. Patch Set 2: (1 comment)

Change in vdsm[master]: net: Change classmethod to staticmethod in IPv4 and IPv6 cla...

2016-10-19 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Change classmethod to staticmethod in IPv4 and IPv6 classes .. Patch Set 2: It could have been a function if ipv4/6 would have been modules. Static methods

Change in vdsm[master]: net: Change classmethod to staticmethod in IPv4 and IPv6 cla...

2016-10-19 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Change classmethod to staticmethod in IPv4 and IPv6 classes .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/65609/1//COMMIT_MSG Commit Message:

Change in vdsm[master]: net: Change classmethod to staticmethod in IPv4 and IPv6 cla...

2016-10-19 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Change classmethod to staticmethod in IPv4 and IPv6 classes .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/65609 To unsubscribe,

Change in vdsm[master]: net: Validate nameservers setup

2016-10-19 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Validate nameservers setup .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/65613 To unsubscribe, visit

Change in vdsm[master]: net: Validate nameservers setup

2016-10-19 Thread edwardh
Edward Haas has uploaded a new change for review. Change subject: net: Validate nameservers setup .. net: Validate nameservers setup Add address validation for the nameservers setup. Change-Id:

Change in vdsm[master]: net: Change classmethod to staticmethod in IPv4 and IPv6 cla...

2016-10-19 Thread edwardh
Edward Haas has uploaded a new change for review. Change subject: net: Change classmethod to staticmethod in IPv4 and IPv6 classes .. net: Change classmethod to staticmethod in IPv4 and IPv6 classes Several validation methods

Change in vdsm[master]: static: move vdsm bonding defaults under static

2016-10-14 Thread edwardh
Edward Haas has posted comments on this change. Change subject: static: move vdsm bonding defaults under static .. Patch Set 6: Code-Review+1 We need to run functional tests on this. -- To view, visit

Change in vdsm[master]: build: Replace pep8 and pyflakes with flake8

2016-10-14 Thread edwardh
Edward Haas has posted comments on this change. Change subject: build: Replace pep8 and pyflakes with flake8 .. Patch Set 2: Code-Review+1 Ah, I got confused between py3 (only) code and py2 code compatible with py3. -- To

Change in vdsm[master]: build: Run the tests with tox

2016-10-14 Thread edwardh
Edward Haas has posted comments on this change. Change subject: build: Run the tests with tox .. Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65404 To unsubscribe, visit

Change in vdsm[master]: build: Replace pep8 and pyflakes with flake8

2016-10-13 Thread edwardh
Edward Haas has posted comments on this change. Change subject: build: Replace pep8 and pyflakes with flake8 .. Patch Set 2: What do you mean it is not relevant? We need it installed once for py2 and once for py3 so tests will

Change in vdsm[master]: net test: fix ovs_test:test_dry_run

2016-10-13 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net test: fix ovs_test:test_dry_run .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65058 To unsubscribe, visit

Change in vdsm[master]: logging: Improve log level alignment

2016-10-13 Thread edwardh
Edward Haas has posted comments on this change. Change subject: logging: Improve log level alignment .. Patch Set 3: IMO the two char saving is not worth the small hack (https://gerrit.ovirt.org/#/c/64217/3/vdsm/vdsm), it is

Change in vdsm[master]: build: Replace pep8 and pyflakes with flake8

2016-10-13 Thread edwardh
Edward Haas has posted comments on this change. Change subject: build: Replace pep8 and pyflakes with flake8 .. Patch Set 2: -Code-Review Will this work with py3? -- To view, visit https://gerrit.ovirt.org/65403 To

Change in vdsm[master]: build: Run the tests with tox

2016-10-13 Thread edwardh
Edward Haas has posted comments on this change. Change subject: build: Run the tests with tox .. Patch Set 8: -Code-Review Will this work with py3? -- To view, visit https://gerrit.ovirt.org/65404 To unsubscribe, visit

Change in vdsm[master]: build: Run the tests with tox

2016-10-13 Thread edwardh
Edward Haas has posted comments on this change. Change subject: build: Run the tests with tox .. Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65404 To unsubscribe, visit

Change in vdsm[master]: automation: Create coverage report sooner

2016-10-13 Thread edwardh
Edward Haas has posted comments on this change. Change subject: automation: Create coverage report sooner .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65414 To unsubscribe, visit

Change in vdsm[master]: tests: Remove cPopenTests.py

2016-10-13 Thread edwardh
Edward Haas has posted comments on this change. Change subject: tests: Remove cPopenTests.py .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65407 To unsubscribe, visit

Change in vdsm[master]: build: Replace pep8 and pyflakes with flake8

2016-10-13 Thread edwardh
Edward Haas has posted comments on this change. Change subject: build: Replace pep8 and pyflakes with flake8 .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65403 To unsubscribe, visit

Change in vdsm[master]: pep8: Fix long line in vdsm sos plugin

2016-10-12 Thread edwardh
Edward Haas has posted comments on this change. Change subject: pep8: Fix long line in vdsm sos plugin .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65402 To unsubscribe, visit

Change in vdsm[master]: net tests: separate ifcfg and libvirt unit tests

2016-10-10 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net tests: separate ifcfg and libvirt unit tests .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65090 To unsubscribe, visit

Change in vdsm[master]: net tests: minor libvirt_tests style refactoring

2016-10-10 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net tests: minor libvirt_tests style refactoring .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65091 To unsubscribe, visit

Change in vdsm[ovirt-4.0]: net: canonicalize IPv4 prefix to netmask

2016-10-10 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: canonicalize IPv4 prefix to netmask .. Patch Set 2: Code-Review-1 (1 comment) The -1 is mainly for the commit message. The scenario where both prefix and

Change in vdsm[master]: logging: Unify SimpleLogAdapter format

2016-10-10 Thread edwardh
Edward Haas has posted comments on this change. Change subject: logging: Unify SimpleLogAdapter format .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/64227 To unsubscribe, visit

Change in vdsm[master]: logging: Improve log level alignment

2016-10-10 Thread edwardh
Edward Haas has posted comments on this change. Change subject: logging: Improve log level alignment .. Patch Set 3: Does it really worth it for just saving 2 spaces? If this is just for the output format, can it be cut there

Change in vdsm[master]: logging: Use same log format in the tests

2016-10-10 Thread edwardh
Edward Haas has posted comments on this change. Change subject: logging: Use same log format in the tests .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/64216 To unsubscribe, visit

Change in vdsm[master]: logging: More standard logging format

2016-10-10 Thread edwardh
Edward Haas has posted comments on this change. Change subject: logging: More standard logging format .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/64113 To unsubscribe, visit

Change in vdsm[master]: net: edit nic detached from bridge but still attached to a vlan

2016-10-10 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: edit nic detached from bridge but still attached to a vlan .. Patch Set 1: Code-Review-1 Can we please add a supporting test for this scenario? When

Change in vdsm[master]: build: Disable tests during build

2016-10-09 Thread edwardh
Edward Haas has posted comments on this change. Change subject: build: Disable tests during build .. Patch Set 5: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/63966/4/configure.ac File configure.ac: Line 307 Line

Change in vdsm[master]: build: Disable tests during build

2016-10-09 Thread edwardh
Edward Haas has posted comments on this change. Change subject: build: Disable tests during build .. Patch Set 4: (2 comments) https://gerrit.ovirt.org/#/c/63966/4/configure.ac File configure.ac: Line 298 Line 299 Line 300

Change in vdsm[master]: net libvirt: make network/libvirt.py suitable for OVS

2016-10-09 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net libvirt: make network/libvirt.py suitable for OVS .. Patch Set 8: Code-Review-1 (8 comments) https://gerrit.ovirt.org/#/c/65065/8/lib/vdsm/network/libvirt.py

Change in vdsm[master]: net tests: minor libvirt_tests style refactoring

2016-10-09 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net tests: minor libvirt_tests style refactoring .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65091 To unsubscribe, visit

Change in vdsm[master]: net tests: separate ifcfg and libvirt unit tests

2016-10-09 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net tests: separate ifcfg and libvirt unit tests .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65090 To unsubscribe, visit

Change in vdsm[master]: net: Ignore missing graphics from VM conf on target host

2016-10-01 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Ignore missing graphics from VM conf on target host .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/64300/1//COMMIT_MSG Commit Message: PS1, Line

Change in vdsm[master]: net: Ignore missing graphics from VM conf on target host

2016-10-01 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Ignore missing graphics from VM conf on target host .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/64300/1/vdsm/virt/vm_migrate_hook.py File

Change in vdsm[ovirt-4.0]: net test: Rename link_test module to netlink_test

2016-09-26 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net test: Rename link_test module to netlink_test .. Patch Set 1: Verified+1 Func tests passed -- To view, visit https://gerrit.ovirt.org/64385 To unsubscribe,

Change in vdsm[ovirt-4.0]: net test: sourceroute thread crashes due to a test race

2016-09-26 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net test: sourceroute thread crashes due to a test race .. Patch Set 1: Verified+1 Func tests passed -- To view, visit https://gerrit.ovirt.org/64386 To

Change in vdsm[ovirt-4.0]: net: Define netlink netdev flags constants under netlink.link

2016-09-26 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Define netlink netdev flags constants under netlink.link .. Patch Set 1: Verified+1 Func tests passed -- To view, visit https://gerrit.ovirt.org/64387 To

Change in vdsm[ovirt-4.0]: net: dhclient command - iface name should appear at the tail

2016-09-26 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: dhclient command - iface name should appear at the tail .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/64388 To unsubscribe, visit

Change in vdsm[ovirt-4.0]: net: Adding the 'link' package with an iface module

2016-09-26 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Adding the 'link' package with an iface module .. Patch Set 1: Verified+1 Func tests passed -- To view, visit https://gerrit.ovirt.org/64389 To

Change in vdsm[ovirt-4.0]: net func tests: Cleanup ifcfg files after each func test.

2016-09-26 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net func tests: Cleanup ifcfg files after each func test. .. Patch Set 1: Verified+1 Func tests passed -- To view, visit https://gerrit.ovirt.org/64391 To

Change in vdsm[ovirt-4.0]: net tests: Set dummy ifaces up by default.

2016-09-26 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net tests: Set dummy ifaces up by default. .. Patch Set 1: Verified+1 Func tests passed -- To view, visit https://gerrit.ovirt.org/64392 To unsubscribe, visit

Change in vdsm[ovirt-4.0]: net: Adding bond api with sysfs driver under link

2016-09-26 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Adding bond api with sysfs driver under link .. Patch Set 1: Verified+1 Func tests passed -- To view, visit https://gerrit.ovirt.org/64390 To unsubscribe,

Change in vdsm[ovirt-4.0]: net: Relocating wait-for-event under its own module.

2016-09-26 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Relocating wait-for-event under its own module. .. Patch Set 1: Verified+1 Func tests passed -- To view, visit https://gerrit.ovirt.org/64393 To

Change in vdsm[ovirt-4.0]: net: ifcfg - dhclient should always be stopped

2016-09-26 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: ifcfg - dhclient should always be stopped .. Patch Set 1: Verified+1 Func tests passed -- To view, visit https://gerrit.ovirt.org/64397 To unsubscribe,

Change in vdsm[ovirt-4.0]: net: Expose disable IPv6 through ip.address module

2016-09-26 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Expose disable IPv6 through ip.address module .. Patch Set 1: Verified+1 Func tests passed -- To view, visit https://gerrit.ovirt.org/64396 To unsubscribe,

Change in vdsm[ovirt-4.0]: net: Use is_link_up instead of operstate in netfunctestlib

2016-09-26 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Use is_link_up instead of operstate in netfunctestlib .. Patch Set 1: Verified+1 Func tests passed -- To view, visit https://gerrit.ovirt.org/64395 To

Change in vdsm[ovirt-4.0]: net: For IP-less networks, wait for link-up on ifup execution

2016-09-26 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: For IP-less networks, wait for link-up on ifup execution .. Patch Set 1: Verified+1 Func tests passed -- To view, visit https://gerrit.ovirt.org/64394 To

Change in vdsm[ovirt-4.0]: net: Introduce iface.exists and start using it in ip.dhclient

2016-09-26 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Introduce iface.exists and start using it in ip.dhclient .. Patch Set 1: Verified+1 Func tests passed -- To view, visit https://gerrit.ovirt.org/64398 To

Change in vdsm[ovirt-4.0]: net: Bond - Expose the (kernel) bond list.

2016-09-26 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Bond - Expose the (kernel) bond list. .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/64401 To unsubscribe, visit

Change in vdsm[ovirt-4.0]: net: dhclient kill - early exit if iface does not exists

2016-09-26 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: dhclient kill - early exit if iface does not exists .. Patch Set 1: Func tests passed -- To view, visit https://gerrit.ovirt.org/64399 To unsubscribe,

Change in vdsm[ovirt-4.0]: net: Bond - preserve original slaves link state.

2016-09-26 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Bond - preserve original slaves link state. .. Patch Set 2: Verified+1 Func tests passed -- To view, visit https://gerrit.ovirt.org/64405 To unsubscribe,

Change in vdsm[ovirt-4.0]: net: dhclient - address flush before starting and on shutdown

2016-09-26 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: dhclient - address flush before starting and on shutdown .. Patch Set 1: Verified+1 Func tests passed -- To view, visit https://gerrit.ovirt.org/64400 To

Change in vdsm[ovirt-4.0]: net: Fix reference to CONFFILE_HEADER_BASE which was moved

2016-09-26 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Fix reference to CONFFILE_HEADER_BASE which was moved .. Patch Set 1: Verified+1 Func tests passed -- To view, visit https://gerrit.ovirt.org/64445 To

Change in vdsm[ovirt-4.0]: net: Expose owned_device method through the configurator

2016-09-26 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Expose owned_device method through the configurator .. Patch Set 3: Verified+1 Func tests passed -- To view, visit https://gerrit.ovirt.org/64095 To

Change in vdsm[ovirt-4.0]: net: Disable IPv6 on OVS southbound iface (nic or bonding)

2016-09-26 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Disable IPv6 on OVS southbound iface (nic or bonding) .. Patch Set 2: Verified+1 Func tests passed -- To view, visit https://gerrit.ovirt.org/64407 To

Change in vdsm[ovirt-4.0]: net: Bond - Add logging to the bond driver.

2016-09-26 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Bond - Add logging to the bond driver. .. Patch Set 2: Verified+1 Func tests passed -- To view, visit https://gerrit.ovirt.org/64403 To unsubscribe, visit

Change in vdsm[ovirt-4.0]: net: Relocate sysfs_bond_permission to nettestlib

2016-09-26 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Relocate sysfs_bond_permission to nettestlib .. Patch Set 2: Verified+1 Func tests passed -- To view, visit https://gerrit.ovirt.org/64410 To unsubscribe,

Change in vdsm[ovirt-4.0]: net: Bond - adding a transaction context.

2016-09-26 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Bond - adding a transaction context. .. Patch Set 2: Verified+1 Func tests passed -- To view, visit https://gerrit.ovirt.org/64402 To unsubscribe, visit

Change in vdsm[ovirt-4.0]: net: Bond - add refresh method to update bond config

2016-09-26 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Bond - add refresh method to update bond config .. Patch Set 2: Verified+1 Func tests passed -- To view, visit https://gerrit.ovirt.org/64404 To

Change in vdsm[ovirt-4.0]: net: Link setup module - includes bond setup logic.

2016-09-26 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Link setup module - includes bond setup logic. .. Patch Set 2: Verified+1 Func tests passed -- To view, visit https://gerrit.ovirt.org/64406 To

Change in vdsm[ovirt-4.0]: net: test ovs info with southbound nic

2016-09-26 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: test ovs info with southbound nic .. Patch Set 2: Verified+1 Func tests passed -- To view, visit https://gerrit.ovirt.org/64408 To unsubscribe, visit

Change in vdsm[ovirt-4.0]: net: Use Linux bonds with OVS networks

2016-09-26 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Use Linux bonds with OVS networks .. Patch Set 2: Verified+1 Func tests passed -- To view, visit https://gerrit.ovirt.org/64411 To unsubscribe, visit

Change in vdsm[ovirt-4.0]: net: Delete an OVS bridge when the last SB is detached.

2016-09-26 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Delete an OVS bridge when the last SB is detached. .. Patch Set 2: Verified+1 Func tests passed -- To view, visit https://gerrit.ovirt.org/64413 To

Change in vdsm[ovirt-4.0]: net: Remove OVS bond implementation.

2016-09-26 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Remove OVS bond implementation. .. Patch Set 2: Verified+1 Func tests passed -- To view, visit https://gerrit.ovirt.org/64409 To unsubscribe, visit

Change in vdsm[ovirt-4.0]: net: Split OVS setup transaction to adjust for bond setup

2016-09-26 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Split OVS setup transaction to adjust for bond setup .. Patch Set 2: Verified+1 Func tests passed -- To view, visit https://gerrit.ovirt.org/64412 To

Change in vdsm[ovirt-4.0]: net: Log a setup networks transaction failure when using ovs...

2016-09-26 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Log a setup networks transaction failure when using ovs switch .. Patch Set 2: Verified+1 Func tests passed -- To view, visit

Change in vdsm[ovirt-4.0]: net test: shared nic between bond and network

2016-09-26 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net test: shared nic between bond and network .. Patch Set 1: Verified+1 Func tests passed -- To view, visit https://gerrit.ovirt.org/64447 To unsubscribe,

Change in vdsm[ovirt-4.0]: net: edit bond detached from bridge but still attached to a ...

2016-09-26 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: edit bond detached from bridge but still attached to a vlan .. Patch Set 1: Verified+1 Func tests passed -- To view, visit https://gerrit.ovirt.org/64446

Change in vdsm[ovirt-4.0]: net: Setup validation for OVS - Check nics usage

2016-09-26 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Setup validation for OVS - Check nics usage .. Patch Set 2: Verified+1 Func tests passed -- To view, visit https://gerrit.ovirt.org/64414 To unsubscribe,

Change in vdsm[ovirt-4.0]: net: edit bond detached from bridge but still attached to a ...

2016-09-26 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: edit bond detached from bridge but still attached to a vlan .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/64446 To unsubscribe,

Change in vdsm[ovirt-4.0]: net test: shared nic between bond and network

2016-09-26 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net test: shared nic between bond and network .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/64447 To unsubscribe, visit

Change in vdsm[ovirt-4.0]: net test: shared nic between bond and network

2016-09-26 Thread edwardh
Hello Petr Horáček, Dan Kenigsberg, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/64447 to review the following change. Change subject: net test: shared nic between bond and network .. net test:

Change in vdsm[ovirt-4.0]: net: edit bond detached from bridge but still attached to a ...

2016-09-26 Thread edwardh
Hello Petr Horáček, Dan Kenigsberg, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/64446 to review the following change. Change subject: net: edit bond detached from bridge but still attached to a vlan

Change in vdsm[ovirt-4.0]: net: Fix reference to CONFFILE_HEADER_BASE which was moved

2016-09-26 Thread edwardh
Edward Haas has uploaded a new change for review. Change subject: net: Fix reference to CONFFILE_HEADER_BASE which was moved .. net: Fix reference to CONFFILE_HEADER_BASE which was moved CONFFILE_HEADER_BASE has been renamed

Change in vdsm[master]: net: Fix reference to CONFFILE_HEADER_BASE which was moved

2016-09-26 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Fix reference to CONFFILE_HEADER_BASE which was moved .. Patch Set 1: Verified+1 All unit and functional tests passed. -- To view, visit

Change in vdsm[master]: net: Fix reference to CONFFILE_HEADER_BASE which was moved

2016-09-26 Thread edwardh
Edward Haas has uploaded a new change for review. Change subject: net: Fix reference to CONFFILE_HEADER_BASE which was moved .. net: Fix reference to CONFFILE_HEADER_BASE which was moved CONFFILE_HEADER_BASE has been renamed

Change in vdsm[ovirt-4.0]: net: Bond - Add logging to the bond driver.

2016-09-25 Thread edwardh
Hello Petr Horáček, Dan Kenigsberg, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/64403 to review the following change. Change subject: net: Bond - Add logging to the bond driver. .. net: Bond -

Change in vdsm[ovirt-4.0]: net: Expose disable IPv6 through ip.address module

2016-09-25 Thread edwardh
Hello Petr Horáček, Dan Kenigsberg, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/64396 to review the following change. Change subject: net: Expose disable IPv6 through ip.address module .. net:

Change in vdsm[ovirt-4.0]: net: Remove OVS bond implementation.

2016-09-25 Thread edwardh
Hello Petr Horáček, Dan Kenigsberg, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/64409 to review the following change. Change subject: net: Remove OVS bond implementation. .. net: Remove OVS

Change in vdsm[ovirt-4.0]: net: Split OVS setup transaction to adjust for bond setup

2016-09-25 Thread edwardh
Hello Petr Horáček, Dan Kenigsberg, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/64412 to review the following change. Change subject: net: Split OVS setup transaction to adjust for bond setup

Change in vdsm[ovirt-4.0]: net: Introduce iface.exists and start using it in ip.dhclient

2016-09-25 Thread edwardh
Hello Petr Horáček, Dan Kenigsberg, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/64398 to review the following change. Change subject: net: Introduce iface.exists and start using it in ip.dhclient

Change in vdsm[ovirt-4.0]: net: Log a setup networks transaction failure when using ovs...

2016-09-25 Thread edwardh
Hello Petr Horáček, Dan Kenigsberg, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/64415 to review the following change. Change subject: net: Log a setup networks transaction failure when using ovs switch

Change in vdsm[ovirt-4.0]: net: Bond - preserve original slaves link state.

2016-09-25 Thread edwardh
Hello Petr Horáček, Dan Kenigsberg, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/64405 to review the following change. Change subject: net: Bond - preserve original slaves link state. .. net:

  1   2   3   4   5   6   7   8   9   10   >