Change in vdsm[master]: hook-fcoe: enable lldpad and fceo service on boot

Edward Haas has posted comments on this change. Change subject: hook-fcoe: enable lldpad and fceo service on boot .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61304 To unsubscribe, visit https://ger

Change in vdsm[ovirt-4.0]: build: Enable openvswitch by default on downstream

Edward Haas has posted comments on this change. Change subject: build: Enable openvswitch by default on downstream .. Patch Set 1: Yes, it needs to be merged with I00991099f6bc5446f43ec0d594d2b0016b65a600 (or after) -- To vi

Change in vdsm[ovirt-4.0]: vdscli: Replace the default '::' host with hostname

Edward Haas has posted comments on this change. Change subject: vdscli: Replace the default '::' host with hostname .. Patch Set 1: Verified+1 Please merge after Change-Id: I19bdd61039fdde30fdb30fe6ff477f059f6f85fa -- To view

Change in vdsm[ovirt-4.0]: net test: Nose labeling of test type breaks with inheritance

Edward Haas has posted comments on this change. Change subject: net test: Nose labeling of test type breaks with inheritance .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/61366 To unsubscribe, visit htt

Change in vdsm[ovirt-4.0]: net test: Nose labeling of test type breaks with inheritance

Edward Haas has uploaded a new change for review. Change subject: net test: Nose labeling of test type breaks with inheritance .. net test: Nose labeling of test type breaks with inheritance While running the test suite on Cento

Change in vdsm[ovirt-4.0]: vdscli: Replace the default '::' host with hostname

Edward Haas has uploaded a new change for review. Change subject: vdscli: Replace the default '::' host with hostname .. vdscli: Replace the default '::' host with hostname vdscli may fail to connect to the VDSM server when usin

Change in vdsm[master]: net test: Cleanup _fakeTypeDetection

Edward Haas has posted comments on this change. Change subject: net test: Cleanup _fakeTypeDetection .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/61362 To unsubscribe, visit https://gerrit.ovirt.org/se

Change in vdsm[master]: net test: Replacing MonkeyPatch with mock.patch for netinfo_...

Edward Haas has posted comments on this change. Change subject: net test: Replacing MonkeyPatch with mock.patch for netinfo_test .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/61269 To unsubscribe, visit

Change in vdsm[master]: net test: Cleanup _fakeTypeDetection

Edward Haas has uploaded a new change for review. Change subject: net test: Cleanup _fakeTypeDetection .. net test: Cleanup _fakeTypeDetection Change-Id: I43a456051f9ad4d50fa4ebaff584bc2828980608 Signed-off-by: Edward Haas ---

Change in vdsm[ovirt-4.0]: build: Enable openvswitch by default on downstream

Edward Haas has uploaded a new change for review. Change subject: build: Enable openvswitch by default on downstream .. build: Enable openvswitch by default on downstream Reverting c323d9a9da20b6770b3d36f910a643ec2f1caf50 after

Change in vdsm[master]: ovs: pass --disable-openvswitch to vdsm.spec

Edward Haas has posted comments on this change. Change subject: ovs: pass --disable-openvswitch to vdsm.spec .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61330 To unsubscribe, visit https://gerrit.o

Change in vdsm[master]: ovs: create ovs-vsctl command only on demand

Edward Haas has posted comments on this change. Change subject: ovs: create ovs-vsctl command only on demand .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61321 To unsubscribe, visit https://gerrit.o

Change in vdsm[master]: ovs: create ovs-vsctl command only on demand

Edward Haas has posted comments on this change. Change subject: ovs: create ovs-vsctl command only on demand .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/61321/2/lib/vdsm/network/ovs/driver/vsctl.py File lib/vdsm/n

Change in vdsm[master]: net: Introduce dhclient state check.

Edward Haas has posted comments on this change. Change subject: net: Introduce dhclient state check. .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/61298 To unsubscribe, visit https://gerrit.ovirt.org/se

Change in vdsm[master]: net: Introduce dhclient state check.

Edward Haas has posted comments on this change. Change subject: net: Introduce dhclient state check. .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/61298/1/lib/vdsm/network/ip/dhclient.py File lib/vdsm/network/ip/dhc

Change in vdsm[master]: net test: Replacing MonkeyPatch with mock.patch for netinfo_...

Edward Haas has posted comments on this change. Change subject: net test: Replacing MonkeyPatch with mock.patch for netinfo_test .. Patch Set 2: (6 comments) https://gerrit.ovirt.org/#/c/61269/2/tests/network/netinfo_test.py F

Change in vdsm[master]: ovs: do not call ovs_info if ovs service is down

Edward Haas has posted comments on this change. Change subject: ovs: do not call ovs_info if ovs service is down .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/61240/2/lib/vdsm/network/netswitch.py File lib/vdsm/netw

Change in vdsm[master]: ovs: do not call ovs_info if ovs service is down

Edward Haas has posted comments on this change. Change subject: ovs: do not call ovs_info if ovs service is down .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/61240/2/lib/vdsm/network/netswitch.py File lib/vdsm/netw

Change in vdsm[master]: net: Introduce dhclient state check.

Edward Haas has posted comments on this change. Change subject: net: Introduce dhclient state check. .. Patch Set 1: Verified+1 Unit and Functional tests are passing. -- To view, visit https://gerrit.ovirt.org/61298 To unsubs

Change in vdsm[master]: net: Introduce dhclient state check.

Edward Haas has uploaded a new change for review. Change subject: net: Introduce dhclient state check. .. net: Introduce dhclient state check. Introduce dhclient.is_active. To be used by caps (next patch) to report dhcp actual s

Change in vdsm[master]: virt net: Interface default driver name set to 'vhost'

Edward Haas has uploaded a new change for review. Change subject: virt net: Interface default driver name set to 'vhost' .. virt net: Interface default driver name set to 'vhost' Change-Id: I508675f9dd40ba70803938902a1c2f8fced00

Change in vdsm[master]: net: Disable IPv6 when IPV6INIT=no

Edward Haas has abandoned this change. Change subject: net: Disable IPv6 when IPV6INIT=no .. Abandoned -- To view, visit https://gerrit.ovirt.org/54206 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageTyp

Change in vdsm[master]: net: Silently skip persisting a non existance running-config

Edward Haas has posted comments on this change. Change subject: net: Silently skip persisting a non existance running-config .. Patch Set 3: Verified+1 Checked that no networks are defined (using getVdsCaps) and issued the comm

Change in vdsm[master]: net test: Replacing MonkeyPatch with mock.patch for netinfo_...

Edward Haas has posted comments on this change. Change subject: net test: Replacing MonkeyPatch with mock.patch for netinfo_test .. Patch Set 2: Verified+1 Passing unit tests. -- To view, visit https://gerrit.ovirt.org/61269

Change in vdsm[master]: net test: Replacing MonkeyPatch with mock.patch for netinfo_...

Edward Haas has uploaded a new change for review. Change subject: net test: Replacing MonkeyPatch with mock.patch for netinfo_tests .. net test: Replacing MonkeyPatch with mock.patch for netinfo_tests Change-Id: Ia4e14162bb2773

Change in vdsm[master]: test: Replacing MonkeyPatch with mock.patch example

Edward Haas has abandoned this change. Change subject: test: Replacing MonkeyPatch with mock.patch example .. Abandoned -- To view, visit https://gerrit.ovirt.org/55603 To unsubscribe, visit https://gerrit.ovirt.org/settings

Change in vdsm[master]: test: Prettify netinfo_test mocks

Edward Haas has abandoned this change. Change subject: test: Prettify netinfo_test mocks .. Abandoned -- To view, visit https://gerrit.ovirt.org/55900 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType

Change in vdsm[master]: vdscli: Replace the default '::' host with hostname

Edward Haas has posted comments on this change. Change subject: vdscli: Replace the default '::' host with hostname .. Patch Set 2: Verified+1 Passing unit tests and verified by user (see bug). -- To view, visit https://gerri

Change in vdsm[master]: net func tests: drop ovs/legacy permutation

Edward Haas has posted comments on this change. Change subject: net func tests: drop ovs/legacy permutation .. Patch Set 2: Verified+1 Passing functional/networkTests.py Please merge with the following patch: I8f9b38c14119ad

Change in vdsm[master]: Revert "net tests: Support the ability to choose the tested ...

Edward Haas has posted comments on this change. Change subject: Revert "net tests: Support the ability to choose the tested switch" .. Patch Set 2: Verified+1 Passing functional/networkTests.py -- To view, visit https://gerr

Change in vdsm[master]: Revert "net tests: Support the ability to choose the tested ...

Edward Haas has posted comments on this change. Change subject: Revert "net tests: Support the ability to choose the tested switch" .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61174 To unsubscribe

Change in vdsm[master]: net func tests: drop ovs/legacy permutation

Edward Haas has posted comments on this change. Change subject: net func tests: drop ovs/legacy permutation .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61173 To unsubscribe, visit https://gerrit.ov

Change in vdsm[ovirt-4.0]: ovs: ovs_net2bridge fails when ovs service is down

Edward Haas has posted comments on this change. Change subject: ovs: ovs_net2bridge fails when ovs service is down .. Patch Set 2: Code-Review-1 Please push this into master as well and add in the commend the motivation (PPC d

Change in vdsm[ovirt-4.0]: ovs: ovs_net2bridge fails when ovs service is down

Edward Haas has posted comments on this change. Change subject: ovs: ovs_net2bridge fails when ovs service is down .. Patch Set 2: -Code-Review Ahhh... Thinking about this again, we have a case where we do not require OVS (for

Change in vdsm[ovirt-4.0]: virt net: Change graphics type from network to address

Hello Petr Horáček, Francesco Romani, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/61262 to review the following change. Change subject: virt net: Change graphics type from network to address ..

Change in vdsm[ovirt-4.0]: Revert "virt net: Change graphics type from network to address"

Edward Haas has uploaded a new change for review. Change subject: Revert "virt net: Change graphics type from network to address" .. Revert "virt net: Change graphics type from network to address" This reverts commit 13603192ab2

Change in vdsm[master]: ovs: rollback acquired ifaces after failure

Edward Haas has posted comments on this change. Change subject: ovs: rollback acquired ifaces after failure .. Patch Set 7: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/61088/7/lib/vdsm/network/ifacquire.py File lib/

Change in vdsm[master]: ovs: acquire external ifaces

Edward Haas has posted comments on this change. Change subject: ovs: acquire external ifaces .. Patch Set 26: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/60404/25/tests/network/ovs_switch_test.py File tests/network

Change in vdsm[master]: net: introduce acquire module

Edward Haas has posted comments on this change. Change subject: net: introduce acquire module .. Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/60974/5/tests/network/acquire_ifaces_test.py File tests/network/acquire_ifa

Change in vdsm[ovirt-4.0]: ovs: ovs_net2bridge fails when ovs service is down

Edward Haas has posted comments on this change. Change subject: ovs: ovs_net2bridge fails when ovs service is down .. Patch Set 2: Code-Review-1 There was an agreement that OVS service must be running on this VDSM version. If w

Change in vdsm[ovirt-4.0]: net systemd: Require openvswitch.service

Edward Haas has posted comments on this change. Change subject: net systemd: Require openvswitch.service .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61239 To unsubscribe, visit https://gerrit.ovirt

Change in vdsm[master]: ovs: copy NIC hwaddr to NB

Edward Haas has posted comments on this change. Change subject: ovs: copy NIC hwaddr to NB .. Patch Set 9: (2 comments) https://gerrit.ovirt.org/#/c/61049/9/lib/vdsm/network/ovs/switch.py File lib/vdsm/network/ovs/switch.py:

Change in vdsm[master]: ovs: rollback acquired ifaces after failure

Edward Haas has posted comments on this change. Change subject: ovs: rollback acquired ifaces after failure .. Patch Set 5: Code-Review-1 (3 comments) https://gerrit.ovirt.org/#/c/61088/5/lib/vdsm/network/acquire.py File lib/v

Change in vdsm[master]: ovs: acquire external ifaces

Edward Haas has posted comments on this change. Change subject: ovs: acquire external ifaces .. Patch Set 25: Code-Review-1 (3 comments) https://gerrit.ovirt.org/#/c/60404/25/tests/network/ovs_switch_test.py File tests/network

Change in vdsm[master]: net: introduce acquire module

Edward Haas has posted comments on this change. Change subject: net: introduce acquire module .. Patch Set 5: Code-Review-1 (18 comments) https://gerrit.ovirt.org/#/c/60974/5//COMMIT_MSG Commit Message: PS5, Line 9: external

Change in vdsm[master]: osutils: Move NoIntrCall to osutils.uninterruptible

Edward Haas has posted comments on this change. Change subject: osutils: Move NoIntrCall to osutils.uninterruptible .. Patch Set 2: Verified+1 Networking functional tests passed. -- To view, visit https://gerrit.ovirt.org/611

Change in vdsm[ovirt-4.0]: vdscli: Provide py3 compatible xmlrpclib (using six)

Edward Haas has posted comments on this change. Change subject: vdscli: Provide py3 compatible xmlrpclib (using six) .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/61150/1//COMMIT_MSG Commit Message: Line 3: AuthorD

Change in vdsm[ovirt-4.0]: net: call address.flush explicitly after dhclient.kill

Edward Haas has posted comments on this change. Change subject: net: call address.flush explicitly after dhclient.kill .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61136 To unsubscribe, visit https:

Change in vdsm[ovirt-4.0]: ovs hook: fix dhclient imports

Edward Haas has posted comments on this change. Change subject: ovs hook: fix dhclient imports .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61135 To unsubscribe, visit https://gerrit.ovirt.org/setti

Change in vdsm[ovirt-4.0]: net: add address.flush family argument

Edward Haas has posted comments on this change. Change subject: net: add address.flush family argument .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61134 To unsubscribe, visit https://gerrit.ovirt.o

Change in vdsm[ovirt-4.0]: ovs: rollback transaction

Edward Haas has posted comments on this change. Change subject: ovs: rollback transaction .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61133 To unsubscribe, visit https://gerrit.ovirt.org/settings

Change in vdsm[ovirt-4.0]: net: move dhclient.py to ip package

Edward Haas has posted comments on this change. Change subject: net: move dhclient.py to ip package .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61130 To unsubscribe, visit https://gerrit.ovirt.org/

Change in vdsm[ovirt-4.0]: ovs: move bridges cleanup to a separate function

Edward Haas has posted comments on this change. Change subject: ovs: move bridges cleanup to a separate function .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61132 To unsubscribe, visit https://gerr

Change in vdsm[ovirt-4.0]: ovs: add network with dhcp configuration

Edward Haas has posted comments on this change. Change subject: ovs: add network with dhcp configuration .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61131 To unsubscribe, visit https://gerrit.ovirt

Change in vdsm[ovirt-4.0]: net: move dhclient_run/stop helpers to dhclient.py

Edward Haas has posted comments on this change. Change subject: net: move dhclient_run/stop helpers to dhclient.py .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61129 To unsubscribe, visit https://ge

Change in vdsm[ovirt-4.0]: net: disable unused IPv6 in ip.address.add()

Edward Haas has posted comments on this change. Change subject: net: disable unused IPv6 in ip.address.add() .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61128 To unsubscribe, visit https://gerrit.o

Change in vdsm[ovirt-4.0]: ovs: turn created links UP

Edward Haas has posted comments on this change. Change subject: ovs: turn created links UP .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61127 To unsubscribe, visit https://gerrit.ovirt.org/settings

Change in vdsm[ovirt-4.0]: ovs: add OVS network with IP configuration

Edward Haas has posted comments on this change. Change subject: ovs: add OVS network with IP configuration .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61126 To unsubscribe, visit https://gerrit.ovi

Change in vdsm[ovirt-4.0]: net func test: add basic bond tests

Edward Haas has posted comments on this change. Change subject: net func test: add basic bond tests .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61125 To unsubscribe, visit https://gerrit.ovirt.org/

Change in vdsm[ovirt-4.0]: net func test: test network based on a vlan

Edward Haas has posted comments on this change. Change subject: net func test: test network based on a vlan .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61124 To unsubscribe, visit https://gerrit.ov

Change in vdsm[ovirt-4.0]: net tests: common tests for 'ovs' and 'legacy'

Edward Haas has posted comments on this change. Change subject: net tests: common tests for 'ovs' and 'legacy' .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61123 To unsubscribe, visit https://gerrit

Change in vdsm[ovirt-4.0]: net func test: Support remove network check

Edward Haas has posted comments on this change. Change subject: net func test: Support remove network check .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61122 To unsubscribe, visit https://gerrit.ov

Change in vdsm[ovirt-4.0]: net tests: Functional tests infrastructure

Edward Haas has posted comments on this change. Change subject: net tests: Functional tests infrastructure .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61121 To unsubscribe, visit https://gerrit.ovi

Change in vdsm[ovirt-4.0]: virt net: Change graphics type from network to address

Edward Haas has posted comments on this change. Change subject: virt net: Change graphics type from network to address .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61120 To unsubscribe, visit https:

Change in vdsm[ovirt-4.0]: net virt: Support connecting VM/s to an ovs bridge

Edward Haas has posted comments on this change. Change subject: net virt: Support connecting VM/s to an ovs bridge .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61119 To unsubscribe, visit https://ge

Change in vdsm[ovirt-4.0]: net: move ip configuration to ip.address module

Edward Haas has posted comments on this change. Change subject: net: move ip configuration to ip.address module .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61116 To unsubscribe, visit https://gerri

Change in vdsm[ovirt-4.0]: netswitch: split setup actions on netswitch level

Edward Haas has posted comments on this change. Change subject: netswitch: split setup actions on netswitch level .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61115 To unsubscribe, visit https://ger

Change in vdsm[ovirt-4.0]: py3: Require libselinux-python3

Edward Haas has posted comments on this change. Change subject: py3: Require libselinux-python3 .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61137 To unsubscribe, visit https://gerrit.ovirt.org/sett

Change in vdsm[ovirt-4.0]: net: Setup ipv6autoconf with OVS switch

Edward Haas has posted comments on this change. Change subject: net: Setup ipv6autoconf with OVS switch .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61114 To unsubscribe, visit https://gerrit.ovirt.

Change in vdsm[ovirt-4.0]: ovs: don't count bond slave duplicates

Edward Haas has posted comments on this change. Change subject: ovs: don't count bond slave duplicates .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61113 To unsubscribe, visit https://gerrit.ovirt.o

Change in vdsm[ovirt-4.0]: ovs: edit bond mode

Edward Haas has posted comments on this change. Change subject: ovs: edit bond mode .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61112 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit

Change in vdsm[ovirt-4.0]: ovs: add/remove OVS network based on a bond

Edward Haas has posted comments on this change. Change subject: ovs: add/remove OVS network based on a bond .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/6 To unsubscribe, visit https://gerrit.ov

Change in vdsm[ovirt-4.0]: ovs: use transaction class for devices setup

Edward Haas has posted comments on this change. Change subject: ovs: use transaction class for devices setup .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61109 To unsubscribe, visit https://gerrit.o

Change in vdsm[ovirt-4.0]: ovs: fix bond removal validation

Edward Haas has posted comments on this change. Change subject: ovs: fix bond removal validation .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61108 To unsubscribe, visit https://gerrit.ovirt.org/set

Change in vdsm[ovirt-4.0]: ovs: validate that to-be-removed bond is not used

Edward Haas has posted comments on this change. Change subject: ovs: validate that to-be-removed bond is not used .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61103 To unsubscribe, visit https://ger

Change in vdsm[ovirt-4.0]: ovs: add/remove OVS network based on a VLAN

Edward Haas has posted comments on this change. Change subject: ovs: add/remove OVS network based on a VLAN .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61102 To unsubscribe, visit https://gerrit.ov

Change in vdsm[ovirt-4.0]: ovs: add/remove OVS network that is based on a nic

Edward Haas has posted comments on this change. Change subject: ovs: add/remove OVS network that is based on a nic .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61101 To unsubscribe, visit https://ge

Change in vdsm[ovirt-4.0]: ovs: don't check if changes are needed in net editation

Edward Haas has posted comments on this change. Change subject: ovs: don't check if changes are needed in net editation .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61100 To unsubscribe, visit https

Change in vdsm[ovirt-4.0]: ovs: use unfaked ovs_netinfo under ovs package

Edward Haas has posted comments on this change. Change subject: ovs: use unfaked ovs_netinfo under ovs package .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/60874 To unsubscribe, visit https://gerrit

Change in vdsm[ovirt-4.0]: ovs: add bridges_by_sb property to OvsInfo

Edward Haas has posted comments on this change. Change subject: ovs: add bridges_by_sb property to OvsInfo .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/60873 To unsubscribe, visit https://gerrit.ovi

Change in vdsm[ovirt-4.0]: ovs: bridge is optional for del-port

Edward Haas has posted comments on this change. Change subject: ovs: bridge is optional for del-port .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/60872 To unsubscribe, visit https://gerrit.ovirt.org

Change in vdsm[ovirt-4.0]: net: use netinfo to split OVS nets and bonds

Edward Haas has posted comments on this change. Change subject: net: use netinfo to split OVS nets and bonds .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/60871 To unsubscribe, visit https://gerrit.o

Change in vdsm[ovirt-4.0]: net: use netinfo to split OVS/legacy nets and bonds

Edward Haas has posted comments on this change. Change subject: net: use netinfo to split OVS/legacy nets and bonds .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/60870 To unsubscribe, visit https://g

Change in vdsm[ovirt-4.0]: net: use netinfo for OVS validation

Edward Haas has posted comments on this change. Change subject: net: use netinfo for OVS validation .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/60869 To unsubscribe, visit https://gerrit.ovirt.org/

Change in vdsm[ovirt-4.0]: net: ovs validator should accept multiple untagged nets

Edward Haas has posted comments on this change. Change subject: net: ovs validator should accept multiple untagged nets .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/60868 To unsubscribe, visit https

Change in vdsm[ovirt-4.0]: net: fix validation bug: ovs_bonds should be used

Edward Haas has posted comments on this change. Change subject: net: fix validation bug: ovs_bonds should be used .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/60867 To unsubscribe, visit https://ger

Change in vdsm[ovirt-4.0]: net: common and legacy CachingNetInfo

Edward Haas has posted comments on this change. Change subject: net: common and legacy CachingNetInfo .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/60866 To unsubscribe, visit https://gerrit.ovirt.or

Change in vdsm[ovirt-4.0]: net: report OVS netinfo in caps

Edward Haas has posted comments on this change. Change subject: net: report OVS netinfo in caps .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/60865 To unsubscribe, visit https://gerrit.ovirt.org/sett

Change in vdsm[ovirt-4.0]: netinfo: report 'vlanid' only if vlan is set

Edward Haas has posted comments on this change. Change subject: netinfo: report 'vlanid' only if vlan is set .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/60864 To unsubscribe, visit https://gerrit.o

Change in vdsm[master]: osutils: Move NoIntrCall to osutils.uninterruptible

Edward Haas has posted comments on this change. Change subject: osutils: Move NoIntrCall to osutils.uninterruptible .. Patch Set 2: Code-Review+1 (1 comment) Looks good to me, only one nit. https://gerrit.ovirt.org/#/c/61153/

Change in vdsm[ovirt-4.0]: vdscli: Provide py3 compatible xmlrpclib (using six)

Edward Haas has posted comments on this change. Change subject: vdscli: Provide py3 compatible xmlrpclib (using six) .. Patch Set 1: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/61150/1//COMMIT_MSG Commit Message: L

Change in vdsm[master]: ovs: copy NIC hwaddr to NB

Edward Haas has posted comments on this change. Change subject: ovs: copy NIC hwaddr to NB .. Patch Set 1: Code-Review-1 (2 comments) Nice solution. https://gerrit.ovirt.org/#/c/61049/1/lib/vdsm/network/netswitch.py File lib/

Change in vdsm[master]: Adding python-setuptools to required ci packages

Edward Haas has posted comments on this change. Change subject: Adding python-setuptools to required ci packages .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/60848 To unsubscribe, visit https://gerr

Change in vdsm[master]: ovs: flush IP config from attached ifaces

Edward Haas has posted comments on this change. Change subject: ovs: flush IP config from attached ifaces .. Patch Set 11: (1 comment) https://gerrit.ovirt.org/#/c/59958/11/tests/network/func_dhclient_test.py File tests/networ

Change in vdsm[master]: ovs: use Setup class directly

Edward Haas has posted comments on this change. Change subject: ovs: use Setup class directly .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/60405 To unsubscribe, visit https://gerrit.ovirt.org/settin

Change in vdsm[master]: ovs: acquire external ifaces

Edward Haas has posted comments on this change. Change subject: ovs: acquire external ifaces .. Patch Set 18: Code-Review-1 (20 comments) https://gerrit.ovirt.org/#/c/60404/18/lib/vdsm/network/netswitch.py File lib/vdsm/networ

Change in vdsm[master]: ovs: use Setup class directly

Edward Haas has posted comments on this change. Change subject: ovs: use Setup class directly .. Patch Set 4: (1 comment) A nit. https://gerrit.ovirt.org/#/c/60405/4/lib/vdsm/network/ovs/switch.py File lib/vdsm/network/ovs/sw

Change in vdsm[master]: ovs: flush IP config from attached ifaces

Edward Haas has posted comments on this change. Change subject: ovs: flush IP config from attached ifaces .. Patch Set 11: (1 comment) https://gerrit.ovirt.org/#/c/59958/11/tests/network/func_dhclient_test.py File tests/networ

Change in vdsm[master]: ovs: use Setup class directly

Edward Haas has posted comments on this change. Change subject: ovs: use Setup class directly .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/60405/3/lib/vdsm/network/ovs/switch.py File lib/vdsm/network/ovs/switch.py:

Change in vdsm[master]: ovs: use ovsdb factory

Edward Haas has posted comments on this change. Change subject: ovs: use ovsdb factory .. Patch Set 6: The point was to avoid exposing ovsdb to the netswitch level. If you create an object in the Setup constructor it makes the

<    1   2   3   4   5   6   7   8   9   10   >