Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 22:
(1 comment)
http://gerrit.ovirt.org/#/c/17694/22/vdsm/virt/domain_descriptor.py
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 22:
(1 comment)
http://gerrit.ovirt.org/#/c/17694/22/vdsm/virt/domain_descriptor.py
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: gluster prepareImage: return gluster-sepecific information
..
Patch Set 3:
(1 comment)
Commit
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: gluster prepareImage: return gluster-specific information
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21059
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: multipath.py: use vdsm.tool.service to restart multipathd
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http
On Mon, Apr 29, 2013 at 03:05:32PM +0200, David Caro wrote:
On 04/29, Kiril Nesenko wrote:
[Adding David]
David,
Can you access the slave and update pep8 there ?
No, that server is owned by ekohl, adding him to the thread.
Update to which version? I've done a yum update python-pep8
On Mon, Apr 29, 2013 at 11:02:43AM -0400, Kiril Nesenko wrote:
- Original Message -
From: Ewoud Kohl van Wijngaarden ew...@kohlvanwijngaarden.nl
To: David Caro dcaro...@redhat.com
Cc: Kiril Nesenko ki...@redhat.com, Dan Kenigsberg
dan...@redhat.com, vdsm-patches
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: vdsm-tool: unify ad-hoc execCmd implementations
..
Patch Set 2: (1 inline comment)
File vdsm
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: vdsm-tool: add service management utilities
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: vdsm-tool: add service management utilities
..
Patch Set 3: Looks good to me, but someone else must approve
I'm not that familiar with all the init
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: vdsmd.init.in: simplify system services management by using
vdsm-tool
..
Patch Set 3: (1 inline comment
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: vdsmd.init.in: simplify system services management by using
vdsm-tool
..
Patch Set 3: (1 inline comment
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: vdsm-tool: add service management utilities
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: make our udev rules take effect later than default Ubuntu lvm
rules
..
Patch Set 3:
I agree with Alon that distribution specifics can be done
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: make our udev rules take effect later than defualt Ubuntu lvm
rules
..
Patch Set 1: (1 inline comment)
FYI: on my Gentoo there's 11-dm-lvm.rules
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Remove redundant exception assignations.
..
Patch Set 4: Looks good to me, but someone else must approve
I think gerrit is trying to tell you
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Remove redundant exception assignations.
..
Patch Set 1: (1 inline comment)
File vdsm/storage
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Remove redundant exception assignations.
..
Patch Set 2: Looks good to me, but someone else must approve
(1 inline comment
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Remove redundant exception assignations.
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Remove redundant exception assignations.
..
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Remove redundant exception assignations.
..
Patch Set 1: (1 inline comment)
File vdsm
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Update except syntax according to pep3110.
..
Patch Set 2: Looks good to me, but someone else must approve
I think this should be merged fast
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Update except syntax according to pep3110.
..
Patch Set 1: Looks good to me, but someone else must approve
(17 inline comments)
In itself a good
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: storageMailboxTests: fix for f18
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10225
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: add xmlrpcTests for cpu pinning
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8412
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: storageMailboxTests: fix for f18
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
Does this affect other unit tests
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: add xmlrpcTests for cpu pinning
..
Patch Set 3: Looks good to me, but someone else must approve
(1 inline comment)
Inline comment is just a typo
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: add xmlrpcTests for cpu pinning
..
Patch Set 4: Looks good to me, but someone else must approve
(1 inline comment)
I don't see the difference
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: dd: use iflag=direct only when supported by the os
..
Patch Set 2:
I'm not sure I agree. I think we have three situations:
* Direct IO
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Fix return value of shutdown() on failure
..
Patch Set 2: Looks good to me, but someone else must approve
I assume patch set 2 is just a rebase
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: dd: use iflag=direct only when supported by the os
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Fix return value of shutdown() on failure
..
Patch Set 1:
If I read it correct in the old situation it will log the error and then fall
through
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: packaging: move /rhev/data-center to /var/lib/vdsm/data-center
..
Patch Set 6: (1 inline comment
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: packaging: move /rhev/data-center to /var/lib/vdsm/data-center
..
Patch Set 5: I would prefer that you didn't submit this
(1 inline comment
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: packaging: move /rhev/data-center to /var/lib/vdsm/data-center
..
Patch Set 6: Looks good to me, but someone else must approve
--
To view, visit
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: packaging: move /rhev/data-center to /var/lib/vdsm/data-center
..
Patch Set 6: I would prefer that you didn't submit this
(2 inline comments
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Reporting error instead of warn when timeout is raised in oop
operation
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Remove redundant plus between two strings in parenthesis
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: packaging: move /rhev/data-center to /var/lib/vdsm/data-center
..
Patch Set 4: I would prefer that you didn't submit this
(1 inline comment)
+1
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: packaging: move /rhev/data-center to /var/lib/vdsm/data-center
..
Patch Set 4: (1 inline comment)
Could you also update the comment in vdsm/storage
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: new API call getVersionInfo()
..
Patch Set 4: I would prefer that you didn't submit this
(2 inline comments
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Integrate deathSignal with execCmd
..
Patch Set 10: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/6242
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Fix vdsm-reg service name
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8037
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Add permutation feature to testing framework
..
Patch Set 13: Looks good to me, but someone else must approve
--
To view, visit http
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Properly propagate pool timeout in file handler
..
Patch Set 7: Looks good to me, but someone else must approve
I think the jenkins failure
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Enable vdsm-reg service
..
Patch Set 2: I would prefer that you didn't submit this
(3 inline comments)
Sorry for the split review, some more
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Properly propagate pool timeout in file handler
..
Patch Set 7: (1 inline comment)
File vdsm
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Enable vdsm-reg service
..
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Sort the pep8 whitelist list
..
Patch Set 13: Verified; Looks good to me, but someone else must approve
Can we get this merged fast? It's a trivial
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Add create operation to qemu-img
..
Patch Set 13: Looks good to me, but someone else must approve
I think it's good now, but still not sure about
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Sort the pep8 whitelist list
..
Patch Set 12: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/6246
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Add deathSignal options to better peopen
..
Patch Set 9: I would prefer that you didn't submit this
Please fix the typos as pointed out by Ayal
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Properly propagate pool timeout in file handler
..
Patch Set 6: Looks good to me, but someone else must approve
--
To view, visit http
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Add create operation to qemu-img
..
Patch Set 12: I would prefer that you didn't submit this
(1 inline comment
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Add permutation feature to testing framework
..
Patch Set 12: Looks good to me, but someone else must approve
--
To view, visit http
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Add permutation feature to testing framework
..
Patch Set 7:
What you're trying to achieve looks similar to
http://melp.nl/2011/02/phpunit-style
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Add permutation feature to testing framework
..
Patch Set 7: (2 inline comments)
I can see that's an advantage, but the format of [(name, args
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Report hsm tasks in getAllTasksStatuses and getAllTasksInfo
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Integrate deathSignal with execCmd
..
Patch Set 8: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/6242
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Sort the pep8 whitelist list
..
Patch Set 11: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/6246
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Report hsm tasks in getAllTasksStatuses and getAllTasksInfo
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Properly propagate pool timeout in file handler
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Sort the pep8 whitelist list
..
Patch Set 7: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/6246
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Integrate deathSignal with execCmd
..
Patch Set 6: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/6242
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Add deathSignal options to better peopen
..
Patch Set 6: Looks good to me, but someone else must approve
Not that familiar with C, but I think
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Add permutation feature to testing framework
..
Patch Set 7: I would prefer that you didn't submit this
I get what you're trying to achieve, but I
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Sort the pep8 whitelist list
..
Patch Set 5: (1 inline comment)
File Makefile.am
Line 64
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Add create operation to qemu-img
..
Patch Set 5: (1 inline comment)
File vdsm/qemuImg.py
Line
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Sort the pep8 whitelist list
..
Patch Set 6: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/6246
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Report hsm tasks in getAllTasksStatuses and getAllTasksInfo
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Add create operation to qemu-img
..
Patch Set 6: I would prefer that you didn't submit this
(2 inline comments
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Properly propegate pool timeout in file handler
..
Patch Set 2: Looks good to me, but someone else must approve
Re-use of exceptions, I like
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Properly propegate pool timeout in file handler
..
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
I could have done
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Add permutation feature to testing framework
..
Patch Set 6: I would prefer that you didn't submit this
Please provide an example because it's hard
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Add deathSignal options to better peopen
..
Patch Set 5: I would prefer that you didn't submit this
(2 inline comments)
Looks good, just
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Integrate deathSignal with execCmd
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/6242
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Check if core is a directory before cleaning
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/6477
To unsubscribe, visit http
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Check if core is a directory before cleaning
..
Patch Set 1:
Oh right. On the jenkins slave I installed (clean fedora 17 install
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Check if core is a directory before cleaning
..
Patch Set 1:
Not sure if it's the same, but from man logrotate:
maxage count
Remove rotated logs
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Add some base functions to vdsm-tool
..
Patch Set 8: I would prefer that you didn't submit this
(2 inline comments
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Add some base functions to vdsm-tool
..
Patch Set 7: I would prefer that you didn't submit this
(4 inline comments)
I think it's a good start
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Add some base functions to vdsm-tool
..
Patch Set 7: (2 inline comments)
File vdsm-tool
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Properly parse configurations in function do_create in
vdsClient
..
Patch Set 5: (2 inline comments)
I like you properly hacked the vdsclient
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Make vdsm/clientIF.py PEP8 clean
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/5412
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Properly parse configurations in function do_create in
vdsClient
..
Patch Set 4: I would prefer that you didn't submit this
(3 inline comments
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Fix return value of shutdown() on failure
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Fix typo (change socekt to socket) in libvirtvm.py and vm.py
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Use domain proxies instead of actual domain references
..
Patch Set 27: I would prefer that you didn't submit this
I'd like a response
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Add some base functions to vdsm-tool
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/5264
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Add some base functions to vdsm-tool
..
Patch Set 5: Looks good to me, but someone else must approve
I think it looks good now.
--
To view, visit
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Add some base functions to vdsm-tool
..
Patch Set 5: I would prefer that you didn't submit this
(2 inline comments)
Now I have another question
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Add some base functions to vdsm-tool
..
Patch Set 3: (4 inline comments)
File vdsm-tool
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Add some base functions to vdsm-tool
..
Patch Set 3: (1 inline comment)
File vdsm-tool/base.py
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Make vdsm/define.py PEP8 clean
..
Patch Set 7: (1 inline comment)
There was a discussion about the 'failed' typo. Maybe we didn't make that clear
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: rename vdsm_tool_expose: prefix is obvious from context
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Move vdsmd.init to vdsm-tool
..
Patch Set 4: (5 inline comments)
Partial review
File vdsm
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Make vdsm/define.py PEP8 clean
..
Patch Set 4: I would prefer that you didn't submit this
(1 inline comment
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Move vdsmd.init to vdsm-tool
..
Patch Set 4: (6 inline comments)
File vdsm/constants.py.in
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Make vdsm/define.py PEP8 clean
..
Patch Set 4: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/4536
Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Make vdsm/clientIF.py PEP8 clean
..
Patch Set 3: (1 inline comment)
File vdsm/clientIF.py
Line
1 - 100 of 182 matches
Mail list logo
