Irit Goihman has posted comments on this change.
Change subject: Method not found should return proper code
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/63120
To unsubscribe, visit https://gerrit.ov
Irit Goihman has uploaded a new change for review.
Change subject: jsonrpc: fix result dictionary
..
jsonrpc: fix result dictionary
Until now, jsonrpc command result held the data itself (not inside a
dict), which caused creatin
Irit Goihman has posted comments on this change.
Change subject: certificates: remove config.read call
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/62941
To unsubscribe, visit https://gerrit.ovirt.org/
Hello Yaniv Bronhaim, Dan Kenigsberg,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/62941
to review the following change.
Change subject: certificates: remove config.read call
..
certificates: re
Irit Goihman has posted comments on this change.
Change subject: automation: remove bond0 hack
..
Patch Set 1: Verified+1
passes on jenkins
http://jenkins.ovirt.org/job/vdsm_4.0_check-merged-fc23-x86_64/117/console
--
To view
Irit Goihman has uploaded a new change for review.
Change subject: automation: remove bond0 hack
..
automation: remove bond0 hack
`echo -bond0 > /sys/class/net/bonding_masters` is causing
check-merged job to fail since bond0 doe
Irit Goihman has posted comments on this change.
Change subject: py3: make conf_persistence_test pass
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/62772
To unsubscribe, visit https://gerrit.ovirt.or
Irit Goihman has posted comments on this change.
Change subject: py3: define __nonzero__ by means of __bool__
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/62771
To unsubscribe, visit https://gerrit.
Irit Goihman has posted comments on this change.
Change subject: certificates: remove config.read call
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/62885
To unsubscribe, visit https://gerrit.ovirt.org/
Irit Goihman has uploaded a new change for review.
Change subject: certificates: remove config.read call
..
certificates: remove config.read call
certificates initiated config read from 'vdsm.conf' file, while config
should be b
Irit Goihman has posted comments on this change.
Change subject: after_vm_destroy.py: migrate to jsonrpcvdscli
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/62383/5/vdsm_hooks/vhostmd/after_vm_destroy.py
File vdsm_h
Irit Goihman has posted comments on this change.
Change subject: after_vm_destroy.py: migrate to jsonrpcvdscli
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/62383/5/vdsm_hooks/vhostmd/after_vm_destroy.py
File vdsm_h
Irit Goihman has posted comments on this change.
Change subject: after_vm_destroy.py: migrate to jsonrpcvdscli
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/62383/4/vdsm_hooks/vhostmd/after_vm_destroy.py
File vdsm_h
Irit Goihman has posted comments on this change.
Change subject: jsonrpcvdscli: add default value to request queue argument
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/62730
To unsubscribe, visit http
Irit Goihman has uploaded a new change for review.
Change subject: jsonrpcvdscli: add default value to request queue argument
..
jsonrpcvdscli: add default value to request queue argument
requestQueue argument of jsonrpcvdscli.c
Irit Goihman has uploaded a new change for review.
Change subject: after_vm_start: changed vdscli to jsonrpcvdsli
..
after_vm_start: changed vdscli to jsonrpcvdsli
vdscli is deprecated and was replaced by jsonrpcvdsli
Change-Id
Irit Goihman has posted comments on this change.
Change subject: build: require only the same version, not release
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/62672
To unsubscribe, visit https://ge
Irit Goihman has posted comments on this change.
Change subject: compat: py3: capture output of CPopen.communicate
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61393
To unsubscribe, visit https://ge
Irit Goihman has posted comments on this change.
Change subject: stomp: use socket pending
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61816
To unsubscribe, visit https://gerrit.ovirt.org/settings
Irit Goihman has uploaded a new change for review.
Change subject: sos: replace dumpStorageTable with dump_volume_chains
..
sos: replace dumpStorageTable with dump_volume_chains
dumpStorageTable is old and uses vdscli and has be
Irit Goihman has posted comments on this change.
Change subject: jsonrpc: shorten executor thread system names
..
Patch Set 7: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61978
To unsubscribe, visit https://gerrit
Irit Goihman has posted comments on this change.
Change subject: automation: fix lago repo for fc24
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/62248
To unsubscribe, visit https://gerrit.ovirt.org/
Irit Goihman has posted comments on this change.
Change subject: dump_volume_chains: migrate to jsonrpcvdscli
..
Patch Set 9: Verified+1
In [2]:
dump_volume_chains.dump_chains('dump-volume-chains','33d5731d-665e-4a70-bb0d-84cd
Irit Goihman has posted comments on this change.
Change subject: dump_volume_chains: migrate to jsonrpcvdscli
..
Patch Set 7:
(2 comments)
https://gerrit.ovirt.org/#/c/62324/6/lib/vdsm/tool/dump_volume_chains.py
File lib/vdsm/
Irit Goihman has posted comments on this change.
Change subject: supervdsmServer: using moduleloader for dynamic imports
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/61313
To unsubscribe, visit https:/
Irit Goihman has posted comments on this change.
Change subject: gluster: use moduleloader for dynamic module import
..
Patch Set 7: Verified+1
--
To view, visit https://gerrit.ovirt.org/62045
To unsubscribe, visit https://ger
Irit Goihman has posted comments on this change.
Change subject: moduleloader: added more functions for modules handling
..
Patch Set 9: -Code-Review Verified+1
--
To view, visit https://gerrit.ovirt.org/61743
To unsubscribe,
Irit Goihman has posted comments on this change.
Change subject: moduleloader: added more functions for modules handling
..
Patch Set 9: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61743
To unsubscribe, visit http
Irit Goihman has uploaded a new change for review.
Change subject: after_vm_destroy.py: migrate to jsonrpcvdscli
..
after_vm_destroy.py: migrate to jsonrpcvdscli
vdscli is deprecated and replaced by jsonrpcvdscli
Change-Id: I3f
Irit Goihman has posted comments on this change.
Change subject: Send vm info report each sampling interval from VMBulkSampler
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/62145
To unsubscribe, visi
Irit Goihman has uploaded a new change for review.
Change subject: check-merged: move to el7
..
check-merged: move to el7
Change-Id: I18655ed38f695e7ffe3d340d7a12cbe22779ddd4
Signed-off-by: Irit Goihman
---
M automation/check-m
Irit Goihman has posted comments on this change.
Change subject: Send metrics info only if metrics enabled to avoid parsing logic
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/62146
To unsubscribe, v
Irit Goihman has posted comments on this change.
Change subject: Adding get_batch to StatsCache - returns dict with all vms stat
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/62144
To unsubscribe, vi
Irit Goihman has posted comments on this change.
Change subject: Adding report_stats to virt.stats
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/62143
To unsubscribe, visit https://gerrit.ovirt.org/s
Irit Goihman has posted comments on this change.
Change subject: Rename reports to metrics
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/62147
To unsubscribe, visit https://gerrit.ovirt.org/settings
Irit Goihman has posted comments on this change.
Change subject: Collect ksm values only if exist
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/62142
To unsubscribe, visit https://gerrit.ovirt.org/se
Irit Goihman has posted comments on this change.
Change subject: jsonrpcvdscli: change getVolumesList schema conversion
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/62325/1//COMMIT_MSG
Commit Message:
Line 7: json
Irit Goihman has posted comments on this change.
Change subject: functional tests: fix supervdsmServer test
..
Patch Set 12:
(2 comments)
https://gerrit.ovirt.org/#/c/61902/11/tests/functional/Makefile.am
File tests/functional
Irit Goihman has uploaded a new change for review.
Change subject: jsonrpcvdscli: change getVolumesList schema conversion
..
jsonrpcvdscli: change getVolumesList schema conversion
getVolumesList was converted to Image.getVolumes
Irit Goihman has uploaded a new change for review.
Change subject: dump_volume_chains: migrate to jsonrpcvdscli
..
dump_volume_chains: migrate to jsonrpcvdscli
Change-Id: I6f34824ba84498bedf9ddc7cb5b41e8cdce603a1
Signed-off-by:
Irit Goihman has posted comments on this change.
Change subject: functional tests: fix supervdsmServer test
..
Patch Set 9:
(5 comments)
https://gerrit.ovirt.org/#/c/61902/8/tests/functional/supervdsmFuncTests.py
File tests/fu
Irit Goihman has uploaded a new change for review.
Change subject: gluster: use moduleloader for dynamic module import
..
gluster: use moduleloader for dynamic module import
moduleloader already handles dynamic module importing
Irit Goihman has posted comments on this change.
Change subject: py3 tests: ported imagetickets_test.py to python3
..
Patch Set 2:
keeping this patch until ovirt-imageio will be py3-compatible
--
To view, visit https://gerrit
Irit Goihman has posted comments on this change.
Change subject: lib: set system name for threads
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55074
To unsubscribe, visit https://gerrit.ovirt.org/se
Irit Goihman has posted comments on this change.
Change subject: check-merged: remove numactl installation from deploy
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/61938
To unsubscribe, visit https://g
Irit Goihman has posted comments on this change.
Change subject: automation: include master repos in check-merged tests
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/61936
To unsubscribe, visit https://
Irit Goihman has posted comments on this change.
Change subject: check-merged: install python-mock on lago deploy
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/61937
To unsubscribe, visit https://gerrit
Irit Goihman has posted comments on this change.
Change subject: automation: move check-merged to fc24
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/61935
To unsubscribe, visit https://gerrit.ovirt.org/
Irit Goihman has uploaded a new change for review.
Change subject: check-merged: remove numactl installation from deploy
..
check-merged: remove numactl installation from deploy
numactl is installed when vdsn is installed so it'
Irit Goihman has uploaded a new change for review.
Change subject: check-merged: install python-mock on lago deploy
..
check-merged: install python-mock on lago deploy
python-mock is needed by testlib and it's not installed when
Irit Goihman has uploaded a new change for review.
Change subject: automation: include master repos in check-merged tests
..
automation: include master repos in check-merged tests
ovirt master repos weren't enabled so vdsm depen
Irit Goihman has uploaded a new change for review.
Change subject: automation: move check-merged to fc24
..
automation: move check-merged to fc24
check-merged repos were moved to fc24 so lago ovirt deploy is
looking for packages
Irit Goihman has posted comments on this change.
Change subject: infra tests: added functional test for upgrading vdsm
..
Patch Set 6: Verified+1
--
To view, visit https://gerrit.ovirt.org/61186
To unsubscribe, visit https://g
Irit Goihman has posted comments on this change.
Change subject: infra tests: added functional test for upgrading vdsm
..
Patch Set 5: Verified+1
functional.supervdsmFuncTests.TestSuperVdsmRemotly
20:11:30 testKsmAction
Irit Goihman has posted comments on this change.
Change subject: functional tests: fix supervdsmServer test
..
Patch Set 3: Verified+1
check-merged run:
nose.config: INFO: Ignoring files matching ['^\\.', '^_', '^setup\\.py$']
Irit Goihman has posted comments on this change.
Change subject: supervdsmServer: using moduleloader for dynamic imports
..
Patch Set 1:
check-merged run:
nose.config: INFO: Ignoring files matching ['^\\.', '^_', '^setup\\.py$
Irit Goihman has posted comments on this change.
Change subject: supervdsmServer: using moduleloader for dynamic imports
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/61313
To unsubscribe, visit https:/
Irit Goihman has posted comments on this change.
Change subject: automation: fix check-merged.sh
..
Patch Set 12: Verified+1
--
To view, visit https://gerrit.ovirt.org/61415
To unsubscribe, visit https://gerrit.ovirt.org/setti
Irit Goihman has uploaded a new change for review.
Change subject: functional tests: fix supervdsmServer test
..
functional tests: fix supervdsmServer test
supervdsmServer dropPrivileges function is switching root user to
a non
Irit Goihman has posted comments on this change.
Change subject: automation: fix check-merged.sh
..
Patch Set 10:
(5 comments)
https://gerrit.ovirt.org/#/c/61415/10/automation/deploy.sh
File automation/deploy.sh:
Line 50
Line
Irit Goihman has posted comments on this change.
Change subject: automation: fix check-merged.sh
..
Patch Set 10: Verified+1
verified on jenkins
http://jenkins.ovirt.org/job/vdsm_master_check-merged-fc24-x86_64/128/console
--
Irit Goihman has posted comments on this change.
Change subject: automation: fix check-merged.sh
..
Patch Set 7: Verified+1
ran check-merged job on jenkins
--
To view, visit https://gerrit.ovirt.org/61415
To unsubscribe, visi
Irit Goihman has uploaded a new change for review.
Change subject: moduleloader: added more functions for modules handling
..
moduleloader: added more functions for modules handling
added import list of modules in a package and
Irit Goihman has uploaded a new change for review.
Change subject: automation: fix check-merged.sh
..
automation: fix check-merged.sh
after moving to fc24 check-merged job started to fail.
This patch fixes broken dependencies an
Irit Goihman has uploaded a new change for review.
Change subject: supervdsmServer: using moduleloader for dynamic imports
..
supervdsmServer: using moduleloader for dynamic imports
moduleloader utility handles dynamic imports o
Irit Goihman has posted comments on this change.
Change subject: vdscli: added DeprecationWarning to module
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/61187
To unsubscribe, visit https://gerrit.ovirt
Hello Yaniv Bronhaim, Dan Kenigsberg,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/61187
to review the following change.
Change subject: vdscli: added DeprecationWarning to module
..
vdscli: add
Irit Goihman has uploaded a new change for review.
Change subject: [wip] infra tests: added functional test for upgrading vdsm
..
[wip] infra tests: added functional test for upgrading vdsm
Change-Id: I589a73fa5285983f7d1adcdae4
Irit Goihman has posted comments on this change.
Change subject: sos report: replace vdscli with jsonrpcvdscli
..
Patch Set 13: Verified+1
--
To view, visit https://gerrit.ovirt.org/60605
To unsubscribe, visit https://gerrit.o
Irit Goihman has posted comments on this change.
Change subject: sos report: replace vdscli with jsonrpcvdscli
..
Patch Set 12:
(1 comment)
https://gerrit.ovirt.org/#/c/60605/12/vdsm/sos/vdsm.py.in
File vdsm/sos/vdsm.py.in:
P
Irit Goihman has posted comments on this change.
Change subject: sos report: replace vdscli with jsonrpcvdscli
..
Patch Set 12: Verified+1
--
To view, visit https://gerrit.ovirt.org/60605
To unsubscribe, visit https://gerrit.o
Irit Goihman has posted comments on this change.
Change subject: sos report: replace vdscli with jsonrpcvdscli
..
Patch Set 10:
(1 comment)
https://gerrit.ovirt.org/#/c/60605/9/vdsm/sos/vdsm.py.in
File vdsm/sos/vdsm.py.in:
Li
Irit Goihman has posted comments on this change.
Change subject: sos report: replace vdscli with jsonrpcvdscli
..
Patch Set 9:
(1 comment)
https://gerrit.ovirt.org/#/c/60605/8/vdsm/sos/vdsm.py.in
File vdsm/sos/vdsm.py.in:
Lin
Irit Goihman has posted comments on this change.
Change subject: sos report: replace vdscli with jsonrpcvdscli
..
Patch Set 8: Verified+1
--
To view, visit https://gerrit.ovirt.org/60605
To unsubscribe, visit https://gerrit.ov
Irit Goihman has posted comments on this change.
Change subject: sos report: replace vdscli with jsonrpcvdscli
..
Patch Set 7:
(6 comments)
https://gerrit.ovirt.org/#/c/60605/6/vdsm/sos/vdsm.py.in
File vdsm/sos/vdsm.py.in:
Li
Irit Goihman has posted comments on this change.
Change subject: sos report: replace vdscli with jsonrpcvdscli
..
Patch Set 7:
(2 comments)
https://gerrit.ovirt.org/#/c/60605/6/vdsm/sos/vdsm.py.in
File vdsm/sos/vdsm.py.in:
Li
Irit Goihman has posted comments on this change.
Change subject: sos report: replace vdscli with jsonrpcvdscli
..
Patch Set 6:
this is the sos report output for jsonrpcvdscli commands:
# ll sos_strings/vdsm/
total 32
-rw-r--r--
Irit Goihman has posted comments on this change.
Change subject: sos report: replace vdscli with jsonrpcvdscli
..
Patch Set 6: Verified+1
verified running `sosreport -o vdsm`
--
To view, visit https://gerrit.ovirt.org/60605
T
Irit Goihman has posted comments on this change.
Change subject: sos report: _importVdsmPylibModule can import all vdsm modules
..
Patch Set 6: Verified+1
(1 comment)
verified importing vdsm.jsonrpcvdscli and vdsm.storage.cons
Irit Goihman has posted comments on this change.
Change subject: sos report: added full module name to _importVdsmPylibModule
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/60627/4/vdsm/sos/vdsm.py.in
File vdsm/sos/v
Irit Goihman has posted comments on this change.
Change subject: sos report: added full module name to _importVdsmPylibModule
..
Patch Set 5:
please ignore last update
--
To view, visit https://gerrit.ovirt.org/60627
To unsub
Irit Goihman has posted comments on this change.
Change subject: sos report: replace vdscli with jsonrpcvdscli
..
Patch Set 3:
(5 comments)
https://gerrit.ovirt.org/#/c/60605/3/vdsm/sos/vdsm.py.in
File vdsm/sos/vdsm.py.in:
Li
Irit Goihman has posted comments on this change.
Change subject: sos: added full module name to _importVdsmPylibModule
..
Patch Set 4: -Verified
(1 comment)
https://gerrit.ovirt.org/#/c/60627/4/vdsm/sos/vdsm.py.in
File vdsm/so
Irit Goihman has posted comments on this change.
Change subject: Modify reports to metrics
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/60450
To unsubscribe, visit https://gerrit.ovirt.org/settings
Irit Goihman has posted comments on this change.
Change subject: sos report: added full module name to _importVdsmPylibModule
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/60627/2/vdsm/sos/vdsm.py.in
File vdsm/sos/v
Irit Goihman has posted comments on this change.
Change subject: sos report: added full module name to _importVdsmPylibModule
..
Patch Set 3: Verified+1
verified importing jsonrpcvdscli works fine and the report is generated
-
Irit Goihman has posted comments on this change.
Change subject: sos report: added full module name to _importVdsmPylibModule
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/60627/2/vdsm/sos/vdsm.py.in
File vdsm/sos/v
Irit Goihman has posted comments on this change.
Change subject: sos report: removed call to vdsClient getVGList
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/60613
To unsubscribe, visit https://gerrit.
Irit Goihman has uploaded a new change for review.
Change subject: sos report: added full module name to _importVdsmPylibModule
..
sos report: added full module name to _importVdsmPylibModule
sos report cannot import modules dir
Irit Goihman has posted comments on this change.
Change subject: [wip] sos report: replace vdscli with jsonrpcvdscli
..
Patch Set 1: -Verified
--
To view, visit https://gerrit.ovirt.org/60605
To unsubscribe, visit https://gerr
Irit Goihman has posted comments on this change.
Change subject: [wip] sos report: replace vdscli with jsonrpcvdscli
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/60605
To unsubscribe, visit https://ger
Irit Goihman has posted comments on this change.
Change subject: sos report: removed call to vdsClient getVGList
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/60613
To unsubscribe, visit https://gerrit.
Irit Goihman has posted comments on this change.
Change subject: vdscli: added DeprecationWarning to module
..
Patch Set 8:
/usr/lib/python2.7/site-packages/vdsm/tool/dump_volume_chains.py:28:
DeprecationWarning: vdscli uses x
Irit Goihman has uploaded a new change for review.
Change subject: sos report: removed call to vdsClient getVGList
..
sos report: removed call to vdsClient getVGList
getVGList has been deprecated and will be fully removed in the
Irit Goihman has posted comments on this change.
Change subject: jsonrpcvdscli: added getAllTasksInfo verb
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/60607
To unsubscribe, visit https://gerrit.ovirt.
Irit Goihman has uploaded a new change for review.
Change subject: jsonrpcvdscli: added getAllTasksInfo verb
..
jsonrpcvdscli: added getAllTasksInfo verb
getAllTasksInfo verb is needed by sos report
Change-Id: I8c02c3aeb35b1b6d
Irit Goihman has posted comments on this change.
Change subject: tox: Exclude .ropeproject from pep8 check
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/59677
To unsubscribe, visit https://gerrit.ovi
Irit Goihman has uploaded a new change for review.
Change subject: [wip] sos report: replace vdscli with jsonrpcvdscli
..
[wip] sos report: replace vdscli with jsonrpcvdscli
Change-Id: I3cc1ba745dad6d3eba9f480830ea01774eb4db71
S
Irit Goihman has posted comments on this change.
Change subject: vdscli: added DeprecationWarning to module
..
Patch Set 8: Verified+1
--
To view, visit https://gerrit.ovirt.org/60318
To unsubscribe, visit https://gerrit.ovirt
Irit Goihman has posted comments on this change.
Change subject: tox: fail make process if required tox version isn't installed.
..
Patch Set 21:
> Irit, did you address the comments in version 7?
version 7 is very old, are yo
101 - 200 of 308 matches
Mail list logo