Martin Betak has posted comments on this change.
Change subject: vdsm: Remove unreachable code
..
Patch Set 1:
(4 comments)
https://gerrit.ovirt.org/#/c/52980/1/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 294
Line 295
Martin Betak has uploaded a new change for review.
Change subject: vdsm: Remove unreachable code
..
vdsm: Remove unreachable code
Change-Id: I919ca97f7b1077be2415287a43b9a9372e1fa593
Signed-off-by: Martin Betak
Martin Betak has posted comments on this change.
Change subject: virt: s/vm._dom.XMLDesc(0)/vm.xml/g
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/52882
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: virt: s/vm._dom.XMLDesc(0)/vm.xml/g
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/52882/1//COMMIT_MSG
Commit Message:
Line 10: it's
> ... its ...
Martin Betak has uploaded a new change for review.
Change subject: virt: s/vm._dom.XMLDesc(0)/vm.xml/g
..
virt: s/vm._dom.XMLDesc(0)/vm.xml/g
Added small helper property to avoid accessing private state
of VM to get it's XML
Martin Betak has posted comments on this change.
Change subject: migration: Add incoming migration semaphore
..
Patch Set 21: Code-Review-1 Verified-1
I was wondering, why the code doesn't work at all :-) Thank you so much,
Martin Betak has posted comments on this change.
Change subject: WIP DONTMERGE: migrationLimit retry
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/52799/1/vdsm/virt/migration.py
File vdsm/virt/migration.py:
Line
Martin Betak has posted comments on this change.
Change subject: migration: Add incoming migration semaphore
..
Patch Set 20:
(3 comments)
https://gerrit.ovirt.org/#/c/45954/20/vdsm/API.py
File vdsm/API.py:
Line 583:
Martin Betak has posted comments on this change.
Change subject: virt: add run_async helper
..
Patch Set 5: Code-Review+1
(1 comment)
Nice job! I really like the simplification over the previous implementations.
Martin Betak has posted comments on this change.
Change subject: virt: introduce "run_async" helper
..
Patch Set 1:
(3 comments)
Nice, I really like the simplification compared to previous version!
Martin Betak has posted comments on this change.
Change subject: virt: introduce "Async" helper
..
Patch Set 2:
I'm going to have to agree with Milan. We need to ask ourselves, what we are
getting in exchange for all this
Martin Betak has posted comments on this change.
Change subject: migration: Add support for max migration bandwidth setting
..
Patch Set 8: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/46846
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: utils: Add @throttle decorator
..
Patch Set 11: Verified+1
--
To view, visit https://gerrit.ovirt.org/47087
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: migration: Add incoming migration semaphore
..
Patch Set 13:
(1 comment)
https://gerrit.ovirt.org/#/c/45954/13/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 2759:
Martin Betak has posted comments on this change.
Change subject: migration: Add migrateChangeGlobalParams verb
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/47409/6/vdsm/virt/utils.py
File vdsm/virt/utils.py:
Line
Martin Betak has posted comments on this change.
Change subject: vm: extract migration completion check
..
Patch Set 7: Verified+1
--
To view, visit https://gerrit.ovirt.org/47086
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: utils: Add @throttle decorator
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/47087/7//COMMIT_MSG
Commit Message:
Line 14: * Blocking operations:
Martin Betak has posted comments on this change.
Change subject: vm: extract migration completion check
..
Patch Set 6:
(2 comments)
https://gerrit.ovirt.org/#/c/47086/6/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 2776:
Martin Betak has posted comments on this change.
Change subject: utils: Add @throttle decorator
..
Patch Set 6: Verified+1
--
To view, visit https://gerrit.ovirt.org/47087
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: vm: extract migration completion check
..
Patch Set 5: Verified+1
--
To view, visit https://gerrit.ovirt.org/47086
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: utils: Add @throttle decorator
..
Patch Set 5:
(2 comments)
https://gerrit.ovirt.org/#/c/47087/5/tests/vmUtilsTests.py
File tests/vmUtilsTests.py:
Line 149:
Martin Betak has posted comments on this change.
Change subject: migration: Add retry logic for incoming limit
..
Patch Set 9:
(1 comment)
https://gerrit.ovirt.org/#/c/46971/9/vdsm/virt/migration.py
File
Martin Betak has posted comments on this change.
Change subject: migration: Add incoming migration semaphore
..
Patch Set 13:
(1 comment)
https://gerrit.ovirt.org/#/c/45954/13/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 2759:
Martin Betak has uploaded a new change for review.
Change subject: migration: Add migrateChangeGlobalParams verb
..
migration: Add migrateChangeGlobalParams verb
Added new verb for setting values of incoming and outgoing
Martin Betak has posted comments on this change.
Change subject: utils: Add @throttle decorator
..
Patch Set 4:
(4 comments)
https://gerrit.ovirt.org/#/c/47087/4/tests/vmUtilsTests.py
File tests/vmUtilsTests.py:
Line 180:
Martin Betak has posted comments on this change.
Change subject: vm: extract migration completion check
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/47086/3//COMMIT_MSG
Commit Message:
Line 6:
Line 7: vm:
Martin Betak has posted comments on this change.
Change subject: vm: small cleanup of _completeIncomingMigration()
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/47086/1//COMMIT_MSG
Commit Message:
Line 3:
Martin Betak has posted comments on this change.
Change subject: vm: small cleanup of _completeIncomingMigration()
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/47086/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line
Martin Betak has posted comments on this change.
Change subject: utils: Add @throttle decorator
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/47087/1/vdsm/virt/utils.py
File vdsm/virt/utils.py:
Line 128:
Line
Martin Betak has posted comments on this change.
Change subject: utils: Add @throttle decorator
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/47087/1/vdsm/virt/utils.py
File vdsm/virt/utils.py:
Line 155:
Martin Betak has posted comments on this change.
Change subject: utils: Add @throttle decorator
..
Patch Set 3: Verified+1
added tests
--
To view, visit https://gerrit.ovirt.org/47087
To unsubscribe, visit
Martin Betak has uploaded a new change for review.
Change subject: vm: small cleanup of _completeIncomingMigration()
..
vm: small cleanup of _completeIncomingMigration()
Extracted the check for recovery completion into separate
Martin Betak has uploaded a new change for review.
Change subject: utils: Add @throttle decorator
..
utils: Add @throttle decorator
Added decorator for API methods that need to limit their maximum number of
concurrent
Martin Betak has posted comments on this change.
Change subject: migration: Add incoming migration semaphore
..
Patch Set 8:
(4 comments)
https://gerrit.ovirt.org/#/c/45954/8//COMMIT_MSG
Commit Message:
Line 7: migration:
Martin Betak has posted comments on this change.
Change subject: migration: Add incoming migration semaphore
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/45954/5/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 2752:
Martin Betak has posted comments on this change.
Change subject: migration: Add incoming migration semaphore
..
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/45954/3/vdsm/virt/migration.py
File
Martin Betak has posted comments on this change.
Change subject: migration: Add incoming migration semaphore
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/45954/3/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line
Martin Betak has posted comments on this change.
Change subject: migration: Add incoming migration semaphore
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/45954/3/vdsm/API.py
File vdsm/API.py:
Line 571:
Martin Betak has posted comments on this change.
Change subject: migration: Add incoming migration semaphore
..
Patch Set 2:
(3 comments)
https://gerrit.ovirt.org/#/c/45954/2/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line
Martin Betak has posted comments on this change.
Change subject: tests: virt: move powerdown related tests away
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/45064
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: hostdev: remove detection of device vmId
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/38668
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: hostdev: report 'net' devices and their interface name
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/35912
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: hostdev: make caps in listByCaps truly optional
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/35867
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: hostdev: make caps in listByCaps truly optional
..
Patch Set 1:
Tested with engine draft, without caps parameter.
--
To view, visit
Martin Betak has posted comments on this change.
Change subject: hostdev: make caps in listByCaps truly optional
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/35867
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: vdsm: Add support for VIR_MIGRATE_COMPRESSED parameter
..
Patch Set 5:
(1 comment)
http://gerrit.ovirt.org/#/c/31992/5/vdsm/API.py
File vdsm/API.py:
Line 504:
Martin Betak has uploaded a new change for review.
Change subject: caps.py: Drop support for Fedora 19
..
caps.py: Drop support for Fedora 19
Change-Id: Ib1f89f3b8371b6d3f4ba8a4e17b454254213960d
Signed-off-by: Martin Betak
Martin Betak has posted comments on this change.
Change subject: vdsm: Add support for VIR_MIGRATE_AUTO_CONVERGE parameter
..
Patch Set 6: Verified+1
--
To view, visit http://gerrit.ovirt.org/31991
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: caps.py: Drop support for Fedora 19
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/34191
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: vdsm: Add support for VIR_MIGRATE_COMPRESSED parameter
..
Patch Set 6: Verified+1
--
To view, visit http://gerrit.ovirt.org/31992
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: vdsm: Add support for VIR_MIGRATE_AUTO_CONVERGE parameter
..
Patch Set 5:
Fixed debian packaging rebase issue and refactored the caps._getVersionInfo
libvirt
Martin Betak has posted comments on this change.
Change subject: vdsm: Add support for VIR_MIGRATE_AUTO_CONVERGE parameter
..
Patch Set 4: Verified+1
--
To view, visit http://gerrit.ovirt.org/31991
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: vdsm: Add support for VIR_MIGRATE_COMPRESSED parameter
..
Patch Set 4: Verified+1
--
To view, visit http://gerrit.ovirt.org/31992
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: vdsm: Add support for VIR_MIGRATE_AUTO_CONVERGE parameter
..
Patch Set 3:
Modified specfile, set required version of libvirt to = 1.2.3
--
To view, visit
Martin Betak has uploaded a new change for review.
Change subject: vdsm: Add support for VIR_MIGRATE_AUTO_CONVERGE parameter
..
vdsm: Add support for VIR_MIGRATE_AUTO_CONVERGE parameter
Add support for configuring the
Martin Betak has uploaded a new change for review.
Change subject: vdsm: Add support for VIR_MIGRATE_COMPRESSED parameter
..
vdsm: Add support for VIR_MIGRATE_COMPRESSED parameter
Add support for configuring the
Martin Betak has posted comments on this change.
Change subject: vdsm: Add force and timeout options to VM.shutdown
..
Patch Set 6:
(2 comments)
http://gerrit.ovirt.org/#/c/27054/6//COMMIT_MSG
Commit Message:
Line 5:
Martin Betak has posted comments on this change.
Change subject: vdsm: Add force and timeout options to VM.shutdown
..
Patch Set 7: Verified+1
--
To view, visit http://gerrit.ovirt.org/27054
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: vdsm: Add force and timeout options to VM.shutdown
..
Patch Set 6:
(1 comment)
http://gerrit.ovirt.org/#/c/27054/6//COMMIT_MSG
Commit Message:
Line 13:
Martin Betak has posted comments on this change.
Change subject: vdsm: Add force and timeout options to VM.shutdown
..
Patch Set 6:
(2 comments)
http://gerrit.ovirt.org/#/c/27054/6/vdsm/virt/vmpowerdown.py
File
Martin Betak has posted comments on this change.
Change subject: vdsm: Add force and timeout options to VM.shutdown
..
Patch Set 4:
(7 comments)
http://gerrit.ovirt.org/#/c/27054/4/lib/vdsm/config.py.in
File
Martin Betak has posted comments on this change.
Change subject: vdsm: Add force and timeout options to VM.shutdown
..
Patch Set 5: Verified+1
--
To view, visit http://gerrit.ovirt.org/27054
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: vdsm: Add force and timeout options to VM.shutdown
..
Patch Set 3: -Verified
--
To view, visit http://gerrit.ovirt.org/27054
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: vdsm: Add force and timeout options to VM.shutdown
..
Patch Set 4: Verified+1
--
To view, visit http://gerrit.ovirt.org/27054
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: vdsm: Add force and timeout options to VM.shutdown
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/27054
To unsubscribe, visit
Martin Betak has uploaded a new change for review.
Change subject: vdsm: Add force and timeout options to VM.shutdown
..
vdsm: Add force and timeout options to VM.shutdown
Added optional boolean parameters 'timeout' and 'force'
Martin Betak has posted comments on this change.
Change subject: vm: add boot menu support
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/23558
To unsubscribe, visit http://gerrit.ovirt.org/settings
Martin Betak has posted comments on this change.
Change subject: vm: add boot menu support
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/23558
To unsubscribe, visit http://gerrit.ovirt.org/settings
Martin Betak has posted comments on this change.
Change subject: vdsm: Add ACPI support for VM shutdown/reboot
..
Patch Set 6:
(4 comments)
http://gerrit.ovirt.org/#/c/23457/6/vdsm/vmCommands.py
File vdsm/vmCommands.py:
Line
Martin Betak has posted comments on this change.
Change subject: vdsm: Add ACPI support for VM shutdown/reboot
..
Patch Set 6: Verified+1
--
To view, visit http://gerrit.ovirt.org/23457
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: vdsm: Add ACPI support for VM shutdown/reboot
..
Patch Set 4:
(3 comments)
http://gerrit.ovirt.org/#/c/23457/4//COMMIT_MSG
Commit Message:
Line 3: AuthorDate:
Martin Betak has posted comments on this change.
Change subject: vdsm: Add ACPI support for VM shutdown/reboot
..
Patch Set 5: Verified+1
--
To view, visit http://gerrit.ovirt.org/23457
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: vdsm: Utilize CallbackChain in vm.shutdown
..
Patch Set 3:
(6 comments)
http://gerrit.ovirt.org/#/c/23457/3//COMMIT_MSG
Commit Message:
Line 5: CommitDate:
Martin Betak has posted comments on this change.
Change subject: vdsm: Utilize CallbackChain in vm.shutdown
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/23457/3/vdsm/vm.py
File vdsm/vm.py:
Line 1891:
Martin Betak has posted comments on this change.
Change subject: vdsm: Enable config of VM serial number
..
Patch Set 2:
The goal of this feature is to give user better control over the resulting
serial number of the VM. At
Martin Betak has posted comments on this change.
Change subject: vdsm: Enable config of VM serial number
..
Patch Set 3: Verified+1
updated commit message
--
To view, visit http://gerrit.ovirt.org/24274
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: vdsm: Enable config of VM serial number
..
Patch Set 4: Verified+1
--
To view, visit http://gerrit.ovirt.org/24274
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: vdsm: Enable config of VM serial number
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/24274
To unsubscribe, visit
Martin Betak has uploaded a new change for review.
Change subject: vdsm: Enable config of VM serial number
..
vdsm: Enable config of VM serial number
Added support for passing explicit serial number
as a part of vmParams from
Martin Betak has posted comments on this change.
Change subject: vdsm: Enable config of VM serial number
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/24274
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: vdsm: Enable config of VM serial number
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/24274/1/vdsm/vm.py
File vdsm/vm.py:
Line 1013:
Line 1014:
Martin Betak has posted comments on this change.
Change subject: vdsm: Utilize CallbackChain in vm.shutdown
..
Patch Set 2:
(5 comments)
http://gerrit.ovirt.org/#/c/23457/2/vdsm/vm.py
File vdsm/vm.py:
Line 2617
Line 2618
Martin Betak has posted comments on this change.
Change subject: vdsm: Utilize CallbackChain in vm.shutdown
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/23457
To unsubscribe, visit
Martin Betak has uploaded a new change for review.
Change subject: vdsm: Utilize CallbackChain in vm.shutdown
..
vdsm: Utilize CallbackChain in vm.shutdown
Refactor the existing shutdown/reboot code to utilize the
Martin Betak has posted comments on this change.
Change subject: vdsm: Utilize CallbackChain in vm.shutdown
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/23457
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: vdsm: Add support for Guest Reboot
..
Patch Set 1:
(3 comments)
Commit Message
Line 12: backwards
Martin Betak has posted comments on this change.
Change subject: vdsm: Add support for Guest Reboot
..
Patch Set 1:
(1 comment)
File vdsm/vm.py
Line 2546: except:
Martin Betak has posted comments on this change.
Change subject: vdsm: Add support for Guest Reboot
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/22440
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 39: Verified+1
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 37:
(1 comment)
File vdsm/vm.py
Line 1729: self.timeout
Martin Betak has uploaded a new change for review.
Change subject: vdsm: Add support for Guest Reboot
..
vdsm: Add support for Guest Reboot
Added optional parameter reboot to shutdown in vdsm and vdsClient.
This parameter
Martin Betak has abandoned this change.
Change subject: vdsm: Reboot capability for VM
..
Abandoned
Abandoned in favor of a more lightweight patch http://gerrit.ovirt.org/22440
adding only guest agent reboot support without
Martin Betak has posted comments on this change.
Change subject: vdsm: Add support for Guest Reboot
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/22440
To unsubscribe, visit
Martin Betak has abandoned this change.
Change subject: vdsm: Fix potential leak in Vm.destroy()
..
Abandoned
--
To view, visit http://gerrit.ovirt.org/18337
To unsubscribe, visit http://gerrit.ovirt.org/settings
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 37:
(1 comment)
File vdsm/vm.py
Line 1764: # flag for
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 37:
(6 comments)
File vdsm/vm.py
Line 1729:
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 38: Verified+1
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 37: Verified+1
--
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 35:
(1 comment)
File vdsm/vm.py
Line 1790:
Martin Betak has posted comments on this change.
Change subject: vdsm: Reboot capability for VM
..
Patch Set 35:
(2 comments)
File client/vdsClient.py
Line 1922:
101 - 200 of 249 matches
Mail list logo