Change in vdsm[master]: vdsm: Remove unreachable code

2016-02-02 Thread mbetak
Martin Betak has posted comments on this change. Change subject: vdsm: Remove unreachable code .. Patch Set 1: (4 comments) https://gerrit.ovirt.org/#/c/52980/1/lib/vdsm/utils.py File lib/vdsm/utils.py: Line 294 Line 295

Change in vdsm[master]: vdsm: Remove unreachable code

2016-02-02 Thread mbetak
Martin Betak has uploaded a new change for review. Change subject: vdsm: Remove unreachable code .. vdsm: Remove unreachable code Change-Id: I919ca97f7b1077be2415287a43b9a9372e1fa593 Signed-off-by: Martin Betak

Change in vdsm[master]: virt: s/vm._dom.XMLDesc(0)/vm.xml/g

2016-01-29 Thread mbetak
Martin Betak has posted comments on this change. Change subject: virt: s/vm._dom.XMLDesc(0)/vm.xml/g .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/52882 To unsubscribe, visit

Change in vdsm[master]: virt: s/vm._dom.XMLDesc(0)/vm.xml/g

2016-01-29 Thread mbetak
Martin Betak has posted comments on this change. Change subject: virt: s/vm._dom.XMLDesc(0)/vm.xml/g .. Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/52882/1//COMMIT_MSG Commit Message: Line 10: it's > ... its ...

Change in vdsm[master]: virt: s/vm._dom.XMLDesc(0)/vm.xml/g

2016-01-29 Thread mbetak
Martin Betak has uploaded a new change for review. Change subject: virt: s/vm._dom.XMLDesc(0)/vm.xml/g .. virt: s/vm._dom.XMLDesc(0)/vm.xml/g Added small helper property to avoid accessing private state of VM to get it's XML

Change in vdsm[master]: migration: Add incoming migration semaphore

2016-01-28 Thread mbetak
Martin Betak has posted comments on this change. Change subject: migration: Add incoming migration semaphore .. Patch Set 21: Code-Review-1 Verified-1 I was wondering, why the code doesn't work at all :-) Thank you so much,

Change in vdsm[master]: WIP DONTMERGE: migrationLimit retry

2016-01-28 Thread mbetak
Martin Betak has posted comments on this change. Change subject: WIP DONTMERGE: migrationLimit retry .. Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/52799/1/vdsm/virt/migration.py File vdsm/virt/migration.py: Line

Change in vdsm[master]: migration: Add incoming migration semaphore

2016-01-27 Thread mbetak
Martin Betak has posted comments on this change. Change subject: migration: Add incoming migration semaphore .. Patch Set 20: (3 comments) https://gerrit.ovirt.org/#/c/45954/20/vdsm/API.py File vdsm/API.py: Line 583:

Change in vdsm[master]: virt: add run_async helper

2015-12-11 Thread mbetak
Martin Betak has posted comments on this change. Change subject: virt: add run_async helper .. Patch Set 5: Code-Review+1 (1 comment) Nice job! I really like the simplification over the previous implementations.

Change in vdsm[master]: virt: introduce "run_async" helper

2015-11-30 Thread mbetak
Martin Betak has posted comments on this change. Change subject: virt: introduce "run_async" helper .. Patch Set 1: (3 comments) Nice, I really like the simplification compared to previous version!

Change in vdsm[master]: virt: introduce "Async" helper

2015-11-25 Thread mbetak
Martin Betak has posted comments on this change. Change subject: virt: introduce "Async" helper .. Patch Set 2: I'm going to have to agree with Milan. We need to ask ourselves, what we are getting in exchange for all this

Change in vdsm[master]: migration: Add support for max migration bandwidth setting

2015-11-09 Thread mbetak
Martin Betak has posted comments on this change. Change subject: migration: Add support for max migration bandwidth setting .. Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/46846 To unsubscribe, visit

Change in vdsm[master]: utils: Add @throttle decorator

2015-11-05 Thread mbetak
Martin Betak has posted comments on this change. Change subject: utils: Add @throttle decorator .. Patch Set 11: Verified+1 -- To view, visit https://gerrit.ovirt.org/47087 To unsubscribe, visit

Change in vdsm[master]: migration: Add incoming migration semaphore

2015-10-26 Thread mbetak
Martin Betak has posted comments on this change. Change subject: migration: Add incoming migration semaphore .. Patch Set 13: (1 comment) https://gerrit.ovirt.org/#/c/45954/13/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 2759:

Change in vdsm[master]: migration: Add migrateChangeGlobalParams verb

2015-10-25 Thread mbetak
Martin Betak has posted comments on this change. Change subject: migration: Add migrateChangeGlobalParams verb .. Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/47409/6/vdsm/virt/utils.py File vdsm/virt/utils.py: Line

Change in vdsm[master]: vm: extract migration completion check

2015-10-21 Thread mbetak
Martin Betak has posted comments on this change. Change subject: vm: extract migration completion check .. Patch Set 7: Verified+1 -- To view, visit https://gerrit.ovirt.org/47086 To unsubscribe, visit

Change in vdsm[master]: utils: Add @throttle decorator

2015-10-21 Thread mbetak
Martin Betak has posted comments on this change. Change subject: utils: Add @throttle decorator .. Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/47087/7//COMMIT_MSG Commit Message: Line 14: * Blocking operations:

Change in vdsm[master]: vm: extract migration completion check

2015-10-21 Thread mbetak
Martin Betak has posted comments on this change. Change subject: vm: extract migration completion check .. Patch Set 6: (2 comments) https://gerrit.ovirt.org/#/c/47086/6/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 2776:

Change in vdsm[master]: utils: Add @throttle decorator

2015-10-19 Thread mbetak
Martin Betak has posted comments on this change. Change subject: utils: Add @throttle decorator .. Patch Set 6: Verified+1 -- To view, visit https://gerrit.ovirt.org/47087 To unsubscribe, visit

Change in vdsm[master]: vm: extract migration completion check

2015-10-19 Thread mbetak
Martin Betak has posted comments on this change. Change subject: vm: extract migration completion check .. Patch Set 5: Verified+1 -- To view, visit https://gerrit.ovirt.org/47086 To unsubscribe, visit

Change in vdsm[master]: utils: Add @throttle decorator

2015-10-16 Thread mbetak
Martin Betak has posted comments on this change. Change subject: utils: Add @throttle decorator .. Patch Set 5: (2 comments) https://gerrit.ovirt.org/#/c/47087/5/tests/vmUtilsTests.py File tests/vmUtilsTests.py: Line 149:

Change in vdsm[master]: migration: Add retry logic for incoming limit

2015-10-16 Thread mbetak
Martin Betak has posted comments on this change. Change subject: migration: Add retry logic for incoming limit .. Patch Set 9: (1 comment) https://gerrit.ovirt.org/#/c/46971/9/vdsm/virt/migration.py File

Change in vdsm[master]: migration: Add incoming migration semaphore

2015-10-16 Thread mbetak
Martin Betak has posted comments on this change. Change subject: migration: Add incoming migration semaphore .. Patch Set 13: (1 comment) https://gerrit.ovirt.org/#/c/45954/13/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 2759:

Change in vdsm[master]: migration: Add migrateChangeGlobalParams verb

2015-10-16 Thread mbetak
Martin Betak has uploaded a new change for review. Change subject: migration: Add migrateChangeGlobalParams verb .. migration: Add migrateChangeGlobalParams verb Added new verb for setting values of incoming and outgoing

Change in vdsm[master]: utils: Add @throttle decorator

2015-10-15 Thread mbetak
Martin Betak has posted comments on this change. Change subject: utils: Add @throttle decorator .. Patch Set 4: (4 comments) https://gerrit.ovirt.org/#/c/47087/4/tests/vmUtilsTests.py File tests/vmUtilsTests.py: Line 180:

Change in vdsm[master]: vm: extract migration completion check

2015-10-15 Thread mbetak
Martin Betak has posted comments on this change. Change subject: vm: extract migration completion check .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/47086/3//COMMIT_MSG Commit Message: Line 6: Line 7: vm:

Change in vdsm[master]: vm: small cleanup of _completeIncomingMigration()

2015-10-14 Thread mbetak
Martin Betak has posted comments on this change. Change subject: vm: small cleanup of _completeIncomingMigration() .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/47086/1//COMMIT_MSG Commit Message: Line 3:

Change in vdsm[master]: vm: small cleanup of _completeIncomingMigration()

2015-10-14 Thread mbetak
Martin Betak has posted comments on this change. Change subject: vm: small cleanup of _completeIncomingMigration() .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/47086/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Line

Change in vdsm[master]: utils: Add @throttle decorator

2015-10-14 Thread mbetak
Martin Betak has posted comments on this change. Change subject: utils: Add @throttle decorator .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/47087/1/vdsm/virt/utils.py File vdsm/virt/utils.py: Line 128: Line

Change in vdsm[master]: utils: Add @throttle decorator

2015-10-14 Thread mbetak
Martin Betak has posted comments on this change. Change subject: utils: Add @throttle decorator .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/47087/1/vdsm/virt/utils.py File vdsm/virt/utils.py: Line 155:

Change in vdsm[master]: utils: Add @throttle decorator

2015-10-14 Thread mbetak
Martin Betak has posted comments on this change. Change subject: utils: Add @throttle decorator .. Patch Set 3: Verified+1 added tests -- To view, visit https://gerrit.ovirt.org/47087 To unsubscribe, visit

Change in vdsm[master]: vm: small cleanup of _completeIncomingMigration()

2015-10-07 Thread mbetak
Martin Betak has uploaded a new change for review. Change subject: vm: small cleanup of _completeIncomingMigration() .. vm: small cleanup of _completeIncomingMigration() Extracted the check for recovery completion into separate

Change in vdsm[master]: utils: Add @throttle decorator

2015-10-07 Thread mbetak
Martin Betak has uploaded a new change for review. Change subject: utils: Add @throttle decorator .. utils: Add @throttle decorator Added decorator for API methods that need to limit their maximum number of concurrent

Change in vdsm[master]: migration: Add incoming migration semaphore

2015-10-07 Thread mbetak
Martin Betak has posted comments on this change. Change subject: migration: Add incoming migration semaphore .. Patch Set 8: (4 comments) https://gerrit.ovirt.org/#/c/45954/8//COMMIT_MSG Commit Message: Line 7: migration:

Change in vdsm[master]: migration: Add incoming migration semaphore

2015-10-06 Thread mbetak
Martin Betak has posted comments on this change. Change subject: migration: Add incoming migration semaphore .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/45954/5/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 2752:

Change in vdsm[master]: migration: Add incoming migration semaphore

2015-10-05 Thread mbetak
Martin Betak has posted comments on this change. Change subject: migration: Add incoming migration semaphore .. Patch Set 3: (2 comments) https://gerrit.ovirt.org/#/c/45954/3/vdsm/virt/migration.py File

Change in vdsm[master]: migration: Add incoming migration semaphore

2015-10-05 Thread mbetak
Martin Betak has posted comments on this change. Change subject: migration: Add incoming migration semaphore .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/45954/3/lib/vdsm/utils.py File lib/vdsm/utils.py: Line

Change in vdsm[master]: migration: Add incoming migration semaphore

2015-10-05 Thread mbetak
Martin Betak has posted comments on this change. Change subject: migration: Add incoming migration semaphore .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/45954/3/vdsm/API.py File vdsm/API.py: Line 571:

Change in vdsm[master]: migration: Add incoming migration semaphore

2015-09-10 Thread mbetak
Martin Betak has posted comments on this change. Change subject: migration: Add incoming migration semaphore .. Patch Set 2: (3 comments) https://gerrit.ovirt.org/#/c/45954/2/lib/vdsm/utils.py File lib/vdsm/utils.py: Line

Change in vdsm[master]: tests: virt: move powerdown related tests away

2015-08-19 Thread mbetak
Martin Betak has posted comments on this change. Change subject: tests: virt: move powerdown related tests away .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/45064 To unsubscribe, visit

Change in vdsm[master]: hostdev: remove detection of device vmId

2015-03-20 Thread mbetak
Martin Betak has posted comments on this change. Change subject: hostdev: remove detection of device vmId .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38668 To unsubscribe, visit

Change in vdsm[master]: hostdev: report 'net' devices and their interface name

2015-01-28 Thread mbetak
Martin Betak has posted comments on this change. Change subject: hostdev: report 'net' devices and their interface name .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/35912 To unsubscribe, visit

Change in vdsm[master]: hostdev: make caps in listByCaps truly optional

2014-12-11 Thread mbetak
Martin Betak has posted comments on this change. Change subject: hostdev: make caps in listByCaps truly optional .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/35867 To unsubscribe, visit

Change in vdsm[master]: hostdev: make caps in listByCaps truly optional

2014-12-11 Thread mbetak
Martin Betak has posted comments on this change. Change subject: hostdev: make caps in listByCaps truly optional .. Patch Set 1: Tested with engine draft, without caps parameter. -- To view, visit

Change in vdsm[master]: hostdev: make caps in listByCaps truly optional

2014-12-04 Thread mbetak
Martin Betak has posted comments on this change. Change subject: hostdev: make caps in listByCaps truly optional .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/35867 To unsubscribe, visit

Change in vdsm[master]: vdsm: Add support for VIR_MIGRATE_COMPRESSED parameter

2014-10-15 Thread mbetak
Martin Betak has posted comments on this change. Change subject: vdsm: Add support for VIR_MIGRATE_COMPRESSED parameter .. Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/31992/5/vdsm/API.py File vdsm/API.py: Line 504:

Change in vdsm[master]: caps.py: Drop support for Fedora 19

2014-10-15 Thread mbetak
Martin Betak has uploaded a new change for review. Change subject: caps.py: Drop support for Fedora 19 .. caps.py: Drop support for Fedora 19 Change-Id: Ib1f89f3b8371b6d3f4ba8a4e17b454254213960d Signed-off-by: Martin Betak

Change in vdsm[master]: vdsm: Add support for VIR_MIGRATE_AUTO_CONVERGE parameter

2014-10-15 Thread mbetak
Martin Betak has posted comments on this change. Change subject: vdsm: Add support for VIR_MIGRATE_AUTO_CONVERGE parameter .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.ovirt.org/31991 To unsubscribe, visit

Change in vdsm[master]: caps.py: Drop support for Fedora 19

2014-10-15 Thread mbetak
Martin Betak has posted comments on this change. Change subject: caps.py: Drop support for Fedora 19 .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/34191 To unsubscribe, visit

Change in vdsm[master]: vdsm: Add support for VIR_MIGRATE_COMPRESSED parameter

2014-10-15 Thread mbetak
Martin Betak has posted comments on this change. Change subject: vdsm: Add support for VIR_MIGRATE_COMPRESSED parameter .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.ovirt.org/31992 To unsubscribe, visit

Change in vdsm[master]: vdsm: Add support for VIR_MIGRATE_AUTO_CONVERGE parameter

2014-10-09 Thread mbetak
Martin Betak has posted comments on this change. Change subject: vdsm: Add support for VIR_MIGRATE_AUTO_CONVERGE parameter .. Patch Set 5: Fixed debian packaging rebase issue and refactored the caps._getVersionInfo libvirt

Change in vdsm[master]: vdsm: Add support for VIR_MIGRATE_AUTO_CONVERGE parameter

2014-09-26 Thread mbetak
Martin Betak has posted comments on this change. Change subject: vdsm: Add support for VIR_MIGRATE_AUTO_CONVERGE parameter .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.ovirt.org/31991 To unsubscribe, visit

Change in vdsm[master]: vdsm: Add support for VIR_MIGRATE_COMPRESSED parameter

2014-09-26 Thread mbetak
Martin Betak has posted comments on this change. Change subject: vdsm: Add support for VIR_MIGRATE_COMPRESSED parameter .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.ovirt.org/31992 To unsubscribe, visit

Change in vdsm[master]: vdsm: Add support for VIR_MIGRATE_AUTO_CONVERGE parameter

2014-09-08 Thread mbetak
Martin Betak has posted comments on this change. Change subject: vdsm: Add support for VIR_MIGRATE_AUTO_CONVERGE parameter .. Patch Set 3: Modified specfile, set required version of libvirt to = 1.2.3 -- To view, visit

Change in vdsm[master]: vdsm: Add support for VIR_MIGRATE_AUTO_CONVERGE parameter

2014-08-26 Thread mbetak
Martin Betak has uploaded a new change for review. Change subject: vdsm: Add support for VIR_MIGRATE_AUTO_CONVERGE parameter .. vdsm: Add support for VIR_MIGRATE_AUTO_CONVERGE parameter Add support for configuring the

Change in vdsm[master]: vdsm: Add support for VIR_MIGRATE_COMPRESSED parameter

2014-08-26 Thread mbetak
Martin Betak has uploaded a new change for review. Change subject: vdsm: Add support for VIR_MIGRATE_COMPRESSED parameter .. vdsm: Add support for VIR_MIGRATE_COMPRESSED parameter Add support for configuring the

Change in vdsm[master]: vdsm: Add force and timeout options to VM.shutdown

2014-05-21 Thread mbetak
Martin Betak has posted comments on this change. Change subject: vdsm: Add force and timeout options to VM.shutdown .. Patch Set 6: (2 comments) http://gerrit.ovirt.org/#/c/27054/6//COMMIT_MSG Commit Message: Line 5:

Change in vdsm[master]: vdsm: Add force and timeout options to VM.shutdown

2014-05-21 Thread mbetak
Martin Betak has posted comments on this change. Change subject: vdsm: Add force and timeout options to VM.shutdown .. Patch Set 7: Verified+1 -- To view, visit http://gerrit.ovirt.org/27054 To unsubscribe, visit

Change in vdsm[master]: vdsm: Add force and timeout options to VM.shutdown

2014-05-21 Thread mbetak
Martin Betak has posted comments on this change. Change subject: vdsm: Add force and timeout options to VM.shutdown .. Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/27054/6//COMMIT_MSG Commit Message: Line 13:

Change in vdsm[master]: vdsm: Add force and timeout options to VM.shutdown

2014-05-14 Thread mbetak
Martin Betak has posted comments on this change. Change subject: vdsm: Add force and timeout options to VM.shutdown .. Patch Set 6: (2 comments) http://gerrit.ovirt.org/#/c/27054/6/vdsm/virt/vmpowerdown.py File

Change in vdsm[master]: vdsm: Add force and timeout options to VM.shutdown

2014-05-12 Thread mbetak
Martin Betak has posted comments on this change. Change subject: vdsm: Add force and timeout options to VM.shutdown .. Patch Set 4: (7 comments) http://gerrit.ovirt.org/#/c/27054/4/lib/vdsm/config.py.in File

Change in vdsm[master]: vdsm: Add force and timeout options to VM.shutdown

2014-05-12 Thread mbetak
Martin Betak has posted comments on this change. Change subject: vdsm: Add force and timeout options to VM.shutdown .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.ovirt.org/27054 To unsubscribe, visit

Change in vdsm[master]: vdsm: Add force and timeout options to VM.shutdown

2014-04-30 Thread mbetak
Martin Betak has posted comments on this change. Change subject: vdsm: Add force and timeout options to VM.shutdown .. Patch Set 3: -Verified -- To view, visit http://gerrit.ovirt.org/27054 To unsubscribe, visit

Change in vdsm[master]: vdsm: Add force and timeout options to VM.shutdown

2014-04-30 Thread mbetak
Martin Betak has posted comments on this change. Change subject: vdsm: Add force and timeout options to VM.shutdown .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.ovirt.org/27054 To unsubscribe, visit

Change in vdsm[master]: vdsm: Add force and timeout options to VM.shutdown

2014-04-29 Thread mbetak
Martin Betak has posted comments on this change. Change subject: vdsm: Add force and timeout options to VM.shutdown .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.ovirt.org/27054 To unsubscribe, visit

Change in vdsm[master]: vdsm: Add force and timeout options to VM.shutdown

2014-04-24 Thread mbetak
Martin Betak has uploaded a new change for review. Change subject: vdsm: Add force and timeout options to VM.shutdown .. vdsm: Add force and timeout options to VM.shutdown Added optional boolean parameters 'timeout' and 'force'

Change in vdsm[master]: vm: add boot menu support

2014-04-03 Thread mbetak
Martin Betak has posted comments on this change. Change subject: vm: add boot menu support .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/23558 To unsubscribe, visit http://gerrit.ovirt.org/settings

Change in vdsm[master]: vm: add boot menu support

2014-03-26 Thread mbetak
Martin Betak has posted comments on this change. Change subject: vm: add boot menu support .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/23558 To unsubscribe, visit http://gerrit.ovirt.org/settings

Change in vdsm[master]: vdsm: Add ACPI support for VM shutdown/reboot

2014-03-20 Thread mbetak
Martin Betak has posted comments on this change. Change subject: vdsm: Add ACPI support for VM shutdown/reboot .. Patch Set 6: (4 comments) http://gerrit.ovirt.org/#/c/23457/6/vdsm/vmCommands.py File vdsm/vmCommands.py: Line

Change in vdsm[master]: vdsm: Add ACPI support for VM shutdown/reboot

2014-03-10 Thread mbetak
Martin Betak has posted comments on this change. Change subject: vdsm: Add ACPI support for VM shutdown/reboot .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.ovirt.org/23457 To unsubscribe, visit

Change in vdsm[master]: vdsm: Add ACPI support for VM shutdown/reboot

2014-03-09 Thread mbetak
Martin Betak has posted comments on this change. Change subject: vdsm: Add ACPI support for VM shutdown/reboot .. Patch Set 4: (3 comments) http://gerrit.ovirt.org/#/c/23457/4//COMMIT_MSG Commit Message: Line 3: AuthorDate:

Change in vdsm[master]: vdsm: Add ACPI support for VM shutdown/reboot

2014-03-09 Thread mbetak
Martin Betak has posted comments on this change. Change subject: vdsm: Add ACPI support for VM shutdown/reboot .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.ovirt.org/23457 To unsubscribe, visit

Change in vdsm[master]: vdsm: Utilize CallbackChain in vm.shutdown

2014-03-05 Thread mbetak
Martin Betak has posted comments on this change. Change subject: vdsm: Utilize CallbackChain in vm.shutdown .. Patch Set 3: (6 comments) http://gerrit.ovirt.org/#/c/23457/3//COMMIT_MSG Commit Message: Line 5: CommitDate:

Change in vdsm[master]: vdsm: Utilize CallbackChain in vm.shutdown

2014-02-26 Thread mbetak
Martin Betak has posted comments on this change. Change subject: vdsm: Utilize CallbackChain in vm.shutdown .. Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/23457/3/vdsm/vm.py File vdsm/vm.py: Line 1891:

Change in vdsm[master]: vdsm: Enable config of VM serial number

2014-02-12 Thread mbetak
Martin Betak has posted comments on this change. Change subject: vdsm: Enable config of VM serial number .. Patch Set 2: The goal of this feature is to give user better control over the resulting serial number of the VM. At

Change in vdsm[master]: vdsm: Enable config of VM serial number

2014-02-12 Thread mbetak
Martin Betak has posted comments on this change. Change subject: vdsm: Enable config of VM serial number .. Patch Set 3: Verified+1 updated commit message -- To view, visit http://gerrit.ovirt.org/24274 To unsubscribe, visit

Change in vdsm[master]: vdsm: Enable config of VM serial number

2014-02-12 Thread mbetak
Martin Betak has posted comments on this change. Change subject: vdsm: Enable config of VM serial number .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.ovirt.org/24274 To unsubscribe, visit

Change in vdsm[master]: vdsm: Enable config of VM serial number

2014-02-10 Thread mbetak
Martin Betak has posted comments on this change. Change subject: vdsm: Enable config of VM serial number .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/24274 To unsubscribe, visit

Change in vdsm[master]: vdsm: Enable config of VM serial number

2014-02-10 Thread mbetak
Martin Betak has uploaded a new change for review. Change subject: vdsm: Enable config of VM serial number .. vdsm: Enable config of VM serial number Added support for passing explicit serial number as a part of vmParams from

Change in vdsm[master]: vdsm: Enable config of VM serial number

2014-02-10 Thread mbetak
Martin Betak has posted comments on this change. Change subject: vdsm: Enable config of VM serial number .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/24274 To unsubscribe, visit

Change in vdsm[master]: vdsm: Enable config of VM serial number

2014-02-10 Thread mbetak
Martin Betak has posted comments on this change. Change subject: vdsm: Enable config of VM serial number .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/24274/1/vdsm/vm.py File vdsm/vm.py: Line 1013: Line 1014:

Change in vdsm[master]: vdsm: Utilize CallbackChain in vm.shutdown

2014-01-30 Thread mbetak
Martin Betak has posted comments on this change. Change subject: vdsm: Utilize CallbackChain in vm.shutdown .. Patch Set 2: (5 comments) http://gerrit.ovirt.org/#/c/23457/2/vdsm/vm.py File vdsm/vm.py: Line 2617 Line 2618

Change in vdsm[master]: vdsm: Utilize CallbackChain in vm.shutdown

2014-01-27 Thread mbetak
Martin Betak has posted comments on this change. Change subject: vdsm: Utilize CallbackChain in vm.shutdown .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/23457 To unsubscribe, visit

Change in vdsm[master]: vdsm: Utilize CallbackChain in vm.shutdown

2014-01-20 Thread mbetak
Martin Betak has uploaded a new change for review. Change subject: vdsm: Utilize CallbackChain in vm.shutdown .. vdsm: Utilize CallbackChain in vm.shutdown Refactor the existing shutdown/reboot code to utilize the

Change in vdsm[master]: vdsm: Utilize CallbackChain in vm.shutdown

2014-01-20 Thread mbetak
Martin Betak has posted comments on this change. Change subject: vdsm: Utilize CallbackChain in vm.shutdown .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/23457 To unsubscribe, visit

Change in vdsm[master]: vdsm: Add support for Guest Reboot

2013-12-18 Thread mbetak
Martin Betak has posted comments on this change. Change subject: vdsm: Add support for Guest Reboot .. Patch Set 1: (3 comments) Commit Message Line 12: backwards

Change in vdsm[master]: vdsm: Add support for Guest Reboot

2013-12-18 Thread mbetak
Martin Betak has posted comments on this change. Change subject: vdsm: Add support for Guest Reboot .. Patch Set 1: (1 comment) File vdsm/vm.py Line 2546: except:

Change in vdsm[master]: vdsm: Add support for Guest Reboot

2013-12-18 Thread mbetak
Martin Betak has posted comments on this change. Change subject: vdsm: Add support for Guest Reboot .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/22440 To unsubscribe, visit

Change in vdsm[master]: vdsm: Reboot capability for VM

2013-12-16 Thread mbetak
Martin Betak has posted comments on this change. Change subject: vdsm: Reboot capability for VM .. Patch Set 39: Verified+1 -- To view, visit http://gerrit.ovirt.org/15829 To unsubscribe, visit

Change in vdsm[master]: vdsm: Reboot capability for VM

2013-12-16 Thread mbetak
Martin Betak has posted comments on this change. Change subject: vdsm: Reboot capability for VM .. Patch Set 37: (1 comment) File vdsm/vm.py Line 1729: self.timeout

Change in vdsm[master]: vdsm: Add support for Guest Reboot

2013-12-16 Thread mbetak
Martin Betak has uploaded a new change for review. Change subject: vdsm: Add support for Guest Reboot .. vdsm: Add support for Guest Reboot Added optional parameter reboot to shutdown in vdsm and vdsClient. This parameter

Change in vdsm[master]: vdsm: Reboot capability for VM

2013-12-16 Thread mbetak
Martin Betak has abandoned this change. Change subject: vdsm: Reboot capability for VM .. Abandoned Abandoned in favor of a more lightweight patch http://gerrit.ovirt.org/22440 adding only guest agent reboot support without

Change in vdsm[master]: vdsm: Add support for Guest Reboot

2013-12-16 Thread mbetak
Martin Betak has posted comments on this change. Change subject: vdsm: Add support for Guest Reboot .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/22440 To unsubscribe, visit

Change in vdsm[master]: vdsm: Fix potential leak in Vm.destroy()

2013-12-10 Thread mbetak
Martin Betak has abandoned this change. Change subject: vdsm: Fix potential leak in Vm.destroy() .. Abandoned -- To view, visit http://gerrit.ovirt.org/18337 To unsubscribe, visit http://gerrit.ovirt.org/settings

Change in vdsm[master]: vdsm: Reboot capability for VM

2013-12-10 Thread mbetak
Martin Betak has posted comments on this change. Change subject: vdsm: Reboot capability for VM .. Patch Set 37: (1 comment) File vdsm/vm.py Line 1764: # flag for

Change in vdsm[master]: vdsm: Reboot capability for VM

2013-12-09 Thread mbetak
Martin Betak has posted comments on this change. Change subject: vdsm: Reboot capability for VM .. Patch Set 37: (6 comments) File vdsm/vm.py Line 1729:

Change in vdsm[master]: vdsm: Reboot capability for VM

2013-12-09 Thread mbetak
Martin Betak has posted comments on this change. Change subject: vdsm: Reboot capability for VM .. Patch Set 38: Verified+1 -- To view, visit http://gerrit.ovirt.org/15829 To unsubscribe, visit

Change in vdsm[master]: vdsm: Reboot capability for VM

2013-12-03 Thread mbetak
Martin Betak has posted comments on this change. Change subject: vdsm: Reboot capability for VM .. Patch Set 37: Verified+1 -- To view, visit http://gerrit.ovirt.org/15829 To unsubscribe, visit

Change in vdsm[master]: vdsm: Reboot capability for VM

2013-12-03 Thread mbetak
Martin Betak has posted comments on this change. Change subject: vdsm: Reboot capability for VM .. Patch Set 35: (1 comment) File vdsm/vm.py Line 1790:

Change in vdsm[master]: vdsm: Reboot capability for VM

2013-12-02 Thread mbetak
Martin Betak has posted comments on this change. Change subject: vdsm: Reboot capability for VM .. Patch Set 35: (2 comments) File client/vdsClient.py Line 1922:

<    1   2   3   >