Michal Skrivanek has posted comments on this change.
Change subject: vm: Automatically add a serial port for a console device
..
Patch Set 5: Code-Review+1
deserves a bug, I'd like to see this in 3.4.z too
--
To view,
Michal Skrivanek has posted comments on this change.
Change subject: agent: Only forward desktopLogin when the agent is responsive
..
Patch Set 1: Code-Review+1
(1 comment)
+1, but enhance the commit message indeed
http
Michal Skrivanek has posted comments on this change.
Change subject: virt: graphdev: support multiple graphics devices
..
Patch Set 16: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/27215
To unsubscribe, visit http
Michal Skrivanek has posted comments on this change.
Change subject: virt: stats: get rid of _getStatsInternal
..
Patch Set 6: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26557
To unsubscribe, visit http
Michal Skrivanek has posted comments on this change.
Change subject: vm: simplify the releaseVm flow
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/27175
To unsubscribe, visit http://gerrit.ovirt.org
Michal Skrivanek has posted comments on this change.
Change subject: virt: graphdev: add the GraphicsDevice class
..
Patch Set 19:
(1 comment)
http://gerrit.ovirt.org/#/c/26895/19/vdsm/API.py
File vdsm/API.py:
Line 206
Michal Skrivanek has posted comments on this change.
Change subject: virt: graphdev: support multiple graphics devices
..
Patch Set 13:
(1 comment)
http://gerrit.ovirt.org/#/c/27215/13/vdsm/virt/vm.py
File vdsm/virt/vm.py
Michal Skrivanek has posted comments on this change.
Change subject: virt: graphdev: add the GraphicsDevice class
..
Patch Set 19:
(1 comment)
http://gerrit.ovirt.org/#/c/26895/19/vdsm/virt/migration.py
File vdsm/virt
Michal Skrivanek has posted comments on this change.
Change subject: virt: stats: explicitily handle not enough samples
..
Patch Set 6: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26791
To unsubscribe, visit http
Michal Skrivanek has posted comments on this change.
Change subject: virt: stats: return empty dict when stats disabled
..
Patch Set 6: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26790
To unsubscribe, visit http
Michal Skrivanek has posted comments on this change.
Change subject: vm: Fix guest channel symlink creation handling
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26882
To unsubscribe, visit http
Michal Skrivanek has posted comments on this change.
Change subject: agent: Add new command setNumberOfCPUs(count)
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26531
To unsubscribe, visit http
Michal Skrivanek has posted comments on this change.
Change subject: vm: consider 'action' when handling I/O errors
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/27016
To unsubscribe,
Michal Skrivanek has posted comments on this change.
Change subject: tests: initial tests for vm libvirt callbacks
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/27128
To unsubscribe, visit http
Michal Skrivanek has posted comments on this change.
Change subject: tests: initial tests for vm libvirt callbacks
..
Patch Set 1:
while we're at it, a test for "else" clause in onIOError would be nice as we
Michal Skrivanek has posted comments on this change.
Change subject: virt: Capture migration start time after the semaphore was
accquired
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/27135
To
Michal Skrivanek has posted comments on this change.
Change subject: recovery: try to restore VMs from recovery files
..
Patch Set 10:
based on my very limited backend understanding I ended up with the same concern.
Arik/Omer
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: add support for hostdev passthrough
..
Patch Set 7:
(2 comments)
ok with the concept
http://gerrit.ovirt.org/#/c/22462/7/tests/functional
Michal Skrivanek has posted comments on this change.
Change subject: schema: graphdev: document the new graphics device
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/26893/3/vdsm_api/vdsmapi-schema.json
File
Michal Skrivanek has posted comments on this change.
Change subject: virt: graphdev: handle ticket for multiple devices
..
Patch Set 5: Code-Review+1
(1 comment)
http://gerrit.ovirt.org/#/c/26897/5/vdsm/virt/vm.py
File vdsm
Michal Skrivanek has posted comments on this change.
Change subject: virt: graphdev: introduce the GraphicsDevice class
..
Patch Set 3: Code-Review+1
(1 comment)
http://gerrit.ovirt.org/#/c/26894/3/vdsm/virt/vm.py
File vdsm
Michal Skrivanek has posted comments on this change.
Change subject: schema: graphdev: document the new graphics device
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26893
To unsubscribe, visit http
Michal Skrivanek has posted comments on this change.
Change subject: vm: Fix guest channel symlink creation handling
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/26882/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line
Michal Skrivanek has posted comments on this change.
Change subject: net_tests: Move network unit tests into package
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/26874/1/tests/run_tests_local.sh.in
File tests
Michal Skrivanek has posted comments on this change.
Change subject: vm: fix _dom access when QEMU is dying
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/26539/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 4323
Michal Skrivanek has posted comments on this change.
Change subject: vm: fix _dom access when QEMU is dying
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26539
To unsubscribe, visit http
Michal Skrivanek has posted comments on this change.
Change subject: agent: number-of-cpus reporting support
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26530
To unsubscribe, visit http
Michal Skrivanek has posted comments on this change.
Change subject: tests: virt: retry to connect to VDSM at startup
..
Patch Set 2: Code-Review+1
(2 comments)
http://gerrit.ovirt.org/#/c/26638/2/tests/functional/utils.py
Michal Skrivanek has posted comments on this change.
Change subject: recovery: try to restore VMs from recovery files
..
Patch Set 9:
(3 comments)
http://gerrit.ovirt.org/#/c/25276/9/tests/functional/virtTests.py
File tests
Michal Skrivanek has posted comments on this change.
Change subject: hook: spiceoptions: To provide spice option attributes to vm
..
Patch Set 10: Code-Review+1
thx for adding the playback as well
--
To view, visit http
Michal Skrivanek has posted comments on this change.
Change subject: Refactor VM._guestSockCleanup into utils.rmFileAndLink
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/26479/3//COMMIT_MSG
Commit Message:
Line 3
Michal Skrivanek has posted comments on this change.
Change subject: Refactor VM._guestSockCleanup into utils.rmFileAndLink
..
Patch Set 3:
(2 comments)
http://gerrit.ovirt.org/#/c/26479/3/lib/vdsm/utils.py
File lib/vdsm
Michal Skrivanek has posted comments on this change.
Change subject: always teardown snapshot's memory volume
..
Patch Set 1:
(2 comments)
http://gerrit.ovirt.org/#/c/26544/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line
Michal Skrivanek has posted comments on this change.
Change subject: hook: spiceoptions: To provide spice option attributes to vm
..
Patch Set 9: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/22178
To unsubscribe
Michal Skrivanek has posted comments on this change.
Change subject: do not use OOP for padding snapshot's memory volume
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/26538/1//COMMIT_MSG
Commit Message:
L
Michal Skrivanek has posted comments on this change.
Change subject: do not use OOP for padding snapshot's memory volume
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/26538/1//COMMIT_MSG
Commit Message:
L
Michal Skrivanek has posted comments on this change.
Change subject: vm: fix _dom access when QEMU is dying
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26539
To unsubscribe, visit http
Michal Skrivanek has posted comments on this change.
Change subject: pad memory volume only when the storage domain is file based
..
Patch Set 3: -Code-Review
(1 comment)
http://gerrit.ovirt.org/#/c/26407/3/vdsm/virt/vm.py
Michal Skrivanek has posted comments on this change.
Change subject: vm: report exit reason for migration failed
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/25164/2/vdsm/vm.py
File vdsm/vm.py:
Line 2337
Michal Skrivanek has posted comments on this change.
Change subject: vm: avoid to reply with half-baked statistics
..
Patch Set 5:
(2 comments)
http://gerrit.ovirt.org/#/c/25803/5/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line
Michal Skrivanek has posted comments on this change.
Change subject: virt: Move all guest agents related cleanup together
..
Patch Set 1: Code-Review-1
(keeping -1 till we decide if we want to swallow all errors on cleanup or
Michal Skrivanek has posted comments on this change.
Change subject: virt: Move all guest agents related cleanup together
..
Patch Set 1: -Code-Review
(1 comment)
http://gerrit.ovirt.org/#/c/26280/1/vdsm/virt/vm.py
File vdsm
Michal Skrivanek has posted comments on this change.
Change subject: hook: spiceoptions: To provide spice option attributes to vm
..
Patch Set 7:
not sure if "playback" is useful, but it's missing from the lis
Michal Skrivanek has posted comments on this change.
Change subject: vm: consider 'action' when handling I/O errors
..
Patch Set 1: Code-Review+1
Yaniv, per process the bug status is correct. The bug is 3.4. It j
Michal Skrivanek has posted comments on this change.
Change subject: recovery: try to restore VMs from recovery files
..
Patch Set 6:
(2 comments)
http://gerrit.ovirt.org/#/c/25276/6/vdsm/clientIF.py
File vdsm/clientIF.py
Michal Skrivanek has posted comments on this change.
Change subject: pad memory volume only when the storage domain is file based
..
Patch Set 2: Code-Review+1
(1 comment)
http://gerrit.ovirt.org/#/c/26407/2//COMMIT_MSG
Michal Skrivanek has posted comments on this change.
Change subject: virt: Move all guest agents related cleanup together
..
Patch Set 1: Code-Review-1
(1 comment)
if I'm not missing anything - I think it shou
Michal Skrivanek has posted comments on this change.
Change subject: virt: Move all guest agents related cleanup together
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/26280/1/vdsm/virt/vm.py
File vdsm/virt/vm.py
Michal Skrivanek has posted comments on this change.
Change subject: vm: add boot menu support
..
Patch Set 4: Code-Review+1
it's not always good to trust them:-) Thanks for the extra verification!
--
To view, visit
Michal Skrivanek has posted comments on this change.
Change subject: vm: add boot menu support
..
Patch Set 4:
Did you actually see the menu?:)
--
To view, visit http://gerrit.ovirt.org/23558
To unsubscribe, visit http
Michal Skrivanek has posted comments on this change.
Change subject: vm: report exit reason for migration failed
..
Patch Set 2: Code-Review+1
(1 comment)
http://gerrit.ovirt.org/#/c/25164/2/vdsm/vm.py
File vdsm/vm.py:
Line
Michal Skrivanek has posted comments on this change.
Change subject: caps: Collect numa information
..
Patch Set 8:
(1 comment)
http://gerrit.ovirt.org/#/c/23703/8/vdsm/caps.py
File vdsm/caps.py:
Line 165:
Line 166:
Line
Michal Skrivanek has posted comments on this change.
Change subject: virt: Remove all guest sockets on cleanup
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26288
To unsubscribe, visit http
Michal Skrivanek has posted comments on this change.
Change subject: virt: Remove all guest sockets on cleanup
..
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.ovirt.org/#/c/26278/1/vdsm/virt/vm.py
File vdsm/virt/vm.py
Michal Skrivanek has posted comments on this change.
Change subject: vm: avoid to reply with half-baked statistics
..
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/25803/4/vdsm/vm.py
File vdsm/vm.py:
Line 2815
Michal Skrivanek has posted comments on this change.
Change subject: vm: avoid to reply with half-baked statistics
..
Patch Set 3:
(3 comments)
not sure about the partial stats
otherwise looks good
http://gerrit.ovirt.org
Michal Skrivanek has posted comments on this change.
Change subject: caps: report if QEMU supports live snapshots
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/26149/1/vdsm/caps.py
File vdsm/caps.py:
Line 181
Michal Skrivanek has posted comments on this change.
Change subject: vm: Automatically add a serial port for a console device
..
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/25979/4/vdsm/vm.py
File vdsm/vm.py:
Line
Michal Skrivanek has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
..
Patch Set 13:
(2 comments)
http://gerrit.ovirt.org/#/c/17694/13/vdsm/vm.py
File vdsm/vm.py:
Line 3105
Michal Skrivanek has posted comments on this change.
Change subject: vm: migration: exponential downtime increment
..
Patch Set 1:
I wonder if we can factor in the convergence/progress of the migration as well.
E.g. for a
Michal Skrivanek has posted comments on this change.
Change subject: vm: consider 'action' when handling I/O errors
..
Patch Set 4: Code-Review+1
It's an error in log, IMO it looks good
--
To v
Michal Skrivanek has posted comments on this change.
Change subject: vm: consider 'action' when handling I/O errors
..
Patch Set 2: Code-Review+1
(1 comment)
http://gerrit.ovirt.org/#/c/25157/2/vdsm/vm.py
File
Michal Skrivanek has posted comments on this change.
Change subject: vm: consider 'action' when handling I/O errors
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/25157/1/vdsm/clientIF.py
File vdsm/clientIF
Michal Skrivanek has posted comments on this change.
Change subject: vm: consider 'action' when handling I/O errors
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/25157/1/vdsm/clientIF.py
File vdsm/clientIF
Michal Skrivanek has posted comments on this change.
Change subject: vm: fix migration progress calculation
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/25038
To unsubscribe, visit http
Michal Skrivanek has posted comments on this change.
Change subject: vm: report migration progress in VmStats
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/24465/3/vdsm/vm.py
File vdsm/vm.py:
Line 140
Michal Skrivanek has posted comments on this change.
Change subject: vm: report migration progress in VmStats
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/24465
To unsubscribe, visit http
Michal Skrivanek has posted comments on this change.
Change subject: vm: ensure finish recover with libvirt connection
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/24423/3/vdsm/vm.py
File vdsm/vm.py:
Line 2306
Michal Skrivanek has posted comments on this change.
Change subject: vm: report migration progress in VmStats
..
Patch Set 2: Code-Review-1
(2 comments)
http://gerrit.ovirt.org/#/c/24465/2/vdsm/vm.py
File vdsm/vm.py:
Line
Michal Skrivanek has posted comments on this change.
Change subject: vm: do not go Up if _dom is None
..
Patch Set 2:
(2 comments)
http://gerrit.ovirt.org/#/c/24423/2//COMMIT_MSG
Commit Message:
Line 25: cannot
"nor w
Michal Skrivanek has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 6:
(1 comment)
http://gerrit.ovirt.org/#/c/22928/6/vdsm/clientIF.py
File vdsm/clientIF.py:
Line
Michal Skrivanek has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 6:
(1 comment)
http://gerrit.ovirt.org/#/c/22928/6/vdsm/clientIF.py
File vdsm/clientIF.py:
Line
Michal Skrivanek has posted comments on this change.
Change subject: stats: report detailed VM down status
..
Patch Set 7:
(1 comment)
http://gerrit.ovirt.org/#/c/22631/7/vdsm_api/vdsmapi-schema.json
File vdsm_api/vdsmapi
Michal Skrivanek has posted comments on this change.
Change subject: tests: validate cdrom path sent to/received from vdsm
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/22194/2/tests/functional/virtTests.py
File
Michal Skrivanek has posted comments on this change.
Change subject: vmDevices: add __slots__ to devices
..
Patch Set 5: Code-Review+1
(1 comment)
http://gerrit.ovirt.org/#/c/21036/5//COMMIT_MSG
Commit Message:
Line 8:
Line
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: add support for S3/S4 suspend calls
..
Patch Set 5: -Code-Review
(1 comment)
http://gerrit.ovirt.org/#/c/19389/5/vdsm/API.py
File vdsm/API.py:
Line
Michal Skrivanek has posted comments on this change.
Change subject: tests: fix possible test failure due to reboot event
..
Patch Set 1: Code-Review+1
ok, add this to jenkins finally?:)
--
To view, visit http
Michal Skrivanek has posted comments on this change.
Change subject: caps: report malfunctioning libvirt
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/23628
To unsubscribe, visit http
Michal Skrivanek has posted comments on this change.
Change subject: vm: per-attribute monitor response check
..
Patch Set 4:
I was wondering how/why is it happening when the _timeoutExperienced flow is
only relevant for 3
Michal Skrivanek has posted comments on this change.
Change subject: guest: Add support for guest cpu topology
..
Patch Set 8:
(1 comment)
http://gerrit.ovirt.org/#/c/23258/8/vdsm/guestIF.py
File vdsm/guestIF.py:
Line 214
Michal Skrivanek has posted comments on this change.
Change subject: vm: per-attribute monitor response check
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/23138
To unsubscribe, visit http
Michal Skrivanek has posted comments on this change.
Change subject: caps: vm: check abort on EIO in libvirt
..
Patch Set 1:
question is if removing 3.4 compatibility is not an overkill…but going forward
with 3.4 I think it&#
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: fix RTC offset
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/14750/3/vdsm/vm.py
File vdsm/vm.py:
Line 1813: self
Michal Skrivanek has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 27: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21789
To unsubscribe, visit http
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: Adding guest agent API versioning support
..
Patch Set 3: Code-Review+1
(1 comment)
http://gerrit.ovirt.org/#/c/17004/3/vdsm/guestIF.py
File vdsm
Michal Skrivanek has posted comments on this change.
Change subject: nestedvt hook: identify kvm_amd properly
..
Patch Set 3: Verified+1 Code-Review+1
Verified by Sander Grendelman
--
To view, visit http://gerrit.ovirt.org
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: fix RTC offset
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/14750
To unsubscribe, visit http://gerrit.ovirt.org/settings
Michal Skrivanek has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 19:
(1 comment)
File vdsm/vm.py
Line 895
Michal Skrivanek has posted comments on this change.
Change subject: utils.py: Add hostUUID retrieval support for KVM on PPC64
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/8637
To unsubscribe, visit
Michal Skrivanek has posted comments on this change.
Change subject: [RFE] set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 18:
(1 comment)
File vdsm/hooks.py
Michal Skrivanek has posted comments on this change.
Change subject: Rename migration_timeout to migration_downtime_delay
..
Patch Set 13: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/22421
To unsubscribe, visit
Michal Skrivanek has posted comments on this change.
Change subject: Rename migration_timeout to migration_downtime_delay
..
Patch Set 12:
(1 comment)
File vdsm/vm.py
Line
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: Adding guest agent API versioning support
..
Patch Set 2:
(3 comments)
File vdsm/guestIF.py
Line
Michal Skrivanek has posted comments on this change.
Change subject: [WIP]add simple balloon functional testcase
..
Patch Set 2:
(1 comment)
File tests/functional
Michal Skrivanek has posted comments on this change.
Change subject: [RFE] set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 15:
(1 comment)
File vdsm/vm.py
Line
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: Create VMs for the POWER architecture
..
Patch Set 10: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/18718
To unsubscribe, visit http
Michal Skrivanek has posted comments on this change.
Change subject: clientIF: Remove unnecessary device is disk check in
prepareVolumePath
..
Patch Set 2:
(1 comment
Michal Skrivanek has posted comments on this change.
Change subject: clientIF: Remove unnecessary device is disk check in
prepareVolumePath
..
Patch Set 2:
(1 comment
Michal Skrivanek has posted comments on this change.
Change subject: vm: Unify checks for vdsm image
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/22370
To unsubscribe, visit http://gerrit.ovirt.org
Michal Skrivanek has posted comments on this change.
Change subject: clientIF: Remove unnecessary device is disk check in
prepareVolumePath
..
Patch Set 2:
(1 comment
501 - 600 of 823 matches
Mail list logo
