Roy Golan has posted comments on this change.
Change subject: storage: add more info to NFS SD getInfo
..
Patch Set 1:
(1 comment)
- can this reveal secure info of some sort?
- Thinking on the client side, the engine should
Roy Golan has posted comments on this change.
Change subject: api: unexpected response when a verb returns nothing
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/59469/1/lib/yajsonrpc/__init__.py
File
Roy Golan has posted comments on this change.
Change subject: storageServer: Normalize local path before escaping
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/52873
To unsubscribe, visit
Roy Golan has posted comments on this change.
Change subject: sp: Allow attaching of monitored domain
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/49597
To unsubscribe, visit
Roy Golan has posted comments on this change.
Change subject: hsm: Prevent stop monitoring of a pool domain
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/49598
To unsubscribe, visit
Roy Golan has posted comments on this change.
Change subject: monitor: Do not release host id during shutdown
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/49596
To unsubscribe, visit
Roy Golan has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 13: Code-Review+1
Later we would need to adapt engine scheduling to consider online cpus - And
Roy Golan has posted comments on this change.
Change subject: monitor: Do not release host id during shutdown
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/49386
To unsubscribe, visit
Roy Golan has posted comments on this change.
Change subject: sp: Allow attaching of monitored domain
..
Patch Set 3: Verified+1
Seems to work correctly. Even saw the log messages
[root@bear noarch]# grep "Monitor for"
Roy Golan has posted comments on this change.
Change subject: sp: Allow attaching of monitored domain
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/48217/2/vdsm/storage/monitor.py
File vdsm/storage/monitor.py:
Roy Golan has posted comments on this change.
Change subject: sp: Allow attaching hosted engine sd
..
Patch Set 1:
Nir I didn't understand our comment.
--
To view, visit https://gerrit.ovirt.org/48217
To unsubscribe, visit
Roy Golan has posted comments on this change.
Change subject: sp: Allow attaching hosted engine sd
..
Patch Set 1:
Nir pending your comments.
--
To view, visit https://gerrit.ovirt.org/48217
To unsubscribe, visit
Roy Golan has posted comments on this change.
Change subject: sp: Allow attaching hosted engine sd
..
Patch Set 1:
getting the logs. will post them on the bz
--
To view, visit https://gerrit.ovirt.org/48217
To unsubscribe,
Roy Golan has posted comments on this change.
Change subject: sp: Allow attaching hosted engine sd
..
Patch Set 1:
First, we need a fix asap and the refcount patch doesn't look like its going to
be merged soon enough.
I'm
Roy Golan has posted comments on this change.
Change subject: sp: Allow attaching hosted engine sd
..
Patch Set 1:
Sanlock sees qemu pid is using a path on one of its a resource(the sd) and when
it needs to remove the
Roy Golan has posted comments on this change.
Change subject: sp: Allow attaching hosted engine sd
..
Patch Set 1: Verified+1
(1 comment)
Working as expected. The domain is imported and attached while
the VM is running and
Roy Golan has posted comments on this change.
Change subject: hsm: Report vg name in getDeviceList
..
Patch Set 3: Code-Review+1
I currently crossmatch using sd id and try to match the lun. The vg_name will
greatly simplify
Roy Golan has posted comments on this change.
Change subject: sampling: Handle numa nodes with zero memory assigned
..
Patch Set 2:
this patch is missing vdsm maintainers. Don't forget to add them
--
To view, visit
Roy Golan has posted comments on this change.
Change subject: sampling: Handle numa nodes with zero memory assigned
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/44121
To unsubscribe, visit
Roy Golan has posted comments on this change.
Change subject: Balloon should not work when guest agent is not present
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/42968
To unsubscribe, visit
Roy Golan has posted comments on this change.
Change subject: vdsm: implement NUMA aware KSM policy
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/40129/6/vdsm/supervdsmServer
File vdsm/supervdsmServer:
Line 319:
Roy Golan has posted comments on this change.
Change subject: Fix the CPU quota MOM policy computations
..
Patch Set 1:
this is merged upstream. can you guys review?
--
To view, visit https://gerrit.ovirt.org/40311
To
Roy Golan has posted comments on this change.
Change subject: vdsm: implement NUMA aware KSM policy
..
Patch Set 3:
@Max is the -1 still relevant?
--
To view, visit https://gerrit.ovirt.org/40129
To unsubscribe, visit
Roy Golan has posted comments on this change.
Change subject: Fix the CPU quota MOM policy computations
..
Patch Set 8:
(3 comments)
https://gerrit.ovirt.org/#/c/39411/8/tests/momPolicyTests.py
File tests/momPolicyTests.py:
Roy Golan has posted comments on this change.
Change subject: Fix the CPU quota MOM policy computations
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/39411/8/tests/momPolicyTests.py
File tests/momPolicyTests.py:
Roy Golan has uploaded a new change for review.
Change subject: mom.d: make CpuTuneEnabled True by default
..
mom.d: make CpuTuneEnabled True by default
we should ship vdsm with that policy enabled otherwise cpu tuning isn't
Roy Golan has uploaded a new change for review.
Change subject: mom.d: make CpuTuneEnabled True by default
..
mom.d: make CpuTuneEnabled True by default
we should ship vdsm with that policy enabled otherwise cpu tuning isn't
Roy Golan has abandoned this change.
Change subject: mom.d: make CpuTuneEnabled True by default
..
Abandoned
--
To view, visit http://gerrit.ovirt.org/36026
To unsubscribe, visit http://gerrit.ovirt.org/settings
Roy Golan has posted comments on this change.
Change subject: mom.d: make CpuTuneEnabled True by default
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/36027
To unsubscribe, visit
Roy Golan has uploaded a new change for review.
Change subject: mom.d: make CpuTuneEnabled True by default
..
mom.d: make CpuTuneEnabled True by default
we should ship vdsm with that policy enabled otherwise cpu tuning isn't
Roy Golan has posted comments on this change.
Change subject: mom.d: make CpuTuneEnabled True by default
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/35330
To unsubscribe, visit
Roy Golan has posted comments on this change.
Change subject: API: fix broken updateVmPolicy for jsonrpc
..
Patch Set 1:
will fix the unit test
--
To view, visit http://gerrit.ovirt.org/35236
To unsubscribe, visit
Roy Golan has posted comments on this change.
Change subject: API: fix broken updateVmPolicy for jsonrpc
..
Patch Set 1:
(1 comment)
@Gilad @Martin - pleaes review the updated signature of updateVmPolicy
Roy Golan has abandoned this change.
Change subject: API: fix broken updateVmPolicy for jsonrpc
..
Abandoned
merged already upstream
--
To view, visit http://gerrit.ovirt.org/35236
To unsubscribe, visit
Roy Golan has uploaded a new change for review.
Change subject: API: fix broken updateVmPolicy for jsonrpc
..
API: fix broken updateVmPolicy for jsonrpc
the schema had a wrong mapping of the above verb.
the argument for that
Roy Golan has posted comments on this change.
Change subject: utils: Add changehash function for change detection
..
Patch Set 1:
engine checks if the string has changed. agnostic to how it is generated of
course
--
To
Roy Golan has posted comments on this change.
Change subject: setNumberOfCpus marshalling issue
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/32414
To unsubscribe, visit
Roy Golan has posted comments on this change.
Change subject: setNumberOfCpus marshalling issue
..
Patch Set 1: Code-Review-1
you need to fix client/vdsClient.py as well
--
To view, visit http://gerrit.ovirt.org/32414
To
Roy Golan has posted comments on this change.
Change subject: setNumberOfCpus marshalling issue
..
Patch Set 1: Code-Review+1
correct - I forgot vdsClient uses XMLRPC binding.
--
To view, visit http://gerrit.ovirt.org/32414
Roy Golan has abandoned this change.
Change subject: refine calculation of cpu topology
..
Abandoned
moving the calculation of maxVCpus to backend
--
To view, visit http://gerrit.ovirt.org/30896
To unsubscribe, visit
Roy Golan has abandoned this change.
Change subject: refine calculation of cpu topology
..
Abandoned
moving the calculation of maxVCpus to backend
--
To view, visit http://gerrit.ovirt.org/31032
To unsubscribe, visit
Roy Golan has posted comments on this change.
Change subject: refine calculation of cpu topology
..
Patch Set 8:
(1 comment)
a
http://gerrit.ovirt.org/#/c/30896/8/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:
Line 422:
Roy Golan has posted comments on this change.
Change subject: refine calculation of cpu topology
..
Patch Set 9:
(1 comment)
http://gerrit.ovirt.org/#/c/30896/9/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi-schema.json:
Roy Golan has posted comments on this change.
Change subject: refine calculation of cpu topology
..
Patch Set 12: Verified+1
--
To view, visit http://gerrit.ovirt.org/30896
To unsubscribe, visit
Roy Golan has uploaded a new change for review.
Change subject: refine calculation of cpu topology
..
refine calculation of cpu topology
engine sends along with createInfo the following:
smp // VM.numOfCpus
Roy Golan has posted comments on this change.
Change subject: refine calculation of cpu topology
..
Patch Set 3:
(4 comments)
http://gerrit.ovirt.org/#/c/30896/3/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:
Line 95:
Line 96:
Roy Golan has posted comments on this change.
Change subject: Fix xml maximum vcpus for odd number of vCores
..
Patch Set 2:
the fix should still be VDSM's and a small engine addition:
engine sends along with createInfo the
Roy Golan has uploaded a new change for review.
Change subject: refine calculation of cpu topology
..
refine calculation of cpu topology
engine sends along with createInfo the following:
smp // VM.numOfCpus
Roy Golan has posted comments on this change.
Change subject: Fix xml maximum vcpus for odd number of vCores
..
Patch Set 1: Code-Review+1
thanks amador
--
To view, visit http://gerrit.ovirt.org/30594
To unsubscribe, visit
Roy Golan has posted comments on this change.
Change subject: vm: add optimizations for hyperv
..
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.ovirt.org/#/c/27619/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 671:
Roy Golan has posted comments on this change.
Change subject: agent: Add new command setNumberOfCPUs(count)
..
Patch Set 4:
hot plug as well as unplug, no?
--
To view, visit http://gerrit.ovirt.org/26531
To unsubscribe,
Roy Golan has posted comments on this change.
Change subject: vm: avoid to reply with half-baked statistics
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/25803/2/vdsm/API.py
File vdsm/API.py:
Line 362: if
Roy Golan has posted comments on this change.
Change subject: guest: Add support for guest cpu topology
..
Patch Set 8:
(1 comment)
http://gerrit.ovirt.org/#/c/23258/8/vdsm/guestIF.py
File vdsm/guestIF.py:
Line 301:
Roy Golan has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 26:
(4 comments)
http://gerrit.ovirt.org/#/c/21789/26//COMMIT_MSG
Commit Message:
Line 39:
Line 40:
Roy Golan has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 27:
* addressed comments
* added an update to the vm container to reflect changes when migrating etc
--
Roy Golan has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 27: Verified+1
--
To view, visit http://gerrit.ovirt.org/21789
To unsubscribe, visit
Roy Golan has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 25: Verified+1
--
To view, visit http://gerrit.ovirt.org/21789
To unsubscribe, visit
Roy Golan has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 26: Verified-1
I think I missed updating the vmcontainer.
--
To view, visit
Roy Golan has posted comments on this change.
Change subject: [RFE] set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 18:
(4 comments)
File vdsm/vm.py
Line 898:
Roy Golan has posted comments on this change.
Change subject: [RFE] set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 17:
addressed most of the comments
--
To view, visit http://gerrit.ovirt.org/21789
To
Roy Golan has posted comments on this change.
Change subject: [RFE] set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 15:
(12 comments)
Commit Message
Line 4:
Roy Golan has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 14:
hook supported isn't verified
--
To view, visit http://gerrit.ovirt.org/21789
To unsubscribe, visit
Roy Golan has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 13:
* reverted the use of EqualsMultiLine which doesn't exist in the 2.6
* following Edu's comments on
Roy Golan has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 10:
* test wasn't fixed yet
--
To view, visit http://gerrit.ovirt.org/21789
To unsubscribe, visit
Roy Golan has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 11:
(2 comments)
File tests/vmTests.py
Line 45:
Roy Golan has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 12:
no change just a rebase. on my side all the tests run OK
when I make rpm.
--
To view, visit
Roy Golan has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 7:
the libvirt xml is changed now to allow adding more cpus
this means we have a topology element and a
Roy Golan has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 7: Verified+1
Verified
* the vm is up and running with 2 cpus
* can call setVcpus
Not verified
* the
Roy Golan has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 2:
(5 comments)
File client/vdsClient.py
Line 245:
Roy Golan has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 3:
* addressed comments
* rename the new vdsClient verb to plural: setNumberOfCpu - setNumberOfCpus
--
Roy Golan has uploaded a new change for review.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
set the # of vcpus for a VM (hot plug/unplug)
RFE https://bugzilla.redhat.com/show_bug.cgi?id=833102
Change-Id:
Roy Golan has posted comments on this change.
Change subject: vdsm: report migration status in migrateStatuses()
..
Patch Set 7:
(1 comment)
File
Roy Golan has posted comments on this change.
Change subject: Catch libvirt timeout and return an error on setVmTicket
..
Patch Set 12: Verified
--
To view, visit http://gerrit.ovirt.org/10285
To unsubscribe, visit
Roy Golan has posted comments on this change.
Change subject: vdsm: Ignore after_vm_cont hook if _dom was not yet created
..
Patch Set 1:
+1 on raising event when _dom is ready
--
To view, visit http://gerrit.ovirt.org/12558
Roy Golan has posted comments on this change.
Change subject: Catch libvirt timeout and return an error on setVmTicket
..
Patch Set 6: (1 inline comment)
File
Roy Golan has abandoned this change.
Change subject: api-schema: adding expection to err objects
..
Patch Set 1: Abandoned
adding exception object to vdsm error objects is the right thing to do but
requires more work than
Roy Golan has posted comments on this change.
Change subject: Catch libvirt timeout and return an error on setVmTicket
..
Patch Set 9: Verified
--
To view, visit http://gerrit.ovirt.org/10285
To unsubscribe, visit
Roy Golan has posted comments on this change.
Change subject: Catch libvirt timeout and return an error on setVmTicket
..
Patch Set 6:
jenkins's jsonRpcTest is failing with Bad File descriptor so I don't think its
related
--
Roy Golan has uploaded a new change for review.
Change subject: api-schema: adding expection to err objects
..
api-schema: adding expection to err objects
Adding optional exception string to the err object for more information
Roy Golan has posted comments on this change.
Change subject: catch libvirt timeout and return an error on setVmTicket
..
Patch Set 3: (2 inline comments)
File
Roy Golan has posted comments on this change.
Change subject: catch libvirt timeout and return an error on setVmTicket
..
Patch Set 1: (2 inline comments)
File vdsm/API.py
Roy Golan has posted comments on this change.
Change subject: catch libvirt timeout and return an error on setVmTicket
..
Patch Set 1: (1 inline comment)
File vdsm/API.py
Roy Golan has posted comments on this change.
Change subject: catch libvirt timeout and return an error on setVmTicket
..
Patch Set 1: (1 inline comment)
File vdsm/API.py
Roy Golan has uploaded a new change for review.
Change subject: catch libvirt timeout and return an error on setVmTicket
..
catch libvirt timeout and return an error on setVmTicket
return an errCode instead of an exception
Roy Golan has posted comments on this change.
Change subject: BZ#847744 fenceNode API is missing the options argument
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit
Roy Golan has posted comments on this change.
Change subject: BZ#847744 fenceNode API is missing the options argument
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/7145
To unsubscribe, visit
Roy Golan has posted comments on this change.
Change subject: fenceNode API is missing the options argument
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/7058
To unsubscribe, visit
Roy Golan has uploaded a new change for review.
Change subject: fenceNode API is missing the options argument
..
fenceNode API is missing the options argument
Change-Id: Ib2ce9b0f71040f9198413fa06c5d8768994842ec
Signed-off-by:
Roy Golan has posted comments on this change.
Change subject: BZ#787728 configNet: restore backup on connectivity failure
..
Patch Set 2: (1 inline comment)
File
Roy Golan has posted comments on this change.
Change subject: boostrap completion: fix no reboot function and report.
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit
Roy Golan has posted comments on this change.
Change subject: added mtu support for network interface
..
Patch Set 6: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/754
To
Roy Golan has posted comments on this change.
Change subject: added mtu support for network interface
..
Patch Set 4:
The backend needs the mtu reported in VdsCaps. If not
reported by the ifcfg file please report the default
92 matches
Mail list logo
