Martin Sivák has posted comments on this change.
Change subject: Fix the charset conversion logic in hooks.py
..
Patch Set 8: Verified
Tests pass.
--
To view, visit http://gerrit.ovirt.org/15856
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix the charset conversion logic in hooks.py
..
Patch Set 8:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3047/ : SUCCESS
Dan Kenigsberg has posted comments on this change.
Change subject: Fix the charset conversion logic in hooks.py
..
Patch Set 8: (1 inline comment)
File vdsm/hooks.py
Line
Dan Kenigsberg has posted comments on this change.
Change subject: Fix the charset conversion logic in hooks.py
..
Patch Set 8: I would prefer that you didn't submit this
--
To view, visit http://gerrit.ovirt.org/15856
To
Dan Kenigsberg has posted comments on this change.
Change subject: Fix the charset conversion logic in hooks.py
..
Patch Set 9: Looks good to me, approved
Martin, would you please verify that this actually passes custom
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix the charset conversion logic in hooks.py
..
Patch Set 9: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3056/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix the charset conversion logic in hooks.py
..
Patch Set 10: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3061/ : SUCCESS
Dan Kenigsberg has posted comments on this change.
Change subject: Fix the charset conversion logic in hooks.py
..
Patch Set 10: I would prefer that you didn't submit this
(1 inline comment)
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix the charset conversion logic in hooks.py
..
Patch Set 11: Fails; I would prefer that you didn't submit this
Build Failed
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Fix the charset conversion logic in hooks.py
..
Fix the charset conversion logic in hooks.py
The proper way to convert text from byte oriented string
Dan Kenigsberg has posted comments on this change.
Change subject: Fix the charset conversion logic in hooks.py
..
Patch Set 11: Verified; Looks good to me, approved
I do not know what is wrong with our slaves' pep8 tool, and
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix the charset conversion logic in hooks.py
..
Patch Set 5: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3030/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix the charset conversion logic in hooks.py
..
Patch Set 6: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3032/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix the charset conversion logic in hooks.py
..
Patch Set 7:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/3036/ : SUCCESS
Martin Sivák has posted comments on this change.
Change subject: Fix the charset conversion logic in hooks.py
..
Patch Set 7: Verified
Tests pass even when unicode chars are present in the environment.
--
To view, visit
Dan Kenigsberg has posted comments on this change.
Change subject: Fix the charset conversion logic in hooks.py
..
Patch Set 7: I would prefer that you didn't submit this
(1 inline comment)
Martin Sivák has posted comments on this change.
Change subject: Fix the charset conversion logic in hooks.py
..
Patch Set 4: (1 inline comment)
File vdsm/hooks.py
Line 59:
Dan Kenigsberg has posted comments on this change.
Change subject: Fix the charset conversion logic in hooks.py
..
Patch Set 4: (1 inline comment)
File vdsm/hooks.py
Line
Martin Sivák has posted comments on this change.
Change subject: Fix the charset conversion logic in hooks.py
..
Patch Set 4: Verified
Tests pass. The fix ignores lines that throw a UnicodeDecodeException.
Jenkins does not
Dan Kenigsberg has posted comments on this change.
Change subject: Fix the charset conversion logic in hooks.py
..
Patch Set 4: I would prefer that you didn't submit this
(2 inline comments)
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix the charset conversion logic in hooks.py
..
Patch Set 4: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2902/ : SUCCESS
Martin Sivák has posted comments on this change.
Change subject: Fix the charset conversion logic in hooks.py
..
Patch Set 2: Fails
(1 inline comment)
Back to the drawing board. It works on command line, but the automated
Dan Kenigsberg has posted comments on this change.
Change subject: Fix the charset conversion logic in hooks.py
..
Patch Set 2: (1 inline comment)
Commit Message
Line 7: Fix
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix the charset conversion logic in hooks.py
..
Patch Set 2: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2838/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix the charset conversion logic in hooks.py
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2838/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix the charset conversion logic in hooks.py
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2838/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix the charset conversion logic in hooks.py
..
Patch Set 3: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2847/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix the charset conversion logic in hooks.py
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2847/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix the charset conversion logic in hooks.py
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2847/ : SUCCESS
Dan Kenigsberg has posted comments on this change.
Change subject: Fix the charset conversion logic in hooks.py
..
Patch Set 3: Looks good to me, but someone else must approve
(2 inline comments)
Martin Sivak has uploaded a new change for review.
Change subject: Fix the charset conversion logic in hooks.py
..
Fix the charset conversion logic in hooks.py
The proper way to convert text from byte oriented string to unicode
David Caro has posted comments on this change.
Change subject: Fix the charset conversion logic in hooks.py
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/15856
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix the charset conversion logic in hooks.py
..
Patch Set 2: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2824/ : SUCCESS
33 matches
Mail list logo
