Dan Kenigsberg has posted comments on this change.
Change subject: Fix the charset conversion logic in hooks.py
......................................................................
Patch Set 7: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/hooks.py
Line 60:
Line 61: scriptenv = os.environ.copy()
Line 62: scriptenv.update(vmconf.get('custom', {}))
Line 63: if len(params) > 0:
Line 64: # Encode the values to UTF-8 and save them to scriptenv
omg, I have mislead you over irc. The most important thing for us to encode is
the content of the "custom" dictionary.
Would you please replace this with something like
for k, v in chain(vmconf.get('custom', {}).iteritems(), params.iteritems()):
?
Line 65: # Pass str objects (byte-strings) without any conversion
Line 66: for k, v in params.iteritems():
Line 67: try:
Line 68: if isinstance(v, unicode):
--
To view, visit http://gerrit.ovirt.org/15856
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9063291f8a4a392b2913220fe2839386dcffd825
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: David Caro <[email protected]>
Gerrit-Reviewer: Martin Sivák <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
