Dan Kenigsberg has submitted this change and it was merged.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Move multipath configuration to vdsm-tool configurator
Previously multipath is reconfigured
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 22:
Build Failed
Dan Kenigsberg has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 21: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/30909
To unsubscribe, visit
Saggi Mizrahi has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 18: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/30909
To unsubscribe, visit
Saggi Mizrahi has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 20: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/30909
To unsubscribe, visit
Yeela Kaplan has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 20: Verified+1
--
To view, visit http://gerrit.ovirt.org/30909
To unsubscribe, visit
Yeela Kaplan has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 21: Verified+1
--
To view, visit http://gerrit.ovirt.org/30909
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 19:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 20:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 21:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 18:
Build Failed
Nir Soffer has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 17:
(1 comment)
http://gerrit.ovirt.org/#/c/30909/17/lib/vdsm/tool/configurators/multipath.py
Yeela Kaplan has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 16:
(4 comments)
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 17:
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 16:
Build Failed
Nir Soffer has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 16:
(4 comments)
http://gerrit.ovirt.org/#/c/30909/16/lib/vdsm/tool/configurators/multipath.py
Yaniv Bronhaim has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 15: Code-Review+1
(1 comment)
this part looks good imo
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 15:
Build Failed
Yeela Kaplan has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 13:
(3 comments)
Separating into two steps / patches:
1. move to backup file from rotate
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 14:
Build Failed
Yeela Kaplan has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 13:
moving to use backup instead of rotateFiles is not because 'Dan doesn't like
it'.
The
Dan Kenigsberg has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 13:
Just to be clear, I refused to see rotateFiles in utils in its current fragile
form
Dan Kenigsberg has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 13:
(1 comment)
Nir Soffer has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 13: Code-Review-1
This patch does now two unrelated changes:
1. Keep one backup of
Dan Kenigsberg has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 13:
Back in http://lists.ovirt.org/pipermail/devel/2014-June/007897.html we agreed
to take
Nir Soffer has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 13:
We may aim for different backup solution, but it is not related to this patch.
--
To
Yeela Kaplan has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 13:
It doesn't make sense to change the use of rotateFiles to copy in a different
following
Nir Soffer has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 13:
This is not the only way to go. If Dan has a problem with rotateFiles, we can
fix it.
We
Yaniv Bronhaim has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 13:
I intend to agree with nir about the code changes. most of the comments I had
were
Yaniv Bronhaim has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 12: Code-Review+1
(1 comment)
my comment there although its as previous implementation in
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 13:
Build Failed
Nir Soffer has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 13:
(3 comments)
I think we are going in the wrong direction. This patch should be simple move
Yaniv Bronhaim has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 11: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/30909
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 12:
Build Failed
Yeela Kaplan has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 10: Verified+1
--
To view, visit http://gerrit.ovirt.org/30909
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 11:
Build Failed
Yeela Kaplan has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 11: Verified+1
--
To view, visit http://gerrit.ovirt.org/30909
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 11: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/30909
To unsubscribe, visit
Yeela Kaplan has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 9:
(4 comments)
http://gerrit.ovirt.org/#/c/30909/9//COMMIT_MSG
Commit Message:
Line 11:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 10:
Build Successful
Nir Soffer has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 10: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/30909
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 9:
(5 comments)
http://gerrit.ovirt.org/#/c/30909/9/lib/vdsm/tool/configurator.py
File
Nir Soffer has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 9:
(4 comments)
http://gerrit.ovirt.org/#/c/30909/9/lib/vdsm/tool/configurators/multipath.py
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 9:
Build Successful
Nir Soffer has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 9:
(1 comment)
The patch is in great shape now.
Unfortunately a rebase is required after
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 8:
Build Successful
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 7:
Build Failed
Nir Soffer has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 7: Code-Review-1
(6 comments)
Need to update for new Configurator interface
Yaniv Bronhaim has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 6:
now it requires big rebase... i warned you
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 6:
I think the rebase should be easy - just move the new class to its own module.
--
To view,
Nir Soffer has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 6:
(2 comments)
http://gerrit.ovirt.org/#/c/30909/6/lib/vdsm/tool/configurator.py
File
Yeela Kaplan has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 5:
(5 comments)
http://gerrit.ovirt.org/#/c/30909/5/lib/vdsm/tool/configurator.py
File
Nir Soffer has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 5:
(1 comment)
http://gerrit.ovirt.org/#/c/30909/5/lib/vdsm/tool/configurator.py
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 6:
Build Successful
Yaniv Bronhaim has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 5: -Code-Review
(1 comment)
so still need to improve the comments. not only me complaining
Yaniv Bronhaim has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 5: Code-Review+1
oh well .. at least I know now what the tags and the 2 empty lines mean
Nir Soffer has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 5: Code-Review-1
(5 comments)
Usage of service_status looks wrong, and some minor
Yaniv Bronhaim has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 4: Code-Review-1
(3 comments)
I'm sorry, i don't understand how the tags work. I know this
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 5:
Build Successful
Yeela Kaplan has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 4:
(3 comments)
force should not override existing configuration if it contains PRIVATE_TAG
Yaniv Bronhaim has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 2:
(7 comments)
http://gerrit.ovirt.org/#/c/30909/2/lib/vdsm/tool/configurator.py
File
Yeela Kaplan has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 2:
(7 comments)
http://gerrit.ovirt.org/#/c/30909/2/lib/vdsm/tool/configurator.py
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 3:
Build Failed
Yaniv Bronhaim has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 3:
(3 comments)
http://gerrit.ovirt.org/#/c/30909/3/lib/vdsm/tool/configurator.py
File
Yeela Kaplan has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 3:
(3 comments)
http://gerrit.ovirt.org/#/c/30909/3/lib/vdsm/tool/configurator.py
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 4:
Build Failed
Nir Soffer has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 2:
(7 comments)
http://gerrit.ovirt.org/#/c/30909/2/lib/vdsm/tool/configurator.py
File
Yaniv Bronhaim has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 2: Code-Review-1
(8 comments)
Nir Soffer has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 2: Code-Review-1
(7 comments)
There are some issues in the old code from multipath that must
Yaniv Bronhaim has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 2:
(4 comments)
http://gerrit.ovirt.org/#/c/30909/2/lib/vdsm/tool/configurator.py
File
Nir Soffer has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 2:
(3 comments)
http://gerrit.ovirt.org/#/c/30909/2/lib/vdsm/tool/configurator.py
File
Yaniv Bronhaim has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 2:
(4 comments)
http://gerrit.ovirt.org/#/c/30909/2/lib/vdsm/tool/configurator.py
File
Yeela Kaplan has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 1:
(3 comments)
Nir:
Thank you for the review... some answers to your comments:
1. as far
Nir Soffer has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 1:
1. as far as I could tell, there is no special check when vdsm starts, it
just uses vdsm
Yeela Kaplan has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/30909
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 1:
3. maybe we should close the bug as duplicate of the current bug-url attached
to this
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 2:
Build Failed
Yeela Kaplan has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 3:
(10 comments)
http://gerrit.ovirt.org/#/c/26123/3/lib/vdsm/tool/configurator.py
File
Yeela Kaplan has abandoned this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Abandoned
replaced by a new patch
--
To view, visit http://gerrit.ovirt.org/26123
To unsubscribe, visit
Yeela Kaplan has uploaded a new change for review.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Move multipath configuration to vdsm-tool configurator
Previously multipath is reconfigured on each
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 1:
Build Failed
Nir Soffer has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 1:
(2 comments)
So much nicer when we have several simple patches!
Whats missing:
1.
Nir Soffer has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/30909/1//COMMIT_MSG
Commit Message:
Line 7: Move
Nir Soffer has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 3:
This patch changes very old code - please start by rebasing on master.
Please break this to
Nir Soffer has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 3:
(10 comments)
To make it easier to review, please separate patches where you remove code
Dan Kenigsberg has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 2:
(2 comments)
http://gerrit.ovirt.org/#/c/26123/2/lib/vdsm/utils.py
File
Dan Kenigsberg has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 3: Code-Review-1
(2 comments)
very partial review
Yaniv Bronhaim has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 3: Code-Review-1
and don't forget to rebase and add toolTests for that
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9779/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 3:
Build Failed
Nir Soffer has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 3: Code-Review-1
Please fix pep8 violations:
lib/vdsm/tool/configurator.py:226:17: E128
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 3: Code-Review-1 Verified-1
Build Failed
Itamar Heim has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 2:
ping
--
To view, visit http://gerrit.ovirt.org/26123
To unsubscribe, visit
mooli tayer has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 2:
Regarding yaniv previous comment the tool tests were merged:
Yaniv Bronhaim has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 2: Code-Review-1
(5 comments)
hope that during next week
Yeela Kaplan has uploaded a new change for review.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Move multipath configuration to vdsm-tool configurator
Previously multipathe is recofigured on each
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 1: Code-Review-1 Verified-1
Build Unstable
Yeela Kaplan has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 2: Verified+1
multipath is configurated when using vdsm-tool, under the same conditions as
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 2:
Build Unstable
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6874/ :
Dan Kenigsberg has posted comments on this change.
Change subject: Move multipath configuration to vdsm-tool configurator
..
Patch Set 2: Code-Review-1
(3 comments)
Very very partial review.
Note the persistent pep8 errors
1 - 100 of 103 matches
Mail list logo
