Dan Kenigsberg has submitted this change and it was merged.
Change subject: NetReload: netmodels for delNetwork
..
NetReload: netmodels for delNetwork
This patch re-implements the delNetwork logic using the network
entities
Dan Kenigsberg has posted comments on this change.
Change subject: NetReload: netmodels for delNetwork
..
Patch Set 16: Looks good to me, approved
Thanks for the quick fixes!
--
To view, visit http://gerrit.ovirt.org/14873
Dan Kenigsberg has posted comments on this change.
Change subject: NetReload: netmodels for delNetwork
..
Patch Set 12: (1 inline comment)
File vdsm/netmodels.py
Line 195:
Assaf Muller has posted comments on this change.
Change subject: NetReload: netmodels for delNetwork
..
Patch Set 13:
My patch set is a result of rebasing so that my Multiple Gateways series of
patches depends on this patch.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: NetReload: netmodels for delNetwork
..
Patch Set 13:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2730/ : SUCCESS
Dan Kenigsberg has posted comments on this change.
Change subject: NetReload: netmodels for delNetwork
..
Patch Set 13: I would prefer that you didn't submit this
(5 inline comments)
Toni, once ready, would you verify this
oVirt Jenkins CI Server has posted comments on this change.
Change subject: NetReload: netmodels for delNetwork
..
Patch Set 14:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2732/ : SUCCESS
Antoni Segura Puimedon has posted comments on this change.
Change subject: NetReload: netmodels for delNetwork
..
Patch Set 13: (5 inline comments)
File
Antoni Segura Puimedon has posted comments on this change.
Change subject: NetReload: netmodels for delNetwork
..
Patch Set 14: Fails
(1 inline comment)
File
Antoni Segura Puimedon has posted comments on this change.
Change subject: NetReload: netmodels for delNetwork
..
Patch Set 15: Fails
(2 inline comments)
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: NetReload: netmodels for delNetwork
..
Patch Set 15:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2733/ : SUCCESS
Antoni Segura Puimedon has posted comments on this change.
Change subject: NetReload: netmodels for delNetwork
..
Patch Set 16: Verified
--
To view, visit http://gerrit.ovirt.org/14873
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: NetReload: netmodels for delNetwork
..
Patch Set 16:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2734/ : SUCCESS
Mark Wu has posted comments on this change.
Change subject: NetReload: netmodels for delNetwork
..
Patch Set 9: I would prefer that you didn't submit this
(1 inline comment)
Mark Wu has posted comments on this change.
Change subject: NetReload: netmodels for delNetwork
..
Patch Set 10:
1. vlaned bridged network and bridgeless network
setup the following networks:
s.setupNetworks({'test1':
Mark Wu has posted comments on this change.
Change subject: NetReload: netmodels for delNetwork
..
Patch Set 10:
Any other cases you would like to verify, please let me know. I will be very
glad to verify it.
--
To view,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: NetReload: netmodels for delNetwork
..
Patch Set 10:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2677/ : SUCCESS
Antoni Segura Puimedon has posted comments on this change.
Change subject: NetReload: netmodels for delNetwork
..
Patch Set 10: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/14873
To
Mark Wu has posted comments on this change.
Change subject: NetReload: netmodels for delNetwork
..
Patch Set 10: Fails
The test cases above is tested by setupNetworks, but it doesn't work well with
delNetwork
--
To view,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: NetReload: netmodels for delNetwork
..
Patch Set 11:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2680/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: NetReload: netmodels for delNetwork
..
Patch Set 12:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2683/ : SUCCESS
Antoni Segura Puimedon has posted comments on this change.
Change subject: NetReload: netmodels for delNetwork
..
Patch Set 12: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/14873
To
Antoni Segura Puimedon has posted comments on this change.
Change subject: NetReload: netmodels for delNetwork
..
Patch Set 12: Verified
verified the top of the branch, so I consider this one as included.
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: NetReload: netmodels for delNetwork
..
Patch Set 8: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2630/ : SUCCESS
Mark Wu has posted comments on this change.
Change subject: NetReload: netmodels for delNetwork
..
Patch Set 8: Verified
1. vlaned bridged network and bridgeless network
setup the following networks:
Mark Wu has posted comments on this change.
Change subject: NetReload: netmodels for delNetwork
..
Patch Set 8: No score
Any other cases you would like to verify, please let me know. I will be very
glad to verify it.
--
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: NetReload: netmodels for delNetwork
..
Patch Set 8: No score
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2662/ : SUCCESS
Antoni Segura Puimedon has posted comments on this change.
Change subject: NetReload: netmodels for delNetwork
..
Patch Set 8: (3 inline comments)
File vdsm/netconf/ifcfg.py
Antoni Segura Puimedon has posted comments on this change.
Change subject: NetReload: netmodels for delNetwork
..
Patch Set 8: I would prefer that you didn't submit this
-1 for visibility. I can be convinced to switch it.
--
Mark Wu has posted comments on this change.
Change subject: NetReload: netmodels for delNetwork
..
Patch Set 8: (2 inline comments)
File vdsm/netconf/ifcfg.py
Line 190:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: NetReload: netmodels for delNetwork
..
Patch Set 6:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2572/ : SUCCESS
Mark Wu has posted comments on this change.
Change subject: NetReload: netmodels for delNetwork
..
Patch Set 6: I would prefer that you didn't submit this
(1 inline comment)
Dan Kenigsberg has posted comments on this change.
Change subject: NetReload: netmodels for delNetwork
..
Patch Set 6: (1 inline comment)
Commit Message
Line 8:
Line 9:
Antoni Segura Puimedon has posted comments on this change.
Change subject: NetReload: netmodels for delNetwork
..
Patch Set 6: I would prefer that you didn't submit this
(2 inline comments)
Apart from the comment you yourself
Mark Wu has posted comments on this change.
Change subject: NetReload: netmodels for delNetwork
..
Patch Set 7: I would prefer that you didn't submit this
patch7 doesn't resolve the comments in patch6. I will fix the problems
oVirt Jenkins CI Server has posted comments on this change.
Change subject: NetReload: netmodels for delNetwork
..
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2565/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: NetReload: netmodels for delNetwork
..
Patch Set 4: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2518/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: NetReload: netmodels for delNetwork
..
Patch Set 3:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2447/ (1/3)
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: NetReload: netmodels for delNetwork
..
Patch Set 3:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2517/ (2/3)
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: NetReload: netmodels for delNetwork
..
Patch Set 3:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1616/ (3/3)
--
To view,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: NetReload: netmodels for delNetwork
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2447/ : SUCCESS
Mark Wu has posted comments on this change.
Change subject: NetReload: netmodels for delNetwork
..
Patch Set 3:
Just verified with the following test case:
nics - bond1 - vlan1 - network1
- vlan2 - network2
Antoni Segura Puimedon has posted comments on this change.
Change subject: NetReload: netmodels for delNetwork
..
Patch Set 2: I would prefer that you didn't submit this
(5 inline comments)
Just a couple of simplifications
Mark Wu has posted comments on this change.
Change subject: NetReload: netmodels for delNetwork
..
Patch Set 2: (5 inline comments)
File vdsm/configNetwork.py
Line 60:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: NetReload: netmodels for delNetwork
..
Patch Set 2: No score
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2487/ (3/3)
--
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: NetReload: netmodels for delNetwork
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2413/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: NetReload: netmodels for delNetwork
..
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2413/ (1/3)
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: NetReload: netmodels for delNetwork
..
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2481/ (2/3)
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: NetReload: netmodels for delNetwork
..
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1579/ (3/3)
--
To view,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: NetReload: netmodels for delNetwork
..
Patch Set 2: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2413/ : SUCCESS
Giuseppe Vallarelli has posted comments on this change.
Change subject: NetReload: netmodels for delNetwork
..
Patch Set 1: (1 inline comment)
File vdsm/netconf/ifcfg.py
Giuseppe Vallarelli has posted comments on this change.
Change subject: NetReload: netmodels for delNetwork
..
Patch Set 1: (1 inline comment)
File vdsm/netconf/ifcfg.py
Giuseppe Vallarelli has posted comments on this change.
Change subject: NetReload: netmodels for delNetwork
..
Patch Set 1: (1 inline comment)
File vdsm/netconf/ifcfg.py
Antoni Segura Puimedon has posted comments on this change.
Change subject: NetReload: netmodels for delNetwork
..
Patch Set 1: I would prefer that you didn't submit this
(5 inline comments)
The context manager proposal is not
Mark Wu has uploaded a new change for review.
Change subject: NetReload: netmodels for delNetwork
..
NetReload: netmodels for delNetwork
This patch re-implements the delNetwork logic using the network
entities defined in
oVirt Jenkins CI Server has posted comments on this change.
Change subject: NetReload: netmodels for delNetwork
..
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2341/ (1/3)
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: NetReload: netmodels for delNetwork
..
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2408/ (2/3)
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: NetReload: netmodels for delNetwork
..
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1506/ (3/3)
--
To view,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: NetReload: netmodels for delNetwork
..
Patch Set 1: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2341/ : SUCCESS
59 matches
Mail list logo
