Ayal Baron has posted comments on this change.
Change subject: domainMonitor: Separate change detection from lastCheck value
..
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21878
To unsubscribe, visit
Federico Simoncelli has posted comments on this change.
Change subject: domainMonitor: Separate change detection from lastCheck value
..
Patch Set 5: Code-Review+2
(1 comment)
Minor nit. But overall is +2.
Nir Soffer has posted comments on this change.
Change subject: domainMonitor: Separate change detection from lastCheck value
..
Patch Set 5: Verified+1
Verified first change event by starting vdsm and checking the emitted
Liron Ar has posted comments on this change.
Change subject: domainMonitor: Separate change detection from lastCheck value
..
Patch Set 4: Code-Review-1
marking -1 just so that my comment on the previous patchset will be seen.
Nir Soffer has posted comments on this change.
Change subject: domainMonitor: Separate change detection from lastCheck value
..
Patch Set 3:
(1 comment)
File
Nir Soffer has posted comments on this change.
Change subject: domainMonitor: Separate change detection from lastCheck value
..
Patch Set 4:
Liron, this is important fix - your -1 block this change for no good reason
Liron Ar has posted comments on this change.
Change subject: domainMonitor: Separate change detection from lastCheck value
..
Patch Set 4:
Let's wait for other opinions with it.
The -1 isn't for blocking the change, but to
Liron Ar has posted comments on this change.
Change subject: domainMonitor: Separate change detection from lastCheck value
..
Patch Set 4:
just to clarify - my -1 is just so a maintainer will see my comment in
Allon Mureinik has posted comments on this change.
Change subject: domainMonitor: Separate change detection from lastCheck value
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21878
To unsubscribe,
Allon Mureinik has posted comments on this change.
Change subject: domainMonitor: Separate change detection from lastCheck value
..
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21878
To unsubscribe,
Nir Soffer has posted comments on this change.
Change subject: domainMonitor: Separate change detection from lastCheck value
..
Patch Set 5:
A cleaner implementation addressing Liron comments.
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: domainMonitor: Separate change detection from lastCheck value
..
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5913/ :
Liron Ar has posted comments on this change.
Change subject: domainMonitor: Separate change detection from lastCheck value
..
Patch Set 5:
(1 comment)
File
Nir Soffer has posted comments on this change.
Change subject: domainMonitor: Separate change detection from lastCheck value
..
Patch Set 5:
(1 comment)
File
Liron Ar has posted comments on this change.
Change subject: domainMonitor: Separate change detection from lastCheck value
..
Patch Set 5: Code-Review+1
(1 comment)
File
Allon Mureinik has posted comments on this change.
Change subject: domainMonitor: Separate change detection from lastCheck value
..
Patch Set 3:
(1 comment)
Commit Message
Nir Soffer has posted comments on this change.
Change subject: domainMonitor: Separate change detection from lastCheck value
..
Patch Set 4:
Refine commit message and add reference to the original bug.
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: domainMonitor: Separate change detection from lastCheck value
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5896/ :
Nir Soffer has posted comments on this change.
Change subject: domainMonitor: Separate change detection from lastCheck value
..
Patch Set 4:
Note: no code change.
--
To view, visit http://gerrit.ovirt.org/21878
To
Allon Mureinik has posted comments on this change.
Change subject: domainMonitor: Separate change detection from lastCheck value
..
Patch Set 3: Code-Review+1
(1 comment)
Liron Ar has posted comments on this change.
Change subject: domainMonitor: Separate change detection from lastCheck value
..
Patch Set 3:
(1 comment)
File
Nir Soffer has posted comments on this change.
Change subject: domainMonitor: Separate change detection from lastCheck value
..
Patch Set 3:
(2 comments)
Commit Message
Liron Ar has posted comments on this change.
Change subject: domainMonitor: Separate change detection from lastCheck value
..
Patch Set 3:
(1 comment)
File
Nir Soffer has posted comments on this change.
Change subject: domainMonitor: Separate change detection from lastCheck value
..
Patch Set 3:
Update commit message after discussion with Federico.
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: domainMonitor: Separate change detection from lastCheck value
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5864/ :
Federico Simoncelli has posted comments on this change.
Change subject: domainMonitor: Separate change detection from lastCheck value
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21878
To
Nir Soffer has uploaded a new change for review.
Change subject: domainMonitor: Separate change detection from lastCheck value
..
domainMonitor: Separate change detection from lastCheck value
Since commit b4b8a7666b68,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: domainMonitor: Separate change detection from lastCheck value
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5833/ :
Nir Soffer has posted comments on this change.
Change subject: domainMonitor: Separate change detection from lastCheck value
..
Patch Set 2:
Fix time() usage.
--
To view, visit http://gerrit.ovirt.org/21878
To unsubscribe,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: domainMonitor: Separate change detection from lastCheck value
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5835/ :
30 matches
Mail list logo
