Dan Kenigsberg has submitted this change and it was merged.
Change subject: migration: Add Dynamic Bounded Semaphores
..
migration: Add Dynamic Bounded Semaphores
This patch adds new Bounded Semaphore class with the ability to
gerrit-hooks has posted comments on this change.
Change subject: migration: Add Dynamic Bounded Semaphores
..
Patch Set 24:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
Francesco Romani has posted comments on this change.
Change subject: migration: Add Dynamic Bounded Semaphores
..
Patch Set 23: Code-Review+2
(1 comment)
the code seems reasonnably OK, I don't have better suggestions and this
Martin Betak has posted comments on this change.
Change subject: migration: Add Dynamic Bounded Semaphores
..
Patch Set 23:
(2 comments)
https://gerrit.ovirt.org/#/c/53304/23/tests/vmUtilsTests.py
File tests/vmUtilsTests.py:
Francesco Romani has posted comments on this change.
Change subject: migration: Add Dynamic Bounded Semaphores
..
Patch Set 23: Code-Review+1
(4 comments)
nitpicking in the tests is not good enough reason to delay my +1.
Martin Betak has posted comments on this change.
Change subject: migration: Add Dynamic Bounded Semaphores
..
Patch Set 23: Verified+1
Verfied using unit tests. Since last patch-set was test-only change, restoring
+V.
--
To
Francesco Romani has posted comments on this change.
Change subject: migration: Add Dynamic Bounded Semaphores
..
Patch Set 22:
(1 comment)
https://gerrit.ovirt.org/#/c/53304/22/vdsm/virt/migration.py
File
gerrit-hooks has posted comments on this change.
Change subject: migration: Add Dynamic Bounded Semaphores
..
Patch Set 23:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Martin Betak has posted comments on this change.
Change subject: migration: Add Dynamic Bounded Semaphores
..
Patch Set 22:
(7 comments)
https://gerrit.ovirt.org/#/c/53304/22/tests/vmUtilsTests.py
File tests/vmUtilsTests.py:
Francesco Romani has posted comments on this change.
Change subject: migration: Add Dynamic Bounded Semaphores
..
Patch Set 22:
(1 comment)
https://gerrit.ovirt.org/#/c/53304/22/vdsm/virt/migration.py
File
Francesco Romani has posted comments on this change.
Change subject: migration: Add Dynamic Bounded Semaphores
..
Patch Set 22: Code-Review+1
(6 comments)
ok, I don't have further comments besides improving the tests.
Added
Milan Zamazal has posted comments on this change.
Change subject: migration: Add Dynamic Bounded Semaphores
..
Patch Set 22: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/53304
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: migration: Add Dynamic Bounded Semaphores
..
Patch Set 22:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Martin Betak has posted comments on this change.
Change subject: migration: Add Dynamic Bounded Semaphores
..
Patch Set 21: Verified+1
--
To view, visit https://gerrit.ovirt.org/53304
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: migration: Add Dynamic Bounded Semaphores
..
Patch Set 21:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Francesco Romani has posted comments on this change.
Change subject: migration: Add Dynamic Bounded Semaphores
..
Patch Set 20: Code-Review+1
looks good, preliminary ACK. I just need to read the tests more carefully
before to
Martin Betak has posted comments on this change.
Change subject: migration: Add Dynamic Bounded Semaphores
..
Patch Set 20: Verified+1
--
To view, visit https://gerrit.ovirt.org/53304
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: migration: Add Dynamic Bounded Semaphores
..
Patch Set 18:
(1 comment)
https://gerrit.ovirt.org/#/c/53304/18/lib/vdsm/virt/utils.py
File lib/vdsm/virt/utils.py:
gerrit-hooks has posted comments on this change.
Change subject: migration: Add Dynamic Bounded Semaphores
..
Patch Set 20:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
19 matches
Mail list logo