Dan Kenigsberg has submitted this change and it was merged.
Change subject: response: Add support for specific error checking in is_error
..
response: Add support for specific error checking in is_error
response.is_error can
gerrit-hooks has posted comments on this change.
Change subject: response: Add support for specific error checking in is_error
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url
Francesco Romani has posted comments on this change.
Change subject: response: Add support for specific error checking in is_error
..
Patch Set 3:
Martin added the required statement, so it is fine now
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: response: Add support for specific error checking in is_error
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/54036
To unsubscribe,
gerrit-hooks has posted comments on this change.
Change subject: response: Add support for specific error checking in is_error
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Martin Betak has posted comments on this change.
Change subject: response: Add support for specific error checking in is_error
..
Patch Set 2:
@fromani: Sure, verified by running tests and also by full e2e manual tests of
Francesco Romani has posted comments on this change.
Change subject: response: Add support for specific error checking in is_error
..
Patch Set 2: Code-Review+1
Looks fine, +2'd on hold:
please don't forget to add a comment on
Francesco Romani has posted comments on this change.
Change subject: response: Add support for specific error checking in is_error
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/54036
To unsubscribe,
Martin Betak has posted comments on this change.
Change subject: response: Add support for specific error checking in is_error
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/54036
To unsubscribe, visit
Martin Betak has posted comments on this change.
Change subject: response: Add support for specific error checking in is_error
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/54036/1/tests/responseTests.py
File
gerrit-hooks has posted comments on this change.
Change subject: response: Add support for specific error checking in is_error
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Francesco Romani has posted comments on this change.
Change subject: response: Add support for specific error checking in is_error
..
Patch Set 1: Code-Review+1
(1 comment)
nice! let's just improve a bit the tests and it is
gerrit-hooks has posted comments on this change.
Change subject: response: Add support for specific error checking in is_error
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
Martin Betak has uploaded a new change for review.
Change subject: response: Add support for specific error checking in is_error
..
response: Add support for specific error checking in is_error
response.is_error can now take an
14 matches
Mail list logo
