Roy Golan has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 26:
(4 comments)
http://gerrit.ovirt.org/#/c/21789/26//COMMIT_MSG
Commit Message:
Line 39:
Line 40:
Roy Golan has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 27:
* addressed comments
* added an update to the vm container to reflect changes when migrating etc
--
Roy Golan has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 27: Verified+1
--
To view, visit http://gerrit.ovirt.org/21789
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 27:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6706/ : SUCCESS
Yaniv Bronhaim has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 27: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21789
To unsubscribe, visit
Michal Skrivanek has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 27: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21789
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
set the # of vcpus for a VM (hot plug/unplug)
Introducing new API for setting the number of cpus of a
Dan Kenigsberg has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 27: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21789
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 27:
Build Successful
Dan Kenigsberg has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 25: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/21789
To unsubscribe, visit
Roy Golan has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 25: Verified+1
--
To view, visit http://gerrit.ovirt.org/21789
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 26:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6691/ : SUCCESS
Yaniv Bronhaim has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 26: Code-Review+1
(3 comments)
Commit Message
Dan Kenigsberg has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 26:
(2 comments)
Commit Message
Line 39:
Line
Roy Golan has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 26: Verified-1
I think I missed updating the vmcontainer.
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 25:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6690/ : SUCCESS
Michal Skrivanek has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 19:
(1 comment)
File vdsm/vm.py
Line 895:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 19: Code-Review-1 Verified-1
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 20:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6657/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 21:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6659/ : SUCCESS
Dan Kenigsberg has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 20:
(5 comments)
File vdsm/vm.py
Line 896:
Dan Kenigsberg has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 23: Code-Review-1
please see my comments to ps20.
--
To view, visit http://gerrit.ovirt.org/21789
oVirt Jenkins CI Server has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 22:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6660/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 23:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6661/ : SUCCESS
Dan Kenigsberg has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 23:
(1 comment)
(sorry)
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 24:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6665/ : SUCCESS
Dan Kenigsberg has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 24: Code-Review-1
(1 comment)
one last documentation nit, and we're good to go.
Dan Kenigsberg has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 15: Code-Review-1
(14 comments)
Commit Message
Francesco Romani has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 15: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21789
To unsubscribe, visit
Vinzenz Feenstra has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 15: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21789
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 13: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21789
To unsubscribe, visit
Roy Golan has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 14:
hook supported isn't verified
--
To view, visit http://gerrit.ovirt.org/21789
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 14: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6514/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 15:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6516/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 13:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6479/ : SUCCESS
Roy Golan has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 13:
* reverted the use of EqualsMultiLine which doesn't exist in the 2.6
* following Edu's comments on
Francesco Romani has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 9:
Looks good to me except for the failed test.
--
To view, visit http://gerrit.ovirt.org/21789
Roy Golan has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 10:
* test wasn't fixed yet
--
To view, visit http://gerrit.ovirt.org/21789
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 10: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6447/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 11: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6457/ :
Francesco Romani has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 11:
(2 comments)
just noticed a couple of minor things.
Roy Golan has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 11:
(2 comments)
File tests/vmTests.py
Line 45:
Roy Golan has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 12:
no change just a rebase. on my side all the tests run OK
when I make rpm.
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 12: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6474/ :
Yaniv Bronhaim has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 9:
it fails (FAIL: testCpuXML (vmTests.TestVm)). except that it looks quite
complete to me
--
To
Roy Golan has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 7:
the libvirt xml is changed now to allow adding more cpus
this means we have a topology element and a
oVirt Jenkins CI Server has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 7: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6393/ :
Roy Golan has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 7: Verified+1
Verified
* the vm is up and running with 2 cpus
* can call setVcpus
Not verified
* the
oVirt Jenkins CI Server has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 8: Code-Review-1 Verified-1
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 9: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6400/ :
Yaniv Bronhaim has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 6: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21789
To unsubscribe, visit
Saggi Mizrahi has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 6:
One of SaggiMizrahi's automated scripts discovered this patch might require his
approval.
Please
oVirt Jenkins CI Server has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 6:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5858/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5846/ : SUCCESS
Roy Golan has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 2:
(5 comments)
File client/vdsClient.py
Line 245:
Roy Golan has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 3:
* addressed comments
* rename the new vdsClient verb to plural: setNumberOfCpu - setNumberOfCpus
--
oVirt Jenkins CI Server has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4950/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4972/ :
Yaniv Bronhaim has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 4:
(1 comment)
looks good to me.
File
Roy Golan has uploaded a new change for review.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
set the # of vcpus for a VM (hot plug/unplug)
RFE https://bugzilla.redhat.com/show_bug.cgi?id=833102
Change-Id:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 1: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4930/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4944/ :
Vinzenz Feenstra has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 2:
(2 comments)
File vdsm/vm.py
Line 3309:
Yaniv Bronhaim has posted comments on this change.
Change subject: set the # of vcpus for a VM (hot plug/unplug)
..
Patch Set 2:
(3 comments)
File client/vdsClient.py
Line
64 matches
Mail list logo
