Vinzenz Feenstra has posted comments on this change.
Change subject: stats: return HA agent score when applicable
..
Patch Set 7: Code-Review-1
(1 comment)
Besides that minor style issue with the logging it looks good to me.
Nir Soffer has posted comments on this change.
Change subject: stats: return HA agent score when applicable
..
Patch Set 7:
(1 comment)
File vdsm/API.py
Line 1220:
Greg Padgett has posted comments on this change.
Change subject: stats: return HA agent score when applicable
..
Patch Set 7:
(1 comment)
File vdsm/API.py
Line 1220:
Greg Padgett has posted comments on this change.
Change subject: stats: return HA agent score when applicable
..
Patch Set 8: Verified+1
--
To view, visit http://gerrit.ovirt.org/20126
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stats: return HA agent score when applicable
..
Patch Set 8:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5117/ : SUCCESS
Oved Ourfali has posted comments on this change.
Change subject: stats: return HA agent score when applicable
..
Patch Set 8: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/20126
To unsubscribe, visit
Sandro Bonazzola has posted comments on this change.
Change subject: stats: return HA agent score when applicable
..
Patch Set 8: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/20126
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: stats: return HA agent score when applicable
..
Patch Set 8: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/20126
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: stats: return HA agent score when applicable
..
stats: return HA agent score when applicable
For Hosted Engine, the engine needs to know the HA score
Greg Padgett has posted comments on this change.
Change subject: stats: return HA agent score when applicable
..
Patch Set 6: Verified+1
Builds fine for me, too. Tested with and without HA client module available.
--
To
Doron Fediuck has posted comments on this change.
Change subject: stats: return HA agent score when applicable
..
Patch Set 6:
The error is:
./vdsm/API.py:54: redefinition of unused 'haClient' from line 52
Try modifying as
Nir Soffer has posted comments on this change.
Change subject: stats: return HA agent score when applicable
..
Patch Set 6:
Looks like a tool error to me; the original code is valid.
Maybe there is an old version of pep8 on
Greg Padgett has posted comments on this change.
Change subject: stats: return HA agent score when applicable
..
Patch Set 7: Verified+1
Doron, thanks. Nir, agreed... it looks like an open issue in pyflakes [1].
The latest
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stats: return HA agent score when applicable
..
Patch Set 7:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5110/ : SUCCESS
Greg Padgett has posted comments on this change.
Change subject: stats: return HA agent score when applicable
..
Patch Set 4:
(7 comments)
File vdsm/API.py
Line 51: try:
Greg Padgett has posted comments on this change.
Change subject: stats: return HA agent score when applicable
..
Patch Set 5:
Addressed comments. Not yet tested/verified. There was some discussion on
vdsm-devel about
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stats: return HA agent score when applicable
..
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5105/ : SUCCESS
Nir Soffer has posted comments on this change.
Change subject: stats: return HA agent score when applicable
..
Patch Set 5:
(1 comment)
File vdsm/API.py
Line 51: try:
Line
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stats: return HA agent score when applicable
..
Patch Set 6: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5107/ : SUCCESS
Doron Fediuck has posted comments on this change.
Change subject: stats: return HA agent score when applicable
..
Patch Set 4: Code-Review+1
I'm fine with it, but let's just get the feedback from the vdsm list on my
question
Sandro Bonazzola has posted comments on this change.
Change subject: stats: return HA agent score when applicable
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/20126
To unsubscribe, visit
Vinzenz Feenstra has posted comments on this change.
Change subject: stats: return HA agent score when applicable
..
Patch Set 4: Code-Review-1
(1 comment)
File
Vinzenz Feenstra has posted comments on this change.
Change subject: stats: return HA agent score when applicable
..
Patch Set 4:
(2 comments)
File vdsm/API.py
Line 1188:
Vinzenz Feenstra has posted comments on this change.
Change subject: stats: return HA agent score when applicable
..
Patch Set 4:
(1 comment)
File vdsm/API.py
Line 1225:
Nir Soffer has posted comments on this change.
Change subject: stats: return HA agent score when applicable
..
Patch Set 4: Code-Review-1
(6 comments)
File vdsm/API.py
Line
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stats: return HA agent score when applicable
..
Patch Set 4: -Verified
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5019/ :
Greg Padgett has posted comments on this change.
Change subject: stats: return HA agent score when applicable
..
Patch Set 4: Verified+1
Rebased. Changed from caps/vdsDynamic to stats/vdsStatistics (patch set 3)
because
oVirt Jenkins CI Server has posted comments on this change.
Change subject: stats: return HA agent score when applicable
..
Patch Set 4: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4999/ :
28 matches
Mail list logo
