Change in vdsm[master]: supervdsm: moving nics between bonds

2016-01-29 Thread mmirecki
Marcin Mirecki has posted comments on this change. Change subject: supervdsm: moving nics between bonds .. Patch Set 8: (5 comments) https://gerrit.ovirt.org/#/c/50596/8//COMMIT_MSG Commit Message: Line 7: supervdsm: >

Change in vdsm[master]: supervdsm: moving nics between bonds

2016-01-28 Thread edwardh
Edward Haas has posted comments on this change. Change subject: supervdsm: moving nics between bonds .. Patch Set 8: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/50596/8/lib/vdsm/network/configurators/iproute2.py

Change in vdsm[master]: supervdsm: moving nics between bonds

2016-01-24 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: supervdsm: moving nics between bonds .. Patch Set 8: Code-Review-1 (4 comments) https://gerrit.ovirt.org/#/c/50596/8//COMMIT_MSG Commit Message: Line 7:

Change in vdsm[master]: supervdsm: moving nics between bonds

2015-12-24 Thread mmirecki
Marcin Mirecki has posted comments on this change. Change subject: supervdsm: moving nics between bonds .. Patch Set 6: (5 comments) https://gerrit.ovirt.org/#/c/50596/6/lib/vdsm/network/api.py File lib/vdsm/network/api.py:

Change in vdsm[master]: supervdsm: moving nics between bonds

2015-12-24 Thread automation
gerrit-hooks has posted comments on this change. Change subject: supervdsm: moving nics between bonds .. Patch Set 8: * #1269175::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1269175::OK, public bug * Check

Change in vdsm[master]: supervdsm: moving nics between bonds

2015-12-24 Thread automation
gerrit-hooks has posted comments on this change. Change subject: supervdsm: moving nics between bonds .. Patch Set 7: * #1269175::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1269175::OK, public bug * Check

Change in vdsm[master]: supervdsm: moving nics between bonds

2015-12-23 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: supervdsm: moving nics between bonds .. Patch Set 6: (3 comments) https://gerrit.ovirt.org/#/c/50596/6/lib/vdsm/network/configurators/ifcfg.py File

Change in vdsm[master]: supervdsm: moving nics between bonds

2015-12-22 Thread mmirecki
Marcin Mirecki has posted comments on this change. Change subject: supervdsm: moving nics between bonds .. Patch Set 5: We objectivize bonds, with only the remaining slaves (original slaves - removed slaves), and pass them to

Change in vdsm[master]: supervdsm: moving nics between bonds

2015-12-22 Thread edwardh
Edward Haas has posted comments on this change. Change subject: supervdsm: moving nics between bonds .. Patch Set 6: (3 comments) https://gerrit.ovirt.org/#/c/50596/6/lib/vdsm/network/api.py File lib/vdsm/network/api.py:

Change in vdsm[master]: supervdsm: moving nics between bonds

2015-12-22 Thread ibarkan
Ido Barkan has posted comments on this change. Change subject: supervdsm: moving nics between bonds .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/50596/2/lib/vdsm/network/configurators/ifcfg.py File

Change in vdsm[master]: supervdsm: moving nics between bonds

2015-12-22 Thread automation
gerrit-hooks has posted comments on this change. Change subject: supervdsm: moving nics between bonds .. Patch Set 2: * #1269175::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1269175::OK, public bug * Check

Change in vdsm[master]: supervdsm: moving nics between bonds

2015-12-22 Thread ibarkan
Ido Barkan has posted comments on this change. Change subject: supervdsm: moving nics between bonds .. Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/50596/2/lib/vdsm/network/api.py File lib/vdsm/network/api.py: Line

Change in vdsm[master]: supervdsm: moving nics between bonds

2015-12-22 Thread ibarkan
Ido Barkan has posted comments on this change. Change subject: supervdsm: moving nics between bonds .. Patch Set 2: Code-Review-1 -1 for visibility -- To view, visit https://gerrit.ovirt.org/50596 To unsubscribe, visit

Change in vdsm[master]: supervdsm: moving nics between bonds

2015-12-22 Thread edwardh
Edward Haas has posted comments on this change. Change subject: supervdsm: moving nics between bonds .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/50596/2/lib/vdsm/network/configurators/ifcfg.py File

Change in vdsm[master]: supervdsm: moving nics between bonds

2015-12-22 Thread automation
gerrit-hooks has posted comments on this change. Change subject: supervdsm: moving nics between bonds .. Patch Set 3: * #1269175::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1269175::OK, public bug * Check

Change in vdsm[master]: supervdsm: moving nics between bonds

2015-12-22 Thread automation
gerrit-hooks has posted comments on this change. Change subject: supervdsm: moving nics between bonds .. Patch Set 4: * #1269175::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1269175::OK, public bug * Check

Change in vdsm[master]: supervdsm: moving nics between bonds

2015-12-22 Thread mmirecki
Marcin Mirecki has posted comments on this change. Change subject: supervdsm: moving nics between bonds .. Patch Set 2: (3 comments) https://gerrit.ovirt.org/#/c/50596/2/lib/vdsm/network/api.py File lib/vdsm/network/api.py:

Change in vdsm[master]: supervdsm: moving nics between bonds

2015-12-22 Thread ibarkan
Ido Barkan has posted comments on this change. Change subject: supervdsm: moving nics between bonds .. Patch Set 4: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/50596/4/lib/vdsm/network/configurators/ifcfg.py File

Change in vdsm[master]: supervdsm: moving nics between bonds

2015-12-22 Thread automation
gerrit-hooks has posted comments on this change. Change subject: supervdsm: moving nics between bonds .. Patch Set 5: * #1269175::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1269175::OK, public bug * Check

Change in vdsm[master]: supervdsm: moving nics between bonds

2015-12-22 Thread mmirecki
Marcin Mirecki has posted comments on this change. Change subject: supervdsm: moving nics between bonds .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/50596/5/lib/vdsm/network/models.py File

Change in vdsm[master]: supervdsm: moving nics between bonds

2015-12-22 Thread ibarkan
Ido Barkan has posted comments on this change. Change subject: supervdsm: moving nics between bonds .. Patch Set 5: Code-Review-1 I do not understand how this works. who removes the moving slaves before you add them back? --

Change in vdsm[master]: supervdsm: moving nics between bonds

2015-12-22 Thread automation
gerrit-hooks has posted comments on this change. Change subject: supervdsm: moving nics between bonds .. Patch Set 6: * #1269175::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1269175::OK, public bug * Check

Change in vdsm[master]: supervdsm: moving nics between bonds

2015-12-22 Thread mmirecki
Marcin Mirecki has posted comments on this change. Change subject: supervdsm: moving nics between bonds .. Patch Set 6: Another version where we don't objectivize the bonds, but just remove all the unwanted nics. More

Change in vdsm[master]: supervdsm: moving nics between bonds

2015-12-21 Thread mmirecki
Marcin Mirecki has posted comments on this change. Change subject: supervdsm: moving nics between bonds .. Patch Set 1: (7 comments) https://gerrit.ovirt.org/#/c/50596/1/lib/vdsm/network/api.py File lib/vdsm/network/api.py:

Change in vdsm[master]: supervdsm: moving nics between bonds

2015-12-21 Thread edwardh
Edward Haas has posted comments on this change. Change subject: supervdsm: moving nics between bonds .. Patch Set 1: Ido and myself have reread your solution, and we would like to propose a different direction. A cleaner way

Change in vdsm[master]: supervdsm: moving nics between bonds

2015-12-17 Thread ibarkan
Ido Barkan has posted comments on this change. Change subject: supervdsm: moving nics between bonds .. Patch Set 1: Code-Review-1 (4 comments) We need a functional test for this. It is easy to do. just make sure (by playing

Change in vdsm[master]: supervdsm: moving nics between bonds

2015-12-17 Thread edwardh
Edward Haas has posted comments on this change. Change subject: supervdsm: moving nics between bonds .. Patch Set 1: Code-Review-1 (7 comments) https://gerrit.ovirt.org/#/c/50596/1/lib/vdsm/network/api.py File

Change in vdsm[master]: supervdsm: moving nics between bonds

2015-12-17 Thread ibarkan
Ido Barkan has posted comments on this change. Change subject: supervdsm: moving nics between bonds .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/50596/1/lib/vdsm/network/configurators/ifcfg.py File

Change in vdsm[master]: supervdsm: moving nics between bonds

2015-12-16 Thread mmirecki
Marcin Mirecki has uploaded a new change for review. Change subject: supervdsm: moving nics between bonds .. supervdsm: moving nics between bonds This patch fixes an problem where a slave removed from one bond could sometimes

Change in vdsm[master]: supervdsm: moving nics between bonds

2015-12-16 Thread mmirecki
Marcin Mirecki has posted comments on this change. Change subject: supervdsm: moving nics between bonds .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/50596 To unsubscribe, visit

Change in vdsm[master]: supervdsm: moving nics between bonds

2015-12-16 Thread automation
gerrit-hooks has posted comments on this change. Change subject: supervdsm: moving nics between bonds .. Patch Set 1: * #1269175::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1269175::OK, public bug * Check